From patchwork Fri Feb 2 18:55:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 1894734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hn749sVo; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRQ3Y2HP7z23gH for ; Sat, 3 Feb 2024 05:56:23 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 61F713857B88 for ; Fri, 2 Feb 2024 18:56:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 90B03385802B for ; Fri, 2 Feb 2024 18:55:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90B03385802B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90B03385802B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706900159; cv=none; b=mu2ynis8Lbvyn5xXhZ19sT3ISVUkgn1IlRMA9+F+w1deOH96Oi5Wo6MLyKJFhutr4XNGm+Uv5raOZ7l78wEh7ITYiheBt9Scc7im1OGF/reYb0jSisuLmsWBmOLEuZdxadgWLkmLKL6rRZrxWCqlTN1az1HcDXOyUBsD3jMC/xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706900159; c=relaxed/simple; bh=vV+Lkm80tRH67H8o9XDwmJQk3bD7ZKl4tA1OcLeSrzM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SosZJjCl8BnYbq30LMUxplc3ULSuIciRY/+UxIEy7+Bc95nKhDvQ18UubCS27gvVfDD4yx+AgMthGhsooNaw6dtVdFzyPXloQaGYTD21UDlGFxS5ZAYcS3ZuZrBjpSki3KYDXtKrO1RsS5T1JOyFuZCiAq1lqGAiKlUR8POanI4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706900158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l+Xmy19y4ff1ilUWMWkg4C0GyaDtnZBpkeyDMF+X0Bc=; b=hn749sVoXiF2Btkv4vDgfk8QJEJTHvuFwwOlY622RHqvtg1TMUbeF1J8C8Sq9K4HyKX2Zn pg0w1GRL5UQHKJWFBwil6M+Ydkf5yEhwHMm52eBFQbjtBf//+MXNklkU9iSyFKyXfjfhna OeZkkc1IFD5ACxPejfDndBPTu0dhtBk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-EoLlhkhrN26warebABO93Q-1; Fri, 02 Feb 2024 13:55:43 -0500 X-MC-Unique: EoLlhkhrN26warebABO93Q-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-680118b101fso35779936d6.3 for ; Fri, 02 Feb 2024 10:55:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706900142; x=1707504942; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l+Xmy19y4ff1ilUWMWkg4C0GyaDtnZBpkeyDMF+X0Bc=; b=vMkMLRmo6QGiji8rxtkYNB26ruYvBD/fYkNxCseZ93sFUDaiAVZu3mbhaAQAReo1Wi HJD9vpRBfarDysQWnhzf0bfgePFz/1bYXQH+gPKIQP8AM+tEsOQpu/tHIm68xl/dhUqE Jw+E7qLy6RjI5e96Gi3TGC2Can5POXuWpMj/EYJwLcUjrlfHnEkzdXglIaVAntlA4pHK vIK2+KX6rFQ+P9XEqt95iaiAvh6vvJrU1wEDFMFVK1F9xbtPWR+EHPG9vqLaM5XZmfuf m2D+1RJM7572mih/8xwZGe4wWBuXGiY7qO1DuViwK3urm5WTVVEKDaE1LOfpSyk+QMlZ 4ZKw== X-Gm-Message-State: AOJu0Yz/175y2snLurriXaFLXZr0ebENOxN4mP64H+Ov+w37ef8/MWKM QpsXvaPLwJ1RMZ10gKM9+YUQQqdqJ3hnys2b6f2afvlO5kq+vE74nrMQsv5R27Xq6ocxBPC5/BL 8FmPJXa8HmB3T9DHpqUdZRxyZQJxWvJ0OBHJjoU0HjRtewgWBLY5PRhm0bbAdXZWzM/6oLAYr6I G/Vxn4c2g83rcHynv6CmMNSk7FP0fCcki3OZA= X-Received: by 2002:a05:6214:f67:b0:68c:75e8:b8cb with SMTP id iy7-20020a0562140f6700b0068c75e8b8cbmr10951268qvb.29.1706900142590; Fri, 02 Feb 2024 10:55:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeMUD/0pQ4Q8Id7E41aSJoPrtGVIq2H/va0UQS/zL9/o40TeOHeNiij3nyS+i2ryfGiACkjA== X-Received: by 2002:a05:6214:f67:b0:68c:75e8:b8cb with SMTP id iy7-20020a0562140f6700b0068c75e8b8cbmr10951248qvb.29.1706900142226; Fri, 02 Feb 2024 10:55:42 -0800 (PST) Received: from jason.cygnus.csb (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id qm18-20020a056214569200b0068c67e305edsm1050445qvb.49.2024.02.02.10.55.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 10:55:41 -0800 (PST) From: Jason Merrill To: gcc-patches@gcc.gnu.org Subject: [pushed] c++: op== defaulted outside class [PR110084] Date: Fri, 2 Feb 2024 13:55:40 -0500 Message-Id: <20240202185540.19758-1-jason@redhat.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- defaulted_late_check is for checks that need to happen after the class is complete; we shouldn't call it sooner. PR c++/110084 gcc/cp/ChangeLog: * pt.cc (tsubst_function_decl): Only check a function defaulted outside the class if the class is complete. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/spaceship-synth-neg3.C: Check error message. * g++.dg/cpp2a/spaceship-eq16.C: New test. --- gcc/cp/pt.cc | 1 + gcc/testsuite/g++.dg/cpp2a/spaceship-eq16.C | 11 +++++++++++ gcc/testsuite/g++.dg/cpp2a/spaceship-synth-neg3.C | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp2a/spaceship-eq16.C base-commit: 1c3cfb5a95dcc7f797ec2815690a6291878580c4 diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index 9d30a271713..355e9609bd3 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -14812,6 +14812,7 @@ tsubst_function_decl (tree t, tree args, tsubst_flags_t complain, if (DECL_SECTION_NAME (t)) set_decl_section_name (r, t); if (DECL_DEFAULTED_OUTSIDE_CLASS_P (r) + && COMPLETE_TYPE_P (DECL_CONTEXT (r)) && !processing_template_decl) defaulted_late_check (r); diff --git a/gcc/testsuite/g++.dg/cpp2a/spaceship-eq16.C b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq16.C new file mode 100644 index 00000000000..e5538ea9890 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq16.C @@ -0,0 +1,11 @@ +// PR c++/110084 +// { dg-do compile { target c++20 } } + +template +class BadTuple { + constexpr bool operator==(const BadTuple&) const; +}; +template +constexpr bool BadTuple::operator==(const BadTuple&) const = default; + +BadTuple a; diff --git a/gcc/testsuite/g++.dg/cpp2a/spaceship-synth-neg3.C b/gcc/testsuite/g++.dg/cpp2a/spaceship-synth-neg3.C index a4d8b32922f..aaa0264e7b3 100644 --- a/gcc/testsuite/g++.dg/cpp2a/spaceship-synth-neg3.C +++ b/gcc/testsuite/g++.dg/cpp2a/spaceship-synth-neg3.C @@ -5,7 +5,7 @@ template struct A {}; struct B { - constexpr auto operator<=>(const B&) const = default; // { dg-error "" } + constexpr auto operator<=>(const B&) const = default; // { dg-error "strong_ordering" } int value; };