From patchwork Fri Feb 2 16:02:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Barinov X-Patchwork-Id: 1894692 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=cjo1mcly; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRLDZ3yXQz1yhq for ; Sat, 3 Feb 2024 03:03:57 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 412963858034 for ; Fri, 2 Feb 2024 16:03:55 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by sourceware.org (Postfix) with ESMTPS id 9E6993858403 for ; Fri, 2 Feb 2024 16:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E6993858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=samsung.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E6993858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=210.118.77.12 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706889808; cv=none; b=JbzlLS+kgQVcS524aK2DmM1SKjbvgSchWLx0VIRcNsfoSORSWBFPfoy0GYTvqou6YxZxRRvztIe5QoHH2NBi+K0Lhcup/QrEKSlTdm9S2zndQ9wKRN4WWHJAO06VSbd/bmdn76iJzSFgYRxiGrxHtC2DLuxlXwI94K5ogsNHGLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706889808; c=relaxed/simple; bh=iG5z32jJF3xqxUjfh7MGiijOq6rF9/Kkrbh6FWx9NLA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rVEM6vvrihaadpoYViaTaAPORVTTXaQXAqw9a0rWFn7ONnlYd0z0sOa5Ij+3+go2eW1gd5q/p5AsmSb5fepQ86TLtPLyjR1Gv0bXcZi1lGF9rBrL4T4efO9/o9aylgbwBYbsZ6645P8KFOvlfqIAk28R9IZHWPzDkzwuGCtnRxs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240202160322euoutp02cd06b128b6a5da57a6a4a4df9b18fa58~wFzthIcsy2968629686euoutp02L for ; Fri, 2 Feb 2024 16:03:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240202160322euoutp02cd06b128b6a5da57a6a4a4df9b18fa58~wFzthIcsy2968629686euoutp02L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1706889802; bh=RCMI+zevMom5UF2r0poRfmMp78fGpz/lXfbzdfSyXiw=; h=From:To:Cc:Subject:Date:References:From; b=cjo1mclyMAq1MgC7evfKAqxtVwkNaIDNgUvJw3bsdGKxGbDgpng7eBdk5HjscdknP 6/Eu3yhBXQyTE3dT/httV2g8qCgklbDNez0yG0GtR9U2mR9nVW+84k+8le0mEgoZp8 ZiO6mRqzyDVdA38k8aImnex4XcWlhyT87giQ9PEI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20240202160322eucas1p298b30c2cf6b5a3b41271ccfb19247450~wFztZlxmQ2486424864eucas1p2A; Fri, 2 Feb 2024 16:03:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 6D.8E.09552.A421DB56; Fri, 2 Feb 2024 16:03:22 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240202160322eucas1p25517fc683bc772879cde2b2229d4b116~wFztDpWvf2488724887eucas1p24; Fri, 2 Feb 2024 16:03:22 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240202160322eusmtrp1c9f6f521ec14bfd5214ac5874ade5863~wFztDLT232128621286eusmtrp1x; Fri, 2 Feb 2024 16:03:22 +0000 (GMT) X-AuditID: cbfec7f5-853ff70000002550-17-65bd124ac31c Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 34.EE.09146.9421DB56; Fri, 2 Feb 2024 16:03:21 +0000 (GMT) Received: from vbarinov (unknown [106.109.129.54]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240202160320eusmtip2cb95f4f78806ff36b47eb83f16adfb21~wFzrwf6LS0157801578eusmtip2e; Fri, 2 Feb 2024 16:03:20 +0000 (GMT) Received: by vbarinov (sSMTP sendmail emulation); Fri, 02 Feb 2024 19:03:29 +0300 From: Slava Barinov To: gcc-patches@gcc.gnu.org Cc: dongkyun.s@samsung.com, Slava Barinov Subject: [PATCH] gcc: configure: Fix the optimization flags cleanup Date: Fri, 2 Feb 2024 19:02:57 +0300 Message-ID: <20240202160314.31083-1-v.barinov@samsung.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsWy7djPc7peQntTDS4sFbeYvPwds8Wn/+kW 98+dYXFg9jh6fyOTR9+WVYwBTFFcNimpOZllqUX6dglcGQc2PWQuWCtQ8bP1DHMD4yzeLkZO DgkBE4kzR+YxdTFycQgJrGCUaFrQwwiSEBL4wijxdk4+ROIzo8SvLV/YYDrOTV7MCpFYziix 7ep/RgjnOaNE4++tUO3BEr+u/WQGsdkEtCV+LX8CZosISEvcuDEZrIZZwFGi9+ITFhBbWMBZ onvVJlYQm0VAVWLOoj6wbbwCVhLzTl5lhNgsL7F4x3JmiLigxMmZEL3MQPHmrbOZQY6QEPjJ LnFnWiMzRIOLREvPTihbWOLV8S3sELaMxOnJPSwQdr7E0cZ5QMs4gOwKifMv/CDC9hJd9xvY QcLMApoS63fpQ4QdJX4cngZVzSdx460gxAV8EpO2TWeGCPNKdLQJQVQrS0xedRwabJISDbfn Q9keEss2/GabwKg4C8kvs5D8Mgth7wJG5lWM4qmlxbnpqcXGeanlesWJucWleel6yfm5mxiB CeL0v+NfdzCuePVR7xAjEwfjIUYJDmYlEd6VcjtThXhTEiurUovy44tKc1KLDzFKc7AoifOq psinCgmkJ5akZqemFqQWwWSZODilGpiKjVaI8rQe+Xcm6Uz+/Wcv78t69+qnW+07x6QadyJI ZdY5P93GDo35C+r5mr01d//4tbKBN/dRm4pO58q5ld2rJIq/7mtPPvVzsavKMutyjwNbZvpp pFRWm3Vus3iot1H5dYaH9znW/z+XpySpXrDZyr79e8K0snuvX1QVJpc9/J1iu8rn1B/Pr8GC V5eZlOwM/y3M09DH7M8vdpJzgVy09COtg44Mne5btMp2ab/PzZqo+uf02UMraqYY5i9YWKvo L333/LoljV/CI3retklUB16qPlUwd0vEvG7n1V0V9ju5O8MfzmA3CNok5FFrpS3+wDd/87WK lRUpEz+Km/9bsDTv1dWLokqxbNUcIkosxRmJhlrMRcWJAPoTsTF/AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xe7qeQntTDebft7GYvPwds8Wn/+kW 98+dYXFg9jh6fyOTR9+WVYwBTFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkam Svp2NimpOZllqUX6dgl6GQc2PWQuWCtQ8bP1DHMD4yzeLkZODgkBE4lzkxezdjFycQgJLGWU 6Hn9hwUiISlxZdt+VghbWOLPtS42iKKnjBJbNvYxgySEBAIlfrTvYgOx2QS0JX4tfwIWFxGQ lrhxYzIjiM0s4Czx/d4EsLgwkN29ahPYUBYBVYk5i/rAenkFrCTmnbzKCLFMXmLxjuXMEHFB iZMzn7BAzJGXaN46m3kCI/8sJKlZSFILGJlWMYqklhbnpucWG+oVJ+YWl+al6yXn525iBIbt tmM/N+9gnPfqo94hRiYOxkOMEhzMSiK8K+V2pgrxpiRWVqUW5ccXleakFh9iNAW6byKzlGhy PjBy8kriDc0MTA1NzCwNTC3NjJXEeT0LOhKFBNITS1KzU1MLUotg+pg4OKUamLb8/7/i49TW hSnGG6ObeZ+F9Uql7085EbZ15qSCCYvZ7t+ecLE2/b/k+je7zyvmvZbeaLD/jfdW/vN7Qr/N Yctfs+Tprzk8nbPjzeZetHu6/J9KjuRNZYvLmvEZae/en597QF3o9fGth2ZlHfdyYV7DdGpv +B/eMBWVf2V9D+4v1Ixef+2Mo+GS5UV+p6p4uV+sDzz1SbngBZPrlIcHDknwXA9eUHvy/3XV PefrNhznT9m+JvMaX9PSh+35yeueP9QQfSJsZf1x21sPO5YNMfpbb0l4LZT+fYrLyFthbaKY YZGO/2ZP2eRnj8/KZoTu5lQ60SZkpbpmt7fvodlXV9o0X89kePHQ4fC/miPODsq3lViKMxIN tZiLihMBo4WUwuQCAAA= X-CMS-MailID: 20240202160322eucas1p25517fc683bc772879cde2b2229d4b116 X-Msg-Generator: CA X-RootMTR: 20240202160322eucas1p25517fc683bc772879cde2b2229d4b116 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240202160322eucas1p25517fc683bc772879cde2b2229d4b116 References: X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Currently sed command in flag cleanup removes all the -O[0-9] flags, ignoring the context. This leads to issues when the optimization flags is passed to linker: CFLAGS="-Os -Wl,-O1 -Wl,--hash-style=gnu" is converted into CFLAGS="-Os -Wl,-Wl,--hash-style=gnu" Which leads to configure failure with ld: unrecognized option '-Wl,-Wl'. gcc/ * configure.ac: Only remove -O[0-9] if not preceded with comma * configure: Regenerated --- gcc/configure | 4 ++-- gcc/configure.ac | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/configure b/gcc/configure index c83e09beea9..fd72034cbc1 100755 --- a/gcc/configure +++ b/gcc/configure @@ -5472,8 +5472,8 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu # optimizations to be activated explicitly by the toplevel. case "$CC" in */prev-gcc/xgcc*) ;; - *) CFLAGS=`echo "$CFLAGS " | sed -e "s/-Ofast[ ]//" -e "s/-O[gs][ ]//" -e "s/-O[0-9]*[ ]//" ` - CXXFLAGS=`echo "$CXXFLAGS " | sed -e "s/-Ofast[ ]//" -e "s/-O[gs][ ]//" -e "s/-O[0-9]*[ ]//" ` ;; + *) CFLAGS=`echo "$CFLAGS " | sed -e "s/-Ofast[ ]//" -e "s/-O[gs][ ]//" -e "s/[^,]-O[0-9]*[ ]//" ` + CXXFLAGS=`echo "$CXXFLAGS " | sed -e "s/-Ofast[ ]//" -e "s/-O[gs][ ]//" -e "s/[^,]-O[0-9]*[ ]//" ` ;; esac diff --git a/gcc/configure.ac b/gcc/configure.ac index 239856a4e20..d62d630d9b7 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -467,8 +467,8 @@ AC_LANG(C++) # optimizations to be activated explicitly by the toplevel. case "$CC" in */prev-gcc/xgcc*) ;; - *) CFLAGS=`echo "$CFLAGS " | sed -e "s/-Ofast[[ ]]//" -e "s/-O[[gs]][[ ]]//" -e "s/-O[[0-9]]*[[ ]]//" ` - CXXFLAGS=`echo "$CXXFLAGS " | sed -e "s/-Ofast[[ ]]//" -e "s/-O[[gs]][[ ]]//" -e "s/-O[[0-9]]*[[ ]]//" ` ;; + *) CFLAGS=`echo "$CFLAGS " | sed -e "s/-Ofast[[ ]]//" -e "s/-O[[gs]][[ ]]//" -e "s/[[^,]]-O[[0-9]]*[[ ]]//" ` + CXXFLAGS=`echo "$CXXFLAGS " | sed -e "s/-Ofast[[ ]]//" -e "s/-O[[gs]][[ ]]//" -e "s/[[^,]]-O[[0-9]]*[[ ]]//" ` ;; esac AC_SUBST(CFLAGS) AC_SUBST(CXXFLAGS)