From patchwork Wed Jan 31 21:40:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 1893658 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Rjm2pb3a; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org; envelope-from=linux-pwm+bounces-1155-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TQFpj5plRz23fD for ; Thu, 1 Feb 2024 08:41:17 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7457F1C22A2A for ; Wed, 31 Jan 2024 21:41:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0354E39FC8; Wed, 31 Jan 2024 21:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Rjm2pb3a" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6F1B39AEC for ; Wed, 31 Jan 2024 21:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706737250; cv=none; b=FFfm8q8fJ+AQ2FT/aiBRhzWQFuwUxjMXW13KBK7KTs0c/TONyFPvoDWomk5JjdQtXdwt8s8iZD3C8hLOJ+XkUhZWw+PW7E+ToE6fKax3yOhagfAtRrvyP238EKZp7j87W2bJnS1CbfCk10zFza8JykSX/qevEE0WeqXGXwSVhRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706737250; c=relaxed/simple; bh=0D3PvBuznXcah933PtyrJperA0WBujRtvSxVac3ciJQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XeYCTM9otsYPQFsPW98BVEtUQRN4LmJB09D/xrlAN7ef7ZC9KWl/Ua6NbbRSy7m0dgZsx7K+jW0xhYPKqOTfxJ0zEK3yWXwzh2YhbBmOfZCWIV2ZB3MNOOaAdYE5Pl0XH63SGNkmB5Mq/enczYhW6th6qKhIk9lf0fxctjIdtFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Rjm2pb3a; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-78405c9a152so20109885a.1 for ; Wed, 31 Jan 2024 13:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706737247; x=1707342047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ki773j0Ev7Hoz0mDYF2rJmieDOfkk6uGJjHoeASEx1g=; b=Rjm2pb3amHOykT0tjpzciG1rmWH1yb8Jeu8cIpkOUaxqRlOHuLXJJEw26g7Z4x9zQc I1puo/z+4byT9O4R2cyBx1EqKAhBINVcA13xhtyqHJAMnktQz5jPWqbEnAYF+qUhsZbw OaNL8bI4lANDHfcPUCkEyn2qkvvKRJanvuBop3dA6vRcRjnJ/knoF2xA7BXgNND3klyl vF7uMpINIeW9A1TlnPXI/d5/yJsTcBNZuCLflr9tgZe6vPzW3KK7yqF9YAvC+wrKCkmG mewOmHBjk5SD4zAioCXaJgSuxUassl2WiLJojjy24GTF8Igxqi3ak95c82LwWysMRFVr mRuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706737247; x=1707342047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ki773j0Ev7Hoz0mDYF2rJmieDOfkk6uGJjHoeASEx1g=; b=VbpugL8XUerySiHrLpylNeE6P0Ad7wn0mq4sPPEnMONNUJ8ePxQxG/T0gRdNcW8FaZ IjyVHQB8hC+pR5mJTblMgsuSu6ct3j+0cipq0Y4HSlAe3JMAhT1+/7BbE0NLuUvpWUSU alMziSDywufJKL+2imfc9x7e4v8hE74tMuoJfvge/iq+qGTplSAYRj9nXiRxLhTgwa/S kzKBmoEqg+oXhJQ27FcFepep/ViMP4mEoG9rPKJSMUV0aXqzgTuTOxOSsnyC36ycCu58 dOLC5E2+hSMMZy6Whq+TpSdzqM/UZ3DY+VQylb2Eeu+abTIbJ4NzX1JYrsvkc3j1NUGK rtXQ== X-Gm-Message-State: AOJu0YyGXgp8fhLMxnxUcnslBZnkvXZL0MhJ9j8+jXKhluthGlQP0lfX dub/de1gRcAS7/IXLp8hZcJGBfLjcb3fXnmn4jt5xgEaKW7/PmowWATWlSHFEHDe53vU/MwVDkp F X-Google-Smtp-Source: AGHT+IFaDhOXjHQMw+jYCipXxDzDrm40IQ5rBwdwqaz+zYtJtbmBYmdynqVDTOLpde+n6lm0TbofQQ== X-Received: by 2002:a05:620a:4043:b0:783:cdca:7e07 with SMTP id i3-20020a05620a404300b00783cdca7e07mr929453qko.13.1706737247652; Wed, 31 Jan 2024 13:40:47 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUVHkkrJMkJXR6adxHX2xRFS15sheDyXeQrz+v871FTb5csux2zwrqce9m4C4G+T5e1RqnlmR/xNby49vrC8h88sM/NAhkfiFHF5dyXEb8nRr6ZG0Qx+EGoLGvXdBMChAWllGzD7CTsq+Dx4lxdCzKBjZPah8OG2z15CeHihNVVHXTL4gog9xrORzTiHuZDu63mGyDNMWIJSbSBADOZA9695LJ81pNTNdRkvGCCLMOVqGXOBtMviZywfsTlR/Y7BsW7IVqKo+4yTjcDMykGpq2hQ7jrMYm2vpwZZ0Ikz+aCEzNCxwRwGw2vT3+2wMFImBNdrPpyGt+l6RjdYwNhmRF+fdAx1xTNNXQAagyxlDU6fX2fdPMTaAnDvGHbPZvsgS/ryEW+GT+sZYuGOAXJ47aI0WJja4aD Received: from workbox.taildc8f3.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id br44-20020a05620a462c00b007853f040aedsm537160qkb.8.2024.01.31.13.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 13:40:47 -0800 (PST) From: Trevor Gamblin To: linux-pwm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de, michael.hennerich@analog.com, nuno.sa@analog.com, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Drew Fustini , Trevor Gamblin , Krzysztof Kozlowski Subject: [PATCH 1/2 v3] dt-bindings: pwm: Add AXI PWM generator Date: Wed, 31 Jan 2024 16:40:40 -0500 Message-ID: <20240131214042.1335251-2-tgamblin@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240131214042.1335251-1-tgamblin@baylibre.com> References: <20240131214042.1335251-1-tgamblin@baylibre.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Drew Fustini Add Analog Devices AXI PWM generator. Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen Signed-off-by: Drew Fustini Co-developed-by: Trevor Gamblin Reviewed-by: Krzysztof Kozlowski Signed-off-by: Trevor Gamblin --- v3 changes: None (rebased, added maintainer's previous Reviewed-by) v2 changes: * Address feedback for driver and device tree in v1: * Relocate "unevaluatedProperties" in device tree binding * Remove redundant "bindings for" in description --- .../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++ MAINTAINERS | 8 ++++ 2 files changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml new file mode 100644 index 000000000000..63461920a362 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AXI PWM generator + +maintainers: + - Michael Hennerich + - Nuno Sá + +description: + The Analog Devices AXI PWM generator can generate PWM signals + with variable pulse width and period. + + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + const: adi,axi-pwmgen-1.00.a + + reg: + maxItems: 1 + + "#pwm-cells": + const: 2 + + clocks: + maxItems: 1 + +required: + - reg + - clocks + +unevaluatedProperties: false + +examples: + - | + pwm@44b00000 { + compatible = "adi,axi-pwmgen-1.00.a"; + reg = <0x44b00000 0x1000>; + clocks = <&spi_clk>; + #pwm-cells = <2>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 8d1052fa6a69..8a4ed5545680 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3431,6 +3431,14 @@ W: https://ez.analog.com/linux-software-drivers F: Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml F: drivers/spi/spi-axi-spi-engine.c +AXI PWM GENERATOR +M: Michael Hennerich +M: Nuno Sá +L: linux-pwm@vger.kernel.org +S: Supported +W: https://ez.analog.com/linux-software-drivers +F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml + AXXIA I2C CONTROLLER M: Krzysztof Adamski L: linux-i2c@vger.kernel.org From patchwork Wed Jan 31 21:40:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trevor Gamblin X-Patchwork-Id: 1893660 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=PoBmTTo0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-pwm+bounces-1156-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TQFq41ycfz23fD for ; Thu, 1 Feb 2024 08:41:36 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 864851F2846F for ; Wed, 31 Jan 2024 21:41:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10EB739FEC; Wed, 31 Jan 2024 21:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PoBmTTo0" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD0339AFE for ; Wed, 31 Jan 2024 21:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706737253; cv=none; b=tgXrFkPtbE+1mNtUDwpsS2uT/qF2IsfhHcThKFYE/npwvtm0nOA3nT2WvQGRXSsdccJ74sFU929+hJWkdf8F6C2L6XcFAFYIRKD9kxq9Jh8HVctb2ti/fO4+iFMYowLMvSBLpFBUAcc/TooSExEz6AZLNtzr6M8rN+gBomhH+QE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706737253; c=relaxed/simple; bh=TzJI9DKcr14wIxwW5xX42GkeCx1HYD+R/f/OjsgMQu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QzKisSJeozR/EiikEFvpMv2tE+1pFVQZ06n9x+wLHp3p+wS79hoov9yOduEUBM8v7b/sRd2CVhF1p3GuiwGhtBDZW5bm9sUSFj+3XZxEIZlGPP38QrkSBKKQzLvtn2kCRNpfOz5h7pV5kjCMEU8lGwNEpKh2Tujah14kBreS+/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PoBmTTo0; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3be90c51299so174585b6e.0 for ; Wed, 31 Jan 2024 13:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706737249; x=1707342049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tsEVxG29WCMfnx8JtgD8uSy6BCcIKhPjoqts5Funlgk=; b=PoBmTTo0KoAn3js0XbH5oWloyA2CgcHc/5JDUAWuMCfMQQXG1ohyDPT0HDrt6NeUNP NQgW4BdUuBZRmyQvOVBVzV3rFewE3t9Y5sZ9wHVbAr3prde7WWs4O8DxB8KZhbmfZQFh 386XAdD0E7CzHtbZaUX0iTK9WOkkFmPBvLjO9/R1x94RVlzDTcubx00tNIGWmSYfsrtf TX5SqFWmnzKFkTHu/lyE2GUrlhEQjfQvPAEFWqCYuf94X7tysj4vKpblaYSDIDHN2UlY qGSby5aqBJ2qQrRFLt9Doyg/Fu4upmS0wj8SannweQQ/Lc3dbTDbdeEZ+pPvwxdolZVp crJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706737249; x=1707342049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tsEVxG29WCMfnx8JtgD8uSy6BCcIKhPjoqts5Funlgk=; b=cLcleJmoLACVt/UxX7y32NuQtbva3tJXqtXZ6LKD0FqM50Rq15LAqd4ugZkxlmZttb F6ta3E0Xnl58qRskQiJsxtAZXnB3q+RjZPOfMqLxFoqUF+Xn1DrqWPU2LtZkUhiU1QCX TnqAHbBpoutureMTHUHIjIQpbYqnRuFP505pYuVB6yG96rkUhhiq1xe5P68UFK2nKeGH K2ZDR57ZdiAQ3M7ddyQ630CjxheIQRTxU8vrhPqytGnlJNvcIXvCWGNEhza43XJj+Pvf gHRUXUbReI6H/SVVIZWqc7k3oK8h9DZdbdR9caSejJY23CUG8bBn0xlu9Z/nDCalZtSV NZqA== X-Gm-Message-State: AOJu0YwgpMfOSAigYpItlNztqzwSbesfoDoPzgHFd4xNLFAcDjZldKcu 5BnMl8Lcge8sx0EaADISo4pH9dJKh2K/GbnGAga3imtbMKJRlx3K12E8vYQxyfvAxA+XjyCRlVg tgUw= X-Google-Smtp-Source: AGHT+IHq/e8pnhFUDAICQ/t87WXNxsEnPo/PiG4c3dkbnBNplJBMJcBVN+cLzHqJSQ4NMwb+ZA020g== X-Received: by 2002:a05:6808:2f05:b0:3be:c0f9:3cb4 with SMTP id gu5-20020a0568082f0500b003bec0f93cb4mr3643826oib.25.1706737249530; Wed, 31 Jan 2024 13:40:49 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUJnNirCWZnLItLHBgrn1/jV23gkm3qXnwUW9u1iYwRtC1mlU+gUu1QUTqY3kzXJNkCWo++RHySDOSFqgd3vJviwX0VBWi/kDs7DYcy5szkGmxpgBTrjJrpiDQy/UTv+LvBO8ydETYTV5AaWlEZEY1k/osNajJ06rQgzuc2rf1QihUAstLTZ+tafxUI13lZcSisziZ6V63fyWXe+aPDzI4NLkT9TVlmg6qdNuvHHe1jhLt+3aEz6IWAeLt5Q8QA6rKKxMN5EzqtqPO+IuCfLRDxRy9rIlJBTuibHSpIjdhmkRkUxeHHTlj6e67/5Z4Q4keiKsaENLQvbBS/aeAeTK8rqDjUoPzZjpkkzZeVMjgPb0esDy02OMbzhrA8pjs4/GjA6vlMs8BT/cel0JDzXVESIdp4+JbVGj3gIsx6JCyQnHQgzlG9YdOVhqY= Received: from workbox.taildc8f3.ts.net (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id br44-20020a05620a462c00b007853f040aedsm537160qkb.8.2024.01.31.13.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 13:40:49 -0800 (PST) From: Trevor Gamblin To: linux-pwm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de, michael.hennerich@analog.com, nuno.sa@analog.com, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Drew Fustini , Sergiu Cuciurean , David Lechner , Trevor Gamblin Subject: [PATCH 2/2 v3] pwm: Add driver for AXI PWM generator Date: Wed, 31 Jan 2024 16:40:41 -0500 Message-ID: <20240131214042.1335251-3-tgamblin@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240131214042.1335251-1-tgamblin@baylibre.com> References: <20240131214042.1335251-1-tgamblin@baylibre.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Drew Fustini Add support for the Analog Devices AXI PWM Generator. This device is an FPGA-implemented peripheral used as PWM signal generator and can be interfaced with AXI4. The register map of this peripheral makes it possible to configure the period and duty cycle of the output signal. Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen Co-developed-by: Sergiu Cuciurean Signed-off-by: Sergiu Cuciurean Co-developed-by: David Lechner Signed-off-by: David Lechner Signed-off-by: Drew Fustini Co-developed-by: Trevor Gamblin Acked-by: Nuno Sa Signed-off-by: Trevor Gamblin --- v3 changes: * Address feedback for driver in v2: * Remove unnecessary blank line in axi_pwmgen_apply * Use macros already defined in for version checking v2 changes: * Address feedback for driver and device tree in v1: * Use more reasonable Kconfig approach * Use common prefixes for all functions * Rename axi_pwmgen struct to axi_pwmgen_ddata * Change use of "pwm" to "ddata" * Set and check state->polarity * Multiply safely with mul_u64_u64_div_u64() * Improve handling of max and zero periods * Error if clk_rate_hz > NSEC_PER_SEC * Add "Limitations" section at top of pwm-axi-pwmgen.c * Don't disable outputs by default * Remove unnecessary macros for period, duty, offset * Fix axi_pwmgen_ddata alignment * Don't artificially limit npwm to four * Use clk_rate_exclusive_get(), balance with clk_rate_exclusive_put() * Cache clk rate in axi_pwmgen_ddata * Don't assign pwm->chip.base, do assign pwm->chip.atomic * Remove redundant calls to clk_get_rate * Test contents of AXI_PWMGEN_REG_CORE_MAGIC instead of arbitrary AXI_PWMGEN_TEST_DATA in AXI_PWMGEN_REG_SCRATCHPAD * Remove redundant clk struct from axi_pwmgen_ddata * Add self as module author * Add major version check for IP core --- MAINTAINERS | 1 + drivers/pwm/Kconfig | 13 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-axi-pwmgen.c | 242 +++++++++++++++++++++++++++++++++++ 4 files changed, 257 insertions(+) create mode 100644 drivers/pwm/pwm-axi-pwmgen.c diff --git a/MAINTAINERS b/MAINTAINERS index 8a4ed5545680..2baa7a0a1c8c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3438,6 +3438,7 @@ L: linux-pwm@vger.kernel.org S: Supported W: https://ez.analog.com/linux-software-drivers F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml +F: drivers/pwm/pwm-axi-pwmgen.c AXXIA I2C CONTROLLER M: Krzysztof Adamski diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 4b956d661755..d44b0e86adee 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -98,6 +98,19 @@ config PWM_ATMEL_TCB To compile this driver as a module, choose M here: the module will be called pwm-atmel-tcb. +config PWM_AXI_PWMGEN + tristate "Analog Devices AXI PWM generator" + depends on MICROBLAZE || NIOS2 || ARCH_ZYNQ || ARCH_ZYNQMP || ARCH_INTEL_SOCFPGA || COMPILE_TEST + select REGMAP_MMIO + help + This enables support for the Analog Devices AXI PWM generator. + + This is a configurable PWM generator with variable pulse width and + period. + + To compile this driver as a module, choose M here: the module will be + called pwm-axi-pwmgen. + config PWM_BCM_IPROC tristate "iProc PWM support" depends on ARCH_BCM_IPROC || COMPILE_TEST diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index c5ec9e168ee7..8322089954e9 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -6,6 +6,7 @@ obj-$(CONFIG_PWM_APPLE) += pwm-apple.o obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o +obj-$(CONFIG_PWM_AXI_PWMGEN) += pwm-axi-pwmgen.o obj-$(CONFIG_PWM_BCM_IPROC) += pwm-bcm-iproc.o obj-$(CONFIG_PWM_BCM_KONA) += pwm-bcm-kona.o obj-$(CONFIG_PWM_BCM2835) += pwm-bcm2835.o diff --git a/drivers/pwm/pwm-axi-pwmgen.c b/drivers/pwm/pwm-axi-pwmgen.c new file mode 100644 index 000000000000..44e62e90b227 --- /dev/null +++ b/drivers/pwm/pwm-axi-pwmgen.c @@ -0,0 +1,242 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Analog Devices AXI PWM generator + * + * Copyright 2024 Analog Devices Inc. + * Copyright 2024 Baylibre SAS + * + * Limitations: + * - The writes to registers for period and duty are shadowed until + * LOAD_CONFIG is written to AXI_PWMGEN_REG_CONFIG at the end of the + * current period. + * - Writing LOAD_CONFIG also has the effect of re-synchronizing all + * enabled channels, which could cause glitching on other channels. It + * is therefore expected that channels are assigned harmonic periods + * and all have a single user coordinating this. + * - Supports normal polarity. Does not support changing polarity. + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define AXI_PWMGEN_REG_CORE_VERSION 0x00 +#define AXI_PWMGEN_REG_ID 0x04 +#define AXI_PWMGEN_REG_SCRATCHPAD 0x08 +#define AXI_PWMGEN_REG_CORE_MAGIC 0x0C +#define AXI_PWMGEN_REG_CONFIG 0x10 +#define AXI_PWMGEN_REG_NPWM 0x14 +#define AXI_PWMGEN_CHX_PERIOD(ch) (0x40 + (12 * (ch))) +#define AXI_PWMGEN_CHX_DUTY(ch) (0x44 + (12 * (ch))) +#define AXI_PWMGEN_CHX_OFFSET(ch) (0x48 + (12 * (ch))) +#define AXI_PWMGEN_REG_CORE_MAGIC_VAL 0x601A3471 /* Identification number to test during setup */ +#define AXI_PWMGEN_LOAD_CONFIG BIT(1) +#define AXI_PWMGEN_RESET BIT(0) + +struct axi_pwmgen_ddata { + struct pwm_chip chip; + struct regmap *regmap; + unsigned long clk_rate_hz; +}; + +static const struct regmap_config axi_pwmgen_regmap_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, +}; + +static struct axi_pwmgen_ddata *axi_pwmgen_from_chip(struct pwm_chip *chip) +{ + return container_of(chip, struct axi_pwmgen_ddata, chip); +} + +static int axi_pwmgen_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct axi_pwmgen_ddata *ddata = axi_pwmgen_from_chip(chip); + unsigned int ch = pwm->hwpwm; + struct regmap *regmap = ddata->regmap; + u64 period_cnt, duty_cnt; + int ret; + + if (state->polarity != PWM_POLARITY_NORMAL) + return -EINVAL; + + if (state->enabled) { + period_cnt = mul_u64_u64_div_u64(state->period, ddata->clk_rate_hz, NSEC_PER_SEC); + if (period_cnt > UINT_MAX) + period_cnt = UINT_MAX; + + if (period_cnt == 0) + return -EINVAL; + + ret = regmap_write(regmap, AXI_PWMGEN_CHX_PERIOD(ch), period_cnt); + if (ret) + return ret; + + duty_cnt = mul_u64_u64_div_u64(state->duty_cycle, ddata->clk_rate_hz, NSEC_PER_SEC); + if (duty_cnt > UINT_MAX) + duty_cnt = UINT_MAX; + + ret = regmap_write(regmap, AXI_PWMGEN_CHX_DUTY(ch), duty_cnt); + if (ret) + return ret; + } else { + ret = regmap_write(regmap, AXI_PWMGEN_CHX_PERIOD(ch), 0); + if (ret) + return ret; + + ret = regmap_write(regmap, AXI_PWMGEN_CHX_DUTY(ch), 0); + if (ret) + return ret; + } + + return regmap_write(regmap, AXI_PWMGEN_REG_CONFIG, AXI_PWMGEN_LOAD_CONFIG); +} + +static int axi_pwmgen_get_state(struct pwm_chip *chip, struct pwm_device *pwm, + struct pwm_state *state) +{ + struct axi_pwmgen_ddata *ddata = axi_pwmgen_from_chip(chip); + struct regmap *regmap = ddata->regmap; + unsigned int ch = pwm->hwpwm; + u32 cnt; + int ret; + + ret = regmap_read(regmap, AXI_PWMGEN_CHX_PERIOD(ch), &cnt); + if (ret) + return ret; + + state->enabled = cnt != 0; + + state->period = DIV_ROUND_UP_ULL((u64)cnt * NSEC_PER_SEC, ddata->clk_rate_hz); + + ret = regmap_read(regmap, AXI_PWMGEN_CHX_DUTY(ch), &cnt); + if (ret) + return ret; + + state->duty_cycle = DIV_ROUND_UP_ULL((u64)cnt * NSEC_PER_SEC, ddata->clk_rate_hz); + + state->polarity = PWM_POLARITY_NORMAL; + + return 0; +} + +static const struct pwm_ops axi_pwmgen_pwm_ops = { + .apply = axi_pwmgen_apply, + .get_state = axi_pwmgen_get_state, +}; + +static int axi_pwmgen_setup(struct axi_pwmgen_ddata *ddata, struct device *dev) +{ + struct regmap *regmap = ddata->regmap; + int ret; + u32 val; + + ret = regmap_read(regmap, AXI_PWMGEN_REG_CORE_MAGIC, &val); + if (ret) + return ret; + + if (val != AXI_PWMGEN_REG_CORE_MAGIC_VAL) + return dev_err_probe(dev, -ENODEV, + "failed to read expected value from register: got %08x, expected %08x\n", + val, + AXI_PWMGEN_REG_CORE_MAGIC_VAL); + + ret = regmap_read(regmap, AXI_PWMGEN_REG_CORE_VERSION, &val); + if (ret) + return ret; + + if (ADI_AXI_PCORE_VER_MAJOR(val) != 1) { + return dev_err_probe(dev, -ENODEV, "Unsupported peripheral version %u.%u.%u\n", + ADI_AXI_PCORE_VER_MAJOR(val), + ADI_AXI_PCORE_VER_MINOR(val), + ADI_AXI_PCORE_VER_PATCH(val)); + } + + ret = regmap_read(regmap, AXI_PWMGEN_REG_NPWM, &ddata->chip.npwm); + if (ret) + return ret; + + /* Enable the core */ + return regmap_update_bits(regmap, AXI_PWMGEN_REG_CONFIG, AXI_PWMGEN_RESET, 0); +} + +static void axi_pwmgen_clk_rate_exclusive_put(void *data) +{ + clk_rate_exclusive_put(data); +} + +static int axi_pwmgen_probe(struct platform_device *pdev) +{ + struct axi_pwmgen_ddata *ddata; + struct clk *clk; + void __iomem *io_base; + int ret; + + ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + io_base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(io_base)) + return PTR_ERR(io_base); + + ddata->regmap = devm_regmap_init_mmio(&pdev->dev, io_base, &axi_pwmgen_regmap_config); + if (IS_ERR(ddata->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(ddata->regmap), + "failed to init register map\n"); + + clk = devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), "failed to get clock\n"); + + ret = clk_rate_exclusive_get(clk); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to get exclusive rate\n"); + + ret = devm_add_action_or_reset(&pdev->dev, axi_pwmgen_clk_rate_exclusive_put, clk); + if (ret) + return ret; + + ddata->clk_rate_hz = clk_get_rate(clk); + if (!ddata->clk_rate_hz || ddata->clk_rate_hz > NSEC_PER_SEC) + return dev_err_probe(&pdev->dev, -EINVAL, + "Invalid clock rate: %lu\n", ddata->clk_rate_hz); + + ddata->chip.dev = &pdev->dev; + ddata->chip.ops = &axi_pwmgen_pwm_ops; + ddata->chip.atomic = true; + + ret = axi_pwmgen_setup(ddata, &pdev->dev); + if (ret < 0) + return ret; + + return devm_pwmchip_add(&pdev->dev, &ddata->chip); +} + +static const struct of_device_id axi_pwmgen_ids[] = { + { .compatible = "adi,axi-pwmgen-1.00.a" }, + { } +}; +MODULE_DEVICE_TABLE(of, axi_pwmgen_ids); + +static struct platform_driver axi_pwmgen_driver = { + .driver = { + .name = "axi-pwmgen", + .of_match_table = axi_pwmgen_ids, + }, + .probe = axi_pwmgen_probe, +}; +module_platform_driver(axi_pwmgen_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Sergiu Cuciurean "); +MODULE_AUTHOR("Trevor Gamblin "); +MODULE_DESCRIPTION("Driver for the Analog Devices AXI PWM generator");