From patchwork Mon Jan 29 15:31:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1892335 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=lFesfq20; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2707-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TNskH24tVz23fv for ; Tue, 30 Jan 2024 02:32:39 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0A86FB2537D for ; Mon, 29 Jan 2024 15:32:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E9CB9155A46; Mon, 29 Jan 2024 15:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lFesfq20" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 329E915442F for ; Mon, 29 Jan 2024 15:31:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542303; cv=none; b=kA0PjM4nLwwpw72gPLME2Q4M7i4WCZW014bmcw7wF8d8GyNB7FG36vnzek6DLewdXVGwg4BkW9dAJIWzuHub0CdGYy6oaOIsSmDaAfdpM7euUecFzXn1kFyC/7WUGZKpXzfGnuJ5IW0SWR0U+nbSMDgLTogCTD2Zf/oIPPKSEuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542303; c=relaxed/simple; bh=o51BgwUINRLb2Rh+uyAByfTYdtuxveCXUtLdizACuZ0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=IIeLIosiqY1zmmTW4cqmMhNZTHwDm3POtAWy/OCUs6GlAIomp5a4FO0Npc61C9rt4d1Ea2U4w+mQPew+G1sfSsx2Wwnh6iIcW9aXqkJLS/Y7tVT3CSoA0tsF0EYry5x6oUFv+XsosX3/yvHzOxaOhfvxCWptgjYqFSz5DSOPbTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=lFesfq20; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40T5fMu7006968; Mon, 29 Jan 2024 09:31:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=A iNcgNsNR3ED+F23emoqO04WwmuVLFwXwovIMe3YjKE=; b=lFesfq20Nu6u5js6j fRKM7HWR+2VO19Mby6aQJlmgzcWugDIITvUm+QQatO8/LuyQFHn336Q3RaoQkBkT c6lCVztmuu4fsluLMG6xeNWpiUSTxVKGSk5JD3qkt+gKafsq4joEltiGQ7CvjtQ0 zt4AY84PzFglEcM6gVI9uUjPd9i21jZz+6G1tD+kOQwwvSoKJi/g8E4azuonknGt aBsWP+3unWh/NVWTl6oD/WZCdkdvqiG1ocQOe4fSi3PYDpnGLWZj5llbxvork5tL /7ibDRvoQon8+jEpiJrtq3oVJMFZNfCRc2H9Sai/iF+GVFNI6SAL2CF1ePpF9vgA Z/Rig== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vvy4nt7v4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 09:31:40 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 6AA2A820242; Mon, 29 Jan 2024 15:31:38 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH v3 1/3] pinctrl: cs42l43: Tidy up header includes Date: Mon, 29 Jan 2024 15:31:36 +0000 Message-ID: <20240129153138.3221604-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: owQgeG-M_7b7AjB3KwIZPRTCe0967HlU X-Proofpoint-GUID: owQgeG-M_7b7AjB3KwIZPRTCe0967HlU X-Proofpoint-Spam-Reason: safe Fixup a couple of incorrect header includes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- No changes since v2. Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index 012b0a3bad5a..24e21d1e0d06 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -5,10 +5,10 @@ // Copyright (c) 2023 Cirrus Logic, Inc. and // Cirrus Logic International Semiconductor Ltd. +#include #include #include #include -#include #include #include #include @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include From patchwork Mon Jan 29 15:31:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1892336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=HNeB45Pf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.48.161; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2708-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [147.75.48.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TNskJ0j3Gz1yQ0 for ; Tue, 30 Jan 2024 02:32:40 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D6A75B253E8 for ; Mon, 29 Jan 2024 15:32:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8A826155A47; Mon, 29 Jan 2024 15:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="HNeB45Pf" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C074A154437 for ; Mon, 29 Jan 2024 15:31:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542304; cv=none; b=LEM9VQ1xiWILebH+DK3YrFEM3MjX4Fu5ePZy2idWhvkKeInrizTvGB1oKCQmscjBrBDntKsjWvzYjUNtuHUUhmwpEHaXLSeK7vugh775y1jBnFTr3aGq9ZWX31vNCYVa0/xiP55ZG6/g5DI+C6mgijXRMZ3p4u8uVjXuyiEBPz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542304; c=relaxed/simple; bh=+V7iZF1bUt8ECxI5EV9HH6cERsk3vLmv0/bRF45pGXY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cDLVrt+VMj8KNmdrBVEL6tJ2BW8gO2tTDoa0sqVju2AHMUFTAJG8nc4nK6g21JmMVoWx/YlctPxxnu9XCLzpu22Ja6jbF56U/JxAgArMdmjAy7qf0vc9+eYgS8V/buyH8SSORnupzgH2fKhzxxwVEc/uk70OoA8Yu8sIYeOcGLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=HNeB45Pf; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40T5fMu8006968; Mon, 29 Jan 2024 09:31:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=vmWY+/jhmqFsrWkgefV76QwMAA1N/XimswufTU3NWtE=; b= HNeB45PfYa1d3I63Gnncys9qQSXPJjTwqo1Q6Eh8caDsKtAWt5Rsbc8sOhMDbFG2 oR0ubR5D/odo5BO6JAh/hUT2pNbOOOBq+xe/veImpDoYlLV8wD8LVqRD7rc0SXO1 5a9ptSKwFhuxPnJgStv5IPCI9HiWxJLNbM500VOaN8uQEPMMyyhw0DXZmSZc+wuX iten/1o0O/rGS+gvGJRQbKCkr+19SNU3EtyyXBVB4gSyWHsQDfqlqHAgBn8Nn6Wy YI7YPHEjDM0s5U47pUmZWl5mncemh74a91WtFyvnL+j20aFmQdofp/XxQbJcVZ3r e3GMWCRE13E4bk5/ugyp+A== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vvy4nt7v4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 09:31:40 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 78335820247; Mon, 29 Jan 2024 15:31:38 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH v3 2/3] pinctrl: cs42l43: Remove some needless inlines Date: Mon, 29 Jan 2024 15:31:37 +0000 Message-ID: <20240129153138.3221604-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240129153138.3221604-1-ckeepax@opensource.cirrus.com> References: <20240129153138.3221604-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: i5P1hEvCYgps4hrYMr1A8dX5NNNMLH8_ X-Proofpoint-GUID: i5P1hEvCYgps4hrYMr1A8dX5NNNMLH8_ X-Proofpoint-Spam-Reason: safe Remove some pointless inline declarations, no reason not to let the compiler decide. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- No changes since v2. Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index 24e21d1e0d06..ac3df58bbe95 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -276,7 +276,7 @@ static const struct pinmux_ops cs42l43_pin_mux_ops = { static const unsigned int cs42l43_pin_drv_str_ma[] = { 1, 2, 4, 8, 9, 10, 12, 16 }; -static inline int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int pin) +static int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int pin) { const struct cs42l43_pin_data *pdat = cs42l43_pin_pins[pin].drv_data; unsigned int val; @@ -289,8 +289,8 @@ static inline int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int return cs42l43_pin_drv_str_ma[(val & pdat->mask) >> pdat->shift]; } -static inline int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int pin, - unsigned int ma) +static int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int pin, + unsigned int ma) { const struct cs42l43_pin_data *pdat = cs42l43_pin_pins[pin].drv_data; int i; @@ -314,7 +314,7 @@ static inline int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int return -EINVAL; } -static inline int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) +static int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) { unsigned int val; int ret; @@ -332,8 +332,8 @@ static inline int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) return 85; // Debounce is roughly 85uS } -static inline int cs42l43_pin_set_db(struct cs42l43_pin *priv, unsigned int pin, - unsigned int us) +static int cs42l43_pin_set_db(struct cs42l43_pin *priv, unsigned int pin, + unsigned int us) { if (pin >= CS42L43_NUM_GPIOS) return -ENOTSUPP; From patchwork Mon Jan 29 15:31:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1892337 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=E+aK5Kuk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2709-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TNskL70Mqz1yQ0 for ; Tue, 30 Jan 2024 02:32:42 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BFA0B1F28E37 for ; Mon, 29 Jan 2024 15:32:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B33015443F; Mon, 29 Jan 2024 15:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="E+aK5Kuk" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A90F153BE2 for ; Mon, 29 Jan 2024 15:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.149.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542305; cv=none; b=TqZaB9puM58KI46shh4UlivIU9yWX1nQPXjMjwZGz8gQQO7JjIKC3ksx328OG5wyJTINDjCbCh7ByhUofJspD3dKlMg+4CUnsVkN/i5uSv5Rh5AcSIDWNI5cRSeK3VrXsTZ3ovkS0CiprWxUORSAmtQrQvGCxvFAYAzDRuUGlJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542305; c=relaxed/simple; bh=O5AzXYIv7qNh7z2Idnp756efMnOmZjvhgPhQJv/z3Lo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qPVCXjb5C5wPFv7VnIYx+3QQxzG2oJanSK6IMnwUDO8tn/Z7swRm3nNlAjyad5MPnWyWVfsDMN28noI8B0+M3j3W2HXUok9ABohsUzzaT5ieSQoQH3tBeJyzMJSTMeqgP3ZqxyODPDnRu5i8+ndiE4Cyft3lxkmsQAl7UuOcq6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=E+aK5Kuk; arc=none smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40T4qVig031043; Mon, 29 Jan 2024 09:31:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=LhpPTyVrGWuvzM/d1AXCKxPRub9zof/YDSOLxPlYd1U=; b= E+aK5Kuk2rZpfqrNQwH/UAN0wnOeb/MkqoqsqHnv9vJFchyEUkojRDMERV4h0QN3 Bt3kOfbrpTmqqHQWa5YjBwtA+WJ/qhJpAVBQeASJ0muTFZ1lffsSVbXHvVBPbd92 SMpy7Q0CAzAu/ZAv0NA4SQksyHKdFjVjvvQy56NwB0agyJNtJ4+HQliM7IXokmQf jt+evFz1eyvVzlgUY3CmsYcrYirSdpNLhdSOZlNQBvh7te7Cr+K7Jr8/3eyRhrYD lzHoCtAtqBk4PmextqHlzIzxYjsWaaELbfFGdJGUklmzhELgT9y9Kf+cVJVPmHp6 ZWwrmpXGgwS1hycZ1n9nWw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3vw043t6m6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 09:31:40 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Mon, 29 Jan 2024 15:31:38 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 7B567820248; Mon, 29 Jan 2024 15:31:38 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH 3/3] pinctrl: cs42l43: Use str_high_low() Date: Mon, 29 Jan 2024 15:31:38 +0000 Message-ID: <20240129153138.3221604-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240129153138.3221604-1-ckeepax@opensource.cirrus.com> References: <20240129153138.3221604-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: rpEaC1rKtOmHrJPHIQOEIqTIFZtNSqCa X-Proofpoint-GUID: rpEaC1rKtOmHrJPHIQOEIqTIFZtNSqCa X-Proofpoint-Spam-Reason: safe Use str_high_low() rather than open coding. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- Changes since v2: - Added missing brackets in commit message. Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index ac3df58bbe95..628b60ccc2b0 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -490,7 +490,7 @@ static void cs42l43_gpio_set(struct gpio_chip *chip, unsigned int offset, int va int ret; dev_dbg(priv->dev, "Setting gpio%d to %s\n", - offset + 1, value ? "high" : "low"); + offset + 1, str_high_low(value)); ret = pm_runtime_resume_and_get(priv->dev); if (ret) {