From patchwork Thu Jan 25 10:33:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1890613 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=OdoN81Lx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2566-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TLHHv6rrnz23f0 for ; Thu, 25 Jan 2024 21:34:19 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3CAB4B2A485 for ; Thu, 25 Jan 2024 10:33:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81353225A9; Thu, 25 Jan 2024 10:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="OdoN81Lx" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF7C22329 for ; Thu, 25 Jan 2024 10:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178807; cv=none; b=k5W1jy+4I5lNSYXWD4CGgIIQwP3hVxDEJamM0D4/JHB0rNe9MrydbCyLg1VUiNYjSxJKTNQBNLYo5La1gjwuqB454lQjaAk84YneX+H5CkAwBm8TNwLtgwN8uEkbaDKvCmqDEkLhsNk4gcMGU1AGZKE9uz/sLUq37i+75Q30ihM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178807; c=relaxed/simple; bh=ixr+ngAHWcc7WgvZ8G73S74mVh8hQtmI36R6aVuob2g=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=IZfL7niXG37WrVLQhZkOxWbAIDvBdSwC6ZX1TZjxXJGMWV1NL3AQMlr90w9WnwAZNLyJnl33RJ9ENnCgNKuBi0pD0+h0KkaL8BYtGsbJuNERWeQ+lwLyErj3gWe4VqRUVzP41Zu8KoOmae+scYl+i/WxjyDLi3sCV97sXG2cwNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=OdoN81Lx; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSx014010; Thu, 25 Jan 2024 04:33:24 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=e QJz3DXt+H2ZmzOkRcCcmuWoccPIHYotDhNHpeTMd24=; b=OdoN81LxJH+sWyiYc vSySpvhAb7CyfKjRVqPv2X8u7MKn4n4rm7owLvsGpPj2KHsd3ppLRr16/aAfGGej v11kFCutXFQSMCorZlwuEQQvM/EdTz5MFUUlRSc8vKE3dvHhsowMYMdmN6A6UVLo n4XXObWe0zkOw/AHQt9xQFhN+E7+onU4beKWe8RaugYJDkGQuwDS6BFpL4Uj5OId rFYkOAtSoXwOI2wiPTIUNlf5Exr+1KIv00+MeiEDgkpDY3oyAwhi94hIT1Z3jqiP tQ+UxvZ5Yqtmx3Dznpqe2pv6P3xcfuVobmJYFn3jpQ3gd8InCC8KNhf7RIhE3FRi STPzw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2rd-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:33:23 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id B7803820247; Thu, 25 Jan 2024 10:33:21 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH v2 1/3] pinctrl: cs42l43: Tidy up header includes Date: Thu, 25 Jan 2024 10:33:19 +0000 Message-ID: <20240125103321.2622277-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: Iv_VAr7X4zCANsdTRJNhHCK5lw1gCYoh X-Proofpoint-ORIG-GUID: Iv_VAr7X4zCANsdTRJNhHCK5lw1gCYoh X-Proofpoint-Spam-Reason: safe Fixup a couple of incorrect header includes. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- No changes since v1. Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index 012b0a3bad5a9..24e21d1e0d06c 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -5,10 +5,10 @@ // Copyright (c) 2023 Cirrus Logic, Inc. and // Cirrus Logic International Semiconductor Ltd. +#include #include #include #include -#include #include #include #include @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include From patchwork Thu Jan 25 10:33:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1890614 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=kEY1zwSB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.48.161; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2564-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [147.75.48.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TLHHy0dW2z23f0 for ; Thu, 25 Jan 2024 21:34:22 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5066EB2A2C1 for ; Thu, 25 Jan 2024 10:33:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6F9B1CD18; Thu, 25 Jan 2024 10:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="kEY1zwSB" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C60E22099 for ; Thu, 25 Jan 2024 10:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178806; cv=none; b=kfhMp3WUMR6aRzfjBPn29CZJo73M2BTwLN7bSclMxG50bapC+n8ET4S/1xd5vGP8VHnr70iYy33IH66R5AlffpRTeqJ3Sl1j3+RN6ZQCNa/m66EyeiNeDRAsJb+RLzIvZQMp+vlGmrGPIMEcoie9F+xO3zmTGzP8UDWTmUiQ2jA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178806; c=relaxed/simple; bh=chzSejzfET32T6MExRy+TyEIxSL7Rh1Il0XzNm7rv9c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jmtjcH+C8cJNt1+4w/FXPL3s5ZbLjtaSw6mhWKrnnsFvu2pa1f+u8ktgFcN1N2PWD/RR1dP+aQpLDsfeZ0dQ/EBrBG8roSwlkXZrLfzVWRoNqd/PIYsHf2ErhgviW8qajXxnxraVHEZxe4kcbTp9a7o/XbzzDPugpWfcKusile0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=kEY1zwSB; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P5wLQA008959; Thu, 25 Jan 2024 04:33:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=/QeOuU99hhn7DP5qgZosWGIMNYI93BB09yMUvBY/K14=; b= kEY1zwSBwTu4hgwSyRh0wBIEdKz1kq397OUUXFyJCQY4Oh84RNAj9Wam4svt7qLP MVcHOi733utnsukeWJVhFl6aeCLPYmjr1AO8eU5ym0MH/SbOCotLFprxHOCa4CMI SpaugIhHkL9YtdxhhCvkSotVBnIp8g0r0xo4iyyYQpmMHXCdWQQjfUDKfTUztwx5 D9JUyw+fJ88Q5GVWSVE5uJOG9wS6T4P+WXy6eeXba6XafQxyrPAb9T0nna2xGBFm NWiq41t/K5Ve7++JygfHK0y36m/VD/wKdrgYmEKeT+hTE5GBrNvxGHB38IkOfSS8 Ug4xdJkr5eLPy4nxhJuH5w== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2re-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:33:23 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id C6037820246; Thu, 25 Jan 2024 10:33:21 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH v2 2/3] pinctrl: cs42l43: Remove some needless inlines Date: Thu, 25 Jan 2024 10:33:20 +0000 Message-ID: <20240125103321.2622277-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125103321.2622277-1-ckeepax@opensource.cirrus.com> References: <20240125103321.2622277-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: LgD10Ys9-95aIQEK46T9ZC0MM46PlElY X-Proofpoint-ORIG-GUID: LgD10Ys9-95aIQEK46T9ZC0MM46PlElY X-Proofpoint-Spam-Reason: safe Remove some pointless inline declarations, no reason not to let the compiler decide. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- Changes since v1: - Added commit message Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index 24e21d1e0d06c..ac3df58bbe951 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -276,7 +276,7 @@ static const struct pinmux_ops cs42l43_pin_mux_ops = { static const unsigned int cs42l43_pin_drv_str_ma[] = { 1, 2, 4, 8, 9, 10, 12, 16 }; -static inline int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int pin) +static int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int pin) { const struct cs42l43_pin_data *pdat = cs42l43_pin_pins[pin].drv_data; unsigned int val; @@ -289,8 +289,8 @@ static inline int cs42l43_pin_get_drv_str(struct cs42l43_pin *priv, unsigned int return cs42l43_pin_drv_str_ma[(val & pdat->mask) >> pdat->shift]; } -static inline int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int pin, - unsigned int ma) +static int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int pin, + unsigned int ma) { const struct cs42l43_pin_data *pdat = cs42l43_pin_pins[pin].drv_data; int i; @@ -314,7 +314,7 @@ static inline int cs42l43_pin_set_drv_str(struct cs42l43_pin *priv, unsigned int return -EINVAL; } -static inline int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) +static int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) { unsigned int val; int ret; @@ -332,8 +332,8 @@ static inline int cs42l43_pin_get_db(struct cs42l43_pin *priv, unsigned int pin) return 85; // Debounce is roughly 85uS } -static inline int cs42l43_pin_set_db(struct cs42l43_pin *priv, unsigned int pin, - unsigned int us) +static int cs42l43_pin_set_db(struct cs42l43_pin *priv, unsigned int pin, + unsigned int us) { if (pin >= CS42L43_NUM_GPIOS) return -ENOTSUPP; From patchwork Thu Jan 25 10:33:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 1890612 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=IPpq4xLv; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-gpio+bounces-2565-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TLHHY3qV1z23f0 for ; Thu, 25 Jan 2024 21:34:01 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 42FD9B23398 for ; Thu, 25 Jan 2024 10:33:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CEC3F22099; Thu, 25 Jan 2024 10:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="IPpq4xLv" X-Original-To: linux-gpio@vger.kernel.org Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA1D22303 for ; Thu, 25 Jan 2024 10:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178806; cv=none; b=Yzvo01IEamsIFAc7l/Ey7UAK2ML81vYc5bHDZSkj7iRRdGouRVE/nvRGTuz2zXOwnW1nktz67t7jTxUs7sKDuRduFVxKlG5VLXhT/zMo/PVwzsR3QAkY/LffnWLH07FTAee1QQsiRXvHwTnZW8xg4GPUpmMh3chnx7a4Bk/CfHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178806; c=relaxed/simple; bh=Lb+75PxGk5ZSSmxpqdnwWt4mQ9hIV0Xdh2tvTk3aRk8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kOQpbFw46pDqD//OIg9EHNqJmbK+jrlpQJwVzgGJli8JVgNXBpPl7RqwopkpZkFelcYe/y7P2Q9EzW66Xmp6HodIkkhCO33zWfbtOYkITDboTPe71pQMeqAk8aWhs/tSYI4bCV8mZxZwFxjAcrUgC/WdmZ7d9jT+FXLLPI2TraI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=IPpq4xLv; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSw014010; Thu, 25 Jan 2024 04:33:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=uS7VtLE2le/Y/2kJjsEOrWV+3WlfX4zzNadAV/IYz7I=; b= IPpq4xLvbqAMhRRKL4Kjou9cUQV9KtFcrarImi+biU9LAqiSB4mIua71qWGmpwKx ChSXlICQV1AaPzdHlTB8rMiu21iHYhiRl+YftRfQa0kPAYSzk4y2W0lc4QsswYZ3 5+uSogmczcteaV4AuTmG6hniFGHQ8pFzL6Mgn/STVhIsNwzsErdD6sLhN/KHHqcm x9CsU2K27f/9otlG+r3UN3XfDSC2qCuh+rHdIHRLe6ycCKgMU85TtknCgAia/M38 pWPAa4GKWuuuJ03Wwmq067GO0oR39kquB3BC5tIsNgnBNGR6f00Q7lvMpH0Ip3b8 ESRyQSXEGHCnRdOn8zZjlA== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2rd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:33:23 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:33:21 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id D2459820248; Thu, 25 Jan 2024 10:33:21 +0000 (UTC) From: Charles Keepax To: CC: , , Subject: [PATCH v2 3/3] pinctrl: cs42l43: Use str_high_low Date: Thu, 25 Jan 2024 10:33:21 +0000 Message-ID: <20240125103321.2622277-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125103321.2622277-1-ckeepax@opensource.cirrus.com> References: <20240125103321.2622277-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: 9pINfeT0kO5b8GWqptmNpi9bC3CbaETb X-Proofpoint-ORIG-GUID: 9pINfeT0kO5b8GWqptmNpi9bC3CbaETb X-Proofpoint-Spam-Reason: safe Use str_high_low rather than open coding. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Charles Keepax --- Changes since v1: - Added commit message Thanks, Charles drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c index ac3df58bbe951..628b60ccc2b07 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -490,7 +490,7 @@ static void cs42l43_gpio_set(struct gpio_chip *chip, unsigned int offset, int va int ret; dev_dbg(priv->dev, "Setting gpio%d to %s\n", - offset + 1, value ? "high" : "low"); + offset + 1, str_high_low(value)); ret = pm_runtime_resume_and_get(priv->dev); if (ret) {