From patchwork Mon Apr 16 17:04:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arturo Borrero Gonzalez X-Patchwork-Id: 898794 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netfilter.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Pvqf6Knlz9s0t for ; Tue, 17 Apr 2018 03:04:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752831AbeDPREO (ORCPT ); Mon, 16 Apr 2018 13:04:14 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:46032 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbeDPREN (ORCPT ); Mon, 16 Apr 2018 13:04:13 -0400 Received: by mail-wr0-f196.google.com with SMTP id u11so28033105wri.12 for ; Mon, 16 Apr 2018 10:04:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=mbschTvves31WB71LHqt0R3Qm6d7KD+slXFnFeZX5R0=; b=TMgjZcUpi00wtJtKJVLRE5YG0O2xSHSIZ7rBw4x1dLMXTE7vByZx+UhgYDpvH2yMkO 2jJLbHPZLg5i9YCO5P/VDFsbjNfcgsGDk1EpEoHpUCGgQQtjDJxtqhoy6jcjJdDxo9k6 9YQwGlUcd3tdCOaxM/40SoQ+FF8SfR8/IBRKc2MmykqRvJfKUET5tPeMsjTN4/ur7qrZ okDa9tUMhVm6DsLhsWPT8flLer4M4LlNcKLR+YjW85AhLaA9LBHpAk4adPvm45U5eF1c /32JyeTplQ3YEhaKQDjb8fMt0ripet53rqVuSq8e+QhsCMw9Cojqh5zaCbVndpsErwrY Z8HA== X-Gm-Message-State: ALQs6tBvYyx6Mu93pDoetoiRZsHqIs7A3J/ugl3f5dxaq0GgGMiPUZcG 4K9EJsGqXKQyjK1bSm+uD935sthp X-Google-Smtp-Source: AIpwx4+TnOjGdB1WHGBMwCI6w5njhXKYCAqVF3aaeiCJDYR8vGaLFXUebriapZ6ZoHfdU2n4Z5TXcg== X-Received: by 10.223.172.170 with SMTP id o39mr11204024wrc.38.1523898252615; Mon, 16 Apr 2018 10:04:12 -0700 (PDT) Received: from endurance (44.red-88-15-116.dynamicip.rima-tde.net. [88.15.116.44]) by smtp.gmail.com with ESMTPSA id x3sm1583203wre.87.2018.04.16.10.04.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 10:04:11 -0700 (PDT) Received: by endurance (sSMTP sendmail emulation); Mon, 16 Apr 2018 19:04:10 +0200 Subject: [conntrack-tools PATCH] conntrackd: add missing fall-through annotation in switch statements From: Arturo Borrero Gonzalez To: netfilter-devel@vger.kernel.org Date: Mon, 16 Apr 2018 19:04:10 +0200 Message-ID: <152389825033.32583.14594499960094575906.stgit@endurance> User-Agent: StGit/0.18 MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Modern GCC compilers will warn if an explicit comment isn't present. Perhaps this should be better done with a proper compiler instruction, but the code comment is more similar to the rest of the codebase. Signed-off-by: Arturo Borrero Gonzalez --- src/cache-ct.c | 2 ++ src/cache-exp.c | 1 + src/tcp.c | 1 + 3 files changed, 4 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/cache-ct.c b/src/cache-ct.c index f86d143..fa5072c 100644 --- a/src/cache-ct.c +++ b/src/cache-ct.c @@ -266,6 +266,7 @@ static int cache_ct_commit(struct cache *c, struct nfct_handle *h, int clientfd) STATE_SYNC(commit).stats.ok = c->stats.commit_ok; STATE_SYNC(commit).stats.fail = c->stats.commit_fail; STATE_SYNC(commit).clientfd = clientfd; + /* fall-through */ case COMMIT_STATE_MASTER: STATE_SYNC(commit).current = hashtable_iterate_limit(c->h, &tmp, @@ -280,6 +281,7 @@ static int cache_ct_commit(struct cache *c, struct nfct_handle *h, int clientfd) } STATE_SYNC(commit).current = 0; STATE_SYNC(commit).state = COMMIT_STATE_RELATED; + /* fall-through */ case COMMIT_STATE_RELATED: STATE_SYNC(commit).current = hashtable_iterate_limit(c->h, &tmp, diff --git a/src/cache-exp.c b/src/cache-exp.c index 9183b2c..acdae10 100644 --- a/src/cache-exp.c +++ b/src/cache-exp.c @@ -236,6 +236,7 @@ cache_exp_commit(struct cache *c, struct nfct_handle *h, int clientfd) STATE_SYNC(commit).stats.ok = c->stats.commit_ok; STATE_SYNC(commit).stats.fail = c->stats.commit_fail; STATE_SYNC(commit).clientfd = clientfd; + /* fall-through */ case COMMIT_STATE_MASTER: STATE_SYNC(commit).current = hashtable_iterate_limit(c->h, &tmp, diff --git a/src/tcp.c b/src/tcp.c index c8f2544..91fe524 100644 --- a/src/tcp.c +++ b/src/tcp.c @@ -300,6 +300,7 @@ ssize_t tcp_send(struct tcp_sock *m, const void *data, int size) /* we got connected :) */ m->state = TCP_CLIENT_CONNECTED; } + /* fall through */ case TCP_CLIENT_CONNECTED: ret = sendto(m->fd, data, size, 0, (struct sockaddr *) &m->addr, m->sockaddr_len);