From patchwork Wed Jan 17 18:17:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 1887594 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ucw.cz header.i=@ucw.cz header.a=rsa-sha256 header.s=gen1 header.b=Ttg0NtIq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TFYyS02WJz1yPh for ; Thu, 18 Jan 2024 05:17:50 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D27653858409 for ; Wed, 17 Jan 2024 18:17:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id C39B03858D33 for ; Wed, 17 Jan 2024 18:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C39B03858D33 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C39B03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705515451; cv=none; b=N2sr4YTMzX91xHLX6Y3liAJN2jL5qd9m6r+UjhftSzKgwrWSkj+IMMNYojCwZhsdEzCsDcKrI0ARK7MvTR3LqIjamrB8zu/rYlx1NHqhPinYab/2zfrG7ZZFZDmQgv6gKPjE1tdTdL+JIkp5pWxjb1krJE/uhHeadJdbrFsAjP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705515451; c=relaxed/simple; bh=Rbrm2JgrgfP2y75DyujLwMMKusg2P7h4J5fv6DWtbeQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=xFRUmHTtt2ERhEECGaC9HiH77D2BIv+I0qxlUq1me/vRc3mnBq1durqKV+GtUJ9FPjTRBjIo09SnkMlgmMVe6BT+vW3gjafH+7dNjEWTIWwZrEw75fgF0OnPGhMY9fn6jEfSmJwukFYmdZ9eLNQBjCRHJ9F4iJ6N+7DBp2O6HCE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 74DC6283B66; Wed, 17 Jan 2024 19:17:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1705515447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=5D/bvlpcrWXRrJgORVHaqYV7ajyGRwPopmo/IKd08bs=; b=Ttg0NtIqUSJ1b9aRQgdTON7YJx5gjr51G/Yo8DzI6gJb5b82jLe112QK3ReIvO23CfkxNe g5BODyK5jHfbhU5w/WJvc3x2IxSEdtQKdNWMLphdcR/bIO57YxeYxiJbSje08JmPRMbFKh +P5WQvU8sxj4G0q4jpaWFIO8b8a/CWg= Date: Wed, 17 Jan 2024 19:17:27 +0100 From: Jan Hubicka To: gcc-patches@gcc.gnu.org Subject: Remove accidental hack in ipa_polymorphic_call_context::set_by_invariant Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, I managed to commit a hack setting offset to 0 in ipa_polymorphic_call_context::set_by_invariant. This makes it to give up on multiple inheritance, but most likely won't give bad code since the ohter base will be of different type. Bootstrapped/regtested x86_64-linux, comitted. gcc/ChangeLog: * ipa-polymorphic-call.cc (ipa_polymorphic_call_context::set_by_invariant): Remove accidental hack reseting offset. diff --git a/gcc/ipa-polymorphic-call.cc b/gcc/ipa-polymorphic-call.cc index 8667059abee..81de6d7fc33 100644 --- a/gcc/ipa-polymorphic-call.cc +++ b/gcc/ipa-polymorphic-call.cc @@ -766,7 +766,6 @@ ipa_polymorphic_call_context::set_by_invariant (tree cst, tree base; invalid = false; - off = 0; clear_outer_type (otr_type); if (TREE_CODE (cst) != ADDR_EXPR)