From patchwork Tue Dec 26 09:06:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Otcheretianski X-Patchwork-Id: 1880216 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=igdLmK8E; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Bvi+GQGY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Szpp71rgPz20Rq for ; Tue, 26 Dec 2023 20:07:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Vm86jD/cPtTfpf6CST+7/ddL46MRmFYC4OQTUrfmyC0=; b=igdLmK8EXOOxMs u2m2B+F+sVuB2ukG6MjH9SJasB2OO++c1k/iFbgBvha2dIhwlkAaIZ6LjoGVu8Bcdk+8wNdYBXcTo aK0ehQ80aFVZ1l4n9OZxXSQWT2PazrwcrdUkpbrhgSls16POwPU9nuRFCNWlAofgObEmvkI/2oSbF kfKHrCH595WFsZbkhbgHzXXtdCgQ++FZFJDQo8k90n5Xx0rS6lwDNZgcFzyTxd9QfgESmBDZDy0BA rT6r03MZVfDqqOmNLo1Dal6dn2GB/sYth1ftjj01SDWIOtFrM0LyxdgePsbY8zbZ6jcOSvuRvpejI uk116HCW0WJoiHhRS/Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rI3P4-00BxRr-1j; Tue, 26 Dec 2023 09:07:10 +0000 Received: from mgamail.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rI3P1-00BxRO-30 for hostap@lists.infradead.org; Tue, 26 Dec 2023 09:07:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703581627; x=1735117627; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cHHsVlVOw6AOLojN/SnfGoXOueazhBEyON8P5R4+pPk=; b=Bvi+GQGYgT40v03Q2rhrx2IwzIOe+4r3d6y5w9OYf54aXo29Tohdy+aP n8hYy5drNR2xXLB0w3NDMxaitt9KaWmSqb159hZ1KFM+uHvUTepteuV2Y zUJWAmxpf89zo0/sxxubNW+GHZP0/3KWdf2Hj5Ui7yTHpn+NUsPnCTrpK w1/+qgXcyjTdKaD7q1OFz5S2waggL4vsaya0ctDFaxNtQkQGgfnD0ty/r l8a/4jMhupzlNXBTi/XYsJ1lCt1vIcGCFLP8ngVtXFdQNrWc52bOAD4uu 2+Jgjlj2aQvMfD1RkpWcE8GMfUBEcQN1k9KhSO/KpazGNQKwWMzV6D26v A==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="386763041" X-IronPort-AV: E=Sophos;i="6.04,306,1695711600"; d="scan'208";a="386763041" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2023 01:07:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="727698729" X-IronPort-AV: E=Sophos;i="6.04,306,1695711600"; d="scan'208";a="727698729" Received: from unknown (HELO WEIS0042.iil.intel.com) ([10.12.217.211]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2023 01:07:04 -0800 From: Andrei Otcheretianski To: hostap@lists.infradead.org Cc: Ilan Peer Subject: [PATCH] AP: Do not iterate disabled interfaces when adding RNR Date: Tue, 26 Dec 2023 11:06:23 +0200 Message-ID: <20231226090625.477451-1-andrei.otcheretianski@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_010708_060400_B7223714 X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Ilan Peer Signed-off-by: Ilan Peer --- src/ap/ieee802_11.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index a939ad35e2..dc41f87da6 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -7403,6 +7403,9 @@ static size_t hostapd_eid_rnr_multi [...] Content analysis details: (-2.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [134.134.136.20 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [134.134.136.20 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Ilan Peer Signed-off-by: Ilan Peer --- src/ap/ieee802_11.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index a939ad35e2..dc41f87da6 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -7403,6 +7403,9 @@ static size_t hostapd_eid_rnr_multi_iface_len(struct hostapd_data *hapd, iface = hapd->iface->interfaces->iface[i]; bool ap_mld = false; + if (iface->state != HAPD_IFACE_ENABLED) + continue; + #ifdef CONFIG_IEEE80211BE if (hapd->conf->mld_ap && iface->bss[0]->conf->mld_ap && hapd->conf->mld_id == iface->bss[0]->conf->mld_id) @@ -7612,6 +7615,9 @@ static u8 * hostapd_eid_rnr_iface(struct hostapd_data *hapd, u8 tbtt_count = 0, op_class, channel; bool ap_mld = false; + if (iface->state != HAPD_IFACE_ENABLED) + return eid; + #ifdef CONFIG_IEEE80211BE ap_mld = !!hapd->conf->mld_ap; #endif /* CONFIG_IEEE80211BE */ @@ -7676,6 +7682,9 @@ static u8 * hostapd_eid_rnr_multi_iface(struct hostapd_data *hapd, u8 *eid, iface = hapd->iface->interfaces->iface[i]; bool ap_mld = false; + if (iface->state != HAPD_IFACE_ENABLED) + continue; + #ifdef CONFIG_IEEE80211BE if (hapd->conf->mld_ap && iface->bss[0]->conf->mld_ap && hapd->conf->mld_id == iface->bss[0]->conf->mld_id)