From patchwork Mon Dec 18 14:22:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1877474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P04/AxZH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Sv2972nPXz23yq for ; Tue, 19 Dec 2023 01:22:51 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70FB43858023 for ; Mon, 18 Dec 2023 14:22:49 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E24B4385828F for ; Mon, 18 Dec 2023 14:22:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E24B4385828F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E24B4385828F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702909362; cv=none; b=iw8YGuCjMbCsEc9rrUVdt41tqe/tpCAMKSKDYJ/HsCVs+3VMZ4p0rwrRBkG6Gbz5Az0l/k5Jl1uubL223U/KJ5KSOHH6lMf5cUDcaSEBSKYQZkdusMMJu9FyY2OEirJ16oH92b6l8BOeSfZ+EFTZNPwv86R5W+DBuBDlF7UIPfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702909362; c=relaxed/simple; bh=/XeSqQqP9kuODmXjFl2mVWGeRFj75lYAQZmJ85wpUjU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=W7UEiQjWbkHRBhteAXDMWBjO4y9feKjHJyLYJyqt9qnqsJZfaqxrD+Vh9CtDMIJwFLPQ8oCt7JDBMqQxPmKmY9B+J+qnpNKLMrn2FNZVKpFIHGdHMYLF9vlw+9PdCOfs+M1urCw37QoXZtH5RoAs6S0z7AoPDwJTce5qpsHAq4k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702909361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=23RO+KZpsCD5m4RQ792dVgME5a1OsnA0orhg/wWVXTA=; b=P04/AxZHFuOra9AJ2anLvojTKhdD7/Y39oLZUoKUvZA2jM5Vd4YtQd5opeqf7wKkAocP0b Ys5orfCx3HVmw8pdmjjpIznX8MQ92sUoxHtIpHeT4nc/azHqR/FceOoA0gT/mjSXT9CMYe lKPMYE97sIU9WpdansiFoi4/Vp45790= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-K0EeAkHFNB-YOD9Bb7rhjg-1; Mon, 18 Dec 2023 09:22:40 -0500 X-MC-Unique: K0EeAkHFNB-YOD9Bb7rhjg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25B94101A5DC for ; Mon, 18 Dec 2023 14:22:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99D542166B33; Mon, 18 Dec 2023 14:22:39 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Cc: Carlos O'Donell Subject: [PATCH] nss: Remove unused allocation from get_nscd_addresses in getaddrinfo Date: Mon, 18 Dec 2023 15:22:38 +0100 Message-ID: <87msu71tg1.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org No bug because this is not visible if glibc is built with optimization. Otherwise this would be a critical resource leak. Reviewed-by: Carlos O'Donell --- Tested on i686-linux-gnu and x86_64-linux-gnu. nss/getaddrinfo.c | 1 - 1 file changed, 1 deletion(-) base-commit: 12ab77e893479a1f7d4666082a48efad79777bb9 diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c index 531124958d..ce3af931b2 100644 --- a/nss/getaddrinfo.c +++ b/nss/getaddrinfo.c @@ -514,7 +514,6 @@ get_nscd_addresses (const char *name, const struct addrinfo *req, int result = 0; char *addrs = air->addrs; - struct gaih_addrtuple *addrfree = calloc (air->naddrs, sizeof (*addrfree)); struct gaih_addrtuple *at = calloc (air->naddrs, sizeof (*at)); if (at == NULL) {