From patchwork Thu Nov 23 14:47:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 1867815 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=TcENdRs3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=devicetree+bounces-18315-incoming-dt=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SbgvZ6KfZz1yS0 for ; Fri, 24 Nov 2023 01:47:54 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6F896B215A9 for ; Thu, 23 Nov 2023 14:47:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A577F25770; Thu, 23 Nov 2023 14:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TcENdRs3" X-Original-To: devicetree@vger.kernel.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3AF3D4A; Thu, 23 Nov 2023 06:47:45 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2CEEAE0002; Thu, 23 Nov 2023 14:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1700750864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MZPJxfvoysVpxIWKBdmpAvA0+UBzj52BEZXDkonKlNQ=; b=TcENdRs3kz8fi6vTvuiHsyqu9OJv6uHiR+bRPRhy8PQDSLgM2G0CWPJNjDggo9N67ByqMp KUcURLficapDrJ+MR6fO0R6raSrIkzwIbKKpzLy83l44CYmItZTfHz8lefwAtq+5U30oQv llDWdphYiFVsHbPtO84+JgZDJlFbGZ/hqIKwUM02DG0I7Car4ma43yF2tdTCPxGT52jQpe pf2dMrOQdC6mozfR1EIeBIdxnroShqdZ+3+q2oLB7MWLxJH7BRlY8n0nDzwQY0Pka3AueG d8xSZQvcZox56d4/r3djwELkwtb9f4RKaav38RqfGD4LUNbgR86+TPUm/UmApQ== From: Luca Ceresoli Date: Thu, 23 Nov 2023 15:47:18 +0100 Subject: [PATCH] of: dynamic: Fix of_reconfig_get_state_change() return value documentation Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231123-fix-of_reconfig_get_state_change-docs-v1-1-f51892050ff9@bootlin.com> X-B4-Tracking: v=1; b=H4sIAPVlX2UC/y2NywrDIBBFf0VmXcFHAm1+pRQJzmhmo8GREgj59 0jp8sA995wg1JgEFnVCoy8L1zLAPhTEbS2ZNONgcMZ5a53XiQ9dU2gUa0mcQ6YepK+dwn+PNYp G88RpRovTy8P42hsN8dd5f67rBmhAxBN3AAAA To: Rob Herring , Frank Rowand , Grant Likely , Pantelis Antoniou Cc: Thomas Petazzoni , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.12.3 X-GND-Sasl: luca.ceresoli@bootlin.com The documented numeric return values do not match the actual returned values. Fix them by using the enum names instead of raw numbers. Fixes: b53a2340d0d3 ("of/reconfig: Add of_reconfig_get_state_change() of notifier helper.") Signed-off-by: Luca Ceresoli --- drivers/of/dynamic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- base-commit: f364a65e37ec9e57809642b00b39e7a530d9cbde change-id: 20231123-fix-of_reconfig_get_state_change-docs-d08d45d1d493 Best regards, diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c index 0a3483e247a8..a5afe14eef28 100644 --- a/drivers/of/dynamic.c +++ b/drivers/of/dynamic.c @@ -98,8 +98,9 @@ int of_reconfig_notify(unsigned long action, struct of_reconfig_data *p) * * Returns the new state of a device based on the notifier used. * - * Return: 0 on device going from enabled to disabled, 1 on device - * going from disabled to enabled and -1 on no change. + * Return: OF_RECONFIG_CHANGE_REMOVE on device going from enabled to + * disabled, OF_RECONFIG_CHANGE_ADD on device going from disabled to + * enabled and OF_RECONFIG_NO_CHANGE on no change. */ int of_reconfig_get_state_change(unsigned long action, struct of_reconfig_data *pr) {