From patchwork Tue Nov 21 21:24:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1867054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SZcp247H1z1yRg for ; Wed, 22 Nov 2023 08:24:25 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA3753858C52 for ; Tue, 21 Nov 2023 21:24:20 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id E1D9D3858D33 for ; Tue, 21 Nov 2023 21:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1D9D3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1D9D3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700601850; cv=none; b=YWov6SrxkhKuRF/dkx+JjUuQvnYMj8T8vGkLppy+n+2vFS5hMBeb9Jz499BaXR2Pgpkq9ZmwYHvbJ9qkDcOawhdbIz0XzISTIJDqOUtLRMSbG5MmvB23LqiQ6CuNC7JAF8Ck6hDeU2+zJ8/+ZdHRyotA7naFwIBvqv9Keuz1YBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700601850; c=relaxed/simple; bh=evgsei/Faf9lgx+JTg1QXtigTnRzZZZGroFnQbv86xk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=fRgziFt2wy3p8kpUFwP6llwIb9AjGdzYEQ887HI0V9X2x8Qc/GaKcKmWk4Ki9AbnjNh0+An7ptSNQ3Gj+vRTMzzAsYvcxAoLLvRG585K2rcHKk7AVTc1m5hrdErxHIF70bxKJ9m5YDAYtlLCmhaXgl6F8Pcckh+mRoKOgUddkaM= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: zS/EH7dbTgmtlhUq2KqdEQ== X-CSE-MsgGUID: TUKwjcMuRwuYjn8v6abePA== X-IronPort-AV: E=Sophos;i="6.04,216,1695715200"; d="scan'208,223";a="26425730" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 21 Nov 2023 13:24:07 -0800 IronPort-SDR: +YU0Oy+xX/ObKAG0klbppx9aBPm1eHyyqBB1ZkpSyqRM4sEmL7MLM7+N9WeJIy86wJDXtV0viQ mZf1YtwKle+5q8Mhysqx26ZIs4UdYKXeXIi5zIKMRRMBLczcz2aWrZxQZ11SKhStJ+tVN38/pK lAAo0jItOLGr0DKEpJVBT1+SFAETzOBtg/PWnY9ChIosRvzQMBkcCVAJGq4E9CztRfa+pttL3c ttkRqAKkK2JHYdLJx7aVIV5NHqtpkWrbji+syez/rnqNrejEZrB40cz5Dr5A0GThPspMRimkKg uQw= From: Thomas Schwinge To: Jan Hubicka , Subject: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values) In-Reply-To: References: <871qcmkmgd.fsf@gentoo.org> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Tue, 21 Nov 2023 22:24:00 +0100 Message-ID: <87r0kiu7f3.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c Pushed to master branch commit a0240662b22312ffb3e3fefb85f258ab0e7010f4 "Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned'", see attached. On powerpc64le-linux-gnu ('char' defaulting to 'unsigned') I still saw: /tmp/ccd1xwD7.o: In function `test': return-value-range-1.c:(.text+0x50): undefined reference to `link_error' Grüße Thomas > @@ -0,0 +1,22 @@ > +/* { dg-do ling } */ > +/* { dg-options "-O1 -dump-tree-evrp-details" } */ > +__attribute__ ((__noinline__)) > +int a(char c) > +{ > + return c; > +} > +void link_error (); > + > +void > +test(int d) > +{ > + if (a(d) > 200) > + link_error (); > +} > +int > +main(int argc, char **argv) > +{ > + test(argc); > + return 0; > +} > +/* { dg-final { scan-tree-dump-times "Recording return range" 2 "evrp"} } */ ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From a0240662b22312ffb3e3fefb85f258ab0e7010f4 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 21 Nov 2023 22:07:13 +0100 Subject: [PATCH] Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' ... added in recent commit 53ba8d669550d3a1f809048428b97ca607f95cf5 "inter-procedural value range propagation", fixed in commit 878a860cae78146d98d7a21612f0bcec0930a9c2 "Fix 'gcc.dg/tree-ssa/return-value-range-1.c'". gcc/testsuite/ * gcc.dg/tree-ssa/return-value-range-1.c: Fix. --- gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c index 74f1a5080bb..97294482c05 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c @@ -1,7 +1,7 @@ /* { dg-do link } */ /* { dg-options "-O2 -fdump-tree-evrp-details" } */ __attribute__ ((__noinline__)) -int a(char c) +int a(signed char c) { return c; } -- 2.34.1