From patchwork Fri Apr 6 22:11:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deb McLemore X-Patchwork-Id: 895865 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 40Hv6m1HGjz9s1s; Sat, 7 Apr 2018 08:11:28 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1f4ZZu-0003qo-Sq; Fri, 06 Apr 2018 22:11:26 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1f4ZZt-0003qY-JD for fwts-devel@lists.ubuntu.com; Fri, 06 Apr 2018 22:11:25 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w36M5wbi057908 for ; Fri, 6 Apr 2018 18:11:24 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0b-001b2d01.pphosted.com with ESMTP id 2h6bxan0vx-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Fri, 06 Apr 2018 18:11:24 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Apr 2018 18:11:23 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 6 Apr 2018 18:11:22 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w36MBMPe62062768; Fri, 6 Apr 2018 22:11:22 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C862BAE04E; Fri, 6 Apr 2018 18:13:03 -0400 (EDT) Received: from debmc-P50.localdomain (unknown [9.85.183.118]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 97FC6AE03C; Fri, 6 Apr 2018 18:13:03 -0400 (EDT) Received: by debmc-P50.localdomain (Postfix, from userid 1000) id 48A54D0026E; Fri, 6 Apr 2018 17:11:20 -0500 (CDT) From: Deb McLemore To: fwts-devel@lists.ubuntu.com Subject: [PATCH] opal: mem_info: Designate property optional Date: Fri, 6 Apr 2018 17:11:18 -0500 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 18040622-0044-0000-0000-000003FEB036 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008813; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000256; SDB=6.01014127; UDB=6.00516985; IPR=6.00793387; MB=3.00020453; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-06 22:11:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18040622-0045-0000-0000-0000082EC618 Message-Id: <1523052678-5715-1-git-send-email-debmc@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-06_12:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804060222 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Deb McLemore MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Some properties do not apply per platform. Signed-off-by: Deb McLemore Acked-by: Alex Hung Acked-by: Ivan Hu --- src/opal/mem_info.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c index 47b26ca..498449d 100644 --- a/src/opal/mem_info.c +++ b/src/opal/mem_info.c @@ -406,24 +406,17 @@ static int get_linux_mem_devices(fwts_framework *fw) fwts_log_nl(fw); if (!found) { - failures++; - fwts_failed(fw, LOG_LEVEL_CRITICAL, - "OPAL MEM Info", - "No MEM devices (memory-buffer@X) were found" - " in \"%s\". Check the system for setup" - " issues.", + fwts_skipped(fw, "OPAL MEM Info MEM devices " + "(memory-buffer@X) found in \"%s\"," + " not applicable for version.", DT_FS_PATH); } if (!found_dimm) { - failures++; fwts_log_nl(fw); - fwts_failed(fw, LOG_LEVEL_CRITICAL, - "OPAL MEM Info", - "No MEM DIMM devices (memory-buffer) were found" - " in \"%s\" with a status of \"okay\" or \"ok\"." - " This is unexpected so please check your" - " system setup for issues.", + fwts_skipped(fw, "OPAL MEM Info MEM DIMM devices " + "(memory-buffer@X) found in \"%s\"," + " not applicable for version.", DT_FS_PATH); }