From patchwork Fri Apr 6 19:52:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 895832 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lFlo6m/i"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Hr4626BZz9s0W for ; Sat, 7 Apr 2018 05:53:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbeDFTwz (ORCPT ); Fri, 6 Apr 2018 15:52:55 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:39487 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbeDFTwx (ORCPT ); Fri, 6 Apr 2018 15:52:53 -0400 Received: by mail-wr0-f193.google.com with SMTP id c24so2762356wrc.6; Fri, 06 Apr 2018 12:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=/3bCYl25bMMVvhlvy6qYNyPGdHHKHcFObQUMmV4Yroo=; b=lFlo6m/iPoBUbAuVYLsntR22VOfwuOvmm7M/QFz7jhZBtnysKMc6LEuaHlbP4DzHSw eeoAWzw0iCMXKEess+qO36h3tb63QpLy5JIJutnfVcqYOPibR8qNZWuHK06TwZm53eKV RT/qHd1vFw4t25VRfrNw/EcEI+nhCX0Fn75xaT0Wzi7VYCQ58hUh3EoMyIHEUEgDPmax 6xwQPwjzCQr1mEByu5xy4WGFh8El1rZQET/uYxfpp7XwazwmbpgdhiF4ajMvvpYUZLQW ESiYSZcbexmkVp8GtGQn6u9BuISL6Vo6psp7GV8mFNWpsDdBBC5dR7uMH+XQ0EzDnSkn rYkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=/3bCYl25bMMVvhlvy6qYNyPGdHHKHcFObQUMmV4Yroo=; b=ma0//Km1Zqgmm7TIdUpA2dk8YqraF5oi0yWiAca5T4RP7gu2Ykh87wz36+7ERy/fi+ IenoA+zCyDo6xe5Ac253Rwr6La/DSsu9j0CA+KLQ4dJU3X/7bGSTdHmzSyU6zzPcC4h9 zyp5cGHPo9IJooLA7fQ6xDRqjunIgv7fR53cYFr9kCCr4ZDBl1vO0RjrtOkDrRlN2zFr r2JAddAnTzAy9SGxEM7Js1xE+MV6H5uwYWbslkD3lqWXtjtAW7QEeD2CISvZHgijdypv dKiUCf++0lt1gPUycy19xdEPNNjL54QpAdTJy62sU/DHxDdTfQms5VrC0qcpyYjxzb33 XPmQ== X-Gm-Message-State: AElRT7GG4iJviUDm7jd2am9j9svrrcfdzgpbb4N4G0jUTZlGTMNQtOk/ yAD9Mtp5GySuKBGFlhng4D8= X-Google-Smtp-Source: AIpwx491IZVNBIBKG2jlOea9Q4yRm6i2RLlEO1R2mWvSFAIcL8RVEyhUzpE2FskOFmZxRwucA8kU5A== X-Received: by 10.223.159.9 with SMTP id l9mr18642825wrf.185.1523044371440; Fri, 06 Apr 2018 12:52:51 -0700 (PDT) Received: from macbookpro.malat.net (bru31-1-78-225-226-121.fbx.proxad.net. [78.225.226.121]) by smtp.gmail.com with ESMTPSA id e8sm23089459wmf.15.2018.04.06.12.52.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Apr 2018 12:52:50 -0700 (PDT) Received: by macbookpro.malat.net (Postfix, from userid 1000) id 4679A10C0679; Fri, 6 Apr 2018 21:52:49 +0200 (CEST) From: Mathieu Malaterre To: tytso@mit.edu Cc: Milan Kupcevic , Ben Hutchings , Mathieu Malaterre , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fs: Add MODULE_SOFTDEP declarations for hard-coded crypto drivers Date: Fri, 6 Apr 2018 21:52:31 +0200 Message-Id: <20180406195231.14868-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This helps initramfs builders and other tools to find the full dependencies of a module. Debian on powerpc (ppc32) still uses yaboot as default boot loader. Using a default installation (debian-installer) 64bit and metadata_csum feature are not setup in ext4. This is discussed in more details at: https://bugs.debian.org/825110#81 and implemented here: https://anonscm.debian.org/cgit/d-i/partman-ext3.git/patch/?id=f87dc92157262de1ad8dd3f2343436f08271b4dc This means that building the kernel as default debian package: make ARCH=powerpc XYZ_defconfig make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- bindeb-pkg Will lead to the following boot failure (initramfs prompt): /dev/sda3: clean, 127679/305216 files, 11128559/1220703 blocks done. [ 5.592819] EXT4-fs (sda3): Cannot load crc32c driver. mount: mounting /dev/sda3 on /root failed: No such file or directory Link: https://bugs.debian.org/819725 Link: https://salsa.debian.org/kernel-team/linux/blob/master/debian/patches/bugfix/all/fs-add-module_softdep-declarations-for-hard-coded-cr.patch Suggested-by: Ben Hutchings Cc: Milan Kupcevic Signed-off-by: Mathieu Malaterre --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 185f7e61f4cf..10bda040e78f 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5886,5 +5886,6 @@ static void __exit ext4_exit_fs(void) MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others"); MODULE_DESCRIPTION("Fourth Extended Filesystem"); MODULE_LICENSE("GPL"); +MODULE_SOFTDEP("pre: crypto-crc32c"); module_init(ext4_init_fs) module_exit(ext4_exit_fs)