From patchwork Sun Oct 1 19:27:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1841812 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Vryuba3J; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RzDdb6kTHz1yng for ; Mon, 2 Oct 2023 06:28:16 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CB723858C2A for ; Sun, 1 Oct 2023 19:28:14 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id 6B6AE3858C2A for ; Sun, 1 Oct 2023 19:28:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B6AE3858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-49d6bd3610cso93757e0c.1 for ; Sun, 01 Oct 2023 12:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696188481; x=1696793281; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jQ0s13XAmkqQ+JnQ0BnLaY160dbem/PXAusihEHLHc0=; b=Vryuba3JO6G0OJhffODE2iV2vfnhmaLpOc5nnRx9CYTjG/TByLq9I35iZaSaXXzOy9 /Zq6+NYTxu4AWkb/LwkAWtzhFXx6JEd+3iv/L032DIOb13wpgtY1H6gclUFlMrpmYFo9 N+gFkgDZp+NYuom4atFAiKL6rYWN1Bk10y2AzvtPwJ2Yofv99krL2cV+ldx6I5uffhHQ 8IJu6RmEmsZUT7QBA+1H0PibvI2w/11OTwXrBuYz9l62C8UsJ9U9TxxC1mnl/6lI0US/ 0hQdGT2JlOuYHdHw/nfSk9hlbCkE3Y8Ugk8DX9eW1kaWIJJwQBFOTe/Z8bJLE0K1c1VB qwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696188481; x=1696793281; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jQ0s13XAmkqQ+JnQ0BnLaY160dbem/PXAusihEHLHc0=; b=MnoMT/FTZ8p2Ngi6tltOwdbV7dLbF/N/VbtUrw47uPSvP8Umpr0aMBsGl5cYq13C7Q e+iZT5PB36qOuOVH4P8WVvLyxaEU8pvW8O64kEhX0gjFEsL359GtjzmkvxmpoNTPi9bz VYZpnT8zbEF6/fvhrIr1AFzbLVCiTgGmDysYgpaaS2SIlRCcGSWGlJv37OSSH1lTwO2w upDQXZlvPi8HcbLGN0dEONDb0fc7qaQMm8UK1R0fHDJPnBlq3zWmLCJai2Epm8UsDTX5 Ib3nxcZKy/j8BdGVJQAbXqbEzZSMi7O7P9WIf5nRm9yojewOJok3+7HLxjIjZDJkcxRs cADA== X-Gm-Message-State: AOJu0Yw4C5S9/bReQ8QlX9AkWLwwoeHYBVvMxpwEHzTte9matuaTYvtT QCFzQ6EKFTzXdJYx1LvdkDaJl+ca7ZsU6w== X-Google-Smtp-Source: AGHT+IGs6WsM2QJIBg9Xk3xgUcmJQQEHKnrSJgFAtTDeTcQXRxU+wR25ZT2nEjC5FInrq/zKW5FPiQ== X-Received: by 2002:a1f:ec43:0:b0:495:febd:9187 with SMTP id k64-20020a1fec43000000b00495febd9187mr7765981vkh.0.1696188481240; Sun, 01 Oct 2023 12:28:01 -0700 (PDT) Received: from xeond2.wrightpinski.org ([98.97.115.43]) by smtp.gmail.com with ESMTPSA id o16-20020a170902d4d000b001c74718f2f3sm5021458plg.119.2023.10.01.12.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 12:28:00 -0700 (PDT) From: Andrew Pinski To: gcc-patches@gcc.gnu.org Cc: Andrew Pinski Subject: [COMMITTED/13] Fix PR 110386: backprop vs ABSU_EXPR Date: Sun, 1 Oct 2023 12:27:43 -0700 Message-Id: <20231001192742.145518-1-pinskia@gmail.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Andrew Pinski The issue here is that when backprop tries to go and strip sign ops, it skips over ABSU_EXPR but ABSU_EXPR not only does an ABS, it also changes the type to unsigned. Since strip_sign_op_1 is only supposed to strip off sign changing operands and not ones that change types, removing ABSU_EXPR here is correct. We don't handle nop conversions so this does cause any missed optimizations either. Committed to the GCC 13 branch after bootstrapped and tested on x86_64-linux-gnu with no regressions. PR tree-optimization/110386 gcc/ChangeLog: * gimple-ssa-backprop.cc (strip_sign_op_1): Remove ABSU_EXPR. gcc/testsuite/ChangeLog: * gcc.c-torture/compile/pr110386-1.c: New test. * gcc.c-torture/compile/pr110386-2.c: New test. (cherry picked from commit 2bbac12ea7bd8a3eef5382e1b13f6019df4ec03f) --- gcc/gimple-ssa-backprop.cc | 1 - gcc/testsuite/gcc.c-torture/compile/pr110386-1.c | 9 +++++++++ gcc/testsuite/gcc.c-torture/compile/pr110386-2.c | 11 +++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr110386-1.c create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr110386-2.c diff --git a/gcc/gimple-ssa-backprop.cc b/gcc/gimple-ssa-backprop.cc index 65a65590017..dcb15ed4f61 100644 --- a/gcc/gimple-ssa-backprop.cc +++ b/gcc/gimple-ssa-backprop.cc @@ -694,7 +694,6 @@ strip_sign_op_1 (tree rhs) switch (gimple_assign_rhs_code (assign)) { case ABS_EXPR: - case ABSU_EXPR: case NEGATE_EXPR: return gimple_assign_rhs1 (assign); diff --git a/gcc/testsuite/gcc.c-torture/compile/pr110386-1.c b/gcc/testsuite/gcc.c-torture/compile/pr110386-1.c new file mode 100644 index 00000000000..4fcc977ad16 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr110386-1.c @@ -0,0 +1,9 @@ + +int f(int a) +{ + int c = c < 0 ? c : -c; + c = -c; + unsigned b = c; + unsigned t = b*a; + return t*t; +} diff --git a/gcc/testsuite/gcc.c-torture/compile/pr110386-2.c b/gcc/testsuite/gcc.c-torture/compile/pr110386-2.c new file mode 100644 index 00000000000..c60e1b6994b --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr110386-2.c @@ -0,0 +1,11 @@ +/* { dg-do compile { target i?86-*-* x86_64-*-* } } */ +/* { dg-options "-mavx" } */ + +#include + +__m128i do_stuff(__m128i XMM0) { + __m128i ABS0 = _mm_abs_epi32(XMM0); + __m128i MUL0 = _mm_mullo_epi32(ABS0, XMM0); + __m128i MUL1 = _mm_mullo_epi32(MUL0, MUL0); + return MUL1; +}