From patchwork Sun Apr 1 20:52:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frans Meulenbroeks X-Patchwork-Id: 894061 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cJVH9Snd"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Dncg4DZzz9s0p for ; Mon, 2 Apr 2018 06:53:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbeDAUxE (ORCPT ); Sun, 1 Apr 2018 16:53:04 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40517 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbeDAUxD (ORCPT ); Sun, 1 Apr 2018 16:53:03 -0400 Received: by mail-wm0-f68.google.com with SMTP id x4so23910095wmh.5 for ; Sun, 01 Apr 2018 13:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=isGPHnI52vkR1MeXEkJdUIgzQtid7+kig/6bQWbqRAw=; b=cJVH9SndPGjR1KHRawSzjX/8P3NqG1QwRe/G/KP0a+WIJWN5SCn8VRA0cdYq+Gc6wX lsaVNYBl8RV7r8SmIAguQMnZVUbL2xC5kPrmyxk825C8FLaVj8k+VpZ3LBc2HV9lD2N2 5QS9kcAQbTijU5m5UQC9DSE+PqLvs3a9QzrvWGo6DJ4baezFQZTP6Q4prU0ibIiF9dpG iGLujpCCnb9XYBjy/Ak/iQSB5lka03pkF4749emXv1g6yz8nVeCTNGLEZmhHJ2MYYOLO vkRsJNRxj8mc6KqgAI2uHCTti3vqRnF1AMOdIvUH5h4OTXVO4fmzXKBPgGWwmkA3FAkv +Jlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=isGPHnI52vkR1MeXEkJdUIgzQtid7+kig/6bQWbqRAw=; b=N6MEdZfxhKs3iNptwyGldquH4HXoFCb41HO6iTbUcoej7HeJ0ZiQrLAeosxtxt7m+g 3nm5oecxpPA+TXm7N6AE2oW7p/vrYT2QGTX3l//1/tKCTzrVm2/O0DHD/DfG6xvp/9ZG inU3pZ08rzL5Q2zywpMEUw6HQDR+pc8gRY/kbFOvwTVNjWIk2ZfPe3kzHBk1sRebKwso u5gwkiKS0qMIhTJK3rxrHuUJ+9HR99pqjL/LhVT5J1IT792MsjRR9CqLYBzeCO4RFOeE lmMigpxzjl0E7OJO+vkFQy2KEXvT4nq09EFy4jV2IRAYdVRetgmgHuPyjO/iIz+jYApi 4iEw== X-Gm-Message-State: AElRT7Hjtcb5wJEjxBqpdT9exz46R4ux/ljRFPjkFC7J1IfJX9g/EZZ9 0c+PnEOnXOFT8jieO2szOmELTg== X-Google-Smtp-Source: AIpwx4/8p3vYHLhFR9tj+OQv6B2lxsK09RMhHmDMk57e6psYlFTZSTlxkCZFkCj+/HteTM35WxtyFw== X-Received: by 10.80.177.81 with SMTP id l17mr10484102edd.65.1522615982156; Sun, 01 Apr 2018 13:53:02 -0700 (PDT) Received: from localhost.localdomain (f160137.upc-f.chello.nl. [80.56.160.137]) by smtp.gmail.com with ESMTPSA id k51sm8701975eda.59.2018.04.01.13.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 01 Apr 2018 13:53:01 -0700 (PDT) From: Frans Meulenbroeks Cc: netdev@vger.kernel.org, trivial@linux.org, davem@davemloft.net, Frans Meulenbroeks Subject: [PATCH] [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang. Date: Sun, 1 Apr 2018 22:52:55 +0200 Message-Id: <1522615975-20952-1-git-send-email-fransmeulenbroeks@gmail.com> X-Mailer: git-send-email 2.7.4 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org mdio-bitbang mentioned 10 for both read and write. However mdio read opcode is 10 and write opcode is 01 Fixed comment. Signed-off-by: Frans Meulenbroeks Reviewed-by: Andrew Lunn --- drivers/net/phy/mdio-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c index 61a543c..403b085 100644 --- a/drivers/net/phy/mdio-bitbang.c +++ b/drivers/net/phy/mdio-bitbang.c @@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int op, u8 phy, u8 reg) for (i = 0; i < 32; i++) mdiobb_send_bit(ctrl, 1); - /* send the start bit (01) and the read opcode (10) or write (10). + /* send the start bit (01) and the read opcode (10) or write (01). Clause 45 operation uses 00 for the start and 11, 10 for read/write */ mdiobb_send_bit(ctrl, 0);