From patchwork Mon Aug 14 11:49:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1820998 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=WAKRQYSM; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RPXlH6nSzz1yfP for ; Mon, 14 Aug 2023 21:50:19 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36A753858C20 for ; Mon, 14 Aug 2023 11:50:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36A753858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692013817; bh=T9dfHj0pPrYigMb+Rav7vfD6P6NktgoRCHyAHDVPPLM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WAKRQYSMrlYbvXoZtgooBgIwnC7heZXSJHx9HrETSgieASmw7ziDftgzBj4zvufoW BGHI8pU2FZBIlDHi1XgevWpmAHdVus4QeSEkGZQv4mqcIcG+6UEpj7OebflTaMfl6g iSwIXEwxk0CbKcMDVc58Fs/7Y1bnvj+S0lavSA4Y= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B11333858C1F for ; Mon, 14 Aug 2023 11:50:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B11333858C1F Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-8VcTICvsN3WAZn4MIa2Kdw-1; Mon, 14 Aug 2023 07:50:00 -0400 X-MC-Unique: 8VcTICvsN3WAZn4MIa2Kdw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7385E2A5957F for ; Mon, 14 Aug 2023 11:50:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D9CB40D2839 for ; Mon, 14 Aug 2023 11:50:00 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] configure: Add -Wall again to the default CFLAGS Date: Mon, 14 Aug 2023 13:49:58 +0200 Message-ID: <87leedc07t.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Commit 78ceef25d64efeeb6067d1cb282a00466e637e2a ("configure: Remove --enable-all-warnings option") removed it due to a missing +. Tested with build-many-glibcs.py (glibcs stage only, full compilers/glibcs test still running). Needs -Wall fixes from the recent malloc fix. Reviewed-by: Siddhesh Poyarekar --- Makeconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: bb481eedcee19bb342b91eddc86417df660e6c56 diff --git a/Makeconfig b/Makeconfig index c4dd9ea8f2..c48fcc59e8 100644 --- a/Makeconfig +++ b/Makeconfig @@ -857,7 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd) endif # Extra flags to pass to GCC. -gccwarn := -Wall -Wwrite-strings -Wundef ++gccwarn := -Wall -Wwrite-strings -Wundef ifeq ($(enable-werror),yes) +gccwarn += -Werror endif