From patchwork Thu Aug 3 17:10:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parker Newman X-Patchwork-Id: 1816592 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4RGwN74NVKz1yds for ; Fri, 4 Aug 2023 03:10:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234543AbjHCRKn (ORCPT ); Thu, 3 Aug 2023 13:10:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233753AbjHCRKl (ORCPT ); Thu, 3 Aug 2023 13:10:41 -0400 Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2129.outbound.protection.outlook.com [40.107.116.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE54A4227; Thu, 3 Aug 2023 10:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xm7/gfqv/4RgDPZI3RYmVOsJjNM6LnD2Nhi8c6fhMU06rKzYmTBkEDtfmcXTAncDEn5NFqsuTdKlW8h0BSZ4ey27N0TiW0w7veVUsUECzfAE29EdoknMw8Drg9Y8LmWvUGgO8yRi2HOPTEFs3mrpN3U7YB1cDba0I0KNbAmZmDa59vwzzTGfvKYW6qTKCR/kNmsRbENer3Hr6KJ7EyjMnOZsILcz6+np0V//n4q/H+f5pqXa1DUyotRO9kCOTTJov7Lwd9MnYJHe1qWHNxabZNHFwt0sBHRZUMyrAixpjcwSN6EFKuHSXLJjTB1ZL06DQgQgjkvLoCdZUPr5DOwacw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XgIq/MrrfIvSpj0V/+dUGZAl08B671VtUm9M+dgDtiY=; b=Cnf2G86GBAdG0xJ/z3JZPTPcsSdVIOKph9B6eqBsLW7Z4tIMBYDwn4IR9VFgWGUhgiutXg9l18m3xaYtg5AqqcJOLagvwFbi4ncz1efdOBVQKb1anOfvabqZU3j+5vgv9PszCGYbRzPjluEY4zW3fD/EgGk7/JHZvlh+zsemQ5mT50Ms+kR2gsbFn+OY1KA9ZT7H+Xy5YkLk3a598VlMI/UY/O+T76Oq2/s2KbL68KSw7fqncT8KWxmDXx53TzMpikOyCeQag26UaUA9+urGdzmOfCi6VgWoFcZc6BdN33IL3/A30C0A44Rt69tOOkhOxWZ3b5CcoCKaOzqDEl+grw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connecttech.com; dmarc=pass action=none header.from=connecttech.com; dkim=pass header.d=connecttech.com; arc=none Received: from YT1PR01MB4124.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2b::11) by YT3PR01MB6051.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:68::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 17:10:02 +0000 Received: from YT1PR01MB4124.CANPRD01.PROD.OUTLOOK.COM ([fe80::7fe0:2f38:7134:6e7d]) by YT1PR01MB4124.CANPRD01.PROD.OUTLOOK.COM ([fe80::7fe0:2f38:7134:6e7d%7]) with mapi id 15.20.6652.020; Thu, 3 Aug 2023 17:10:02 +0000 From: Parker Newman To: Laxman Dewangan , Dmitry Osipenko , Andi Shyti , Thierry Reding , Jonathan Hunter , "linux-i2c@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing Thread-Topic: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing Thread-Index: AQHZxi1XxuhBoZdpFUiMCrgiycCKGw== Date: Thu, 3 Aug 2023 17:10:02 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=connecttech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT1PR01MB4124:EE_|YT3PR01MB6051:EE_ x-ms-office365-filtering-correlation-id: 6d4e95be-44a2-4ad5-18ab-08db944479e7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nLuZxC+OReXBgkWMUlsDDpja4sY/F9ZVeKdkZwIB9qCwqcbUYE3dbLOc7Xq98HCqqgsXTiD5HUtyJKPezAqVRk2RC9s/mskAo0bmRElJk1xFu5tGyriJ7/RQnpTSOz6hua8tZLG64U87Vde8rvxuhvYmlJrRQCWZbA3YYrFRBijRL4+WYQMO0T1gOzORonyWaqojQpYU5grBOV1KcdMFYLAE0G9CpsBS+f573kP9Fbjw83ttKij4vT5phkNaDtfvzs6txuLTGkA9nzIYBIsRpdApsTjd2u5DY6OnRnCDw95NWFHAd6r4d2oYX8sQMK57xyjhswRVRSvVCkLLPXUCWOT+r1yfbZbyxs/zfrqR8RCCdQcTQSXbcbDyw7GSK1vrP6Ea7ChW1LF+Vjba+VzIyvLblGeEZimy6bfzWbsVwec1M6fgfUtM1jMxIXUF6ONwuSEovbZMOPJ/WRPlk5NgaJwftUMXY0RBxNzh1GvkFpgTLK3nScvZEjHqeTZwjcbsTxf0TWEfzcjlkMeIL2xi/P8JxbZC8jd0m63+5V5XsLhui8F/AvhznnTaZ/EdqG74mzuluW/v/mHzH/lDy2Cwzh6Ujq7Z2IS3YmAXyTrTINwsMnD/ONVXb13ZYVy1hilW5WL3OsNPch9LM0/DRjqvKw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB4124.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39840400004)(396003)(366004)(376002)(451199021)(2616005)(6506007)(83380400001)(186003)(26005)(8676002)(76116006)(316002)(66556008)(2906002)(64756008)(66946007)(5660300002)(66446008)(66476007)(41300700001)(8936002)(6486002)(71200400001)(6512007)(110136005)(478600001)(38100700002)(122000001)(31696002)(86362001)(36756003)(38070700005)(31686004)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?VOGBRkDWcXna5o7sYVUFzK+S4ZuX?= =?utf-8?q?lY61y7L29VUfascJJL4HXLKeOFyhq8OOPDzTNLymle3SODB3Ar1eTh5TT+JWaCWUN?= =?utf-8?q?AEbWWe+NLJU9fJVbSPyrf7DizbOw5ZEojC34yGxlxafgnA105Mx4y4acwlFjHe9RK?= =?utf-8?q?cwgy1DCgr+vgY+bSbw0qQYxeAVMn/6IYsZIs6VL1c/0Cm/uoSTHHD3K9ik8FZ7p6F?= =?utf-8?q?+jGvx7vxbCJBAu+aXSF1dlsNTB4+AHmJdxBAratZ6qUDQvfv0OQjv4z8OorBQ6Uk5?= =?utf-8?q?3iJECel3/3uhEamdbKKyD+uL6VlUJxWySDtyHDflyAboj4i6KNwwwm4OIt4MaBTID?= =?utf-8?q?dEs2aMoMhzIVDBmXwY/oAoeSFKKPq3jf6ZlNzgSlVN293+NHVBnnzyIbBZZhUSUk6?= =?utf-8?q?i8I8K+eqDaUlep05acv8hyobpVDQKcm2H8Bb1WtcaTcFTIQrmCTKwNDKqvKYQR0tg?= =?utf-8?q?xs5JXKeD651lic2h9BXLzoWHEIgdiwbvT42XRHmAJgc+fdpxIbCeSt9s4+Od+c/0c?= =?utf-8?q?2gY8D/txBcraxK8vPAHcFqfOmx5K/0juYo9i0RYZZVSLX5Ww9m5j8Ur0tsn9IVXUk?= =?utf-8?q?e7OCPEAcNvRMBTnenVVHNVcTmYL8zvTqrzAKF2xOI/KKfztgqcHtZasppJADOynUT?= =?utf-8?q?Q/QjZjxXcmxl8Tzj5f4SmBetd8lqz2kc6ocJwaJPJQ7srg/nN8/NNtA9Rn22wfL7I?= =?utf-8?q?O/mb1yhc0DjXnb+UW8Cultz/q6ouzWHzDSn+zuZNgqJEyWiv6kpDIKSZvkkgpWNgx?= =?utf-8?q?q7j++R5cjE44SI7L/Gx117dkNESjI19JV+cvlOEF/NAx+ezZJBZcV+g8YTB/ezoj9?= =?utf-8?q?YH+3oIlKbP8o1sYAERW4NzOia60XaQCtVv/+7Od4qJeArdBGAHyODF0VZSqJUKep2?= =?utf-8?q?soTW9ag/HadVbFoPVRO79RuQPo3oery1J5ECsV8rH3dJeQRsLyPiNANb0oB0Pcb2M?= =?utf-8?q?xnrQy+4rJyJBxtYIezH+CZIDbOr/L+eJA0XYcY/WKKsYtJjq9CHyehbYvw2lso2ff?= =?utf-8?q?Gd4M3KmTdEZ/orWaTTa3LzknVwGBQxA3FrxmSy3eGZuxYySM7JLyI3PSShy//npHJ?= =?utf-8?q?BCecaJPOrD0rRVL2/m9lm+SZad43rAh8lNhrn5k44wu8M9TPWKZENmAPv6u2RoUV/?= =?utf-8?q?scs5ywd3L/42eQ6r9TPXoE3UDpxsxSEwMRcGBxWUzT3/yuhaYnBiFJBhVUiYSZAGj?= =?utf-8?q?kfVmq1p4GT4lR08/CE6+DUrL0HfsbSUVQu7GSMNgzXcGHjC5I2S1MRxbVgwgbjVaX?= =?utf-8?q?HMA1z8pjf+FgGMAQNx7qtSjXYXgPRfWgL3dUmBNnnrri6b1Ya/nMsGnev1pHpzGfG?= =?utf-8?q?80RAJ0CiGYnREVWjpGT0Zt3Cn0ejSavL5MhP1JTC+0wjIGvk/gfrdxSvbhxuahmCT?= =?utf-8?q?DTCiq0bsKAIzHqAVBEEejicbDA61VOcqw3FhFhqeCZE9K5PauGXdWnYViGY77RiAo?= =?utf-8?q?p4JEacyrGnYqGneMqxveOAzTRb7UQZZZf8G9qhnRvk/LwPwOdKdvLG4w3+0wTBGzS?= =?utf-8?q?vN3lQP3mn1p1?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: connecttech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB4124.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 6d4e95be-44a2-4ad5-18ab-08db944479e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 17:10:02.6632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d33071ec-da55-4b12-8469-920f998c36b3 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c872yGM8Bnca/XGIwm/+BKjik3Qi6685HA5wyzKnI0Le/pcOCv9tAsbHH/AtZKIcd1dVtAVMisKHLzQnaWRPQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6051 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org This patch fixes the Tegra DMA config option processing in the i2c-tegra driver. Tegra processors prior to Tegra186 used APB DMA for I2C requiring CONFIG_TEGRA20_APB_DMA=y while Tegra186 and later use GPC DMA requiring CONFIG_TEGRA186_GPC_DMA=y. The check for if the processor uses APB DMA is inverted and so the wrong DMA config options are checked. This means if CONFIG_TEGRA20_APB_DMA=y but CONFIG_TEGRA186_GPC_DMA=n with a Tegra186 or later processor the driver will incorrectly think DMA is enabled and attempt to request DMA channels that will never be availible, leaving the driver in a perpetual EPROBE_DEFER state. Signed-off-by: Parker Newman Acked-by: Andi Shyti Acked-by: Akhil R --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bcbbf23aa530..dc6ed3a8d69e 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -442,7 +442,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) if (IS_VI(i2c_dev)) return 0; - if (!i2c_dev->hw->has_apb_dma) { + if (i2c_dev->hw->has_apb_dma) { if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) { dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n"); return 0;