From patchwork Mon Jul 24 15:26:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Chiu X-Patchwork-Id: 1811882 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=bM1tNG38; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R8kYB18Hfz1ybV for ; Tue, 25 Jul 2023 01:27:08 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qNxSc-0001YC-66; Mon, 24 Jul 2023 15:26:58 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qNxSa-0001WI-GC for kernel-team@lists.ubuntu.com; Mon, 24 Jul 2023 15:26:56 +0000 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 097B33F137 for ; Mon, 24 Jul 2023 15:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1690212416; bh=ijlL7W4rUP4BHPwcVmnRvi3OE8nYFI1/RdZrCOD3rrM=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bM1tNG38YoWrmZygQf8dvEl54eMkLPgGs/ai+3JhDFtihlTh0EGysSBtd2xmfJdEE Te4nABap817HU0F0aCAw1L4AHu3AWAjzQGbhlg9kjcJrozPKKFr35GxnZgZnzUVEDJ YI4prhZADlnf1/UEWMigCo/lCPiH3pwwu+y/CIgVBQ/cBQ0zU5np9X6MUYHrCOEYYg ngA98yG1MfLP3idpuxc/ZRmTw1032N3ltKOwFMKA+EM7AcgSZJE1go235NGVkI1Vyo GN+QouxEt2MT0hvCQcowt45ZFRgGE3ILYNlw+MFkbCV4AcdNRPMOCtgkw/t5NMMd50 W8AUS0TwU7QzQ== Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-55b2ac94f31so4462682a12.2 for ; Mon, 24 Jul 2023 08:26:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690212414; x=1690817214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ijlL7W4rUP4BHPwcVmnRvi3OE8nYFI1/RdZrCOD3rrM=; b=E7xZGqPpsVU/VBX2wElrkFMmu46gOUZSYCpcgD4Na8cqytNNkARS7Oxiyu7L0VAve+ NrOtxCmSTR1zkLeLbD1pnGRCWGc2RdBsmPP/c/Ka+kNsgurKA68pMplBzJRPKPp9XoTu LUo/G1P42czt/+51KpXyWiYDvX/2z+6d73Trgra+d5i3iWjg7MDDFjUEyrnp4pCV9BpW W8ZwsEKCjsypaFhQtyef/Dp0p0sc2nVOk4bReUxmsbjRFSujKT26JWDRAwoC9EY4ay4v cKExcHWXoTd35f+UUj20enED6twzkDn8IeUfJEDiOQfTHqd+1EIgLpr7Kl1Bm79ZO34S +wIA== X-Gm-Message-State: ABy/qLYXalASdxTS4N2Oazo8GD+r625fL08Y/C0foEj1sD8Uy7DZfcFW jdIc5iz1WIUVtvdbOcmioEvIRvuqDo7Jquu4Y9wErYL0jftqf8NaSqv4q9EYd/sfz1b1Ne/2bl0 UjephLQv8GVSXsYfoeLfuvcfGNryT/zn7OEC+Guuek9LbN0KjHQ== X-Received: by 2002:a05:6a20:7f9f:b0:135:8a65:a772 with SMTP id d31-20020a056a207f9f00b001358a65a772mr13109065pzj.50.1690212414279; Mon, 24 Jul 2023 08:26:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlHCHDrKLNM9Y4ADDMYGXlEz5fh2LZHKqB0kQxpMbPwnp6tLLzOSD30NORWe78UdJ97ES5TZFQ== X-Received: by 2002:a05:6a20:7f9f:b0:135:8a65:a772 with SMTP id d31-20020a056a207f9f00b001358a65a772mr13109049pzj.50.1690212413962; Mon, 24 Jul 2023 08:26:53 -0700 (PDT) Received: from u-Precision-5560.mymeshdevice.home (2001-b011-3817-d6a9-6013-daf3-4a71-bf96.dynamic-ip6.hinet.net. [2001:b011:3817:d6a9:6013:daf3:4a71:bf96]) by smtp.gmail.com with ESMTPSA id u11-20020a170902e5cb00b001b89a6164desm9120213plf.118.2023.07.24.08.26.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 08:26:53 -0700 (PDT) From: Chris Chiu To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/1][SRU][L] ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform Date: Mon, 24 Jul 2023 23:26:50 +0800 Message-Id: <20230724152650.357630-2-chris.chiu@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230724152650.357630-1-chris.chiu@canonical.com> References: <20230724152650.357630-1-chris.chiu@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2023197 In the commit 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute LEDs not work on a HP platform"), speakers and LEDs are fixed but only 2 CS35L41 amplifiers on SPI bus connected to Realtek codec are enabled. Need the ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED to get all amplifiers working. Signed-off-by: Chris Chiu Fixes: 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute LEDs not work on a HP platform") Cc: Link: https://lore.kernel.org/r/20230606145747.135966-1-chris.chiu@canonical.com Signed-off-by: Takashi Iwai (cherry picked from commit b752a385b584d385683c65cb76a1298f1379a88c) Signed-off-by: Chris Chiu --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 37a01954e73c..87e19029607b 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9477,7 +9477,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8b8a, "HP", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b8b, "HP", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b8d, "HP", ALC236_FIXUP_HP_GPIO_LED), - SND_PCI_QUIRK(0x103c, 0x8b8f, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b8f, "HP", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b92, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8b97, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),