From patchwork Fri Jun 23 15:33:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Maignial X-Patchwork-Id: 1799069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sSLZAwwy; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QnhBS1KHjz20XB for ; Sat, 24 Jun 2023 01:34:54 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=I6ngomzx7w4pWP/iZ/Fvsdi8WsgDZAs8J/4SDxt8Cqw=; b=sSLZAwwyBD1003 uws6HbJuB5ZeHpV1vCfTikMqkNcLO6DsJCzbjxZ6mUfO3Eq++/G2+NT5KF1lRFBIBxKkQQFOh8sT/ JhqdlNzxosXuzT+x0yFgJmPfn/MHUYboNotxf2BoHGtZi/44+gTRQuZ84p7HWNwPnbaRIKmebhmnW wryD3LfMKJ/ClHgda1jNbII0u8o2ZekHxeyt4wVv+OM0z3zvmOym9KUyIztmN5kRfQqOMBdEvOGLo XSLJMs0FMMhqI9NjoD5eCLRdXqlf3EVqcpeDqd/4HTNj1QRsCyGsMTkCQSUCIh/wLybsJSzTVwIDQ XNLFCVX6uB3TWL0Hbk/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCinf-003x5g-1n; Fri, 23 Jun 2023 15:34:15 +0000 Received: from mail-vi1eur05olkn2082f.outbound.protection.outlook.com ([2a01:111:f400:7d00::82f] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCinc-003x4d-2X for linux-mtd@lists.infradead.org; Fri, 23 Jun 2023 15:34:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMkU+00QuFkA6O00Z1pBulEBW4fFzZmYBnu8ej3VXtTvsZBTG71WH4/3AXRF20L/7rK7JvGMQidetVbDg7I8LipUcgVRyG2jGgziaKaWv/AOlQn/Y821esbFmha460AdKpCnTnhAjzaCK5cuZojKf8uzH7vCcO4LtD8Mi6J0vEogF7c2xjzh9uGSlRvsnbw/uEw0cbE87mxjQ+KmZBubyRckkdj67X27WitNUIciRnV0sSv9MW3hVmKgEtpJBWPPL6ZR3Z/zQ103d+gJIvPGAWSLX5m89mUcSLln7mwiVkGfPgodtzXGRirWk6STFjOpXfPQnkAcDZqHYgblYiVC6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ykEQ/VfQXM1yjfbUj/w4I3uHAwlVs0OdG4VE3j08iT0=; b=WsWsacGgDGlar8E7e3NZ5vETpDEjtv0cV+E6LrkAwDFz7ve2oBCdZTK16et/apM3zI3holngSqu7Atomr3uCWSBhblLi1rbrVgF1fjSqTd+OqLstYN5tE9rGMygXTJmPlBg0mjudcNHRifa9X1RSTUfU6cffihG/y5M7TGkARJ1ICyqvPsdTeRAgT5b+YJxDbePynNh3hl6wn5gRn62qf0hrJ0g8V2NVgacbXGFK2M0L7CwzA76WVsiNexcSTq9CJD16Fii8p1dAVm/vUpa+BKnWt9Dn1CUykPZUnkf4AwPNvevJA01Lza7eGfcVBXirh7jhm2DPrWrE2tJSaJu72w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB4P250MB1032.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cc::7) by AM8P250MB0042.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3d9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 23 Jun 2023 15:34:00 +0000 Received: from DB4P250MB1032.EURP250.PROD.OUTLOOK.COM ([fe80::1f3e:9e10:27b2:5ae4]) by DB4P250MB1032.EURP250.PROD.OUTLOOK.COM ([fe80::1f3e:9e10:27b2:5ae4%2]) with mapi id 15.20.6521.023; Fri, 23 Jun 2023 15:34:00 +0000 From: Olivier Maignial To: Cc: Olivier Maignial , stable@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Schrempf Frieder , Mikhail Kshevetskiy , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [v2, 1/2] mtd: spinand: toshiba: Fix ecc_get_status Date: Fri, 23 Jun 2023 17:33:36 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [ZlZu7uX6XhMphMQK0xfQEX+v3hmWL+k2] X-ClientProxiedBy: PR0P264CA0249.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::21) To DB4P250MB1032.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cc::7) X-Microsoft-Original-Message-ID: <20230623153337.3818369-1-olivier.maignial@hotmail.fr> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4P250MB1032:EE_|AM8P250MB0042:EE_ X-MS-Office365-Filtering-Correlation-Id: 7812bb74-50a9-431a-825d-08db73ff43da X-MS-Exchange-SLBlob-MailProps: a+H6FLLcF3qXcYLnbyrqKtqrVM43XjewP5Mt+qMANFrOaoioyzYvwNlPu4Ae4c8pBQeJkGK4uYJsHOoRrd4elmpXKlH8VjbkAhLCuJI+1JkCOl4gCq8X+tw96X0rJwVz30AZNO0ddnlILkMR3vLOmBWoOV/MDSQyX8EQ/1QunOnDNVNI2GeiGH2hcj/PBbzgwFp/p+jYMhpnjqaZMMxZ3HoXf6QRDu2CJYkxMj7SajcPd/05R0vp1R6qcKrMfO91Q2Ms3zT+4ozh9NraDjEUJ+JruGeOItyJlkU940/vnA5n+zKuj4QsVrgUVfyi9Ud9U4mth0O0YdAspArT8kGN4CwRPXnAMT9SQgmnF+XdlkL0ok9h95yv1n3URYjZVTYDfRFwyXKaqNOio26EEU8FzFz3WQ8u2o8jUrA8RNWjJyxWS3SXxeWqnigAkXEXAWvfwukSFL3e4+Siwxc4SG9ZfltjOBhRzkwZQ7cY4rw39BeFPO0cicuLv+EpM1yiExWirbO1DD+8Fz46xI1F8lBKKr2st9ldkn7viy0iyZv7OWUUBVaMvtjUmh55OHLvrtdqYSMHl4+QJkwSCYYGdi3Jx39SemxyJPA3IH7I9M1IBL1GvT8uf6wlZk68MOhUu8JwHwSmpqIU4hJ0+JZXT0fhP3oyAtdUvxZu/gGBPWGM/4UVwoPg04PKwjNAL2iTsECT7FAVU0gWiV9VSmdxjs0ZVNLHmdkp479RLtQ8KvwESJaPoeE/SlHu9JeDj3VpgFlIYW9yDe+RtFvn6yRfRdFP4faCAsE8Ppuj+LQCZ1cn5xG5AwXEfmsxXp3hRdW8rOIw X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XgesvwcWzjQsrlX/3+iTwQkw+8W2y5HlmYEgo739s2sL9qLkqMagk25RfN4z5kHXha+7dcazAzocO/Se2mSVdjcg5VUjAolvSruRd3DZuWOLTeLV4LNGJZb2hreVK4YUVUex0Yy3TGETEqeH7IxrPNRHiBk60VeAWPWhjGUCojaWJzqzuRYINF+sPy5qnSqeVs8s4UZD535hqJT4AmRVKTJb1hCP/biAt14oCNuma9Nf5wbLTl+nrpqvDFmros5bvtaL/KcncRSnORZwiBtfw747f8cLWdYZLiYhzpbqUxRjpqRtwEqXHryml81jp2Qt7zCtXfU0UvUBgy7onftYmSjH1ygScQYX6aHqiB3BnSHxpbf3k8wZ9XHaKiQ2I1ytArzJVCqleftMpg6hRj2JCFkJUrMBeOml+WMcyhOul+3SWWO4VV6ayxGlcNLmQWzaI1lm69aknvQl0pV1CuE5K8QiouBFajIpJt1wABaVQUQm2yJYooPhTo2C6zLrKo9myfohMA74IXLAqS2NtKFQrmikGh7iSPDUS5NG5xPg3+dsPgbjnKp07RoZ9VTd8fpLAk0VPoCZwI+6c08UmHzHUjXvvJzvkwWsz3L9Wow/p2rp6HNBpgpwu+x0N+B854cUN4K0eGCVFU4fQhFrhz4qnQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6k6bBLEK+u+lZUAneU+qqqD/OEXUKbOp2XKBAi9AMAW/iIBf0/tM1wB+e/Aopy/Kmjh90hIOdkn3OI3Qc82KbOooOG9JVzbyW8x/WNyHH1DhS4KMHqWq6krv2SB1U/tFOuPCtSeOiV9G451q2Ub6Y0aScSP7EuCBqu8AqfUhKJVxnA6oXbuavu9NtrFWfAbGIQ+yK7dC4PTeTYvOsjqbOTRRQ9HEb5u8c+354SHzKIg1Bv5Z2YfIVMTFrqHPkDQGrx8SeOchTzNv8ZoayJBnMtHlG0yk9SooXAsUOQC5uqAjZ3thrdU7Gv4IcZ+iuAofVPA6ISr+13i0QWnOLI8FVyJYLxiKKbBjiBwui7dhTAzJrqkKwOUHZkLCvZqSrSQkctiKTfYiKIOHmwkXIIF8Xg5wbSeJQoqvYL5pfCdacA1kiCbDD6arBzRlnuiKT7ZLhqMTkwvYEeuircuFa5AdQuyFfl9npmJGbfO1prU7AB/f2ur+l5P7hA8np1p8Yrpw3URXIuEBFek06JRbmi8B3PSnXRgSpT7yYji6qlRSwJQIztYeShE4KZhbuBr8Kx6TKQ/hp6628YydY+gPD6khd6FuP6pKaJeDW2YZ1PTda4xJwr4pg23d3VnnE7GLeN8HmgOwjrutvxBEukR2bX4WYKlczay93TFg+GnRUu1kArIEf9akBcvVSos7re0JPCkoJxJbD/xu3+7i+bpnFFOtiB3s+3E3Ri+FygW1KBZV/b9M5ZmgNDz1f8dAPsus9TOka/u3t6RUC9r60fCw5vgNA9cZv7Sjhl9t5h/RmF6wN9zmYmQcJrw+HHJBv+keEKk8zEZUwhEN5O0M9neb1I3COzb7lzHAoCBXG69hfJcQ4nSvFaRQ4K6lhfcFIAuxsr+FsjAzQXiifz3Tl17X1tkcVr/FUMRNvtvB+AgiLSR0+gKn38dz8PPobsQIWS5Hv4Un4eiMlSmVA0R7Fq7uGqSP1XbAn3790ieG/L3r1kozLuayVSOK7NdZSLUsc9cWvCOJeaJsMwKfZprMiKNHcCLUNm7sUcz+g5gkblXXNIR0DKaYz9nuW7qz1Z+dbs6FhtvDt+v0KAoZEJD0YxEzrvurCFO/qVBLszFtp1H12ktj7orxGogC5jjZ70wN3oQYZwfC4NmdmGSITKquymnvs9FlWD7vxbqTAM87PTF8NjiJl/ESvKlOoK0FOQvsnLcWPprh3175JVEuGaSCHUX0Ruw6H3GGBMTxTlVjJEBGodEZZts= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e3d53.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7812bb74-50a9-431a-825d-08db73ff43da X-MS-Exchange-CrossTenant-AuthSource: DB4P250MB1032.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 15:34:00.5502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0042 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_083412_852786_E07FD035 X-CRM114-Status: GOOD ( 10.56 ) X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Reading ECC status is failing. tx58cxgxsxraix_ecc_get_status() is using on-stack buffer for SPINAND_GET_FEATURE_OP() output. It is not suitable for DMA needs of spi-mem. Fix this by using the spi-mem operations dedicated buffer spinand->scratchbuf. Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a01:111:f400:7d00:0:0:0:82f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [olivier.maignial[at]hotmail.fr] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Reading ECC status is failing. tx58cxgxsxraix_ecc_get_status() is using on-stack buffer for SPINAND_GET_FEATURE_OP() output. It is not suitable for DMA needs of spi-mem. Fix this by using the spi-mem operations dedicated buffer spinand->scratchbuf. See spinand->scratchbuf: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418 spi_mem_check_op(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199 Fixes: 10949af1681d ("mtd: spinand: Add initial support for Toshiba TC58CVG2S0H") Cc: stable@vger.kernel.org Signed-off-by: Olivier Maignial --- drivers/mtd/nand/spi/toshiba.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c index 7380b1ebaccd..a80427c13121 100644 --- a/drivers/mtd/nand/spi/toshiba.c +++ b/drivers/mtd/nand/spi/toshiba.c @@ -73,7 +73,7 @@ static int tx58cxgxsxraix_ecc_get_status(struct spinand_device *spinand, { struct nand_device *nand = spinand_to_nand(spinand); u8 mbf = 0; - struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, &mbf); + struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, spinand->scratchbuf); switch (status & STATUS_ECC_MASK) { case STATUS_ECC_NO_BITFLIPS: @@ -92,7 +92,7 @@ static int tx58cxgxsxraix_ecc_get_status(struct spinand_device *spinand, if (spi_mem_exec_op(spinand->spimem, &op)) return nanddev_get_ecc_conf(nand)->strength; - mbf >>= 4; + mbf = *(spinand->scratchbuf) >> 4; if (WARN_ON(mbf > nanddev_get_ecc_conf(nand)->strength || !mbf)) return nanddev_get_ecc_conf(nand)->strength; From patchwork Fri Jun 23 15:33:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Maignial X-Patchwork-Id: 1799068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VWfMksli; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QnhBS1PYhz20Xp for ; Sat, 24 Jun 2023 01:34:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2UVP9eDVZhwMNOQ/dakv82gaoGvuDUswoAyTOIKWjso=; b=VWfMksliC2NF46 YD+AOHCRyMCVEtjd8Aifz/7jcQQ3AxrXY4Pdc8KpKyFVjs0bu8Dp1+b5q4xEmTFOaLm4IZsplQkkL hK4+jy4Y71EeuGUhWb/B3z6tcGb04NsxCdLZmQrXe3t6FAFxZaw+10ixn43l5SFOpy3sgnrEUqNzc ovwtMsP0qPHQJqCLaSWIMuFTVjiJAPJT4JVhFSdDg9YfU2lPIiJHErIIixQH4WXe0EsLOV2nta1g8 17K8GcOxjYFUdTSDhoTGPdeYwr5FIvrQbhHz1qSXNNYDMQqMvtzEv6eHpAG1RwoFp3Dg01t6Y8+u0 XuJ5ln5hhMW86KjVTI3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCint-003x8x-0T; Fri, 23 Jun 2023 15:34:29 +0000 Received: from mail-vi1eur04olkn0818.outbound.protection.outlook.com ([2a01:111:f400:fe0e::818] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCinq-003x7n-1S for linux-mtd@lists.infradead.org; Fri, 23 Jun 2023 15:34:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkOZSEUCm3u6ROvjRhcPN7t3adDg4P2IhYwhJaL5uRqZqHqBS5h+8qlKh1E6H5txkIFhcnvKu3pdQ/C2BPv9xQYzsqnLiQNG+tx+L//J/7Za+C8CVA8Wdoq32xbebzbLhT4zxIIE6LTdIed0ygbN+5tGG7aJe9QEP63BadHtPed5GHWjb5yJVI93HZXgs+hX0YlVf7BB6HV1eMzUwSc6zgQxqwzmUI6Cwno2COgF8dRr6lVKTPQpkCvQsXaJlIikfZcTBj+Nih8xL33iC3Io9NHchxrRFpr/7sCidwNtgjUgyh1q3kBoGaRonNXDdgBgFztmpgWrMnCokyFpCpLTcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NLprr/21Fj5NqO0IczSq5tMyoC4apgBU7K5sCy4rKbc=; b=cw/AbKiaERlubxZIoFiDbkE1YiHGi/TwjCIQBooxB5hg2LiqeL6wlE3DFLUklzbfYLHLg7tQ4XjY65sZXaBP9GvT1Sv+CofHG/nkXwymwN7k6oj/ItwdpmwvbKuuU03BMGkKpNu+qa+PU6Ry7zsEPFrZ3ufAQYwKgQ0Hjj0zJZZ+EoTM6f6k5+Q7IDb2zJ0+EzBdAQU+T77x8UtK2CdB9yQe3uxkIL8sDc1AdvyR8iPTDJEqLvuvgN1iI1enuxmM1XmLkLE6TKL52DAASYInuvX5IupYNhYV7UCczbGgvT2QezS/uRy3rDfwQgBdaGbKJekEbT+3/KYFgk6xtm8uqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB4P250MB1032.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cc::7) by AM8P250MB0042.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:3d9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 23 Jun 2023 15:34:20 +0000 Received: from DB4P250MB1032.EURP250.PROD.OUTLOOK.COM ([fe80::1f3e:9e10:27b2:5ae4]) by DB4P250MB1032.EURP250.PROD.OUTLOOK.COM ([fe80::1f3e:9e10:27b2:5ae4%2]) with mapi id 15.20.6521.023; Fri, 23 Jun 2023 15:34:20 +0000 From: Olivier Maignial To: Cc: Olivier Maignial , stable@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Schrempf Frieder , Mikhail Kshevetskiy , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [v2, 2/2] mtd: spinand: winbond: Fix ecc_get_status Date: Fri, 23 Jun 2023 17:33:37 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230623153337.3818369-1-olivier.maignial@hotmail.fr> References: <20230623153337.3818369-1-olivier.maignial@hotmail.fr> X-TMN: [zanMV4eiVPO53ocmI8ZGKTnV7PvRdaP7] X-ClientProxiedBy: PR1P264CA0058.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2ca::12) To DB4P250MB1032.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3cc::7) X-Microsoft-Original-Message-ID: <20230623153337.3818369-2-olivier.maignial@hotmail.fr> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4P250MB1032:EE_|AM8P250MB0042:EE_ X-MS-Office365-Filtering-Correlation-Id: 7af60408-3afd-4282-64ba-08db73ff5027 X-MS-Exchange-SLBlob-MailProps: a+H6FLLcF3qXcYLnbyrqKtqrVM43XjewP5Mt+qMANFqJddK6Qn17WN7r6idc3ocOgfShtwL85AOCKS+x3jEFpwEsh1lE51a3VELdI42C61VRSRWdTGuol4DnIvHJwaSh8hxh7iTN6j2BRl0+mLjV/DIeXn6gDFLnUXNeNiFrzKt0nCQk1KfgcoK600SOhuwh2CHFWEEqkMzz+5AwZYIZnSjWTo14Ct3oRQbjwRhkIJvG2pHHkjQzv+jCgjGZLsfEzfotCsbeB955A7Hkt+aE+oaydFG597Y+Qm4qJNXCL8qu6a3jFLltikjF60Z+b1uhoxQTodtM6ztRdPCO6eMWl4Dv+LYfkwRe/aTe9E3lnyJLprabQ2l4Vss57bFAC0lpjDD3xAfDsSjzJlEN2UDbIvJ0VXscfXRd/nJ1Xmbrq5ypGD7MBgirweeL3grJY4S/76ta+JZAEE6VtMNAzv3EgJbeaP17vKRMJcDBCz7YfeWX4pGrlMnPaZ6A4RuuS2WGFQRjeoyaHx1QP2aMwY5vniSDCe1agCg2UId4bhqo8+PmsUeL8f2v+dpmbK0eHio57kc7sZ5yA4F/qtbQt65mf91JPNvv9q9kKrB8sYn1PfhVBP9nfHvDMI2/CDCvylBDaN1xHL+HdWaypvdYUndbxCoezHIZKoxAQfeRxUO7kVdagCFxnrhzS6Xwj8j/iBNEFR/JFvIAQf9Av7Vb+7nUksOni6NoXxijmXeoDIZ5OPZuFkZbx5uG1qJ18qz1DEY4kNISkgVTo2nCCIBtVQcIp2XK9hZxe0foDPl3iyKZQvJkfO3trKZt3geDwfpvThWZ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2MfYA1slhC80sh47rovDRaPLYl4+CiDSQALPtDk/QvPrNk4KmJqbRt59/Nyhrv13Lo3zD3TokVUvUJ/fByEXzPwIECL4g6bNYeGWD27VroIA4vh2TjD4ni/IzVqHsJCjNFiKIqQJYHHGcbNig72hNBsm8uE8AHX+y1fZ7gb4LV1XpI5TAgLvqeppDojRjHFJ4n9dbxW8Subh+3qxX3pCFV9Cz9to3FmbDa1DXKjPHsYeUL1cStoHVgeuOBfjoNTgxpSaSfOt9oq/Fmeeoj3hObtXlwQa6YdWE8RdW18EldJWljmBE8nlJ0Jkftwp1aj7CloCQ5yt9noGYCJkVZ2opm/G5wYs0tczl5HeQe+hrpbmU+rPYr3b9Yw4DYLpO8NU+IHDWyvIlEpws3nQ3XpvkgMRNJT9HC5/smr3yXXh3NIM67ok/MBVhyJjdvpkQLq8eAoauxJPktcsbGaBTwR+i5HOKfhYCmuu2CbrgfqBV3tZKGiMebpVZoynamLPr8wiys6QQEC5WkwHB3poQWhzh0n2m4C5ec8ivHWOA1N1Udoz1MuhptEH4vtl30FqYkKSX1gnjGAOYRsmi+kVoY5hAP/DNVgEBLCQ1GevbyWL/5vXD55RzeMAElt6810IZ3DpwoGh4whLHcLHXHNwHadJUQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KEYVpBj/y4D6RjSIUpaDSllgYCqHSEQTnGVgePh1kvZ5wgQMBBs4QvESg15MAur2zdgcZvmYkyZJN40xs2YhQlcAmmkVdyQrO1rCXyQDgesgy9uWHfZKahMM9Y+4O6EzCS0cu6hm/DcMJZXVYWHSiesfdKce0miC+I9Z9uBWtLHycvJGpeXZLEkNhoo4AQYsIJPjXg8CgmNlYekE8GfPcJpedGL68YQP1q7dLBDdM0clRxZRgV8KfE3akaw3IVj000chEu5pM+4uby9/xTj8IySaHb2zzt5VZ4TcxOu5cUAOLx9ZYfrxpUslQ8Yp5uKRcqkcIDIdi1PlX5BkbCqim3I8JvitkhgzX3c2YHgaCzlK4G36N0mU4lBq51apOJQ+SncLxegZ3bi4rRVKjb751hd0imaqBM4BEi/NuU9bWC6ZaE+A7BQ1zLbo9m5SxfQ+mpEQfG+tsFhtWQsiUCQ/xwe31okvKU7eawsvvILSSuIjHqaDRoFY6ME1XiHrRNh8msDtKy/z7j9NLyaYBc5vQXvFMWEAhHX94ve8+bTKfUQNlpGqkmcDsKgh75KS4QBTJcUIHV6wzb4mnJ7pV9V62WI14u7/nsS03rXcPSzt6jW+k7P2NJ+3ICu1YagYBDKmM6zFuY/kg/Y7CQrtq8GU0MDi/ax/X7mqbFwzd6S50YdKmLthG6gubFLljT/dzZV1f/QLs+S0Cuyc31vvpWPBT0lkSgc2m0MZyP4NgLnTObS6g9hBuxbwcGmh0e5lgbVA1AJnqcaNZnzjtKZB4rOe9HLajRbPMlqgug7iXi4vFHECyK8pYM6ACDShLxVlJBs3Xe8UGloBxht/qe7dDbgSMSD+YTIxrVu/DUWKzr+PReMT46AZ9ROcEKqh1SHdDA0qHuu7w1mGrWOjMHWDVvksUW0Bm9enJaFW1qFPTwroTyNF32b7ViJErsy3tq+Vnil2T9DalMNrEIA6ZqbUjIJeD8gVuPggORpwLXQW4Wwujx3lUvHsoZOxJBwpPtElqt+Cy9V8EXIQHT3UcRBY695n126HwLiGp8vS6Lz90SV/xj5hl5PCngmPtM2AQME2N8928KuKvVzDdOwjIN7zzPqnRGIQIE9NgpLLx1Ptzzox2iY2+CmmwAIhWmGJIS3NDlHXMbbqDYAjs9elC8fRsYHpGqtyv0AsxozbDR+05vWjBUdDRg2ZunS9uNk6+YnTMSWVklhhucGHQZW/Qtpu1W2uRjYm21xqWaNuMdt4oKiQhvk= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e3d53.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7af60408-3afd-4282-64ba-08db73ff5027 X-MS-Exchange-CrossTenant-AuthSource: DB4P250MB1032.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 15:34:20.4591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0042 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_083426_497398_CF493F14 X-CRM114-Status: GOOD ( 10.63 ) X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Reading ECC status is failing. w25n02kv_ecc_get_status() is using on-stack buffer for SPINAND_GET_FEATURE_OP() output. It is not suitable for DMA needs of spi-mem. Fix this by using the spi-mem operations dedicated buffer spinand->scratchbuf. Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [olivier.maignial[at]hotmail.fr] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Reading ECC status is failing. w25n02kv_ecc_get_status() is using on-stack buffer for SPINAND_GET_FEATURE_OP() output. It is not suitable for DMA needs of spi-mem. Fix this by using the spi-mem operations dedicated buffer spinand->scratchbuf. See spinand->scratchbuf: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418 spi_mem_check_op(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199 Fixes: 6154c7a58348 ("mtd: spinand: winbond: add Winbond W25N02KV flash support") Cc: stable@vger.kernel.org Signed-off-by: Olivier Maignial --- drivers/mtd/nand/spi/winbond.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c index 3ad58cd284d8..f507e3759301 100644 --- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/winbond.c @@ -108,7 +108,7 @@ static int w25n02kv_ecc_get_status(struct spinand_device *spinand, { struct nand_device *nand = spinand_to_nand(spinand); u8 mbf = 0; - struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, &mbf); + struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, spinand->scratchbuf); switch (status & STATUS_ECC_MASK) { case STATUS_ECC_NO_BITFLIPS: @@ -126,7 +126,7 @@ static int w25n02kv_ecc_get_status(struct spinand_device *spinand, if (spi_mem_exec_op(spinand->spimem, &op)) return nanddev_get_ecc_conf(nand)->strength; - mbf >>= 4; + mbf = *(spinand->scratchbuf) >> 4; if (WARN_ON(mbf > nanddev_get_ecc_conf(nand)->strength || !mbf)) return nanddev_get_ecc_conf(nand)->strength;