From patchwork Wed Jun 14 13:31:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Coplan X-Patchwork-Id: 1794969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=eCQY120C; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qh5vT2Lcsz20QH for ; Wed, 14 Jun 2023 23:32:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32B363858000 for ; Wed, 14 Jun 2023 13:32:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32B363858000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686749555; bh=McXYFokVdPcCLkH2J+qI5YcB5m1LnYFHLTSIA1pEByc=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=eCQY120CzsuYLInwkxR8zVQ2haxazA9fu6QBrgrRfnaIUPW6Gr5gDLvANFTlH+B+B HHuvIGIMIzDTm/IVe1TBVEcjdk2MEkCxGkt6+rxYpLDhX7SUBFwp3zJjiboFMBanFZ Ce4EysM+JcdeW6jnZs+aA2QPW303UM5V7owq3DGk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2041.outbound.protection.outlook.com [40.107.7.41]) by sourceware.org (Postfix) with ESMTPS id 47D4B3858D1E for ; Wed, 14 Jun 2023 13:32:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47D4B3858D1E Received: from FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::20) by PAVPR08MB9236.eurprd08.prod.outlook.com (2603:10a6:102:307::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun 2023 13:32:09 +0000 Received: from VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::48) by FR0P281CA0146.outlook.office365.com (2603:10a6:d10:96::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.23 via Frontend Transport; Wed, 14 Jun 2023 13:32:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT032.mail.protection.outlook.com (100.127.145.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25 via Frontend Transport; Wed, 14 Jun 2023 13:32:08 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Wed, 14 Jun 2023 13:32:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4bd15a33d03b7f09 X-CR-MTA-TID: 64aa7808 Received: from 17ff2ceba28a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FCBFE3F7-54B0-4C18-BD28-4CAF6ED73D5A.1; Wed, 14 Jun 2023 13:32:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17ff2ceba28a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Jun 2023 13:32:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hT4PIW/zxSjeS3R7yjF0c1PivzSiEVj+JvgFhGvnpoKAdh33OYh84/Ntu6DVubPoVQSx94/eiXS+qoehevep6dlchVSuqT4lXmiWj5NwOyfKEKOY978pqi3RzDWdRd71DwH67MVs4VwEYeEdxHNn2lS1k+Z+S8yvYJe/cwjSjU+zQFhfTp2TgUelv/t+7EFvZIixgW6eroNarfORC8SPZ4EUOOAX/McQOf5jAWQMfqvy5ylrky32ZW5DSO21WQgmSc/cursbEMIJaV0O+gvUCJklW7SW3Yui9ijv/0+l/8yx0LGBLGRYwllEGZug4iL2t1yV/yanfyUJRJI51PQVGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=McXYFokVdPcCLkH2J+qI5YcB5m1LnYFHLTSIA1pEByc=; b=FC0q2ZUGdEKyXD3qvkgorvTY0aQi+OSnZYsu8V0rV80ng1uyL3yk8FUGmU6LgCApqV9BpEJNfWogXYOXWeYF9ECQNSaMaZ9tYDmJwxsTGBcnX2jFwfmc09boRTpoWCCO/qF8OXBzEANrQtWpyQPuOe+EW14lVZFm2uDgF0EyQe7Kn4n63iT5vKDNwtBOP6DcMwFLtg+3EQKlLY/DPQjWvYCPp0BXBXk0hF7VzFbiP+kNVltElpWu2/mSA9PF0Yes98xeoMhBH9pYz68h6sVaziN1C1mALq4DAzPbY+Mdro4WnIiM7IGnBUloSE/13T4o+Tn0C+38O8ZZ9L7OaMsy8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by GV1PR08MB7379.eurprd08.prod.outlook.com (2603:10a6:150:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.38; Wed, 14 Jun 2023 13:31:56 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::202a:45b7:3be8:47d5]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::202a:45b7:3be8:47d5%6]) with mapi id 15.20.6477.037; Wed, 14 Jun 2023 13:31:56 +0000 Date: Wed, 14 Jun 2023 14:31:54 +0100 To: gcc-patches@gcc.gnu.org Cc: Jason Merrill , Nathan Sidwell , Iain Sandoe Subject: [PATCH v2] c++: Accept elaborated-enum-base in system headers Message-ID: Content-Disposition: inline X-ClientProxiedBy: LO4P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::13) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|GV1PR08MB7379:EE_|VI1EUR03FT032:EE_|PAVPR08MB9236:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f60bbb8-3b6c-49dc-e1c9-08db6cdbc0cd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: yQeAFY8FQsTqQ/hXHGQMwWrWqW8p1ts6jrU4sbkpgHQ/4j/WaYXA/78KzmmSFwmvtkyEhesV8k2D0qz7FyqxqH1Wbdb9U1h7qXpPHL+Bt8ezzGWvV6HYO9x6Et4S8uoLrTQHyPtg4m2Xw7IlDAwdFjmYYcJgH4kq0cUqiEtaoma7aG6h/PdBK3TciEpQ+4zG0k2iIgbvZro0UKOsloz2zix67qJEvnmg7BUcmmnBE1cXCUO5EMm5Yo8AtbkJouP/fxCDQU7HjwGdQJyxbzqznIrdwWgadW+3trx6qI+CEbYUcz2FRevMygP+/aTRIvwrUQoJleS9EMyK/mi/rlA52XjXlgh4aA27YCX50SfSabevvjfEyvP7VIDzJLmPSFu+cug8IC5lCmSp0vv+siDDl/zZWg+wnwbFuVA6JGjeq2yw6ScfgfbXGxsn+pYzB4t/s1R1NSxQyH/Rb9kEThqZ+laS1aazfFvvdY4o95nwnPfPXoqJ5vmzm9N02U3Wt0QSLx+d1MnlkmZlxUbQv7gZJajFBMXeR2HenppbIVMW5BV+pg7KKqK70qIXe1ZbOII26c+14Fbf1sHuzhBXhMyKRi3NBHWv6zok3Q6P2P/us3L/6N9kmiPlwBdEe9AHALtupSC+ntf6VLz0yMNRIevsSQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8958.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199021)(2906002)(83380400001)(26005)(2616005)(186003)(6506007)(86362001)(478600001)(6512007)(21480400003)(38100700002)(6486002)(33964004)(44144004)(966005)(5660300002)(235185007)(8676002)(41300700001)(8936002)(66946007)(316002)(36756003)(66556008)(66476007)(4326008)(54906003)(6916009)(44832011)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7379 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e41ee8a-5234-40a0-b078-08db6cdbb92d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6venCZ9AoK9bd4iJNjGzXNjf/UkaI8GWLD6cw7ZTRWhZ53LL1K7Rc9nIofiWEYF9zbDo2iggqS/3NDRjgIlMGQrE+4UE8NdWzf666L1rDO1tT8wTJqsvwFdMIkerBPvIIQC+sEeRY+uITcUlojLLEu6HfXBHk7ln549AZuDAa8ReLZ9ki2AVe2XS+HAI/oj4fgaacKN/eTO+D+aP0H4kNVvU+Jqa3K/GznMmoqATdmNdrC0iTcCSOGXlPSNkxrYUMwrKn7m7fI7cM2vBc2sesyVkBYYsxw6E+oIricmf0yz4TCaqbT/lZV7Oo/LhrJtFuxUXE4cNh9BPaUIGr0RxfgAgsWVEpBAqBxf5MFokCOLYNTcdnPApIjj0J+kEpVFEcezE/p6i1NHo04nxE1StcMStF54jvwR7HiyEwyVLoLAsh0KKJxu8oFJa5IuRqKaoemVYzv1srPWM52O8ezSvt2vWOPwssufbpzeJ8xS4H5E6vhTqqfNNeMsCkfafUddXL3BppN8HrnwOzDRq9n+RSnceIbVbIA1zk207gTSTlkqQ1Q7L8IIysGfh691VIapF0MhwpQqBqpz6RiUjFR+yuTANvyks4DFC9HgHB09yR3MGrv0w7uKchuUjVL/Q0ir5WdRKsXXdiHn4X5c9jNgeq5kU5EXHh3E3rppKtQwwBZHzxG342ewNMC7E/mdWCG3iyhlQLfuF04P3ifE4bbYahat6dDJQiWWMR3v4Ie9TvrMGsowCvOqEiGLPCYUmcKca7NGVqgzHPdyFMVuLpHxfj7gqXeFGO9y4VC+qJ9O5BM= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199021)(36840700001)(40470700004)(46966006)(336012)(36860700001)(83380400001)(40480700001)(44832011)(40460700003)(82310400005)(235185007)(4326008)(70586007)(70206006)(54906003)(36756003)(316002)(5660300002)(6512007)(26005)(41300700001)(8676002)(8936002)(107886003)(6506007)(86362001)(47076005)(356005)(2906002)(81166007)(6916009)(82740400003)(478600001)(2616005)(21480400003)(186003)(966005)(33964004)(44144004)(6486002)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 13:32:08.9850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f60bbb8-3b6c-49dc-e1c9-08db6cdbc0cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9236 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alex Coplan via Gcc-patches From: Alex Coplan Reply-To: Alex Coplan Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi, This is a v2 patch addressing feedback for: https://gcc.gnu.org/pipermail/gcc-patches/2023-June/621050.html macOS SDK headers using the CF_ENUM macro can expand to invalid C++ code of the form: typedef enum T : BaseType T; i.e. an elaborated-type-specifier with an additional enum-base. Upstream LLVM can be made to accept the above construct with -Wno-error=elaborated-enum-base. This patch adds the -Welaborated-enum-base warning to GCC and adjusts the C++ parser to emit this warning instead of rejecting this code outright. The macro expansion in the macOS headers occurs in the case that the compiler declares support for enums with underlying type using __has_feature, see https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618450.html GCC rejecting this construct outright means that GCC fails to bootstrap on Darwin in the case that it (correctly) implements __has_feature and declares support for C++ enums with underlying type. With this patch, GCC can bootstrap on Darwin in combination with the (WIP) __has_feature patch posted at: https://gcc.gnu.org/pipermail/gcc-patches/2023-May/617878.html Bootstrapped/regtested on aarch64-linux-gnu and x86_64-apple-darwin. OK for trunk? Thanks, Alex gcc/c-family/ChangeLog: * c.opt (Welaborated-enum-base): New. gcc/cp/ChangeLog: * parser.cc (cp_parser_enum_specifier): Don't reject elaborated-type-specifier with enum-base, instead emit new Welaborated-enum-base warning. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/enum40.C: Adjust expected diagnostics. * g++.dg/cpp0x/forw_enum6.C: Likewise. * g++.dg/cpp0x/elab-enum-base.C: New test. diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index cead1995561..f935665d629 100644 --- a/gcc/c-family/c.opt +++ b/gcc/c-family/c.opt @@ -1488,6 +1488,13 @@ Wsubobject-linkage C++ ObjC++ Var(warn_subobject_linkage) Warning Init(1) Warn if a class type has a base or a field whose type uses the anonymous namespace or depends on a type with no linkage. +Welaborated-enum-base +C++ ObjC++ Var(warn_elaborated_enum_base) Warning Init(1) +Warn if an additional enum-base is used in an elaborated-type-specifier. +That is, if an enum with given underlying type and no enumerator list +is used in a declaration other than just a standalone declaration of the +enum. + Wduplicate-decl-specifier C ObjC Var(warn_duplicate_decl_specifier) Warning LangEnabledBy(C ObjC,Wall) Warn when a declaration has duplicate const, volatile, restrict or _Atomic specifier. diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index d77fbd20e56..4dd290717de 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -21024,11 +21024,13 @@ cp_parser_enum_specifier (cp_parser* parser) /* Check for the `:' that denotes a specified underlying type in C++0x. Note that a ':' could also indicate a bitfield width, however. */ + location_t colon_loc = UNKNOWN_LOCATION; if (cp_lexer_next_token_is (parser->lexer, CPP_COLON)) { cp_decl_specifier_seq type_specifiers; /* Consume the `:'. */ + colon_loc = cp_lexer_peek_token (parser->lexer)->location; cp_lexer_consume_token (parser->lexer); auto tdf @@ -21077,10 +21079,13 @@ cp_parser_enum_specifier (cp_parser* parser) && cp_lexer_next_token_is_not (parser->lexer, CPP_SEMICOLON)) { if (has_underlying_type) - cp_parser_commit_to_tentative_parse (parser); - cp_parser_error (parser, "expected %<;%> or %<{%>"); - if (has_underlying_type) - return error_mark_node; + pedwarn (colon_loc, + OPT_Welaborated_enum_base, + "declaration of enumeration with " + "fixed underlying type and no enumerator list is " + "only permitted as a standalone declaration"); + else + cp_parser_error (parser, "expected %<;%> or %<{%>"); } } diff --git a/gcc/testsuite/g++.dg/cpp0x/elab-enum-base.C b/gcc/testsuite/g++.dg/cpp0x/elab-enum-base.C new file mode 100644 index 00000000000..57141f013bd --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/elab-enum-base.C @@ -0,0 +1,7 @@ +// { dg-do compile { target c++11 } } +// { dg-options "" } +// Empty dg-options to override -pedantic-errors. + +typedef long CFIndex; +typedef enum CFComparisonResult : CFIndex CFComparisonResult; +// { dg-warning "declaration of enumeration with fixed underlying type" "" { target *-*-* } .-1 } diff --git a/gcc/testsuite/g++.dg/cpp0x/enum40.C b/gcc/testsuite/g++.dg/cpp0x/enum40.C index cfdf2a4a18a..d3ffeb62d70 100644 --- a/gcc/testsuite/g++.dg/cpp0x/enum40.C +++ b/gcc/testsuite/g++.dg/cpp0x/enum40.C @@ -4,23 +4,25 @@ void foo () { - enum : int a alignas; // { dg-error "expected" } + enum : int a alignas; // { dg-error "declaration of enum" } + // { dg-error {expected '\(' before ';'} "" { target *-*-* } .-1 } } void bar () { - enum : int a; // { dg-error "expected" } + enum : int a; // { dg-error "declaration of enum" } } void baz () { - enum class a : int b alignas; // { dg-error "expected" } + enum class a : int b alignas; // { dg-error "declaration of enum" } + // { dg-error {expected '\(' before ';'} "" { target *-*-* } .-1 } } void qux () { - enum class a : int b; // { dg-error "expected" } + enum class a : int b; // { dg-error "declaration of enum" } } diff --git a/gcc/testsuite/g++.dg/cpp0x/forw_enum6.C b/gcc/testsuite/g++.dg/cpp0x/forw_enum6.C index 01bf563bcdd..8ad3f733292 100644 --- a/gcc/testsuite/g++.dg/cpp0x/forw_enum6.C +++ b/gcc/testsuite/g++.dg/cpp0x/forw_enum6.C @@ -23,7 +23,7 @@ enum class E7 : int; //ok enum class E3 e3; // { dg-error "scoped enum must not use" } enum struct E3 e4; // { dg-error "scoped enum must not use" } -enum E5 : int e5; // { dg-error "expected|invalid type" } +enum E5 : int e5; // { dg-error "declaration of enumeration with fixed underlying type|invalid type" } enum E6 : int { a, b, c }; // { dg-message "previous definition" } enum E6 : int { a, b, c }; // { dg-error "multiple definition" }