From patchwork Tue Mar 27 07:46:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 891408 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fA7KcTLA"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 409NHj6RXqz9s0m for ; Tue, 27 Mar 2018 18:41:36 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 0EEE6C21F94; Tue, 27 Mar 2018 07:41:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 3DF20C21D83; Tue, 27 Mar 2018 07:41:26 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0276AC21DA1; Tue, 27 Mar 2018 07:41:23 +0000 (UTC) Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by lists.denx.de (Postfix) with ESMTPS id 87E48C21D56 for ; Tue, 27 Mar 2018 07:41:22 +0000 (UTC) Received: by mail-pl0-f67.google.com with SMTP id s24-v6so3230517plq.6 for ; Tue, 27 Mar 2018 00:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kEwI+Dl5ccG3ODiHKZD7+QFTQxVcEMs6jKJshMnAyhc=; b=fA7KcTLAAw2/Ke80TPY4GFJBKHXR7bbC4i2aVfoKXL+T9M1RaPY7By5P/GCgV86G0W lEZ381D0hVuy6/aouZ1a780OgHoYkHHWB49u2rfngYZ2Ssj5d/WzCzk5vedX05wDQSxl Mp1OjkGqUDIqaO2fjCaYEYlbTU7+iJIu8OweUcgPa+BMaiZ7sCXvqRfMWv/1qT8KJasg 4xiszq1PMbqjIy5xpFhDTqZhQpdfAUHd7YCEZwf3wH0h4DFFyRW2lUooZJ0nisWpHlxe hbZvgdSxd/die1JKtwvZsXhx4d4igtiCB692VK0p/cs5miQw4oGUBfNSrtYyIiljtKiS ZFOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kEwI+Dl5ccG3ODiHKZD7+QFTQxVcEMs6jKJshMnAyhc=; b=mpEssWsWEnkTB8F7GF8cQdKdsaozgI/ZdVnvXixenqr0zY+u5EeJYsFmcKyDyk9yqU Ewmu2SLph8oQmWdeZ9o6R1dZVg1zdDWGh/nF1/JcMXSW8uZTN7Bs+dvJ0gMfxzTzzMeN Jg8pbQzIJ39u/Aw0+3FLPdan+EJVNvmW81d/PMrq0D5Ao9sszZ9Ih9x3YV4iZdpYCkcL k4/5N2ywC1uvYpX1XkiiyI2VufLUXl5RosW8iA9CFUMoZ9hEOpTZELEn1dVw70q+k4Cm MjOVNY0A9vr8pd1X0VO0OE1/qoJ+h0jhn1MM318cArnE5Qti9YF72XyG3VyrcWvkxea8 MdzQ== X-Gm-Message-State: AElRT7HVM75yI5t5xY/TohkHPn/ULyJcwDcXHGpPc/VcLfc2E38X8qc9 AuOeKzbFyxOfwQNJqVG0rIw= X-Google-Smtp-Source: AIpwx49iGB2BcIigGwgyK5KzDREc8ftopN/PL9lFKlsM17lp0+hldAJvLBMRmnEEb8IBVGli4wG2SQ== X-Received: by 2002:a17:902:b181:: with SMTP id s1-v6mr6067568plr.263.1522136480806; Tue, 27 Mar 2018 00:41:20 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id h6sm1108985pgn.65.2018.03.27.00.41.19 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Mar 2018 00:41:19 -0700 (PDT) From: Bin Meng To: Simon Glass , U-Boot Mailing List Date: Tue, 27 Mar 2018 00:46:05 -0700 Message-Id: <1522136766-30991-1-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 Subject: [U-Boot] [PATCH 1/2] dm: pci: Check board information pointer in decode_regions() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" PCI enumeration may happen very early on an x86 board. The board information pointer should have been checked in decode_regions() as its space may not be allocated yet. With this commit, Intel Galileo board boots again. Fixes: 664758c ("pci: Fix decode regions for memory banks") Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- drivers/pci/pci-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index ad43e8a..9d51236 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -876,6 +876,9 @@ static int decode_regions(struct pci_controller *hose, ofnode parent_node, #ifdef CONFIG_NR_DRAM_BANKS bd_t *bd = gd->bd; + if (!bd) + return 0; + for (i = 0; i < CONFIG_NR_DRAM_BANKS; ++i) { if (bd->bi_dram[i].size) { pci_set_region(hose->regions + hose->region_count++, From patchwork Tue Mar 27 07:46:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 891409 X-Patchwork-Delegate: bmeng.cn@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NbTAnoAC"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 409NJG0MRmz9s1P for ; Tue, 27 Mar 2018 18:42:05 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id B69DEC21EB4; Tue, 27 Mar 2018 07:41:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 249B0C21EF7; Tue, 27 Mar 2018 07:41:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3393BC21D56; Tue, 27 Mar 2018 07:41:24 +0000 (UTC) Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by lists.denx.de (Postfix) with ESMTPS id 8250EC21D83 for ; Tue, 27 Mar 2018 07:41:23 +0000 (UTC) Received: by mail-pl0-f65.google.com with SMTP id 91-v6so5804411pld.3 for ; Tue, 27 Mar 2018 00:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=yLmDkvEC6LCci/u3eqnle5XSIc9zt6CKA5nNg4dghq4=; b=NbTAnoACpg12/rDGBm8eNetuNkrZcD9Ozun7vZdwAjVO6kpku8M5uhSXumlDJv2YuD 5O674k2p79mrQCfUb2bp9Jq5FXMXW96Iu2rl0tNpDbxBYNSWBAYFJunlCcCGqdfLUSoj 1TjazISikKSwLxhncXjHYsrR53Gvq8YBQ5d18Z6QfwTCQliYfTLqVE++ODkoQ26tRyo5 Ob5Sjbs0IvlcrN/SlTfXHNlg0DNrRulGxcd9dNkoaGYAaMiQlo1CL5Uy3F+OqLmaZmQg Yrf1aGHhswP2LwukSwvP6owmJAOXnD8ht0HnUVREYH64BpqUysnKqEXpeRZg9nNKKGB/ vuiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=yLmDkvEC6LCci/u3eqnle5XSIc9zt6CKA5nNg4dghq4=; b=h0V+h5ES6NXkiF2ZmbAbexgVBesOz+AuTJNVwhkcztemh/JoMYAAA6R2s3vs43OMIt 9Mk4lf/1u0cIuoU9nwvOs63jhiQBz9ycbYYe4pMrhViqZ21sMEXDFvI3EpF77pfWqjdS 7m8006pH++zSpHck3GljGHti+s73S6dHBzrt3rsX/RvS2yhRy+LJq8bkVGEzFSi9DrzL Jpt2ZBcY1Rw+QPhCQS9b2pbB2xq3MXeal1Ycbf/bkFx8zZo3lDUrCtmQ0KWXxMFOW6Im HTw4z/iW7yQVA7KaOU4drUfo4OgwZ4KkCjs0WuG50KryQb5QnjnYzACAy1Xd84iXpaPt ko2A== X-Gm-Message-State: AElRT7FMD0Ik/8xVzB0OPWLxMomOgmwBLMA4KVK7E8KGKd0QzkxNH+dO m+nkQfR4q1SuJX7UoHlfy9yOog== X-Google-Smtp-Source: AG47ELul3+p6TPztNse4jLhZUPDmffNc/sH2/mQKAQ5lHXY7MMpiq2bvhlLMbAQ7PnWXT6aItEwqwg== X-Received: by 2002:a17:902:bd46:: with SMTP id b6-v6mr43260584plx.38.1522136482151; Tue, 27 Mar 2018 00:41:22 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id h6sm1108985pgn.65.2018.03.27.00.41.20 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Mar 2018 00:41:21 -0700 (PDT) From: Bin Meng To: Simon Glass , U-Boot Mailing List Date: Tue, 27 Mar 2018 00:46:06 -0700 Message-Id: <1522136766-30991-2-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1522136766-30991-1-git-send-email-bmeng.cn@gmail.com> References: <1522136766-30991-1-git-send-email-bmeng.cn@gmail.com> Subject: [U-Boot] [PATCH 2/2] dm: pci: Avoid setting a PCI region that has 0 size X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It makes no sense to set a PCI region that has 0 size. Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- drivers/pci/pci-uclass.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 9d51236..a2e8296 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -897,8 +897,9 @@ static int decode_regions(struct pci_controller *hose, ofnode parent_node, #endif if (gd->pci_ram_top && gd->pci_ram_top < base + size) size = gd->pci_ram_top - base; - pci_set_region(hose->regions + hose->region_count++, base, base, - size, PCI_REGION_MEM | PCI_REGION_SYS_MEMORY); + if (size) + pci_set_region(hose->regions + hose->region_count++, base, + base, size, PCI_REGION_MEM | PCI_REGION_SYS_MEMORY); #endif return 0;