From patchwork Sat Mar 24 11:18:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi Singhal X-Patchwork-Id: 890430 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i6BkcgI2"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LeAgo3NR"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 407dGm45H9z9s0W for ; Sat, 24 Mar 2018 22:19:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=I7f4u1rNdXNh1FhzwIcMx1vMXLNiSU33kdHa6dMuug8=; b=i6BkcgI2Ze+8Sm uRGrL3dUqYs0w1/Lo9X+juYZSpR2IYYszao4bdv0Pg78ZgfwjsXzliHl0zjqzY62+yDZqsmAx7qRO bnHbtaHLwQPY0Qht353Oga6ITbXJva4S7XAV2zTA4NdWMK9kfVWrvTUpfhegbxxTjQiz5A1PCQA3G e64Xo0xuxlngFEe0nlT/ZhFsMRLxF1mAupgEgkrGarotVlNs6knFU0z6FPrGoT1d2aSDDVyl87HTw nerGhPdombAw431CkaUBW0/OkBBf07eyy8NIbxRCxLEFWxhz3Ad7ZXRIgJyUNncl8Q2DVLe1VtdDw RRv325qpXDcxLdqabfUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezhCs-0005bg-Co; Sat, 24 Mar 2018 11:19:30 +0000 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ezhCo-0005Za-Rm for linux-mtd@lists.infradead.org; Sat, 24 Mar 2018 11:19:28 +0000 Received: by mail-pl0-x241.google.com with SMTP id x4-v6so8994613pln.7 for ; Sat, 24 Mar 2018 04:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Wxeeg8SqC/bEceCgvEod/ZngIQ2PG0g9L/fznH+5ZiE=; b=LeAgo3NRVOnr07mp8Tx9HXjDdLwsBCwAR3OsTZRb3mBo8uYnNyGZG790+PxL7pAIas 32VOfeew5/ipkhj+VJ6IcvFqt3GQvVCUUbTo085oPg9cxcZjqyAwSdLR9qRahf2vVEUK 4o5NCXTLzc6PVPWWEMQapmd4xPDBHs+gDNi44QQHH8tDMGG6/KDMjZE0Yn2VMF+FlT18 +1R9LPLcBl6tvB9GX+Nj/0BbiIogMkdR/w1RE+pDvgxlsCytrNIg5k1PgNyEZmiPkt2w eEbNz4n6kRHihbRcOyVe3EMu5MFffM1+HPHWKtiOvbO8A+JVz6NJuaXIkYbTUZkW5NzP qHXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=Wxeeg8SqC/bEceCgvEod/ZngIQ2PG0g9L/fznH+5ZiE=; b=ZorFdzk/ut0fi4j4bSAii3CYTzRMTr1dItbepk1GI583swDH/qGqN7T6gQrYSVJeYh SQBcjfdAxLRUSIgXw3BjSqM23LKvjeK8vCTMZ7I+m7Dg9CAe4hHAJKCZqLKGa/30+pyB jbabXY/ZYGmjAlNTpg1XO1/FMMhIhqqewCry8f6TmXEBDXntHB5rzbzkLLe7hY6GywY1 QVSn6qh+0vBeNgOB6OAV9tqxma3PW0IJM+aWHCJnKNIhmhLaOdKx8GFu6Wx99SdeE3HH n1xtBiAnRheYAx3zR9o2jMd5gl7Ew391sTLS1oMubHYOEdMYtZTavZVLyGWnClfxnCda XacQ== X-Gm-Message-State: AElRT7H/P/j3w3cKTbZy766imXEil/peVqn0qxcV4tznh797VwJlK3+U LPQaQWOUClNStGnx9BYD3OQ= X-Google-Smtp-Source: AG47ELvqFZXcSgUkSK8mvGjn+eV8eND6pJ7AFi5TIAM7vcGYHsfvtu+dUbcfrA0i0/4JH5Qz1D6BOg== X-Received: by 2002:a17:902:47aa:: with SMTP id r39-v6mr21489162pld.59.1521890356017; Sat, 24 Mar 2018 04:19:16 -0700 (PDT) Received: from seema-Inspiron-15-3567 ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id e2sm18964435pgr.92.2018.03.24.04.19.14 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Mar 2018 04:19:14 -0700 (PDT) Date: Sat, 24 Mar 2018 16:48:20 +0530 From: Arushi Singhal To: dwmw2@infradead.org Subject: [PATCH] mtd: devices: check mtd_device_register() return code Message-ID: <20180324111820.GA1997@seema-Inspiron-15-3567> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180324_041926_914919_42754768 X-CRM114-Status: GOOD ( 13.98 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c01:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arushisinghal19971997[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (arushisinghal19971997[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org stfsm_probe() misses error handling of mtd_device_register(). Signed-off-by: Arushi Singhal --- drivers/mtd/devices/st_spi_fsm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c index 7bc29d7..4a99a6a 100644 --- a/drivers/mtd/devices/st_spi_fsm.c +++ b/drivers/mtd/devices/st_spi_fsm.c @@ -2125,7 +2125,13 @@ static int stfsm_probe(struct platform_device *pdev) (long long)fsm->mtd.size, (long long)(fsm->mtd.size >> 20), fsm->mtd.erasesize, (fsm->mtd.erasesize >> 10)); - return mtd_device_register(&fsm->mtd, NULL, 0); + ret = mtd_device_register(&fsm->mtd, NULL, 0); + if (ret) { + pr_err("Failed to register device\n"); + goto err_clk_unprepare; + } + + return 0; err_clk_unprepare: clk_disable_unprepare(fsm->clk);