From patchwork Fri Apr 21 17:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772086 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uHf1pypr; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32Bk1hJ7z23rW for ; Sat, 22 Apr 2023 03:51:10 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2A67A86371; Fri, 21 Apr 2023 19:50:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="uHf1pypr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EC83C86356; Fri, 21 Apr 2023 19:50:48 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69BAB86359 for ; Fri, 21 Apr 2023 19:50:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2a7a74fa8e6so796621fa.1 for ; Fri, 21 Apr 2023 10:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099445; x=1684691445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9M4VklkPUP9LQAx7j6705xNhGlImo+VZpdlYtgzaSQU=; b=uHf1pyprNluF5TCEI3urUOhwImpYREAcdW+aomyrfDBrOs+RDsg/58U0x9nFSwzv0W Rr1OHC+LQ41yipnZ9/8eOVf+Q2uHV7G6SPgpJbGIZ8QvSCHqjsmy09PWdI+7867bW08u svuApVRkqvcqRK8OrpXrQUMxDr41Ryl0m8q4DXHuQdXNw/wbvEwMEe13q34aqvkQAmEP aSGLsL1foqLPkyAkRge8QI2gewKRBKvJv82kTgucG+XWgjIgwuMIbZf9w8tOZ2Xj0qrB hHHA2qweybQZ4NLm0a1Y+AmMKiMW/GvqTu7Umx0pJVvDcz63ipuXlP0vsrM5/315YH6o Gibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099445; x=1684691445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9M4VklkPUP9LQAx7j6705xNhGlImo+VZpdlYtgzaSQU=; b=EpmfPN3np00QK7xWShTneF7JFrzrNq1WthNoieVkmGH8faAApottq70q2f/GVtSXGM Y/b7PH2oq+J+UphQaQ5ePsFQcNi312HtXGlIN6GgVxSPvQ//UUQu6IeS0UmP4ePvliiA og96Wb3acFLJfHgLBjwJQMGsV5rTQ+cc422NkXfBPbaiiA6yr/DGWEk5iSwR5QHMyOre 0jigeGpd2rVroScGDkZma8AYC1fzOfKKJiOkjjEFiWG0MfAuoopbC1DeqitQ9i5GoEdL eI855MZjzIHBdHVkjOtq0V6IIPZU1fQlUVjpgj3zZyKkKniofU+wUZP5n4O0VdqgcjO1 brEA== X-Gm-Message-State: AAQBX9di7e07DQ1mDnFsNZ4Zz7ekfxxuhndGvQHGKCryyQjuTiTyIJIU dJJGIouClPtG+7h03RMccsMzew== X-Google-Smtp-Source: AKy350ay9GbweQNghLQ9eekAV41nBzyqBG0oExrVS5HxeZR2gONtfIHJajpBDxLje5Sj8eQUqnFP1g== X-Received: by 2002:a2e:6d02:0:b0:2a7:970a:1c1b with SMTP id i2-20020a2e6d02000000b002a7970a1c1bmr1425766ljc.3.1682099445635; Fri, 21 Apr 2023 10:50:45 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:45 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 1/9] misc: add Qualcomm GENI SE QUP device driver Date: Fri, 21 Apr 2023 20:50:33 +0300 Message-Id: <20230421175041.275566-2-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This change adds a Qualcomm GENI SE QUP device driver as a wrapper for actually enabled and used serial devices found on a board. At the moment the driver is pretty simple, its intention is to populate childred devices and provide I/O mem read interface to them as clients, this is needed for GENI UART driver to set up a proper clock divider and provide the actually asked baud rate. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Konrad Dybcio --- drivers/misc/Kconfig | 7 +++++++ drivers/misc/Makefile | 1 + drivers/misc/qcom-geni-se.c | 41 +++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+) create mode 100644 drivers/misc/qcom-geni-se.c diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index b5707a15c504..fc4c893334d3 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -511,6 +511,13 @@ config WINBOND_W83627 legacy UART or other devices in the Winbond Super IO chips on X86 platforms. +config QCOM_GENI_SE + bool "Qualcomm GENI Serial Engine Driver" + depends on ARCH_SNAPDRAGON + help + The driver manages Generic Interface (GENI) firmware based + Qualcomm Technologies, Inc. Universal Peripheral (QUP) Wrapper. + config QFW bool help diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 3b792f2a14ce..52aed096021f 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -60,6 +60,7 @@ obj-$(CONFIG_NUVOTON_NCT6102D) += nuvoton_nct6102d.o obj-$(CONFIG_P2SB) += p2sb-uclass.o obj-$(CONFIG_PCA9551_LED) += pca9551_led.o obj-$(CONFIG_$(SPL_)PWRSEQ) += pwrseq-uclass.o +obj-$(CONFIG_QCOM_GENI_SE) += qcom-geni-se.o ifdef CONFIG_QFW obj-y += qfw.o obj-$(CONFIG_QFW_PIO) += qfw_pio.o diff --git a/drivers/misc/qcom-geni-se.c b/drivers/misc/qcom-geni-se.c new file mode 100644 index 000000000000..281a5ec819a9 --- /dev/null +++ b/drivers/misc/qcom-geni-se.c @@ -0,0 +1,41 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Qualcomm Generic Interface (GENI) Serial Engine (SE) Wrapper + * + * Copyright (C) 2023 Linaro Ltd. + */ + +#include +#include +#include +#include + +static int geni_se_qup_read(struct udevice *dev, int offset, + void *buf, int size) +{ + fdt_addr_t base = dev_read_addr(dev); + + if (size != sizeof(u32)) + return -EINVAL; + + *(u32 *)buf = readl(base + offset); + + return size; +} + +static struct misc_ops geni_se_qup_ops = { + .read = geni_se_qup_read, +}; + +static const struct udevice_id geni_se_qup_ids[] = { + { .compatible = "qcom,geni-se-qup" }, + {} +}; + +U_BOOT_DRIVER(geni_se_qup) = { + .name = "geni_se_qup", + .id = UCLASS_MISC, + .of_match = geni_se_qup_ids, + .ops = &geni_se_qup_ops, + .flags = DM_FLAG_PRE_RELOC, +}; From patchwork Fri Apr 21 17:50:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772087 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LiQNk/z7; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32C058Gdz23rW for ; Sat, 22 Apr 2023 03:51:24 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 336CA863AD; Fri, 21 Apr 2023 19:50:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LiQNk/z7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1D24486390; Fri, 21 Apr 2023 19:50:50 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 84EAB8635F for ; Fri, 21 Apr 2023 19:50:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2a7ffe75ae4so2032081fa.0 for ; Fri, 21 Apr 2023 10:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099447; x=1684691447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LlALwL79O6+cCuRN+rzhCrrYlDj8MP0mBmjzSXa2lhQ=; b=LiQNk/z7py2h6C0WJXUDkBan6+YwBm5GNZqz7kVzZVZbYQLc7vRXAsKVH3Rbi8M3pR j0JWSeaBo61gH9lhDZZb+eXvoRSskiyHpF3I5N2ffpb44XtIoOwp88g5COkbvYEh+6Q7 BwPHgID9jop7DOgaUcVCG0faXCW9u8MknbXxASMpfoQO54iKV5JmTMDxTazYnx/GAq6C c9A9VmvNZoYbNitmSPZXAn9sL2BjbLu8P9kSIOjfnKt6uG2GOK5zQqS6N31msVxz7yq/ RvJU0AcJavAafdquN3h63chPyw5St0lByg2dySPJXgeDrlpYKvSDqH1b1tB+XdfalowL j1+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099447; x=1684691447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LlALwL79O6+cCuRN+rzhCrrYlDj8MP0mBmjzSXa2lhQ=; b=OdRmwIYCpMIinXhD2+LLmaHh01f1cUcnxkPqgbBlt60ZGDQ1DFEA2RWX8TTfSJjpBD VVtHi8n9W8D6pu6iuJSqAz1qlM17CH26VT07ElFNMeS5/Jyaw3+NcqQ3JNR7E2LWQmSE iqBgXg1cg51k40jdkLPswjlcklLAmzfZa+GbDDdHVD1TZ70COmT31q33eFxe6vhPa4jS FvChwl962uQqUH7j1hU0gVbfrnoR+lVM2xdU62cYvmTRm+ZaB5cFmYxrOWNoi0eOnDXP lUtZ7BreUzOj34iDLU36CAYl8MJoQxIl1eGphY0YIaoa8ZDIfo+s2AICk1XYDooDdV7q ewtw== X-Gm-Message-State: AAQBX9dsQqIUW1R+k7yALx1oFktwvYU2HICx1w8zrIhVuLcjg3PuG5Fm LYL20rPzLAkTpasSitRUtCfabA== X-Google-Smtp-Source: AKy350b+S6a/mOgzgU2s0J/DgTAOvA72fEaYh/X6eqL6qd8okaqdSL65ekK4ed/KKNGiyo4F/yB3Sw== X-Received: by 2002:a2e:1f09:0:b0:2a8:c274:b411 with SMTP id f9-20020a2e1f09000000b002a8c274b411mr1367089ljf.1.1682099446887; Fri, 21 Apr 2023 10:50:46 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:46 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 2/9] serial: msm-geni: remove redundant includes Date: Fri, 21 Apr 2023 20:50:34 +0300 Message-Id: <20230421175041.275566-3-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean For whatever reason, likely a driver stub was copied from another driver, the driver contains a bunch of unnecessary and confusing includes like watchdog.h etc., the change reduces the list. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Konrad Dybcio --- drivers/serial/serial_msm_geni.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 3943ca43e49e..df61ae04df0a 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -11,15 +11,9 @@ #include #include #include -#include #include -#include -#include #include -#include #include -#include -#include #define UART_OVERSAMPLING 32 #define STALE_TIMEOUT 160 From patchwork Fri Apr 21 17:50:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772088 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=hStR93lg; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32CF6njPz23rW for ; Sat, 22 Apr 2023 03:51:37 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 06EE9863B6; Fri, 21 Apr 2023 19:50:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="hStR93lg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD33386397; Fri, 21 Apr 2023 19:50:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E840586358 for ; Fri, 21 Apr 2023 19:50:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4edcc712d95so182421e87.1 for ; Fri, 21 Apr 2023 10:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099448; x=1684691448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oXYQyyuR7oVDY7D5Ghpn4whpNeQyOHW+4Hjesqp5URA=; b=hStR93lgU0LJLcle4aGWbXo/L2M1c9WoosOfM/eAhOofxSQRNhj++9qmipWV4xjFHm dM1Fk21TVZJG5GnljC7NwVafwai8u9hl2EPQLa9o1xEvSxgZKZEA8IupYFoCNFNoYCTI NktpY4jAJ8h85yc6bbQYOAlSzNH5JlW5orAaG5Q6DHBXRAcj3h07nRRTj2LzZvZZl+Hm kjRKm4lAePIgXUFpVOHZjXq9ZM3X5chLMUjmm9kjNEsR6FaOYE+wZayisZ2xzc2crtDk RsTRNw/hZ5J+TmJyBDoUSvjfcCSMeRY1jG/L//V7WS6REcvFKI0W6VklptUrXMuRCK1T JfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099448; x=1684691448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oXYQyyuR7oVDY7D5Ghpn4whpNeQyOHW+4Hjesqp5URA=; b=YhsTPbk2DiloGsoP8wAO3ycwwT6CavdZWJrq9Oaif4gJyGyw4DzsJX1PNsY9xGpkxO 7bdHEzJbgiAIJGbhTaYJaSw6/X4xbVqQ5gkXWYhIteeD9+mloGnLb4DWvxQtR/N7ExK8 Qe8qzJjVT4uh+tD7oKgkPx6EONRYZMZKKnMU8zI/WNeVdlOl5VKyjwi93sADpdvBfUfj ogYCEVfrUhj9FdDZycKEulIjxm0r/ChH7Dginm+jbV6IbGmvfXIkiF9byqRtFCT30uSN HJj05qLX+l5JQTBMjH/RPT4JhLB7Vn/WdQuqam6Xw3Xwl5fix4YThe3wK795cEFIgZpF mi7Q== X-Gm-Message-State: AAQBX9dTLPQQ7Avsmyzbe1Fxv233AgyiR7SlOEi+Tf4HzT7vzW9lzrpj HnMzwMHsyFk7YtqlFzIm/Oqvpw== X-Google-Smtp-Source: AKy350Y5QkMsJ+6wTcCvt529UceEQufNcrCzkAvArIQle+i/DoMAXtK5Guzx3WOUjw3SOg8NGjkP3Q== X-Received: by 2002:a19:f617:0:b0:4eb:2b54:5cb5 with SMTP id x23-20020a19f617000000b004eb2b545cb5mr1425586lfe.0.1682099448210; Fri, 21 Apr 2023 10:50:48 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:47 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 3/9] serial: msm-geni: Always bind before relocation Date: Fri, 21 Apr 2023 20:50:35 +0300 Message-Id: <20230421175041.275566-4-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Konrad Dybcio In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. [vzapolskiy: extracted the driver change from a combination with dts changes] Signed-off-by: Konrad Dybcio Signed-off-by: Vladimir Zapolskiy --- drivers/serial/serial_msm_geni.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index df61ae04df0a..146b05748459 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -558,6 +558,7 @@ U_BOOT_DRIVER(serial_msm_geni) = { .priv_auto = sizeof(struct msm_serial_data), .probe = msm_serial_probe, .ops = &msm_serial_ops, + .flags = DM_FLAG_PRE_RELOC, }; #ifdef CONFIG_DEBUG_UART_MSM_GENI From patchwork Fri Apr 21 17:50:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772089 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=v50+bU4S; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32CZ1lF4z23rW for ; Sat, 22 Apr 2023 03:51:54 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1AD11863CF; Fri, 21 Apr 2023 19:51:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="v50+bU4S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6979C86397; Fri, 21 Apr 2023 19:50:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0130B86371 for ; Fri, 21 Apr 2023 19:50:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4eca9c8dd57so296722e87.1 for ; Fri, 21 Apr 2023 10:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099449; x=1684691449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RnmrsCVlgjdwBRf3bAeInT0NkMn0qIZ47/eeLwNO+as=; b=v50+bU4S2VkYMx4j/7noB65Z59soaVY4BgSGca3IJnIswltaRl8jLXJ8zAClHLAGHk 78pIRggXjG7o39SrqHKHMdmYNCWAJrfCPMDWECVooUe0Yt2yAKSyzGl3JFfxDN+P/xGU mv6VTyseVIqcYPIyTG9Ua9eq0p/GFWVVfMN2YiVk82/QT2w/afMW44GAdBWjowCqrS1J LW+W8nZi4Ef0ZZ19+vJlsanjoAvWqRbYMsYQGFAc8HhH4+RHIiul8uUSegMdV5BgmKTp 2BdMPQiA6OTDEQGPkox0qE1ON8xk2+6pZmor3z5cJ/gPMm7Myd6ANm34w5PhAZlHFnBt mlOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099449; x=1684691449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RnmrsCVlgjdwBRf3bAeInT0NkMn0qIZ47/eeLwNO+as=; b=AKnozpEymlTdERd6VP65WLNd9tmHcA9ROcBfBewfDTRlVtPKgjbWOX6/nCkno13psX M1kSxIySY0+IItAQOqxltaWboBv/AaINjaED37YfZP/UfREKR0nTojKqbF5tpOFiOy7L JHPA3ob3c3EBuvyW1ZfPGSpcG0uWKhzx5hGincWOEpiMysgPeiZTyekEaRyutGQ/T/Cd nEdMyKYSCtdGJEYW/UJqRk6yAaZwP6wvi5KeklWH3k52U8LgxT/vEBG8zUaaak8w4bKG ZzJxcaPEP+fXoAhjX9gBqAEcIBnED57SsQ4NuBeRQzRh40sAy28413CoM+Pj8aClwVgY KRzg== X-Gm-Message-State: AAQBX9dK7fo1Add5oLMnCxsCeC3o9RvmRoDBIxQyDFBtQUwf00g9faMD ncXLZpLclvgWYiBC9yMaRgS03g== X-Google-Smtp-Source: AKy350a/k7whcU7/NkI/iwHB7x803ENiPXknXOjmyXwI5uatgRX+VsbEcfmVI1sLB37l7icfJQvoXQ== X-Received: by 2002:a05:651c:1306:b0:2a9:f93c:84cc with SMTP id u6-20020a05651c130600b002a9f93c84ccmr1149816lja.3.1682099449213; Fri, 21 Apr 2023 10:50:49 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:48 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 4/9] serial: msm-geni: remove invalid se-clk clock name Date: Fri, 21 Apr 2023 20:50:36 +0300 Message-Id: <20230421175041.275566-5-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean There is only one clock supplier to the serial IP, thus getting it by name is not needed, also note that "clock-names" property is not listed under doc/device-tree-bindings/serial/msm-geni-serial.txt, and finally "se-clk" clock name is invalid, if added, it shall get "se" value like it's already described in Linux device tree documentation. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Konrad Dybcio --- drivers/serial/serial_msm_geni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 146b05748459..8fd769eb4d0d 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -183,7 +183,7 @@ static int geni_serial_set_clock_rate(struct udevice *dev, u64 rate) struct clk *clk; int ret; - clk = devm_clk_get(dev, "se-clk"); + clk = devm_clk_get(dev, NULL); if (!clk) return -EINVAL; From patchwork Fri Apr 21 17:50:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772090 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=VQ0aJuEz; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32Cp6xx6z23rW for ; Sat, 22 Apr 2023 03:52:06 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 73188863A9; Fri, 21 Apr 2023 19:51:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="VQ0aJuEz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA3F486397; Fri, 21 Apr 2023 19:50:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4487486390 for ; Fri, 21 Apr 2023 19:50:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2a8ac993884so3270521fa.0 for ; Fri, 21 Apr 2023 10:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099450; x=1684691450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pss8X7bgu3LOS8N22uSYRTMb3NQ6H4RT32F84vbK7nY=; b=VQ0aJuEz6HKfB17OcEZINMOb/1/IeT8PfuCDb9cXo5EjLVUf1WvKNLL36rJN6W+3CV AGffpSOysYn/fdstlh+tjrwfYp0fBFBORXWmRv7E0U5yAlAJMHbotrCnKRBPyyxYxrol tiCZkaPd6q4Xqx66Z2ZD63vY7fQ1uB69Pf+w1cthJaZW9tkaI/1IPrbq8v3KYZ84gqjN PHfBElbrL5qaJydLnlTAVR0bnPSR9Vp/qPwRMa6LPuSVotkczxWSd7FBkmqRRnwkIbWQ AwtAtIi/GaEg9PtXsNXq6hSDB6PRntVS1Q8tkSXPzgS5rq6aRtNs/EZu1LKol+N5c0k8 xY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099450; x=1684691450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pss8X7bgu3LOS8N22uSYRTMb3NQ6H4RT32F84vbK7nY=; b=PDyvHUqUDpL2nWL9oa9ts6A3WOD0YSuyvLpCJZq7uS+Vk4V37Mgpsd/bDQIQxY7kCg UQeSz8x+jg4cBskUNJNJzI0dDMl1yScj8+4eQn69PiFg8rGj+DgjtI9QOK0ckFFt2EZa QZjanK04UQeKNbsbCgahjTMtdNrs71ydJ8a5KcQgnHL8gHO9ZreRjpQ6HdPVFS0vxtil to9q+GN4aBeU2X4l768xO2Xzkzg/Acli/TtqvIeUcptTMaGqepNJeeqg7RCEDSBrAjv8 5W5DRn3AeipmLh5mtpiHIMzKivJ3V4kWKEmSx+JgtNV+SF/c3P9BkwseC5O8xQ/ELq6U YXww== X-Gm-Message-State: AAQBX9cywKhQmMEDzLp56suq47VHGj79zy+z6sUp8S+G4KyjIALD2BEY VcRr3GhXlxCUkynpOOGhYPWbDg== X-Google-Smtp-Source: AKy350Ziej2RIj6PsX6Hfzd0iD97EeEtUWjyIhbaUGNcf+RQicU2OdDdgDnATJi0q3X0d28CEsZ17Q== X-Received: by 2002:a2e:1f02:0:b0:2a6:18f4:6c90 with SMTP id f2-20020a2e1f02000000b002a618f46c90mr1452940ljf.0.1682099450422; Fri, 21 Apr 2023 10:50:50 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:49 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 5/9] serial: msm-geni: fix code indentation Date: Fri, 21 Apr 2023 20:50:37 +0300 Message-Id: <20230421175041.275566-6-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This a cosmetic change, which corrects code indentation in a few places. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Konrad Dybcio --- drivers/serial/serial_msm_geni.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 8fd769eb4d0d..55dd9188a56c 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -130,8 +130,8 @@ struct msm_serial_data { }; unsigned long root_freq[] = {7372800, 14745600, 19200000, 29491200, - 32000000, 48000000, 64000000, 80000000, - 96000000, 100000000}; + 32000000, 48000000, 64000000, 80000000, + 96000000, 100000000}; /** * get_clk_cfg() - Get clock rate to apply on clock supplier. @@ -160,8 +160,7 @@ static int get_clk_cfg(unsigned long clk_freq) * * Return: frequency, supported by clock supplier, multiple of clk_freq. */ -static int get_clk_div_rate(u32 baud, - u64 sampling_rate, u32 *clk_div) +static int get_clk_div_rate(u32 baud, u64 sampling_rate, u32 *clk_div) { unsigned long ser_clk; unsigned long desired_clk; @@ -228,7 +227,7 @@ static inline u32 geni_se_get_tx_fifo_width(long base) } static inline void geni_serial_baud(phys_addr_t base_address, u32 clk_div, - int baud) + int baud) { u32 s_clk_cfg = 0; @@ -268,7 +267,7 @@ int msm_serial_setbrg(struct udevice *dev, int baud) * reached. */ static bool qcom_geni_serial_poll_bit(const struct udevice *dev, int offset, - int field, bool set) + int field, bool set) { u32 reg; struct msm_serial_data *priv = dev_get_priv(dev); From patchwork Fri Apr 21 17:50:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772091 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TON/uoB6; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32D23ZhYz23rW for ; Sat, 22 Apr 2023 03:52:18 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B34C863D8; Fri, 21 Apr 2023 19:51:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="TON/uoB6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9614486356; Fri, 21 Apr 2023 19:50:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0439186358 for ; Fri, 21 Apr 2023 19:50:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2a8a4cbe473so883381fa.1 for ; Fri, 21 Apr 2023 10:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099451; x=1684691451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ic9B31eSPuTHLg5dKtybI1SMa/YD3tQdPCS7eX5J8pM=; b=TON/uoB6+6C9PzR9LlR8FlOWIDwRrYQGxqfn7C16ZGYIi8e/JQRZKUWo5t9YB8kz9r L7BhPNDyTw9CqElvYSiLrcY9aI9MbS5OUd9Q90qS+CkL0MIBBe8hp/vpECP8ODIXoar8 0lvyzQQLn1OWngmW2lYa6lb1+hvu0TSijN2cwm/+rs0G4w3ejwSh3B9N2FvJttzA/+hY wYr5aHJKu8DOXSsj4hNUWWOWnGHrNuJlNgZkaaksYiHeKJlPu9Qs2Kuyz/3VG5xrO6Ze gRrGv82uOhdkthgcG7aOXGHnmffP4kRyB0S+usnTZVLn6pAWV8fcbCXem3+gFuJqAJP/ RLFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099451; x=1684691451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ic9B31eSPuTHLg5dKtybI1SMa/YD3tQdPCS7eX5J8pM=; b=RBESztbe1WRVG2kV9ppK3knnIJyOXVnaj3w1kSZbrKV4L0dNqbs46gC36Oz6/p+Syq 3tG+g9BeHdMUs/WaVrD5YfaVpOUXeUIJa67s09uU/8/MPMDWs1Rx5AuZWtRp0419vJan PBsRwhKVF5AG+nbdzHu2bdH0EVsNhg6wYvHv0TUjYkfKq/DsYbt78iqmlf4w49myRe+B z4avHECvxPwSDL1ENRos2ChytrQBdlHfJMO79qUxbuR55jE7aBd9hmRH/DY2ylspuHBT 5a89/DnI3BaXudMETZQkwxm1sFmJLTyTUQwlgswKs5EsTsisTVP/X0Uumw/I+FYc9gwL Mq8A== X-Gm-Message-State: AAQBX9esLFXtOiY5OC3kXV3St6zMJiQzvwc27D0J066eoEhdu4qe27FI /9UNGh869GzlOtRDcSscHVHROw== X-Google-Smtp-Source: AKy350YcludHb8suKyg6lpDrtgJDIjOqJ4YPiShg5R8u1jtNbZqpCy5R6YSqmR6Zi5Pp9/kkqcKfqg== X-Received: by 2002:a2e:2a05:0:b0:2a9:efdb:4188 with SMTP id q5-20020a2e2a05000000b002a9efdb4188mr1331427ljq.3.1682099451698; Fri, 21 Apr 2023 10:50:51 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:51 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 6/9] serial: msm-geni: fix a compile time warning from msm_serial_setbrg() Date: Fri, 21 Apr 2023 20:50:38 +0300 Message-Id: <20230421175041.275566-7-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean A compiler warns about a missing function prototype, which is valid and fixed by converting the function into static one, also fix interleaved local variable declarations and assignments. Signed-off-by: Vladimir Zapolskiy Fixes: 324df15a292e ("serial: qcom: add support for GENI serial driver") Reviewed-by: Konrad Dybcio --- drivers/serial/serial_msm_geni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 55dd9188a56c..3a200f45a6ce 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -238,13 +238,13 @@ static inline void geni_serial_baud(phys_addr_t base_address, u32 clk_div, writel(s_clk_cfg, base_address + GENI_SER_S_CLK_CFG); } -int msm_serial_setbrg(struct udevice *dev, int baud) +static int msm_serial_setbrg(struct udevice *dev, int baud) { struct msm_serial_data *priv = dev_get_priv(dev); + u64 clk_rate; + u32 clk_div; priv->baud = baud; - u32 clk_div; - u64 clk_rate; clk_rate = get_clk_div_rate(baud, UART_OVERSAMPLING, &clk_div); geni_serial_set_clock_rate(dev, clk_rate); From patchwork Fri Apr 21 17:50:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772092 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bNf1TSGu; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32DG1V57z23rW for ; Sat, 22 Apr 2023 03:52:30 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DED1F863D2; Fri, 21 Apr 2023 19:51:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="bNf1TSGu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BE1C863A6; Fri, 21 Apr 2023 19:50:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ABE198639D for ; Fri, 21 Apr 2023 19:50:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4eed7932605so184790e87.0 for ; Fri, 21 Apr 2023 10:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099453; x=1684691453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=clCMELQO5CTC9bl0ZZC/QKbDsRxs5YKUO3QyeP4FEyI=; b=bNf1TSGuMAHH9hb/ngr8FRWvwrdNNs0E8uVoaTYUYM5R/PVjpVpOpf7VdmVDp9D8oH BW5UFMIlbN+KZTdkAFRGaCew/R3ULIn5JshMhRAHx60DTnw/mbc89y7Tlg53QzwMbE6c EraPhrSs6S8iqeowDwQO3Wo33ec36gIODvzkicjbR0Ofn3aNzUjt2mOry37/2aAFHLzD jECw3840X051U8yrMPrHeqcjGx0R1x3fjOh1uvBTgR3oH4CH5+Rl4Lj7er3cP/U4Cwhm mSRrvwWAj/Cjb+ntVJx+Oe236Acc22m5XmNg+A7lSdOjmGun0Iw9uechPw7kCwj4Rt5G Kzvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099453; x=1684691453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clCMELQO5CTC9bl0ZZC/QKbDsRxs5YKUO3QyeP4FEyI=; b=Gq9+FeJMKaLxF+PzQmPOOCU2Mxwe9rPFpv6FYXJTB1H8GbR8R7I4RHkQybUFHvxtfp ZidOMDm2O9K+U30t9cePQaNepysc9TUZ8FBt3ZgDqzOTaz1rx4ZDT8fsrFM454BOYjb3 pvwDfawxpFpRRkxf9JchjwdsyprJiPknrqUGBTMa92OTr/kM+wbR4+LXdeKOtAy1ekHm lQcsxgRB8048glNrnv7/hq3zrxyQnhRQ9djTnyY6vr4B5Kd2r898Pv/1OOAgeHPXXD5I x98iyZJXGH1OBUPWSP01MtccKHxOLtXnwRmhrSqwbLD6dPfik5Qg+PsMTocdbeaot6By +Ltg== X-Gm-Message-State: AAQBX9cnObEPm4ti5cjBUOx+MgAyhqIG9d9iCJ2PvVTnngzVVf+IowgE zTSwUiBRvgpC4nwLgolE+kYbTA== X-Google-Smtp-Source: AKy350a+O+slU7hxqYviwJWus+ErxUtqKIiVkoaoDdzZk/TaoNIZdgTvk2F73hNF6f126HwgrzUxEg== X-Received: by 2002:a2e:2205:0:b0:2a8:cfa9:a2b7 with SMTP id i5-20020a2e2205000000b002a8cfa9a2b7mr1363420lji.1.1682099452879; Fri, 21 Apr 2023 10:50:52 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:52 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 7/9] serial: msm-geni: Use upstream Linux bindings Date: Fri, 21 Apr 2023 20:50:39 +0300 Message-Id: <20230421175041.275566-8-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Konrad Dybcio The name "se" is used in upstream Linux device trees and has been for ages, long before this U-Boot-ism was introduced. Same goes for the existing compatible. Get rid of that. [vzapolskiy: removed a ready change in the driver] Signed-off-by: Konrad Dybcio Signed-off-by: Vladimir Zapolskiy --- arch/arm/dts/sdm845.dtsi | 4 ++-- doc/device-tree-bindings/serial/msm-geni-serial.txt | 2 +- drivers/serial/serial_msm_geni.c | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/dts/sdm845.dtsi b/arch/arm/dts/sdm845.dtsi index 607af277f8be..92bdc82177d6 100644 --- a/arch/arm/dts/sdm845.dtsi +++ b/arch/arm/dts/sdm845.dtsi @@ -52,10 +52,10 @@ }; debug_uart: serial@a84000 { - compatible = "qcom,msm-geni-uart"; + compatible = "qcom,geni-debug-uart"; reg = <0xa84000 0x4000>; reg-names = "se_phys"; - clock-names = "se-clk"; + clock-names = "se"; clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>; pinctrl-names = "default"; pinctrl-0 = <&qup_uart9>; diff --git a/doc/device-tree-bindings/serial/msm-geni-serial.txt b/doc/device-tree-bindings/serial/msm-geni-serial.txt index 9eadc2561b4b..eaa39c949b10 100644 --- a/doc/device-tree-bindings/serial/msm-geni-serial.txt +++ b/doc/device-tree-bindings/serial/msm-geni-serial.txt @@ -1,6 +1,6 @@ Qualcomm GENI UART Required properties: -- compatible: must be "qcom,msm-geni-uart" +- compatible: must be "qcom,geni-debug-uart" - reg: start address and size of the registers - clock: interface clock (must accept baudrate as a frequency) diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 3a200f45a6ce..29fae810d6fe 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -547,7 +547,9 @@ static int msm_serial_ofdata_to_platdata(struct udevice *dev) } static const struct udevice_id msm_serial_ids[] = { - {.compatible = "qcom,msm-geni-uart"}, {}}; + { .compatible = "qcom,geni-debug-uart" }, + { } +}; U_BOOT_DRIVER(serial_msm_geni) = { .name = "serial_msm_geni", From patchwork Fri Apr 21 17:50:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772093 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=p+uhXXen; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32DV5kBtz23rW for ; Sat, 22 Apr 2023 03:52:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B734D863D7; Fri, 21 Apr 2023 19:51:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="p+uhXXen"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0DD87863B3; Fri, 21 Apr 2023 19:50:58 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0800486358 for ; Fri, 21 Apr 2023 19:50:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2a8dc09e884so3255751fa.1 for ; Fri, 21 Apr 2023 10:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099454; x=1684691454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c0OdR0wxOR1/QZ9nd1Yf9IBSGbGWHouODsr4StWTM8o=; b=p+uhXXen7c1fZhcYABpk/xtBZhoe9dd3b7T1ebnSnj/Znq1SCqTnpbnXe7OQmvsTxO 2mXGoZXWs4ZmkSNhtauKSzCyUx7o5gvMwwoBrodd8GaohdhXiDgcc5+fujGTChxOLBAL UCpl7P1W9o4gxQfI7w1L1/KvNS1PgMa+/ybUrv0Hea7qIQ90J62pQkHerJomIQzpuIoF IgKf4cdqcJwIQQob/UPt+pQbX32cmf3SHrol1fu0Pzc8TktiJc9KCjoB0D3hQ1NabhOb njRTcKlXR1KluVH+H9LQ5GwQoFIzd/Id528ee8G1SskK0U8nShz0bvrL6FQqoLCChdwu SkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099454; x=1684691454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c0OdR0wxOR1/QZ9nd1Yf9IBSGbGWHouODsr4StWTM8o=; b=F4SaXYzAcjitOrRQFrPfbcMas8sDpCKbXAtIKhb8XrFzJrvo7B1p0GH8hLClYpr7p8 XS8C6ny7ul1Fs8p8RQ30ZKj3TZ+an+rcDqhevPFcu/6pwKeWfX2RWCGhQ9pp2J5q/7ZK 53fv4GOKqj89nZ/XFhGdG/J+Rvnmw9MOrOu9vWd63QCHLYGmloAyraCB9XdLmuVqXw88 plat3RA0P1xjiBd73k6NNx7cv2/QWr51G2DSRyyssQBy3EU/GgLKUD/zRKQNmEc2eXAK Z4I6VuHtOKrHy+eRG+sSZKHxvJHdxG9SNFcvpjUw7mo7fLrjYGfZrHkVAtn8SYQeLSzN ZYWw== X-Gm-Message-State: AAQBX9e3iF0JtQaoxp4fckHeeQm1QdQzvpQ0uU+Zn6n3wkSNy8AhSHog ZDNb1dfbkFUnksaZlpslGgQHig== X-Google-Smtp-Source: AKy350aOGmEyb2HsWai7Y3fY1ctAc2UMJNicluBjpdG9ET6xdwF/Rl6PxHDsk/zgNabuaNjPsGWc5w== X-Received: by 2002:a2e:2a01:0:b0:2a9:f4e9:1a3d with SMTP id q1-20020a2e2a01000000b002a9f4e91a3dmr1466539ljq.2.1682099454058; Fri, 21 Apr 2023 10:50:54 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:53 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 8/9] serial: msm-geni: correct oversampling value based on QUP hardware revision Date: Fri, 21 Apr 2023 20:50:40 +0300 Message-Id: <20230421175041.275566-9-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Starting from QUP v2.5 the value of oversampling is changed from 32 to 16, keeping the old value on newer platforms results on wrong set UART IP clock divider, thus the asked baudrate does not correspond to the actually set with all the consequencies for a user. The change links the driver to a new Qualcomm GENI SE QUP driver to get its hardware version and update the oversampling value. Deliberately the code under CONFIG_DEBUG_UART_MSM_GENI is not touched, since a wanted baudrate can be controlled by setting a modified CONFIG_DEBUG_UART_CLOCK build time variable. Signed-off-by: Vladimir Zapolskiy --- drivers/serial/Kconfig | 2 ++ drivers/serial/serial_msm_geni.c | 35 +++++++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index bb5083201b38..d50a1fd3f382 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -938,6 +938,8 @@ config MSM_SERIAL config MSM_GENI_SERIAL bool "Qualcomm on-chip GENI UART" + select MISC + imply QCOM_GENI_SE help Support UART based on Generic Interface (GENI) Serial Engine (SE), used on Qualcomm Snapdragon SoCs. Should support all qualcomm SOCs diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c index 29fae810d6fe..78fd9389c036 100644 --- a/drivers/serial/serial_msm_geni.c +++ b/drivers/serial/serial_msm_geni.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #define UART_OVERSAMPLING 32 @@ -110,6 +111,10 @@ #define TX_FIFO_DEPTH_MSK (GENMASK(21, 16)) #define TX_FIFO_DEPTH_SHFT 16 +/* GENI SE QUP Registers */ +#define QUP_HW_VER_REG 0x4 +#define QUP_SE_VERSION_2_5 0x20050000 + /* * Predefined packing configuration of the serial engine (CFG0, CFG1 regs) * for uart mode. @@ -127,6 +132,7 @@ DECLARE_GLOBAL_DATA_PTR; struct msm_serial_data { phys_addr_t base; u32 baud; + u32 oversampling; }; unsigned long root_freq[] = {7372800, 14745600, 19200000, 29491200, @@ -246,7 +252,7 @@ static int msm_serial_setbrg(struct udevice *dev, int baud) priv->baud = baud; - clk_rate = get_clk_div_rate(baud, UART_OVERSAMPLING, &clk_div); + clk_rate = get_clk_div_rate(baud, priv->oversampling, &clk_div); geni_serial_set_clock_rate(dev, clk_rate); geni_serial_baud(priv->base, clk_div, baud); @@ -480,6 +486,31 @@ static const struct dm_serial_ops msm_serial_ops = { .setbrg = msm_serial_setbrg, }; +static void geni_set_oversampling(struct udevice *dev) +{ + struct msm_serial_data *priv = dev_get_priv(dev); + struct udevice *parent_dev = dev_get_parent(dev); + u32 geni_se_version; + int ret; + + priv->oversampling = UART_OVERSAMPLING; + + /* + * It could happen that GENI SE IP is missing in the board's device + * tree or GENI UART node is a direct child of SoC device tree node. + */ + if (device_get_uclass_id(parent_dev) != UCLASS_MISC) + return; + + ret = misc_read(parent_dev, QUP_HW_VER_REG, + &geni_se_version, sizeof(geni_se_version)); + if (ret != sizeof(geni_se_version)) + return; + + if (geni_se_version >= QUP_SE_VERSION_2_5) + priv->oversampling /= 2; +} + static inline void geni_serial_init(struct udevice *dev) { struct msm_serial_data *priv = dev_get_priv(dev); @@ -523,6 +554,8 @@ static int msm_serial_probe(struct udevice *dev) { struct msm_serial_data *priv = dev_get_priv(dev); + geni_set_oversampling(dev); + /* No need to reinitialize the UART after relocation */ if (gd->flags & GD_FLG_RELOC) return 0; From patchwork Fri Apr 21 17:50:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 1772094 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LNrUAln/; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q32Dl4vv4z23rW for ; Sat, 22 Apr 2023 03:52:55 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B34D6863DF; Fri, 21 Apr 2023 19:51:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LNrUAln/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5994186358; Fri, 21 Apr 2023 19:50:58 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1A4A863A4 for ; Fri, 21 Apr 2023 19:50:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.zapolskiy@linaro.org Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2a7ffe75ae4so2032271fa.0 for ; Fri, 21 Apr 2023 10:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682099455; x=1684691455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wup+CBY6u7TSY4TeWQWa9so56VwP6kLw4QvYwq6be98=; b=LNrUAln/iv2eiq4SjgLry4+EgTGHJwW1lrkyD+Df9O0Rkik7BuIhQWtnmvoMfv7QzU SgwPTgVADrrEB8lvJonAKXV6Xo8H5fGfaomwjWy9SFa/bSprotYTvPf1TTdOfOuSU5jA bMB37I5/0zisxPIwvDK40KrVJK8fHu7rDqHTWR6WpynfAsjovvVkAOnTP7FVDs4Xbv5H RISo2dDEcSC5r79l+9SFwWolGOAiQOimOaphjYjnUFX/wQ+bcumvQkSUElr8DHMH1mph Rf5NVinHe3I1l+CHoveXmfIQiTbMnx59dDN7g8D4dyfuoY3hTONV2poXzvAfEJupYBG2 OyBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682099455; x=1684691455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wup+CBY6u7TSY4TeWQWa9so56VwP6kLw4QvYwq6be98=; b=OLiUeLKGgnHBfsI/jRLsLFA+5bfsWW4JwLM86pd74BZeurGAuuUBbImOCvSOeFACGb Vc/gcCpMDiquNO0jbgGApn1GD146/QCipItbdESNoti0w4D23YYgIs2sq0Pxeqag8jfx Ott+W29s7DDl2mF5eygI15owVBsxKCacr/C1YeVxJ1GdFUmoWPVQrrNH/oNkWvd6yNr6 Dp+y5E9NCqt/llgbNudhz1+9dHEiDRZ6H+HpBAv6uFgtctJbsJY57CscZwaxpZBVaVcl vLJPZkT4sxD7pb7AhYNiauojU+dNcKnKHJeXki+KZJZaAszYc4Nq/D77prgC6WLFTZzW JTWw== X-Gm-Message-State: AAQBX9eDnegef8F+cOF4Sd3fFEVdu7KRpEr04iwXRpS77Vy4F4W/XCTh 476xMXuONizlI6sts96W4dJaRg== X-Google-Smtp-Source: AKy350Yqtn5mzCoKOmNsypxAHPf8315LRjBVAt1ITY0EK8LX4abZp2iC1as2glCR0pB6bx1nevl4BA== X-Received: by 2002:a2e:6d12:0:b0:2a6:142e:ee70 with SMTP id i18-20020a2e6d12000000b002a6142eee70mr1436173ljc.4.1682099455419; Fri, 21 Apr 2023 10:50:55 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7aa25c3b6sm674256ljj.88.2023.04.21.10.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 10:50:54 -0700 (PDT) From: Vladimir Zapolskiy To: Tom Rini , Simon Glass , Ramon Fried , Dzmitry Sankouski Cc: Konrad Dybcio , Bhupesh Sharma , u-boot@lists.denx.de Subject: [PATCH v3 9/9] arm: dts: msm: add GENI SE QUP device tree node Date: Fri, 21 Apr 2023 20:50:41 +0300 Message-Id: <20230421175041.275566-10-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> References: <20230421175041.275566-1-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On modern Qualcomm platforms including SDM845 a GENI SE QUP IP description is supposed to be found in board device tree nodes, the version of the IP is used by the GENI UART driver to properly set an oversampling divider value, which impacts UART baudrate. The change touches dragonboard845c and starqltechn board device tree source files, a device tree node label to "debug" UART is renamed to 'uart9' according to the naming found in Linux. Signed-off-by: Vladimir Zapolskiy --- arch/arm/dts/dragonboard845c.dts | 2 +- arch/arm/dts/sdm845.dtsi | 25 +++++++++++++++---------- arch/arm/dts/starqltechn.dts | 2 +- 3 files changed, 17 insertions(+), 12 deletions(-) diff --git a/arch/arm/dts/dragonboard845c.dts b/arch/arm/dts/dragonboard845c.dts index 1722dce33ff2..b4f057ac6537 100644 --- a/arch/arm/dts/dragonboard845c.dts +++ b/arch/arm/dts/dragonboard845c.dts @@ -21,7 +21,7 @@ }; aliases { - serial0 = &debug_uart; + serial0 = &uart9; }; memory { diff --git a/arch/arm/dts/sdm845.dtsi b/arch/arm/dts/sdm845.dtsi index 92bdc82177d6..3b86b9328fc6 100644 --- a/arch/arm/dts/sdm845.dtsi +++ b/arch/arm/dts/sdm845.dtsi @@ -51,16 +51,21 @@ }; }; - debug_uart: serial@a84000 { - compatible = "qcom,geni-debug-uart"; - reg = <0xa84000 0x4000>; - reg-names = "se_phys"; - clock-names = "se"; - clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>; - pinctrl-names = "default"; - pinctrl-0 = <&qup_uart9>; - qcom,wrapper-core = <0x8a>; - status = "disabled"; + qupv3_id_1: geniqup@ac0000 { + compatible = "qcom,geni-se-qup"; + reg = <0x00ac0000 0x6000>; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + uart9: serial@a84000 { + compatible = "qcom,geni-debug-uart"; + reg = <0xa84000 0x4000>; + clock-names = "se"; + clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&qup_uart9>; + }; }; spmi@c440000 { diff --git a/arch/arm/dts/starqltechn.dts b/arch/arm/dts/starqltechn.dts index 34a4f59cbd17..dcbc3b6d4966 100644 --- a/arch/arm/dts/starqltechn.dts +++ b/arch/arm/dts/starqltechn.dts @@ -21,7 +21,7 @@ }; aliases { - serial0 = &debug_uart; + serial0 = &uart9; }; memory {