From patchwork Wed Mar 21 17:32:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagdish Gediya X-Patchwork-Id: 888563 X-Patchwork-Delegate: yorksun@freescale.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Zo2ggLcx"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405dY90MtZz9s0m for ; Wed, 21 Mar 2018 16:25:16 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 938BBC21C50; Wed, 21 Mar 2018 05:24:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=BAD_ENC_HEADER, DATE_IN_FUTURE_12_24, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1EBEBC21DB6; Wed, 21 Mar 2018 05:24:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id DD6D3C21D56; Wed, 21 Mar 2018 05:24:23 +0000 (UTC) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0080.outbound.protection.outlook.com [104.47.1.80]) by lists.denx.de (Postfix) with ESMTPS id 80FD9C21C29 for ; Wed, 21 Mar 2018 05:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kfKfDBAA5f6wDqMspg7JJdkFqSm2jVoOBmG7GXxzCtM=; b=Zo2ggLcxUncXYTjK+ZsXXWSnR1Ph8jR33QK2JkYmkeNO+9b0uRYmMTtVOBpOZfbT4IjjImF33v2TS/TmEn0UBWTWJCdfNbN+6e/bwCEwr5zhSvp0j0fkjQgEim8tFp4BH1XI02AnlNzLIyqrolyricrQP3zxnHI22MRSRNVGvWU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jagdish.gediya@nxp.com; Received: from lab_pc.ap.freescale.net (14.142.187.166) by AM5PR0402MB2770.eurprd04.prod.outlook.com (2603:10a6:203:98::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.14; Wed, 21 Mar 2018 05:24:21 +0000 From: Jagdish Gediya To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 23:02:45 +0530 Message-Id: <1521653565-30864-2-git-send-email-jagdish.gediya@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521653565-30864-1-git-send-email-jagdish.gediya@nxp.com> References: <1521653565-30864-1-git-send-email-jagdish.gediya@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: MAXPR0101CA0046.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::32) To AM5PR0402MB2770.eurprd04.prod.outlook.com (2603:10a6:203:98::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 91a0723e-7d56-42e9-c830-08d58eec0110 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0402MB2770; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0402MB2770; 3:7avLGDPgsaXihCUbW612+/6O4b7YpCLz7SXP6CTGSou9jL7PSdkbF1hor0EMQwUPoBInhV7ABYsm4ylad6aWkfeMut6d4iHQjNGubMfE/S8ECkIBBGNnnpd24opLpL5zyII8RwukfLUEL//jZsKbGAeXUqGQyfZ6aPQW6B4JJ1/+e49qzBocV7qFeTEP3512E+IbVY6UeSbV8ht9gMmjR1iyQSn4UBRXkk7jVYQzu5o2E7RJ4bllrlFatE6EiJF8; 25:mrPad2MOza0wnJkdb6BX5qAEQnepOd7iXxvksgWRljy9CmRMw/3aKE8NPyUok1/RLelJ/5CSzy5FVX1PbCRWN840wPglW0csG7EeSQAu4GTzwwK/XUmxB1h3yUfDgA1rC989ODYeUFGjccSoVQk36dhl7OH3Jhm9Jripj5vOXrB4+M2cz3x6cXL1Oyo0nZQmylyqpSc8AJX2yeSxumfI3MIq4DjqRHViGQJRWBQM9nbBWGkZG2Dq1ds5bZG5jGaLPqzEEGJhiBhvJPR/TMUTtzCOumYkeyYTmQ5l//IUzg0JnR9CB2Pzf5WrDSEHYnC/Yj+JUIVeRTIe2oyvueHmzQ==; 31:ymTLZ4dQPqmBHmygqS0uhGVuVeYRgS/84QTRra/GMGXNunyxiW+2P/PNBL1UMj6jFlTuS31F9i0U2X6d8+UhSZSStRh1vKhVgb9v35gx1lNaV/CUQCVnceVycfSZoa8FVQ9zbkH0fg9s0duDDcRxjk8+6XcBkDQaX7hAbrF5yGEmrhwr5X4uSRSuNJCGaIcBtO6k8+324snotJUAhc2J7S39JILObOMLXD2G8XXg6xs= X-MS-TrafficTypeDiagnostic: AM5PR0402MB2770: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0402MB2770; 20:j+QlkmTtaGEXjsV8OAz5yr7CncsL92z9jzqazcnGedbNau8qq6KptJSwVIRp5+cTajM0JAKeVtJ4Lo2z/bp2sIbzRqMlUBPpSTwdBsu2+Xke51KysskV+UlnlV1RkbUCKmdF8akHu6n9jSux56FvI3JKmL5vC3KxNGyK3lagCPET2SehlBzJSlsC8GOjdkob4TsruAKANxPtzU1wK4VLHIEzuF5vuchjrfFqjbKLUfqvMMAO0i8dgXcgwl3+GK9iZgKvGzKs3wHRSionnzj7jAO4lm2c0BCoFw/KfAddXhu7+/CsaX8Wu9vrwHsHiSyXHktWWkcX8e8EMRLi0X5yjQlcJZnmj7NC7syrQ1pssPXXv12GSCLFVmcJZipg7cMxIA8oHUf/YklvI1zVcUA2Iv9U0/WZxjGfcF+1oRESQht0KMOvn8Jg3XRAL0Ktt/iiw38xZnpVJNrVu6ei7jxyMV4n7hglB05Day6321CMG8hdAqB78biQl336eWvKTajR; 4:5Q+qgezAWX6DbSzr8ZOdM9QJ/g2twbltuIk8OUWK9WwsGSZRC6W/rRIEOK9LbatLUCNS653n1BdW0YiXvfWGCeA1OX/fIaPn7bf6SB644wPt+a0aADIrQiiem7EnnJFqtvkHVQMXDRGgJSqhaptG2LNleUyoI5HcZ07nfxWhZXQ0Y6UC7P8ra3YyUgk/GTItEybLK409EzvW+FjONDmONRnW4iTuoNQ9nTaaK18sVp1YGZJlP+yniu0pVjYDpyuEedKmWIzvh5Bb9dFfleM0HvIK6h8I0dAPpSNrut0IOADznombUDoYxDUBL9+1yAmH35PDDwIDbnjtlB3HtVCzENQfDzQ260EN3Bu+Irb8Qxo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501319)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM5PR0402MB2770; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0402MB2770; X-Forefront-PRVS: 0618E4E7E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(346002)(396003)(366004)(39860400002)(189003)(199004)(316002)(2950100002)(8936002)(68736007)(86362001)(6506007)(386003)(52116002)(6512007)(48376002)(50226002)(81156014)(6486002)(16586007)(76176011)(55236004)(8676002)(53936002)(16526019)(4326008)(50466002)(478600001)(66066001)(5009440100003)(26005)(186003)(105586002)(81166006)(106356001)(7736002)(3846002)(6116002)(25786009)(47776003)(97736004)(36756003)(305945005)(5660300001)(1857600001)(2361001)(6916009)(2906002)(2351001)(51416003)(6666003)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0402MB2770; H:lab_pc.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0402MB2770; 23:ubumKDS0E1pxpGAi6JZZAXEEgaK6XXz4MRiFGgh?= ychzMYMDy9Vi4C7EkrUTqs283L9PwQM8TRwxpIVr2SVro1RHDWhSJdye9DfkjnmgFEDehEY7CT+odqtF1knaU5/CD98ghakp2EI8MrpM4rkGaVnjzdA4PO/mQts/q8LkpHtXKRj45KXmNG/CxVh5CuHW9T8KVyVp5bw2LO0wB1tbU6kWphHv+MvdXjp5IWQENAzBoQbNsqaypxoMRuE1un9jeP9mZkqDtjnQwIT7tW1x1Du6+e90IYutHwCVjxpSbLGAKnN+Bk4P2gjpeb18aHCth4beYM72SjHEyETuBoPeN4NGDz7laFYwQBbg8r/GT3//CvP2EVz+smFenHfMsSBiFebkumw/+mh/pJN+NQRpBTgnkTaHZgVETUqjaksRIVBH29cBDVxTwcCaQCfeEdTFxettsuLGLsFhE35x5v7PU8KKdIfpUemfxHJ+E0dMZwvRzbXI+hco5P9k2zH0/C+erL5UciH8gpsCLJcwQoMMhqVWvUUsLwxuvEYQ/vQhcPxK/zDyotQTSm+WGwIv0XtuO1Bpa/TWSoa/Vo7bo8W29cH5UN8tZDdHtwixOKVaWt9F2/hrkYm8d2jdk5Huu2fVIvyGlVNFhiSD/+5A1BYifOfbkdyd5GaN2TFBPgNx0M7psHytMCjl0sUQcMlSvFi877OOoAeVaxnbduzBJD2aUcUFSEby71qtRD4FBYF+1SIkJv1FYU7WAwtkzmMkBrdIxi/aP17Ki+kCQC7m1ZxnXszk7TzouQ2G/Mz9HXzT87h8KZQPdH/VSJp7Ne/tNCYMIKSaZjchpv9MOjDLzzEXx1nZnszPRY2S68fTXs2dsRXj1jX490vxrjz3DhKxD3azIdEzEkStdulSa4sQxAY3CKXpe46cuTXpn9omTxG7+3WLPCYDxgRTBoHGk5AFOM+JgeLztU4GVUrwCEWbmmRQELAqZNg37MGheT5xMry6tfDgWK2OyMXawaYqb8dYqfPr/7rotH6kADK2k3vzb+KW67LeGMpnrMv2gzqKO2lpqIhuKmL2C3LfLbBd3vajEFzF0JZfQtbizah5fh2/o5HXvWQ8/QsQGvY9ed9yHK575KmcVY1r/yQqBZiVcmpfxQbGtFR6HA0ZYMa/iehCuhLMG6OSxhal979C8aZMVR34yBghXyocXWj4oUmJirSRq5oebcyW9dQS3KlQaOex++kTzEi7av6Iu0zx3wfox20/sdgE= X-Microsoft-Antispam-Message-Info: oPniLqWUcrbaliUOlTrSFCQMs38wDzIHuI+eKP3TFv2tkgrvl4wfz7mk7JcC45pTeKB3veFBmRNmzE6VtfzwC517WRGGagHyF2Nucq7AQQ1E/uPbGLrRxnfLn7Ip5+gKoJjCxpxCoVTwt2mZyvpjVnat1ng9n5ib1vKGrIEZ8OHZfVJFqIpHiNvAXIECd6zG X-Microsoft-Exchange-Diagnostics: 1; AM5PR0402MB2770; 6:SAgLfo9NLPdZJqdZpNb3xI5oUeTQDfNVybVKDwxM+1OIjAAxJL2LLs4lAaD1tSzXh2YvBGyYqynKvnC3KzwLt2hFCdufxIsyhPkX68kKm64dXOQO7QcbHzThF3YSxRSR9UT4NZDrqZjs0OQEQlQ8gs7i6vu4OY2zX3VRlnBI+z89uylIicKu7jFkSF/pZt/JZ+2LO4M5w6Gwp+cwcIRLKO6L/j9L8ywxRtU3P7M/LSfBDd5pjZzZ36Krv17OtWkEjb00BMHLoVlT8EljQs/G4nUNpAPo1PD1ee3mWefDBw2HAMYWf2sy3ayrQ45WEoCFJyO6wXxEWSjQBpw2ggiGubwjUO5yufGcu/tZ6HIOJQs=; 5:eRUo+yy8ZutkEZSTobF69ATdvuFHrUYjHoLr5c1oFtWbPsjRE+AJ3pJ+tUTaai8WkgGjTqjinEIa9zYZJPkBfl8Xxhgnaqc3ngmmShmp7albIIqiN8r4KX3+A+aYBxIxMHQx1rCpocFrviYMTjcDE4X3OmfUeYxAHs6ulUz5RQ0=; 24:Dg+m8b+AForL4MxgvUfrmFj+xE4tRn6EzRkhUXwvhnwugw/zJADSWNfB8jFG2UFUO1IScrzhTExH8lIEdBCZhjMam11/54su0uXoYWv841M=; 7:OthKXOoWPGSNrbgEBXKHYnADTTO4mvCYH8O3+IeRq7I5jexV+G9+KhXda/mN4kmWxdYaJzoK+Ud+OM76as+ZrPkD3hwHPiMj0s+AC5RdoIIOT58RU5JhBN3RrCD+XLl62pGU2PcXGv3QigXM3wvqXqRp51WofLi1bt5AWLMQ2FuKjdkiqvOlZ+knkgY0wI7q4EeYmw52hiin0hITAE6r9xEU5Ef2NRKzPYFl0gyPuyj8VZkwOZ3r4KhSugufRDbZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2018 05:24:21.0755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91a0723e-7d56-42e9-c830-08d58eec0110 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2770 Cc: oss@buserror.net Subject: [U-Boot] [PATCH][v2] mtd: nand: fsl_ifc: Fix nand waitfunc return value X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As per the IFC hardware manual, Most significant 2 bytes in nand_fsr register are the outcome of NAND READ STATUS command. So status value need to be shifted and aligned as per the nand framework requirement. Signed-off-by: Jagdish Gediya Reviewed-by: Prabhakar Kushwaha --- Changes for v2: - Change the waitfunc return value according to semantic enforced by framework. drivers/mtd/nand/fsl_ifc_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c index 6eb44c3..7f487e7 100644 --- a/drivers/mtd/nand/fsl_ifc_nand.c +++ b/drivers/mtd/nand/fsl_ifc_nand.c @@ -701,6 +701,7 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip) struct fsl_ifc_ctrl *ctrl = priv->ctrl; struct fsl_ifc_runtime *ifc = ctrl->regs.rregs; u32 nand_fsr; + int status; if (ctrl->status != IFC_NAND_EVTER_STAT_OPC) return NAND_STATUS_FAIL; @@ -721,10 +722,10 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip) return NAND_STATUS_FAIL; nand_fsr = ifc_in32(&ifc->ifc_nand.nand_fsr); + status = nand_fsr >> 24; /* Chip sometimes reporting write protect even when it's not */ - nand_fsr = nand_fsr | NAND_STATUS_WP; - return nand_fsr; + return status | NAND_STATUS_WP; } static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,