From patchwork Sat Apr 1 16:18:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764081 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HecmP88C; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8905Gtz1yZH for ; Sun, 2 Apr 2023 02:21:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OmzA7krTcLMoYjd3SrlHSdZNUXTuGqJcqM4ALouZckY=; b=HecmP88CrKqp4N I3TcBwVyz1segUd3kgkDgQfJPCTsM/xULO/ZOjwDV3vqZOvcW+pdEIWLPhcXAgg6tUN5BgiK7USYh SXBFV5Mw+wyxexN6Z/kk3QPOIZ2ut1FuTcy2POupCnUIGm6KC7AC+JmsdvnIbF496Hgm1GnPWuexK SWK7N7zitFtWjSnulbSeRDqmS/qeK8+jc9yQtnmya8mXQ97/QTHuWH5hhvedg7j6JVJ13tZzAkgtU xvvJzs0RszgJUHqjb1Sll3PRUMB8XZeqjUL0275FuJNCnLbd1dCL9HocdmsY/R8XHMGWQ87tuAOCG x9j+ydFPZ6gBB45ktZiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxl-00AsLx-1l; Sat, 01 Apr 2023 16:20:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As8t-0S for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxE-00089E-Uj; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxD-008GPa-2l; Sat, 01 Apr 2023 18:19:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxC-009kfA-EH; Sat, 01 Apr 2023 18:19:46 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/49] mtd: nand: mxic-ecc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:50 +0200 Message-Id: <20230401161938.2503204-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1617; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=NGvYn0k/gn9DbRBQZa8+JZhOJBeUk/AzPgAnpYjZcME=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNiI8r2NvZel6pqcv3ifSsPhW8kMdp8/V6IakTs2uLr 07X3P6pk9GYhYGRi0FWTJHFvnFNplWVXGTn2n+XYQaxMoFMYeDiFICJHBBl/58gx6m5VHx7d12D SMTqQmnT/OCzE/5mVB3N4re/uOb+tt3+xnvYg7fsOeXEJthyqdt9RqrXE6ZzrU8vGLDoKAcpefL FLwxN3S2/8c+0/Z7rbdfdZLLy+fS/IMZNm2Hf0eeXszQYBfh0dvRN3v/3767OqUGTbh1g+HIvyC 4v6MCG/Kt33ydzOS108fxru/XHmfnW7qa7WU1yzvvxyIrKWdmEzzdPuD5nkkyjitzLrusxu+c0z mZoS5+0WUWxm2H9yp5HvHbCr4sqH+6eJO1wV2NNmL/cD67Tggtm8PI57bDO8pSJ+Ma2+Nf0S3It N/fwiTVZyieG/XcI9rMsmzjFsYyjnbGriiWj8bSQoScrAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_198170_1FA61524 X-CRM114-Status: GOOD ( 15.85 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/ecc-mxic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/ecc-mxic.c b/drivers/mtd/nand/ecc-mxic.c index 8afdca731b87..915aadd1a170 100644 --- a/drivers/mtd/nand/ecc-mxic.c +++ b/drivers/mtd/nand/ecc-mxic.c @@ -847,13 +847,11 @@ static int mxic_ecc_probe(struct platform_device *pdev) return 0; } -static int mxic_ecc_remove(struct platform_device *pdev) +static void mxic_ecc_remove(struct platform_device *pdev) { struct mxic_ecc_engine *mxic = platform_get_drvdata(pdev); nand_ecc_unregister_on_host_hw_engine(&mxic->external_engine); - - return 0; } static const struct of_device_id mxic_ecc_of_ids[] = { @@ -870,7 +868,7 @@ static struct platform_driver mxic_ecc_driver = { .of_match_table = mxic_ecc_of_ids, }, .probe = mxic_ecc_probe, - .remove = mxic_ecc_remove, + .remove_new = mxic_ecc_remove, }; module_platform_driver(mxic_ecc_driver); From patchwork Sat Apr 1 16:18:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764132 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=t4pvO19j; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppkl12gLKz1yZH for ; Sun, 2 Apr 2023 03:33:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Tlic0Ovg4jSMHWvTTyBuzRiiQ6o3xcGSLfwyYadEUA=; b=t4pvO19jROpNK3 8RFhJGn0BxD1fkFFukvDdElgZnADUmC2w7oSKsvM+l/aVQx2g3FaRSSxxit8ebnvtY1+9n4KwLhNW CQK9gtftgR1k08LbNz+w0s0TCh4AoSpXaZk9xqJxRJingz+jAokwskXFYK8A1JT2xR4uTt6vfygoh V/nd7PjXm0lRizKWOhAVpO18usl7yD/EldGROh17WEF4YdIgA8MqrdaYmAguGbcvF2itDSX/J0Yz+ ounkA4hAprarWLLK+EnCMif4awOIKUePoh16Cap5mleVnc6fMY90Z2ZwlXou8+nK3vxxhfPSi5WmL n7smZ5SbhGKfCBD4OAqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pif4m-00B2QG-35; Sat, 01 Apr 2023 17:31:40 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9B-15 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxE-00089F-Up; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxD-008GPe-8E; Sat, 01 Apr 2023 18:19:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxC-009kfD-LG; Sat, 01 Apr 2023 18:19:46 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Kyungmin Park , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 02/49] mtd: onenand: generic: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:51 +0200 Message-Id: <20230401161938.2503204-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1805; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=iVoDRea/XJ4anuADCYCoACan08EveYf2jBCG/YgECZo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFjyde/ucaZLYiIg2Pl6gRVFmeD/cos/tlIuG Nu/0jGlFrKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY8gAKCRCPgPtYfRL+ TpviB/47lsRE5JJBQB+mD2MJ9+GIzyW1b7iPyKiua9PzhGm9Dcyf9dlIBCxFzK/mjpkiZl4eTG7 4LCcaMPX9hflvxORig+4kOHv7+IKaSCmgnba8QEg1BcrmDgeyRNDeg9Wr2U6Onm9C3S/YadWHMH M2y35lFtGCKCm8TjoTrhOdk5X19uszrcZyp1lgbBqvGNn9K1sF5uchm2ygHHcY0OjTdsv8TQbQy 7p5iLGolVhoEPNEy+hOdztWhJyQ/q8uAblkYy+2fVssR3XWRDq88Eih5x0x0XW37tl8OE4TzALd BPKLayFd93o3/TQ4OmxB+zF8HOvHm7JN+60JImf0iVujr3Zy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_420030_5A467786 X-CRM114-Status: GOOD ( 16.32 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/onenand/generic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/onenand/generic.c b/drivers/mtd/nand/onenand/generic.c index a4b8b65fe15f..4e7de48f07a6 100644 --- a/drivers/mtd/nand/onenand/generic.c +++ b/drivers/mtd/nand/onenand/generic.c @@ -85,7 +85,7 @@ static int generic_onenand_probe(struct platform_device *pdev) return err; } -static int generic_onenand_remove(struct platform_device *pdev) +static void generic_onenand_remove(struct platform_device *pdev) { struct onenand_info *info = platform_get_drvdata(pdev); struct resource *res = pdev->resource; @@ -97,8 +97,6 @@ static int generic_onenand_remove(struct platform_device *pdev) iounmap(info->onenand.base); kfree(info); } - - return 0; } static struct platform_driver generic_onenand_driver = { @@ -106,7 +104,7 @@ static struct platform_driver generic_onenand_driver = { .name = DRIVER_NAME, }, .probe = generic_onenand_probe, - .remove = generic_onenand_remove, + .remove_new = generic_onenand_remove, }; module_platform_driver(generic_onenand_driver); From patchwork Sat Apr 1 16:18:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764096 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ukw/G8xA; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8b4Gldz1yY8 for ; Sun, 2 Apr 2023 02:21:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fXdHVnC/eKD2ycsc8TBaqGeerK/KBJDtnOmQVR1jSZY=; b=ukw/G8xAYE6Gzf GA+V71peSSuALpuoMpRpZgqv3GpJgYvAPPH1Zrpdj5sf2XIvGAQfG2Tv01ofWXGLdfDJXJkahvZvO hNpmjtdhxBvg7zgd8w1tZbBB3QXWM48n2Fo5Ng8fZgu7C+074zQ0i/oRTSD2YHJlCJ7Y0zQ3YToM0 Fd0f0XduA7qChHYD2SYdrRMA3Ub7QGKSdy99JoSVwRdH8vsHSF2jNhJRdxFKv9L58XY8riJud09uB NtQ36S6ucLE7v2hbQROl+79bhQvdAd5WUSfFv9FZ7aUK+2CPCcuHL/+ipabOvL35VUzRBr3h3gXrL x2Ab0tgaYYEt1tjpbVgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyR-00Asm3-2Z; Sat, 01 Apr 2023 16:21:04 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9A-15 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxE-00089H-Un; Sat, 01 Apr 2023 18:19:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxD-008GPj-Fe; Sat, 01 Apr 2023 18:19:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxC-009kfG-RV; Sat, 01 Apr 2023 18:19:46 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Kyungmin Park , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 03/49] mtd: onenand: omap2: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:52 +0200 Message-Id: <20230401161938.2503204-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ugJWs93QuxD0VnBIsnIIC7NVxTy83kogOzdVHcZ6XOM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFjzVaKvY/owp2CteX8O2HMzn5Vc+Yy5UpW1m wZLocahK4uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY8wAKCRCPgPtYfRL+ TkFuB/0Xag3ijKLZ0gP+OgceJrM/yxM+zT3ulQcWR9GRApIPnNAx0KUajGUzyL6MxpcjAMtVfCp C1eevDQk5eDNvhuuUmeHccfIR+aCHV9nCgOCVcY49BDRQ7tR2OlI10xOus/eLYAuX7SZNflRmgS o+y4QJYgdzNlThLPyaHHtg7ZeDlc/asmG+vU/eIWhdpGt5TeZPr/O9XGX2+cwUXuO2//82JVlTb ZxRXGYG7cAF9eeTVrw9vq4JGkTqfLVpBXHJDZmaQdFfQnE48VXR35HPOEyXUvx4E/208gCUaErz w4QF4NL+OpIyFCbyr6FWsubcNnabknOZZyJOVC3hsMMkcrkN X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_428676_656DB0FC X-CRM114-Status: GOOD ( 16.28 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/onenand/onenand_omap2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/onenand/onenand_omap2.c b/drivers/mtd/nand/onenand/onenand_omap2.c index 12825eb97938..ff7af98604df 100644 --- a/drivers/mtd/nand/onenand/onenand_omap2.c +++ b/drivers/mtd/nand/onenand/onenand_omap2.c @@ -581,7 +581,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) return r; } -static int omap2_onenand_remove(struct platform_device *pdev) +static void omap2_onenand_remove(struct platform_device *pdev) { struct omap2_onenand *c = dev_get_drvdata(&pdev->dev); @@ -589,8 +589,6 @@ static int omap2_onenand_remove(struct platform_device *pdev) if (c->dma_chan) dma_release_channel(c->dma_chan); omap2_onenand_shutdown(pdev); - - return 0; } static const struct of_device_id omap2_onenand_id_table[] = { @@ -601,7 +599,7 @@ MODULE_DEVICE_TABLE(of, omap2_onenand_id_table); static struct platform_driver omap2_onenand_driver = { .probe = omap2_onenand_probe, - .remove = omap2_onenand_remove, + .remove_new = omap2_onenand_remove, .shutdown = omap2_onenand_shutdown, .driver = { .name = DRIVER_NAME, From patchwork Sat Apr 1 16:18:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764082 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XJ1Z6itM; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj89591Hz1yY8 for ; Sun, 2 Apr 2023 02:21:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Tg+uWyHTzk7ahKkJhT/dXdvF/BBk2lxEwUXq/Td33g=; b=XJ1Z6itMyn+4w8 KsLhY5ChZVcL+Wp6AradoHlGybBg6TXjpjmgHV5x99ThMAK5aSCMfzXYQWmP0e4iCvW+BUUioblcq P/ruBegRGNjIZcPB/EmAWGHcTIUXI3sB3KSesr+Dy8SQsAIK//Fl4ozziz94ENwKdRyH1KJiUk1G0 nwmTrXh6ekPFCU7HnKIFjaEohw2EEuxxERDErM4RIY9TjZTTGEjQfPcEWESzfuzXgYluQB8ikOLLQ WsuwzONtdHqG4fGxIhpGXlBvrjro8rtfWTYQTfglnoQeqNjOBP7u6EGUd8nsJXpc3Bwb0q9eQ7v6E CWUFmBejumqoTJZZ9aog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxj-00AsKv-2V; Sat, 01 Apr 2023 16:20:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9D-0H for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxE-00089I-Uo; Sat, 01 Apr 2023 18:19:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxD-008GPq-Q2; Sat, 01 Apr 2023 18:19:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxD-009kfJ-1j; Sat, 01 Apr 2023 18:19:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Kyungmin Park , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 04/49] mtd: onenand: samsung: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:53 +0200 Message-Id: <20230401161938.2503204-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1683; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HZhr3wtXScHQata752iFFkBouaYyTcwz0fuk3NBW8HE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj0EmPMBzokGJuMW9KijxhFy7ic5bPMbApHP HYFrQPbniaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY9AAKCRCPgPtYfRL+ ToE9B/0cttMH5J3owegf74UICe2Z58oOkReNWDY2QsVvFG3fKLjzZo8lgMpsokuCuONZiYlADtU 74AQ6r/NR9U18oUrJWF2ifa+6uNH/7i/NGSyTEm8FMlOG5ZlDTZk2HYPQzDpKaxK+qguYhrfbWu GhMiSJENkRJEhC7NzzpaSixoUIiVcUmJY7L++9jWz/B6mNwh+Zou+aXmQBDHe+hRAxdJy/2jkIp VSk4WhfNUYhdhbKPeOtnfQPKbDsSQiLhEZ6Kzzj0mqFSP54Glek1m0OqA9reg3TwmjEDI0e/KKu hRvxOeHsRVdsof7811dur/NBhtE5957cJMPcZFdD0sniIrLl X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_148286_D11708B7 X-CRM114-Status: GOOD ( 15.76 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/onenand/onenand_samsung.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/onenand/onenand_samsung.c b/drivers/mtd/nand/onenand/onenand_samsung.c index b64895573515..92151aa52964 100644 --- a/drivers/mtd/nand/onenand/onenand_samsung.c +++ b/drivers/mtd/nand/onenand/onenand_samsung.c @@ -943,13 +943,11 @@ static int s3c_onenand_probe(struct platform_device *pdev) return 0; } -static int s3c_onenand_remove(struct platform_device *pdev) +static void s3c_onenand_remove(struct platform_device *pdev) { struct mtd_info *mtd = platform_get_drvdata(pdev); onenand_release(mtd); - - return 0; } static int s3c_pm_ops_suspend(struct device *dev) @@ -996,7 +994,7 @@ static struct platform_driver s3c_onenand_driver = { }, .id_table = s3c_onenand_driver_ids, .probe = s3c_onenand_probe, - .remove = s3c_onenand_remove, + .remove_new = s3c_onenand_remove, }; module_platform_driver(s3c_onenand_driver); From patchwork Sat Apr 1 16:18:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764086 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HNCaf4em; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8B578zz1yZJ for ; Sun, 2 Apr 2023 02:21:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1hHJ6X6/01Fgz4ay2EYjb8blT0spxgH9RzoMrxwIhXk=; b=HNCaf4em1NULHJ 8IrAFTtJMyPJhuF0WustJHQNQwjgKPTK7uC+tBKx7ylKVCYU9iap2FiFOsPRS3R7QmZElftIgLW8M 8eZuu4ZuTc8eNLgdUCoKhF3/7HpEkQSgSI35IL+nn4O46+fBQr1Die2/sCr9GbZ9HGFkhq7ozvbfB NcwiZrymyGsTiG2P4NoeKk7HiNCdZ0/sVNB5c83/UDR1/uA+PfbPqqaXplWaUUNSK942gALCfNedU OHvN06YfI41L2THcNH9Kkf5aRes/oOWsdQ27XWmzSgCdcrRqlJQI8jzGiZv8C9RC+37qT+BBMN2tt x6y3DDfT1T8QErwWQzPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxr-00AsOi-0P; Sat, 01 Apr 2023 16:20:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As8p-0k for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxE-00089J-Uk; Sat, 01 Apr 2023 18:19:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxD-008GPs-Re; Sat, 01 Apr 2023 18:19:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxD-009kfN-8Q; Sat, 01 Apr 2023 18:19:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 05/49] mtd: rawnand: ams-delta: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:54 +0200 Message-Id: <20230401161938.2503204-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1825; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VtI+ygXkmxX71/ikFzjg+mq47iFVFdJLSTwb8ONqOvM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj1D/c0e3ml2OyzJJCcbGz2zS36rkT0rwK5W cIOUjYX0QiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY9QAKCRCPgPtYfRL+ TkBlB/oCW8MQOYBxMUx4vozICJ7xHt0uicFs8nNJalU01QgdMUZrHfM+75CbIOfSpYS0jkWiv9t Sm9oKsU2yNCkc6WjCaQp4LAnZYAYb5iPeChDEbeZcP+eBcp6aSc5lbuILjoeFriYrqxPUWwAOAo K7yKTgIZ/d8yDPIp1HyB6P6/aTIXRr4oXfN+V5DbkfgKHdj/rDyjRApl6oxkduJdmerhqgncSIn aEJJROXZ353DgBaQ1/uDzUs4EolslP75RWcqxXG8t3O+oEYnGDpGWRT8MgjF443Mmzyubwmgt+3 X7y+Vd4+GBvoBQDSQu7H//sS7i+Az4loQ5QbAT3jm5BqVpXD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_283454_5654A0A8 X-CRM114-Status: GOOD ( 16.52 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/ams-delta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c index 13de39aa3288..fa621ffa6490 100644 --- a/drivers/mtd/nand/raw/ams-delta.c +++ b/drivers/mtd/nand/raw/ams-delta.c @@ -397,7 +397,7 @@ static int gpio_nand_probe(struct platform_device *pdev) /* * Clean up routine */ -static int gpio_nand_remove(struct platform_device *pdev) +static void gpio_nand_remove(struct platform_device *pdev) { struct gpio_nand *priv = platform_get_drvdata(pdev); struct mtd_info *mtd = nand_to_mtd(&priv->nand_chip); @@ -410,8 +410,6 @@ static int gpio_nand_remove(struct platform_device *pdev) ret = mtd_device_unregister(mtd); WARN_ON(ret); nand_cleanup(mtd_to_nand(mtd)); - - return 0; } #ifdef CONFIG_OF @@ -434,7 +432,7 @@ MODULE_DEVICE_TABLE(platform, gpio_nand_plat_id_table); static struct platform_driver gpio_nand_driver = { .probe = gpio_nand_probe, - .remove = gpio_nand_remove, + .remove_new = gpio_nand_remove, .id_table = gpio_nand_plat_id_table, .driver = { .name = "ams-delta-nand", From patchwork Sat Apr 1 16:18:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764130 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xiyVVTur; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppkl00Wvxz1yZB for ; Sun, 2 Apr 2023 03:33:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dzHKsXZUnY8WG5EOKjQUq6I6JJB8GQ3D4wa2DdE2Kbg=; b=xiyVVTuru08jQx XNux8dd7n/sEAt7a94GzzgqnT0GOwq4s82xHvWtZD5uggl2I/6CYtIa56zSOc+ek7X2fd0ygNvjno J0Vaz07VBZMcrpiuhlb3gQxhpBus+UToNrOZsfhIEA/uUL3UoiwWimmciEQm9FGPlsUCU2LzPrptZ VtLiQT7Wmhxva1IhaxcBYLfSTYtyl3kcBD2VsCVM9gsjbSM+ObPkFwBxmmreh02+66pCixmBw25fh Z32PaULX3hMYlS9tmU0pmrMal35y0qXI9LdkifTQRYAycowWepmnEd7j8ELrnz/B5ALW7aLk8ECD8 v2FS26ko4PojDr3EdLfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pif4m-00B2Q9-0y; Sat, 01 Apr 2023 17:31:40 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As99-0W for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxF-00089K-1A; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxE-008GPy-9P; Sat, 01 Apr 2023 18:19:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxD-009kfR-F2; Sat, 01 Apr 2023 18:19:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Naga Sureshkumar Relli , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 06/49] mtd: rawnand: arasan: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:55 +0200 Message-Id: <20230401161938.2503204-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1759; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=oFuwbdTVb4BgAJh+EvdenrEifG3QnzKeYSjGpFh33Oc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj2nSgc8VmElB9f3Mfe+ZvrlhTGu8E/qSXiP sqIBt9S1ZmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY9gAKCRCPgPtYfRL+ ThE0B/9yV19FMlLoe/0T1ggBeIJqX8G6u2PZZUhS+JRVrSEsiZtNWqSz5aXrDXkqn1vdTa3VDX5 9nezj0uv27gL9feXPTnWSEq3iSeo700a2R1VwIb0mDumWBHf0JREwBCXblSsBoNUzGHC3b4CfqR 1nXyajF5+FkCnjJy8wAnknHEwiRgSGrAYjjd1Cdfa8JWcg9IgHXFb5C7jpguNR5Gr7v/5s850kj e7Go6nk8xhKLt1eXC08ffKVrXuC3JZJaIeIgSDDUbgdr0B3m9GDjeMEO8KW22LzvSVoa8+rgobz +h07WbwH6ikFpS5SYhfKUqWdXiT8mDEJMuCGQXO/88UgBrWs X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_413287_1593686E X-CRM114-Status: GOOD ( 15.81 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/arasan-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c index ec7e6eeac55f..d513d2db3549 100644 --- a/drivers/mtd/nand/raw/arasan-nand-controller.c +++ b/drivers/mtd/nand/raw/arasan-nand-controller.c @@ -1496,7 +1496,7 @@ static int anfc_probe(struct platform_device *pdev) return ret; } -static int anfc_remove(struct platform_device *pdev) +static void anfc_remove(struct platform_device *pdev) { struct arasan_nfc *nfc = platform_get_drvdata(pdev); @@ -1504,8 +1504,6 @@ static int anfc_remove(struct platform_device *pdev) clk_disable_unprepare(nfc->bus_clk); clk_disable_unprepare(nfc->controller_clk); - - return 0; } static const struct of_device_id anfc_ids[] = { @@ -1525,7 +1523,7 @@ static struct platform_driver anfc_driver = { .of_match_table = anfc_ids, }, .probe = anfc_probe, - .remove = anfc_remove, + .remove_new = anfc_remove, }; module_platform_driver(anfc_driver); From patchwork Sat Apr 1 16:18:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764080 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tJuWllaY; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj882Xd5z1yZB for ; Sun, 2 Apr 2023 02:21:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcNMJeXwVRhiXARdoZHJSJTND4p/X1g8w3oDhca0Sa4=; b=tJuWllaYzUjTUL ytGm4vzEuycWLa+Fh9wn0YlPg+65WuP4UeqsfZVMNBTgo1k0g/eyk4UERTibwgFiPZ1YbF0Xp1Qfd E/u13V1lihACanWyrnjhGLyRmE0teKf5c5PrT3x+1Piu2g7F97s16OqeywTF9Qo1vlXEPDgmGOvQ5 ygivSIH0k1ROumt6a8soBZeSe47T+7GHrLkSff7OSFuHqhTp4aoApEH2eFXn1IGaCXqwPdo46aqNp UDGMFFwR8IgF9ASY56AzwQIijeSl4zL5373TbV29g68gWJZSo8sZ/YykO9ExPXj01a8Hn76HIb34t gaYPNhcdlWgn5tOEVMlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxk-00AsLZ-2O; Sat, 01 Apr 2023 16:20:20 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9l-0T for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxF-00089L-G6; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxE-008GQ2-Ha; Sat, 01 Apr 2023 18:19:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxD-009kfW-ME; Sat, 01 Apr 2023 18:19:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Tudor Ambarus , Miquel Raynal , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 07/49] mtd: rawnand: atmel: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:56 +0200 Message-Id: <20230401161938.2503204-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1836; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=62cKYMuQ2K4bCDqUddzPQqOui91z2yoxLirMj5OqyIw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj3fMxmiwaw2cqjh+N0F9jtTWUeARgGXppEG 1PhiAMKj6qJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY9wAKCRCPgPtYfRL+ TrtdB/9bzK2R2buQkl9VCUAENhS1Gej5ViZ+GoP0PvV7+G/LtX3e1z9iBhYzfhAP3TwJbf7VRLF pS6rAiUrwH6Rt25hqTWbo0h7OAQ+iHm4qQiUPa7Udr3N86wQiWo49IKajg2KIIoSOmUNlgTtEPe m/mZbb5oUFlkyJdJfRQkcqpcH66dv0h+7YkaMgUJ11LTJuQ3Rs6TVIPxWFyawNPoQy6tPTbSeS8 clPUcTbbUa1V0QcxANMnaghXINlKzwPKH90Lj1UgopMAjO0n5xpOzvFgDUgmlmMCcumpB74KqvM wsTd6c+p4maEnFvGC87iP1WduOpZ7wNv5yrwdi+IVlX0oeTb X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_200908_E825E993 X-CRM114-Status: GOOD ( 15.58 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Nicolas Ferre --- drivers/mtd/nand/raw/atmel/nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index 41c6bd6e2d72..81e3d682a8cd 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -2626,13 +2626,11 @@ static int atmel_nand_controller_probe(struct platform_device *pdev) return caps->ops->probe(pdev, caps); } -static int atmel_nand_controller_remove(struct platform_device *pdev) +static void atmel_nand_controller_remove(struct platform_device *pdev) { struct atmel_nand_controller *nc = platform_get_drvdata(pdev); WARN_ON(nc->caps->ops->remove(nc)); - - return 0; } static __maybe_unused int atmel_nand_controller_resume(struct device *dev) @@ -2663,7 +2661,7 @@ static struct platform_driver atmel_nand_controller_driver = { .pm = &atmel_nand_controller_pm_ops, }, .probe = atmel_nand_controller_probe, - .remove = atmel_nand_controller_remove, + .remove_new = atmel_nand_controller_remove, }; module_platform_driver(atmel_nand_controller_driver); From patchwork Sat Apr 1 16:18:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764077 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ryD6x7zw; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj863sjmz1yZB for ; Sun, 2 Apr 2023 02:21:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZKnI2NX/SxHx3ywXKcmJAqofbzu4VYbG2aGZRwx16uo=; b=ryD6x7zwIBSNwa bnCSb3LuH07qR0UfZjgmANmmLwrmr8KwuHKl2omRO4A0nISriNcl4UxbimnoKe1i0Yx6AMvWEDcEn MEQoknD+TjiVjKEKedanQbRFC/4rElf4MfCc4cJeriqvj3AGqeT5jEMAzHxub0a65jZi6cV2l14UE B1PhRXaxdc4MjPTyPHVADhRM3BzIIOiZMIRJu6ME/rJDl+cKrfnWvB21GhBlZcqvLureqIwGA1GAq QEq2avTGOG+4E30IHFJ394K+xZe2Zq5r8wwobHzsk5GyyanwsE2VHSdrz5EzgieqWnAFCl57eVpyG W5LTn1MMTjzoAaZus96A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxi-00AsKS-0b; Sat, 01 Apr 2023 16:20:18 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As8s-01 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxF-00089h-E8; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxE-008GQ6-Q9; Sat, 01 Apr 2023 18:19:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxD-009kfZ-SJ; Sat, 01 Apr 2023 18:19:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 08/49] mtd: rawnand: au1550nd: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:57 +0200 Message-Id: <20230401161938.2503204-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1774; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zR4KJcDy8DkDRPFs1TFovFy1Y4Ig2wiD2/77Dyp2h2U=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj50iV5z22Ij3VWT5Jk2bjBtZQYADW+rSmBB po/dg74IwOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY+QAKCRCPgPtYfRL+ TnzyCACnrlfh5M2+y32Bxp4PUl4qUj/6G/it024Td4JAHKb/m4yuC3V0tHnQU4rfxhmGjDk/qWm YhufUjagstjKhCLhS1OErPHn0qvFKZd5m05aF2cIdfc7KI2581ulQ0O4ELAXSeuHk7QcjwzVGQX kfoGAkwxod6ZLLtZuB5QaRpWsDpQ7ao9vD4ZNG7zdJ3Y5rIVATwtIDROVnrQoAITtrnrIge98Yt OK3pt2QL0I6TzoQohv3gM0F7+NrPQgp71UWX+CRI+GL57k/L4KSpf6f/K1E8IOI/R5lQrKrE/jU FygcYIBTVqqsRfF7JmEvygfwHIJFQzPt2eiRM5w0VVXqj2xZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_062644_EBB23E09 X-CRM114-Status: GOOD ( 16.59 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/au1550nd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/au1550nd.c b/drivers/mtd/nand/raw/au1550nd.c index 5aa3a06d740c..063a5e0b8d4b 100644 --- a/drivers/mtd/nand/raw/au1550nd.c +++ b/drivers/mtd/nand/raw/au1550nd.c @@ -337,7 +337,7 @@ static int au1550nd_probe(struct platform_device *pdev) return ret; } -static int au1550nd_remove(struct platform_device *pdev) +static void au1550nd_remove(struct platform_device *pdev) { struct au1550nd_ctx *ctx = platform_get_drvdata(pdev); struct resource *r = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -350,7 +350,6 @@ static int au1550nd_remove(struct platform_device *pdev) iounmap(ctx->base); release_mem_region(r->start, 0x1000); kfree(ctx); - return 0; } static struct platform_driver au1550nd_driver = { @@ -358,7 +357,7 @@ static struct platform_driver au1550nd_driver = { .name = "au1550-nand", }, .probe = au1550nd_probe, - .remove = au1550nd_remove, + .remove_new = au1550nd_remove, }; module_platform_driver(au1550nd_driver); From patchwork Sat Apr 1 16:18:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764092 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=x3JqMOVb; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8L755qz1yZB for ; Sun, 2 Apr 2023 02:21:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dXPbLio0BQT7HugkU1YLM8ccpX1HgOAo8wOmT8ICb68=; b=x3JqMOVbOX5VqY Q7LCTq6nma4VV01vezUAMXVbVF6/9r64Kd0+68PS6cPpEGK04m6odX98MypYpjKtSmyccaye+NlZG chFci7SMUgzF2HIaSzoEI1VomtrJDu8nhu7jKuCBuvdPm5ByzBWeO3yt30pwqD7iMcDCh0FRWfd3h BEYO/khYfskdnHArNAshIk3N6HbtDCrU+PuqFzQxnbCUfTfDfHkSad9JoYfXrjxDonNnnF3gY5s7H JWkeIy60NNET+btWClBLlkpSZPPFYHDwHNrwBuhBETSg1yr546uqxhD8W6BABAwc0TGpmooUPbjVs tCCfvzVtXiVovrjguYWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyE-00AsaT-2l; Sat, 01 Apr 2023 16:20:51 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As98-0d for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxF-0008AA-O8; Sat, 01 Apr 2023 18:19:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxF-008GQF-4C; Sat, 01 Apr 2023 18:19:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxE-009kfe-4Q; Sat, 01 Apr 2023 18:19:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 09/49] mtd: rawnand: bcm47xxnflash: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:58 +0200 Message-Id: <20230401161938.2503204-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=vBbbS66OwtQuWqNU5RP4uqe0iTYZjagBym+7MxdQoqI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj6xaViYZ6pypactGh+k76eGvuQOcm1Rgw+q vgDHOfsnGOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY+gAKCRCPgPtYfRL+ TnNLCAC7oH7/FuiWDo7A+RZQZacjEW/vANwwJnuzqeTJE66h6JslbwXoEDV9vM689vfqMfWm2rJ WYi4S3IOzMrwrfpcAZiClB/5G33aXMF+XqTi0qnG6tG2tWdHeKAQyADNtp5Np96YOkG2WV5c59P ebHxVMUfajSJOWD0EhUkIfDXC5VGxtYMRWXHAMwopXweKMo+WGVyXoDe7RoSL+0QoZPSq1ReybW mmKB4aLRdXwUUzm475kI/dIGNDKR2zVW0NZpXoiq2x3jqZ/bjZbwx7faSDHovpiBhqHIhOHp3Re NMPKIwnC+OVNkTqPcw6ZPmBxS5ZU3W+ihTP7lvigNnfFBlq0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_261609_39B56CFD X-CRM114-Status: GOOD ( 16.22 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/bcm47xxnflash/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/bcm47xxnflash/main.c b/drivers/mtd/nand/raw/bcm47xxnflash/main.c index dcc70d9dc6e5..ebcf508e0606 100644 --- a/drivers/mtd/nand/raw/bcm47xxnflash/main.c +++ b/drivers/mtd/nand/raw/bcm47xxnflash/main.c @@ -57,7 +57,7 @@ static int bcm47xxnflash_probe(struct platform_device *pdev) return 0; } -static int bcm47xxnflash_remove(struct platform_device *pdev) +static void bcm47xxnflash_remove(struct platform_device *pdev) { struct bcm47xxnflash *nflash = platform_get_drvdata(pdev); struct nand_chip *chip = &nflash->nand_chip; @@ -66,13 +66,11 @@ static int bcm47xxnflash_remove(struct platform_device *pdev) ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); nand_cleanup(chip); - - return 0; } static struct platform_driver bcm47xxnflash_driver = { .probe = bcm47xxnflash_probe, - .remove = bcm47xxnflash_remove, + .remove_new = bcm47xxnflash_remove, .driver = { .name = "bcma_nflash", }, From patchwork Sat Apr 1 16:18:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764107 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QiP21l6l; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=CV50YF7B; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWb5bblz1yY8 for ; Sun, 2 Apr 2023 02:38:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QpKk98NeKS5NDv54OwaUo/wqlqXK2GxrrHAckq4/kuU=; b=QiP21l6lTMRAWd bEtxsY1tr5838w5tNkriRsaws/YZlk0mK8QM9s3YV75MGlyXBqhOBYDDy41iXvViS4OfuX+1uFh4l m4m+lti6aIjrb2LcAHOw6cAfkBXNCr6lViHcXkux8E6n1dnWirme8w0gCcg1+IqkPAGIwJ5MxuF4j kmM/4cQrVBuZpoNXWbpVPnSGnZ3MFkHwCzjFrU9qSytAnbLBAurJXuzJdf+oEXyafRLmeVGtqUR8J 55Jgwww5QuqrU/TOQoFnDtPC+TmEzHnbFnFH/s7ZG3WAdHEvxl6S3xd791GOVa++FHJdnXqDnoTZz LBLSNjSeDE7qP/6GIdrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEJ-00AwTg-0m; Sat, 01 Apr 2023 16:37:27 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEG-00AwRk-35 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=5hpxSLTSThuxjxj27ulW6Ade2fFJNEPt2IBjMu6lKqo=; b=CV50YF7BtyHYcjkX1aERagnXsq xvFt+m5cELxvTiFegrXFj9D9X7MzI5399nDztQVeWlHKz5cZ8HU1u60WXbWSjcpoMQcDtzIdvGzXV 6y7HIihg3ga8Ya2AZlVQhnchA7GmE3cov+lYRZIKmlYOMN+EZGnTEzGuv7MktLLRvfzcZFpnQQb5V mtchcazNLRZZQbwKDBSgae9tzSWyQ1hY6vYXD3B1DvgqtiVX5f6fnpVZURChFlgU4Z/ePzxRZwFxq VDVq8r4rw38zi45p7YRBHirtP0/34ogV92YnX5EFnX/4Kf/XRC9scXe0Qi4eHNInqQFZsbkMeXj+O 7iHHcLPQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxX-00CYO9-Nm for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008A9-Gw; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxF-008GQE-3O; Sat, 01 Apr 2023 18:19:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxE-009kfh-Bb; Sat, 01 Apr 2023 18:19:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Yang Yingliang , ye xingchen , Valentin Korenblit Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 10/49] mtd: rawnand: cadence: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:18:59 +0200 Message-Id: <20230401161938.2503204-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1667; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AfpjgW7LVj0UxqzoFH2l4MZgjRpe9UZwos7pFGy2fVs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj7eSJKUCMH6vVKAM+ccqOrA5XEBtJlYGKAi oFeJQ4LE/SJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY+wAKCRCPgPtYfRL+ TuQaB/9vaszWHiMJTokM824uj/VcOwyphvdGcrWRxleQXL1DDJR9Uk0Kj52h8rH1dgK/0fXArZi pXruLlrDwG3v3wwaX8/Mv3LcSiBPeyB7t0W2I9Nw1eXsRy2InIL3eKX0ZcSJ8qHDQnrqRCrz+uL luXg42go0UrFiPq+YYgbR663/8y3iX01SFPvnZm/fEOFduXwtdLqUyOZ1FdM6BBSArFaAw3tVaD Cq87I0dJq2zGzMnTrxVMH1K1pTtcZJ+DZrGysnklgIbGjRe2Vbxd/RUA6YOCmbHLK4ANOI1JgZ+ MbuVZ56n4nxg6qRkEpLbK+JNyWOlNrie2Mu+5ulp/C8GIbZK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_836571_E61B9CBA X-CRM114-Status: GOOD ( 12.56 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/cadence-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c index 7661a5cf1883..034ec564c2ed 100644 --- a/drivers/mtd/nand/raw/cadence-nand-controller.c +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c @@ -3055,18 +3055,16 @@ static int cadence_nand_dt_probe(struct platform_device *ofdev) return 0; } -static int cadence_nand_dt_remove(struct platform_device *ofdev) +static void cadence_nand_dt_remove(struct platform_device *ofdev) { struct cadence_nand_dt *dt = platform_get_drvdata(ofdev); cadence_nand_remove(&dt->cdns_ctrl); - - return 0; } static struct platform_driver cadence_nand_dt_driver = { .probe = cadence_nand_dt_probe, - .remove = cadence_nand_dt_remove, + .remove_new = cadence_nand_dt_remove, .driver = { .name = "cadence-nand-controller", .of_match_table = cadence_nand_dt_ids, From patchwork Sat Apr 1 16:19:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764098 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gFjq2OHA; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=EArabt7h; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8p2YG3z1yY8 for ; Sun, 2 Apr 2023 02:21:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=40lrhw7Ivb7Zcq+WQdQzOQ4N3BHRe7Q/u4aspCFCRJs=; b=gFjq2OHAlchT6c shmjfn2VOXtaxdRR/yewNetFmFrf9ySd+LHjvQRBk385OxJxb2Rzuy1MqEObEcGLS7RGI+MrEgWo/ rKoswLPiExYlza0jb6mRWEveHcuusm6sm2myIm+tP1ZeDP3PlItMHF+UZ4u1CFbfCPEo3yua2kGrI JIzaHf/C6p0vOR/gJJSn4ROjVA3egP+tLEn5EUPCtJDKsUft0UsKyWhB8OsQUPeEP7T9dvybvERwY I8EJ5UAi/FU+8I7NcTmqkFlLsbmV41k9tDdrRqP7IDlOpDKPmYxlJIIR2YratHafp/s9j9pRzGP5Q Ks0cAFzBs7N9E8dr9Yfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyX-00Asr0-1l; Sat, 01 Apr 2023 16:21:10 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxe-00AsIJ-1J for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=Nwv+hEef3prAOF1uQ9Zm+GfCP3l9mNoBs/uqeuaNDEo=; b=EArabt7hC8xVBUXz5FBrRJ6pB+ Rpt8AdpkArbsB0XVfobIFQXziYYr2gox+q8TNxR8rtwvElJa0W+NjGNQl7MW2v2W0IirHu1MOMmCr dD4wO+LQ/wIEMM1cXKd0Ux8RtzFlMvTtNweQOX/SK7MuUUqmP7aQ+jcnePD7ftQqIJeL6y0egoGnn 5oVl9oZk7etZKmmVzzAdHBO+1sBv86nJYM1YB3VvJAvp6QVE703eRVmymuKgvVUZX5+Povi1n74K/ 8pxY4SGR+osgY8v87p2G0cF7sJPLetdWHaYfP7zPlEScZcjgg76dl9XTeW6dhAN4d9xtsZL8ZzlyR VMYU6G8Q==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DLN-0F for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008AK-ES; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxF-008GQL-6g; Sat, 01 Apr 2023 18:19:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxE-009kfl-Hz; Sat, 01 Apr 2023 18:19:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Wang Weiyang Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 11/49] mtd: rawnand: davinci: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:00 +0200 Message-Id: <20230401161938.2503204-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1767; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=6j4UEMrS0KAskczZmMyNk/+K1HHRyJInNQcZ4a0+R0Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj8fcpEjzOi6DvCXPaMB0evheDUt0RmkpGpN hHgNMlZ84qJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY/AAKCRCPgPtYfRL+ TixZB/48yF9uUDKNS9Fnz11n8XadIQGt+Ylz38EWBRn4873wNGddvYixBptRmXHLKsAJIKfxZnu 1jRmuo3URW0hzvdLNyX4oRQqZ3GGF9sdvljx+tE8a5acJEMvFoMA8ZVK98HY1+KHo4gqy72kCa+ qxenn0j4JKMdn3EuVWC79gV5SRJX2w/gfoJMvZSoUuYWdvbsCSZa5jE28Ape5x30dbzOBJyrYAH xkXuzO7u6Q9dJY2HUaOyBpnveGkL7LJSA1mvsQJxKzYB1Blqh1l0f4B89HtZUyBtFcDnTXo9vz4 hkhUHxPg7Wn6sQVsBs1Pxd3AdkrAzGvmHqOs6VQpBWjN/cz/ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_222374_6461F151 X-CRM114-Status: GOOD ( 16.17 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/davinci_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c index 3e98e3c255bf..415d6aaa8255 100644 --- a/drivers/mtd/nand/raw/davinci_nand.c +++ b/drivers/mtd/nand/raw/davinci_nand.c @@ -821,7 +821,7 @@ static int nand_davinci_probe(struct platform_device *pdev) return ret; } -static int nand_davinci_remove(struct platform_device *pdev) +static void nand_davinci_remove(struct platform_device *pdev) { struct davinci_nand_info *info = platform_get_drvdata(pdev); struct nand_chip *chip = &info->chip; @@ -835,13 +835,11 @@ static int nand_davinci_remove(struct platform_device *pdev) ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); nand_cleanup(chip); - - return 0; } static struct platform_driver nand_davinci_driver = { .probe = nand_davinci_probe, - .remove = nand_davinci_remove, + .remove_new = nand_davinci_remove, .driver = { .name = "davinci_nand", .of_match_table = of_match_ptr(davinci_nand_of_match), From patchwork Sat Apr 1 16:19:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764095 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bVw9TWdX; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8X1cGKz1yZB for ; Sun, 2 Apr 2023 02:21:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y1EzuhW6RCrWnOcNZNQqmdRF8skvF10zs7GFVParlDk=; b=bVw9TWdXjGvave CxncmoTAbEZPpWsOPnpu1hEVFeC1KPd8yKEMURZtaOWPkDt8jhZHeywjzH57/e5VNoC7zdkliF9qz L3Ny5wBUTJ1spn14b8rntnP0rQdWqEiRoDT0l++KKQQyBrGXPCiJCNoEfj6mIAK4C/8eFtFG6Jfnk BJaTxJvIzlNKEv7qvDQlX8XXn7wMKxsing6GFG3qD59rfeGj8xWfoFMOFyuyqpByh6EGM8FXg6Eax vSrOF27/WOOCIYC1w4tkkO4MC+zIers+xRLs41ksSX6LSTARB21TM5pCQ/zvGqd+1E8xSGhgRaFW+ tWV82KXzVkxbJuZNubFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyO-00Asiv-0j; Sat, 01 Apr 2023 16:21:00 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9K-1R for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008H8-AL; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GQr-6p; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxE-009kfp-Ot; Sat, 01 Apr 2023 18:19:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 12/49] mtd: rawnand: denali_dt: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:01 +0200 Message-Id: <20230401161938.2503204-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1685; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qu53JEhv/Z4bJEqq9yVu8BBGocu88PSDD4T3tHfhkJ8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFj97/26wkgPxEpKLL179mj7Up6terazQIygM /MdpKim+Y2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChY/QAKCRCPgPtYfRL+ Th8qCACOt4YCxyM8hsDXuBmwLUYnH9eVIqVRi+zZcYaUUSdfrFHVb81kgsqvuIuADi7pbl2ZfzH 0CbGYLY/IfkDCPBaVdvhg9lgq57GUocn/eWCfWCs6wQsdwDCAwO0F9qavLICION6ybSYVyGRXI+ l7Hv708BYGMtUQNBLzhbjZVmNY0N9oPn32jf7UwHY849IosGWvQ+BIfjar1OwNFodAHHl/N0Lnh J0jtnPQgk4R3vZtm3baVKzGtkxSqtoGM1S1gLHkNZAF4NbJSPb1ISfcSHzZL0SbcwlnxiqGq0W5 leqJFGmcFUj3Bh0uI+M5CBSzSmNe3IPOq/YM3ViRpNpbu2oQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_481829_6A58120D X-CRM114-Status: GOOD ( 16.02 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/denali_dt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c index 8513bb9fcfcc..915047e3fbc2 100644 --- a/drivers/mtd/nand/raw/denali_dt.c +++ b/drivers/mtd/nand/raw/denali_dt.c @@ -233,7 +233,7 @@ static int denali_dt_probe(struct platform_device *pdev) return ret; } -static int denali_dt_remove(struct platform_device *pdev) +static void denali_dt_remove(struct platform_device *pdev) { struct denali_dt *dt = platform_get_drvdata(pdev); @@ -243,13 +243,11 @@ static int denali_dt_remove(struct platform_device *pdev) clk_disable_unprepare(dt->clk_ecc); clk_disable_unprepare(dt->clk_x); clk_disable_unprepare(dt->clk); - - return 0; } static struct platform_driver denali_dt_driver = { .probe = denali_dt_probe, - .remove = denali_dt_remove, + .remove_new = denali_dt_remove, .driver = { .name = "denali-nand-dt", .of_match_table = denali_nand_dt_ids, From patchwork Sat Apr 1 16:19:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764117 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Xz5TySzt; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=dUGEA9Zn; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjX36B21z1yY8 for ; Sun, 2 Apr 2023 02:38:27 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4oJbiIkRfSuTNUMaBj5n/wFGI3/gr2cPVB0XMnSWkhI=; b=Xz5TySztgBWFHW KDeV8vAN+4oxV3DVs4ePYKuqZTNAq4FkYqhk8Q22I7lzQTjHgTfEbZxeLPR3f9PH9UlcV1jC8/5YS pX/YxZAxGA4ni5kfuCN2yrumJgtILUD/aZD/RFSw1xpxE2jGAGfT8CtjRjalr2dt32gCQazm6Mf2q 3a3Hiq5gVeJTHG0cCR5xfE0xoOwAqSDHuzABEcG2grm/hab6EqXeSCr7hJmHS9QSPjLIqf5GCFi2e D0VlQYL4d5eGc1CAQmS3SyQRRss4gXvJHxeUJKJWLY6kjnbgSfo5EFJC23W73xLGbXfEVCjAUc+yc DOSn32VL6BiDIbSoGnNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEi-00AwnO-1N; Sat, 01 Apr 2023 16:37:52 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEM-00AwRk-1m for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=1XNmrMy+Da78LTZx0o0AjKxWoVKumJIsPm1ctORoeok=; b=dUGEA9Znbf6gfn2pUBBy97ESEI +/ms2TDJI1pgMmYB4zzptGLAv5ptBaTw6mvWBA0bg5J0aGWoBPIRVEYr15nkVr5BbSN/WX8G8cUS7 WhM9PUv/xn039XMJzjQXQfx2g9o/b33YIju32fSxUJ5d90De967RaX+srqirHijrJhzvP4oN5E+1L bzYwbwM3pRJYVSfQulrzhaf8XSj6PTlfrW8K1oitpedC2QYUJ7FX7ExzJdXpnuc4+wWu8m1ESa1Vz Z5wVOovqKHb+6DP9Lm02H2wCyb7m+w7d/V/hB7DWrwRQDs3jqdkeK/YAgtDQN4KKfu1+EL9VhU2oO smuk7aQg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOD-K1 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:09 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008Cb-4K; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxG-008GQb-5K; Sat, 01 Apr 2023 18:19:50 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxE-009kft-Vw; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , =?utf-8?q?Pali_Roh=C3=A1r?= , =?utf-8?q?Marek_Beh=C3=BAn?= Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 13/49] mtd: rawnand: fsl_elbc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:02 +0200 Message-Id: <20230401161938.2503204-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1839; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=yfVH0jbDdqw7wRLZMJmiFxpHx5shhXL+m8ng86xuQIs=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNiH9K0XOOsa+azBi2uHjeTxf3mVZtlTu2zJTb5vPrX 31oX/P0TkZjFgZGLgZZMUUW+8Y1mVZVcpGda/9dhhnEygQyhYGLUwAmMieZg2Fd+OTHWq9znx9n Dg4JaVgkK+Nx629So8uBbWvCZ5yNDTN6Fl3iwHF6erXuVKFJ3zK3sEQlLF3Mt7+6slDDQeKPvSe bPrO+bPDjSJsqJpGOhttr1i7aV7M59W6rUcJvD7Mt3u4nbDp/qyQwlrBJ/uftnW1ndGi+dVbA3E Msx6tfH2Due648U7nFy9G0xTeQlXGNwe3UT241tkdUeT4ZObyO4jQ/ZcVx0fEZTxqDc+sH5nyNi s9HlMq5V57TltIs2DfL2ezd6uAoGbeECS/tC7KVnb0uzObZe+H+x1vPDnyc91NOdc88TbbsOsuj v61P3+ELy3Y4o6z+71N5Rtgq0ZsT3IQ2FHJf4ZROPG4IAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_823268_07E93654 X-CRM114-Status: GOOD ( 13.13 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/fsl_elbc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_elbc_nand.c b/drivers/mtd/nand/raw/fsl_elbc_nand.c index e25119e58b69..1e3a80f06f33 100644 --- a/drivers/mtd/nand/raw/fsl_elbc_nand.c +++ b/drivers/mtd/nand/raw/fsl_elbc_nand.c @@ -963,7 +963,7 @@ static int fsl_elbc_nand_probe(struct platform_device *pdev) return ret; } -static int fsl_elbc_nand_remove(struct platform_device *pdev) +static void fsl_elbc_nand_remove(struct platform_device *pdev) { struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl = fsl_lbc_ctrl_dev->nand; struct fsl_elbc_mtd *priv = dev_get_drvdata(&pdev->dev); @@ -984,8 +984,6 @@ static int fsl_elbc_nand_remove(struct platform_device *pdev) } mutex_unlock(&fsl_elbc_nand_mutex); - return 0; - } static const struct of_device_id fsl_elbc_nand_match[] = { @@ -1000,7 +998,7 @@ static struct platform_driver fsl_elbc_nand_driver = { .of_match_table = fsl_elbc_nand_match, }, .probe = fsl_elbc_nand_probe, - .remove = fsl_elbc_nand_remove, + .remove_new = fsl_elbc_nand_remove, }; module_platform_driver(fsl_elbc_nand_driver); From patchwork Sat Apr 1 16:19:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764097 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qp+HyN9F; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8g11yMz1yY8 for ; Sun, 2 Apr 2023 02:21:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZxOt64Et4SLZ8fcaGsAIUk5Whocici2yicPDWevbLIA=; b=qp+HyN9FtX4BpX 3IBSpxc03bnHs6fxlhk7X4GT9oaYe/2O5dgMqDua8e0gmGDdzZwLmaZQHJugPHqBLD8JIEzKiGOtC W/M7u1bXuD9S2LHISVCt/g55Ry3a0yudnb/PdQ0NW412bLY+ty6CeYQM6Ksjvg/Of1tIg+8OdrSGW n1NPsPlOxLmpxsdw7e0jn9J9Hpvlp9uS9nrof66+vToqQoVl79xZxijn7e6PKZvO3lyNg3f66BBek yAJKQw+bKYOUuB49i0SOjD5Df07kcf6uk9tCbylbq3PjCgoHjnTpqXHf/rXw26v/+5Nfra0IYIfcA 7LvM1HD1JQZCS3IWKf5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyU-00Asog-1N; Sat, 01 Apr 2023 16:21:06 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9E-15 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008C1-1z; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxG-008GQZ-3S; Sat, 01 Apr 2023 18:19:50 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxF-009kfw-5q; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 14/49] mtd: rawnand: fsl_ifc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:03 +0200 Message-Id: <20230401161938.2503204-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1828; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=tILjMWwXKfgbmOVfr+Iz7CPm8Wx8v3dtR1CS5qHAr7g=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNiP9t8//NLPvoMNNUk1mlNO+lYWezttwVjZknvtZtM cntihToZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAiS0TY/ymFiJwuUOPVWihY s5TLwSFds8Aw1vrk740fLBXTsvOWiJxyKgqM3yUQq/37916VP/ktjx0iG0O2BPUw32k9lv2u8cg 7yQCztD8MUdwF9vH7VweEWH38+pb9zJlF91as/Og8XcTqG5P/3Ujry/NsV1zXsr0UUJTwV6XArJ yzel6K/yu7mpQlwT6s8hKu2zRPpKn8P7Mo+9hsLsNZ89g4AtZt8Vh8SODXar99UmunP2Jd7tz5Q fPNST/lSwrqG3+n1L2v4JHoV56WXWgxPSwrwU1SX+S8dqXdvM3TlBRbL2Vllj9buNnphOL9h1uN pi1zvBHmMGsP2z8hY/3dxZoTklsVJHgiz3OLzg4V/mwIAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_434211_665284A0 X-CRM114-Status: GOOD ( 15.86 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/fsl_ifc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c b/drivers/mtd/nand/raw/fsl_ifc_nand.c index 02d500176838..fa537fee6701 100644 --- a/drivers/mtd/nand/raw/fsl_ifc_nand.c +++ b/drivers/mtd/nand/raw/fsl_ifc_nand.c @@ -1094,7 +1094,7 @@ static int fsl_ifc_nand_probe(struct platform_device *dev) return ret; } -static int fsl_ifc_nand_remove(struct platform_device *dev) +static void fsl_ifc_nand_remove(struct platform_device *dev) { struct fsl_ifc_mtd *priv = dev_get_drvdata(&dev->dev); struct nand_chip *chip = &priv->chip; @@ -1113,8 +1113,6 @@ static int fsl_ifc_nand_remove(struct platform_device *dev) kfree(ifc_nand_ctrl); } mutex_unlock(&fsl_ifc_nand_mutex); - - return 0; } static const struct of_device_id fsl_ifc_nand_match[] = { @@ -1131,7 +1129,7 @@ static struct platform_driver fsl_ifc_nand_driver = { .of_match_table = fsl_ifc_nand_match, }, .probe = fsl_ifc_nand_probe, - .remove = fsl_ifc_nand_remove, + .remove_new = fsl_ifc_nand_remove, }; module_platform_driver(fsl_ifc_nand_driver); From patchwork Sat Apr 1 16:19:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764088 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lsuqVwyl; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8C1nxhz1yZB for ; Sun, 2 Apr 2023 02:21:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nLNIUPxNiCwlR8dCm99xYEMkQwAhYK5MKuPNqBQFYAI=; b=lsuqVwylKBneNi O+Ishi0vNRxZ9VZXlLpyYut8lhbBlQxEHuNpq2DEkNi3ud7nsI4lR0krP5TooYWQy3fzcjzm5DUJb APhQYWWf+uedHtzLIGV+kyGlnlEEPl/yCHQyoHK0z8aGzO+hf3yJUjAkkMS4mICTJvEBt05Btl/4o 8kqq0YDmHiZc6riqQ/p1J97mOYBgMDI85VISm9frNiYwPVyxHmqUy56KZXoL7uETg/ub2494EKRqR eR7y/KSJo6yUKc8Y6Rlm+a5/QPBqMZfUBMvBSSCBbHrhn8JP1cCqEyE430WHGFI9GyejiL1CeJpWP WQFkLNWZDBQQNVMOV4ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxe-00AsHY-2w; Sat, 01 Apr 2023 16:20:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-00As9C-2h for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008DG-44; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxG-008GQf-7w; Sat, 01 Apr 2023 18:19:50 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxF-009kg2-D0; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 15/49] mtd: rawnand: fsl_upm: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:04 +0200 Message-Id: <20230401161938.2503204-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1715; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=yZE5CDDd1iHrEXra21mbM2Q2IlKf1WeY/qLOyXhxXPY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkBuKSQuzHYVuWYWkbgZubytAFdDzQS0/uIF nMwAId9g0iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZAQAKCRCPgPtYfRL+ To5yB/9Kch4YmPlaxNgI4BDaMBTgZ4BWKnx6lYQZzINRHiWUBX6R+ENE9q3gT9HHWVz+GdX7Nae KOlT80PN6lIVn5JWNiW/CpQ/BZFrIR6LN8g57JiWmqj4JoY5AU/jMA3xuf0InHEsgjLm3boWBj8 6zc8JG7l1jff/3iCBHxwXU8Ngg3ovbhkWpHe71YU7Qs9PNU5BdFnVMGSrG+rTYOeNAaEJyiE0Wx +kUToRlZ+tREZ7U1+dN81bwTPE1FL4m6yimAl0R6dm8xhAUuUGhrvMlGJZ375a9M5jQOFxc41jR 9Bz7kPgsVdU/Rzx0/rR27buBJpHOZ40+j3touX76lyt51yVa X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092006_901977_9D2C4EB2 X-CRM114-Status: GOOD ( 15.85 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/fsl_upm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c index b3cc427100a2..086426139173 100644 --- a/drivers/mtd/nand/raw/fsl_upm.c +++ b/drivers/mtd/nand/raw/fsl_upm.c @@ -235,7 +235,7 @@ static int fun_probe(struct platform_device *ofdev) return 0; } -static int fun_remove(struct platform_device *ofdev) +static void fun_remove(struct platform_device *ofdev) { struct fsl_upm_nand *fun = dev_get_drvdata(&ofdev->dev); struct nand_chip *chip = &fun->chip; @@ -245,8 +245,6 @@ static int fun_remove(struct platform_device *ofdev) ret = mtd_device_unregister(mtd); WARN_ON(ret); nand_cleanup(chip); - - return 0; } static const struct of_device_id of_fun_match[] = { @@ -261,7 +259,7 @@ static struct platform_driver of_fun_driver = { .of_match_table = of_fun_match, }, .probe = fun_probe, - .remove = fun_remove, + .remove_new = fun_remove, }; module_platform_driver(of_fun_driver); From patchwork Sat Apr 1 16:19:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764085 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=JHO/Pgse; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8B02dvz1yZG for ; Sun, 2 Apr 2023 02:21:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XUn5R73J90ShKTV82DrzCsJApFjiDIAOLpqmmKIjqYI=; b=JHO/PgsecmoFjQ xn+h7OpDTGjXiqM40QhKzMKLQGM7Hajf5BNsqXzP7FoxDKxunt5pZMoNCBChsigQBrsmKaKnC2HrJ O83V9FNFaH3HSCtCTmE7EFWkCigPvJvlq85zzynVpgEnVWJlwx/dMguExsanw+fsfHIxLwwUlFPeO QTcB3t78nJOGbYkIHV00VFPBZnhQf0HB100b83/8/Hzh7bEPGxcLrQuCc4aRDY0+i3s5nPWV9jPSQ xQ0xiPoOB9bVUD2gKOT0oMo7lNaTR0tl/j8Z3uIEPQZ7QMSZn4jphEnZxB0SnVccyVE60XpF9CS5V wxXFI849rMeegNe2lrkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxp-00AsNl-1W; Sat, 01 Apr 2023 16:20:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9G-0Y for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxH-0008Fc-Fx; Sat, 01 Apr 2023 18:19:51 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxG-008GQk-JS; Sat, 01 Apr 2023 18:19:50 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxF-009kg5-K9; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 16/49] mtd: rawnand: fsmc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:05 +0200 Message-Id: <20230401161938.2503204-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1769; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=vObKBhmsgafU84zWNgN/mJ2oBdY9JTjl+5IEs4QUJ/w=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkC7JpAwVir9GvL+9NLFwLEhooOFUkWe9zu0 X7myerF1e2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZAgAKCRCPgPtYfRL+ TrlbB/910Vh/RtFd3Oa7uEghclq0vV7m/FH1inyisEX6s1RZcKm3iFYULF79LbdcDCtmcxMJO7r vy/EV6BYBYJauDrpRz36jncdEWLEFsCdvba5vj2ce9UWsoJaZBTvNPYP+cb3KBpe0GhzqDxHzKV +hSLOVD4OzkhnUOABlkX6Aez5o7LgZiFZUHwZjeAYAEWM/fWZKQ7TFEbJq0cPgboJtyZtZswcqf HWOQP6tmp3YjQZ5eA4yE/36WsHf+ilJGHZMenmcsdgMI32EI9Z4Wv7zKk3J12Yxf4qYPbx227V5 LS9h0yfWe6UJw3XkrqWb7k31eK7tV2OJGFSn3ebu6hyYhh+j X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_234103_26A98394 X-CRM114-Status: GOOD ( 16.75 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/fsmc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/fsmc_nand.c b/drivers/mtd/nand/raw/fsmc_nand.c index 6b2bda815b88..d57867089079 100644 --- a/drivers/mtd/nand/raw/fsmc_nand.c +++ b/drivers/mtd/nand/raw/fsmc_nand.c @@ -1165,7 +1165,7 @@ static int __init fsmc_nand_probe(struct platform_device *pdev) /* * Clean up routine */ -static int fsmc_nand_remove(struct platform_device *pdev) +static void fsmc_nand_remove(struct platform_device *pdev) { struct fsmc_nand_data *host = platform_get_drvdata(pdev); @@ -1184,8 +1184,6 @@ static int fsmc_nand_remove(struct platform_device *pdev) } clk_disable_unprepare(host->clk); } - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1224,7 +1222,7 @@ static const struct of_device_id fsmc_nand_id_table[] = { MODULE_DEVICE_TABLE(of, fsmc_nand_id_table); static struct platform_driver fsmc_nand_driver = { - .remove = fsmc_nand_remove, + .remove_new = fsmc_nand_remove, .driver = { .name = "fsmc-nand", .of_match_table = fsmc_nand_id_table, From patchwork Sat Apr 1 16:19:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764094 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=b0DU2xSz; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=NuZert1l; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8W21ZYz1yY8 for ; Sun, 2 Apr 2023 02:21:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bcf8BZOEZqMPelC2JVwPn4uxwxS97+alV8xRmIrXjKQ=; b=b0DU2xSzFVBvV6 Henq6h9jZIq3ICIamY9L46Gu0fRoBSVMm64r7iPx/z4D3NnnHv69p9n8Cqw/z/UWbvRdwBGPbhGtA GnZVRxIWxijCpp9BncPAqhm+BgDYZnWnmhE1/Dm99nD+I59e988MNHQGYX3/1SOivUH9r0kufzAzi /dwoYuYS7aLh/TGUN7Iw9jB92IlcyrP49JSVMnbYwE+6h7fpHwAFotP73k1JQt6alxVoZW5YWt2Po IzrOOGaqboybMUpQLqeo94v6elhq1KA5xU4NTZi5eiWy5CjJeU9UnHpnnYQvwoNZxIkouW7u3D5sn MN0fZgVGZIW/x2UxCjAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyL-00Asg2-0v; Sat, 01 Apr 2023 16:20:57 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxd-00AsHc-1v for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=2GBW08o9sTvlTKfiDQpR1H3c6dpyS4I0ZoJMTPm2OzM=; b=NuZert1lmm6ucUCoCB05UcygZ7 sWjFg1SPyW9HJlBv1TfXk3l8VkFj9STcYDbkeZkokCmVgg1OyvT1KmFSMLqim2beojy8Z6+tWri6f fBduuYN1D/AMtoD2l1DhGcAmapoa8QhP3CZqNO2xKfm8/6JwgEQG3mDJSIsZ1uaChxOGhM+hpSJLc 93m6EKYq90nnVUmA3m93zJEl3604p+7XETx16iI/ODFdq9Nm7TxQhRRW/nYN/YZ6HqdUe5d8LFnVQ GRm0SZ/e+h25x/vcyofw4MLf5T4SfUeJWToWOZ8ml78Yiyg+fGCY1tyHt1mjsSqFQx6bAqkekvFHf fClCbCRA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKn-2c for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008Iv-HG; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GR5-JB; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxF-009kg8-Q5; Sat, 01 Apr 2023 18:19:49 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 17/49] mtd: rawnand: gpio: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:06 +0200 Message-Id: <20230401161938.2503204-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1905; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Qa0UNc0ZLq5BiHzyZQHe7oOtRkhVAwb/C37f8QKiCIg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkDDoqKcvCvM36bnCMSmTLzMEL9FaZobvqbk HnwgOPymZyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZAwAKCRCPgPtYfRL+ TkkcB/9PL5+WTs93Q17vScnxfBpWbznl+xUvpL8jGLwvbHdet19/2n3z0llWMcQI6AsNixAuvsr 4evR4K+aoIieWmTdJaIzSE55RZqsOsS1nmdokBIQrOE2ir6cO2JMIFG7iF24H9ESwzmekrWCDn4 HhtfG/Mu8vHzMTFyxXqlLxY8xUgMQW7nr5lO3JHk41XoRfZ8GfPRMv9lq59lAo2PvOV/RrsxQSK 8voa6kst0BaPzo0V6uf0SqvNt3XO4s3zOp7IJHnSuzJo8FJhJMAFIGpv4WJk/DnMY211PWzNINj cSoqspa/BvE5KJE17diR5YynArdFWTbcNbw1Rcaz+kUtpPV2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_094039_F625ACA4 X-CRM114-Status: GOOD ( 16.06 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/gpio.c b/drivers/mtd/nand/raw/gpio.c index dcf28cff760d..d6cc2cb65214 100644 --- a/drivers/mtd/nand/raw/gpio.c +++ b/drivers/mtd/nand/raw/gpio.c @@ -265,7 +265,7 @@ gpio_nand_get_io_sync(struct platform_device *pdev) return platform_get_resource(pdev, IORESOURCE_MEM, 1); } -static int gpio_nand_remove(struct platform_device *pdev) +static void gpio_nand_remove(struct platform_device *pdev) { struct gpiomtd *gpiomtd = platform_get_drvdata(pdev); struct nand_chip *chip = &gpiomtd->nand_chip; @@ -280,8 +280,6 @@ static int gpio_nand_remove(struct platform_device *pdev) gpiod_set_value(gpiomtd->nwp, 0); if (gpiomtd->nce && !IS_ERR(gpiomtd->nce)) gpiod_set_value(gpiomtd->nce, 0); - - return 0; } static int gpio_nand_probe(struct platform_device *pdev) @@ -394,7 +392,7 @@ static int gpio_nand_probe(struct platform_device *pdev) static struct platform_driver gpio_nand_driver = { .probe = gpio_nand_probe, - .remove = gpio_nand_remove, + .remove_new = gpio_nand_remove, .driver = { .name = "gpio-nand", .of_match_table = of_match_ptr(gpio_nand_id_table), From patchwork Sat Apr 1 16:19:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764099 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kPAeUzZo; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=bH5Z+GF/; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9060W6z1yY8 for ; Sun, 2 Apr 2023 02:21:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y+t6cWT83TznZyeDyWZv+6QQHvpKbuvVMUqhb6fM6bo=; b=kPAeUzZorVBi3A 2dlY/675C96PrXDBtxEm0y8Br3Pket4/tlv7dvD6GCDSR4vTfBG1/2mQqFPeORh0BgZRPegkzTf3f Yc3tUDBSErsJAgNJP4aaNst4YdXEp1iJ5UiyrQnyViZmTAtdH1By4bs3uDSyLMRt5W/Qgwk57dL3w 5qfizxCk/y3gkk/2/J4Jwvk4fLzU/E0CiiwqEVIKdDoBdixahM2AHCgTDPnlLhC9z8BcyscbplLEz ceGkJi8Y5d+hNv+9i+Dcmgv5dEQaWpXLloZCJ1WJxW1Xj6Pc7SzDhrIdwPNCungktNqcYn6lDaOJh usY0TbdWT1lAFgRSQ7Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyq-00At65-2f; Sat, 01 Apr 2023 16:21:29 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxe-00AsIW-1g for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=XeoA3VXnYeL85qkIJ3C4q8nryJqrAD1lDdJN55Ny8eM=; b=bH5Z+GF/l+jpBnR1f5HnyXYUWZ yLya3Wp3Z/LpABaLIWVBk2Zphv90Btxte5082eMZ0LZYAyorM03t6boawJ8ah2IeUTB7aealTXiNH x1airFqL1Zk+1MQE29PxaJly4ZSYdsH7jN5+jGivjuEK4zmfk06L8mR6WMKNJ4obilUUZQ6vfNp47 FS6xDqvvW+IqxFzMF0hKflN32LndpKZtN9INSMKL29G81dRc4lek4csBdUh36YVUNwXGFiyOLAsoF wz3SGNW+oAUtj5rq+s/KAhxyDzar7i+77kxkygxunWd4txdOfC8PU6NFIzaHug6HO6/3NnYCKCK9T w1I5KjsA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DKq-0e for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008IJ-Ob; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GQx-GI; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgB-0V; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Han Xu , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 18/49] mtd: rawnand: gpmi: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:07 +0200 Message-Id: <20230401161938.2503204-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1808; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=I6EVSr6QGjL8lpfPKlM/3fhcolF1XVFCCRUURQirUmQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkEuJ3wIJOaK4fGO8lU70GEV7wfz1ww4Yfnm nKMVt+eyOCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZBAAKCRCPgPtYfRL+ To05CAC6UtwPrRzoXurRptFLYotS3M5Kil56Bdf1CCJmTqG4kBX6ubgsiSA/QMvUYHceB40ms9Z 4jemDbyLX7AqqQhH+8Ku3YJCqALI6LCkSyrg5y5SJazaU4/OZtp17GPj/vwgQNl5cpjeYntFI2w gltO5yM2tvyG2uDKmC92I1qlCkfR4DTPzbKUALDfvxgMV2c4kZ45IpaFvJFDDr+wPhYzA2xkFoZ PJAYigY9RcFzWklErD6iTKEP0oV0XWwnZosxC1+CMkyI3TWr1LKl/IIaoBWfpEobALztasBsH9l EZ0yoCtwc5guuXXxJsPDRolJDsN4958FAEplScKTVsyYKQmU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_343403_8F1E5AB6 X-CRM114-Status: GOOD ( 16.06 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index ada83344b0f9..500e7a28d2e4 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -2777,7 +2777,7 @@ static int gpmi_nand_probe(struct platform_device *pdev) return ret; } -static int gpmi_nand_remove(struct platform_device *pdev) +static void gpmi_nand_remove(struct platform_device *pdev) { struct gpmi_nand_data *this = platform_get_drvdata(pdev); struct nand_chip *chip = &this->nand; @@ -2791,7 +2791,6 @@ static int gpmi_nand_remove(struct platform_device *pdev) nand_cleanup(chip); gpmi_free_dma_buffer(this); release_resources(this); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2860,7 +2859,7 @@ static struct platform_driver gpmi_nand_driver = { .of_match_table = gpmi_nand_id_table, }, .probe = gpmi_nand_probe, - .remove = gpmi_nand_remove, + .remove_new = gpmi_nand_remove, }; module_platform_driver(gpmi_nand_driver); From patchwork Sat Apr 1 16:19:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764087 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kOKF9VSx; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8C1DlHz1yY8 for ; Sun, 2 Apr 2023 02:21:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aBX4KuB6rnJvJMe9uLa9RK3m5LJA6sezsNiGlxPU6cs=; b=kOKF9VSxGh6fNl Udx4bHrxgX5dw8Do965JoEexj8mmze2vLQkzZK4c0Tdq6xOgVteQEkXBqCPuIJ2cBKpqwHO3Sgwgu Yk2ldsu+y/SGZO/+pK7i8DkF09b6XVsGHRAJhBRxUJ2t949YKOmaBdnung1KFDEm8lH67LucT1kgY tey0VEgm5KMS8YQ3ZzECs5cUMtEhKQBB/ibyoczgnGJcGLoZp7v28mGfzwdEJysUNGdYRK4J3ZJGe nwPz2eKleMtmJojwFGDYrOXYKvzU11g9Xu3hQM1kb9qOxurpJ+Db9Pz1gRZja6bIcwPKZhiQg74YC ZVrrJiRjpxyp2n1nfjgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxm-00AsMF-0m; Sat, 01 Apr 2023 16:20:22 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9J-07 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008Ic-C4; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GQz-HG; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgF-7U; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 19/49] mtd: rawnand: hisi504: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:08 +0200 Message-Id: <20230401161938.2503204-20-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1750; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=h8KzG0qUANsFBO3MML34oItRa53SpBDKuXSmd1dfVzs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkKbW+23FNTo1YB000C/ol/uznYjrhjefjfu PF2LzAHgnyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZCgAKCRCPgPtYfRL+ TlOAB/9FjvEzimZ5MyccbAGNS8giH/4Kbmp3kdvxbbDDGQNRdz7FsczesyWDi8bNvkgdbc5c8VI MX1hBxMD/k5xnitqPqNmkd0Zq4l7prkJAk7NhR1n81U9Pmdf6hqbmkTlmXxdZIaCC7aY+fwRV6S p95ycHwxS8DSu0FuRdRLD/zWXgTy0jF42R44/26h0jdS+Xj4mEq+GyOSU7FvvUt+NJ8rQ0ambAH Lt8ebFqF0cDvFQ+Am42wv3rqhCFvTBoEYDNshNhoDkxp9GTE2yJ7d3sAK/sIlxqQ/+cH5k1V6S0 gsFj3xNqb8WH5X6lCJg65ROEpydMzis+WmC0kGGJoJuewPkY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_098934_296B4DF1 X-CRM114-Status: GOOD ( 15.84 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/hisi504_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/hisi504_nand.c b/drivers/mtd/nand/raw/hisi504_nand.c index c74f6b2192fc..fe291a2e5c77 100644 --- a/drivers/mtd/nand/raw/hisi504_nand.c +++ b/drivers/mtd/nand/raw/hisi504_nand.c @@ -798,7 +798,7 @@ static int hisi_nfc_probe(struct platform_device *pdev) return 0; } -static int hisi_nfc_remove(struct platform_device *pdev) +static void hisi_nfc_remove(struct platform_device *pdev) { struct hinfc_host *host = platform_get_drvdata(pdev); struct nand_chip *chip = &host->chip; @@ -807,8 +807,6 @@ static int hisi_nfc_remove(struct platform_device *pdev) ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); nand_cleanup(chip); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -860,7 +858,7 @@ static struct platform_driver hisi_nfc_driver = { .pm = &hisi_nfc_pm_ops, }, .probe = hisi_nfc_probe, - .remove = hisi_nfc_remove, + .remove_new = hisi_nfc_remove, }; module_platform_driver(hisi_nfc_driver); From patchwork Sat Apr 1 16:19:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764123 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=eNvdVzYn; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=izzfxGsh; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXj16b9z1yY8 for ; Sun, 2 Apr 2023 02:39:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vGWNCarJ7On1NAaPPvMk6/nDaBC8GN4tQ40OyoHWxIw=; b=eNvdVzYnRl4Bgx 2JObs77AjAwQnF+tkOEXWcYivv5+K0Wb5BwBJyyd2mmgdfW+OF8BZxvVFedMf47mSiYlreqHtQE6r kTjQnodRsQvBn3Kg4jyHiVq/J9FbZTLb6zSBFPQ0ibJhV3vsXYt21oG17MFmrMo+9tQiKHufhmD5w TCCdhAVf7UGtaeR416A+LgsV/21q/rsuS5cwNbyMjh1jvjaWn7U2n6dl+Pa7cFraF1EDdJ/3jPVvt ADEVhevEF6cZBMiRdGG0FvahIYXY+8Nhk2CsQkAyHjwzKO+M6ZPRy5THvkERaqgZh1aoAlmHOCwm3 GIbRYCYUlmQ2dDNwVXlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieFI-00AxFG-0K; Sat, 01 Apr 2023 16:38:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEQ-00AwRk-0v for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=NkQmT0MtYuhSZ/lqLaAtv0/txXMGMP/IWLxZlzja2y0=; b=izzfxGshkAMs8fKtzZ1ayXh9ah kPek5HSf0oS/FIvF8Mh+tXvRPmweRV+l7plTK5LT5a3VVTxqkO3O3O6E7gjnmKhZLwhswTSJTJlD4 GQlCiDlJz4ZwZhsRf+g3qd01fKL8jxYSSo5H0cbqsbgDyh6AMjVcA2606U9mCoDC77vPIBtrkjMn4 43ru9EE+C3I8hgwDOoEqCzf8SgRmBgLLWVAaV87teuJ088nbGHPwnP5QoYv+8WMp66gaGPp4+ULwj f+nhEQgbN5379wwfXo6+Xzmli2LVSlEX0BkI864IMXE/ndS+Dgf7GtSuTYcNe0wzHp9HRI8JUaTTv tnBlS8Tg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYO1-RS for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:05 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008J6-HP; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GRB-KD; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgK-DH; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Harvey Hunt , Paul Cercueil , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-mips@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 20/49] mtd: rawnand: ingenic: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:09 +0200 Message-Id: <20230401161938.2503204-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wcjtx8KlaSUvzq2Bnb9sgvoi7LKE1iNvYAl9n41L3Oo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkQfxkqOIajMiniSiCExT7JGOcXyLx06eRkg c7WSGy37MyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZEAAKCRCPgPtYfRL+ TtWkB/9rXtvGRYkvAsfdnUSBj39s9dz0fLhSkpeHxEHVVVSMFVxjwKAKBryDM/hltnbIAtdjwVu CuFuXT2Mx+XmdEDcI0/8ZZyZzs0QbDe4000pWiLQqBxnXdV9t4guJY5DTFGr2zuluPMtz8tJDJa 2cEH6NMoRTGYMThT5387I2P56tjDOKok7q9rD0D7P4aLbsdSDJj25k6aXyPYyBvStSTcDn0Zv2x 7TXNvSCqd4ZgrdlNTo4m0SoyXUhRRc7PBsty565ZHqXdq9KjHT9N4SSQJ60msdM8w3ssKct8dEO TWNUF6oAqGHb93Yk1gZ2yWxwIIwQg9Ed81aMXA34LKJ0+R2R X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172002_968039_B72D1276 X-CRM114-Status: GOOD ( 12.93 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Paul Cercueil Reviewed-by: Philippe Mathieu-Daudé --- drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c index ff26c10f295d..b9f135297aa0 100644 --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c @@ -522,7 +522,7 @@ static int ingenic_nand_probe(struct platform_device *pdev) return 0; } -static int ingenic_nand_remove(struct platform_device *pdev) +static void ingenic_nand_remove(struct platform_device *pdev) { struct ingenic_nfc *nfc = platform_get_drvdata(pdev); @@ -530,8 +530,6 @@ static int ingenic_nand_remove(struct platform_device *pdev) ingenic_ecc_release(nfc->ecc); ingenic_nand_cleanup_chips(nfc); - - return 0; } static const struct jz_soc_info jz4740_soc_info = { @@ -564,7 +562,7 @@ MODULE_DEVICE_TABLE(of, ingenic_nand_dt_match); static struct platform_driver ingenic_nand_driver = { .probe = ingenic_nand_probe, - .remove = ingenic_nand_remove, + .remove_new = ingenic_nand_remove, .driver = { .name = DRV_NAME, .of_match_table = ingenic_nand_dt_match, From patchwork Sat Apr 1 16:19:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764079 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zXsDrXjS; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=qRf72L8L; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj865hjHz1yZG for ; Sun, 2 Apr 2023 02:21:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Ox8KJRBPDHTPkRAUiY8zaHXN4/0LxrUUlRAabY6zwc=; b=zXsDrXjS9LtU1E WmrHiBHzJlXTfLrCtLGTblNajxpwcEY78n4yRe11ulynwH5MLxDZojX+F0Pk6UBmCxOmVG3oqZ1ix grhNUnOdynOYb8yQCfcYKxM8mzEnQDLjba6zin+gxNmwAZwQhYJ07d+THg8xCgayQ+mR9H/5G3w/X eEE7EadVCwcuHQxAnTqcIqymT5rR7lz4ltaoyZijQjtjlRZSfhOV8F52ldYjmcOdz4BdA8rkQh6tP VJRrtCYQPpZorv1dv92Mrn5vNPuF93itmZIL9hvJg2d8tiWkxc12Vo9mlvvIJx6ezPBmLynIlBn7h fExLdLb2V2Z3vHQHI/KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxn-00AsN2-2k; Sat, 01 Apr 2023 16:20:23 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxb-00AsGV-2l for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=7NGiJ81IrYLn/swek120Jnkdjqchm2Fjao1ggs2HpR8=; b=qRf72L8L9xeziN+GPoDyOWNQWN qhfZU4f8gE0YNfkdxYKeMkcTcZz4hUfhxfW6p3SlSqQzKVqqf/kIB1fSsmnIdt6Uk1gb6gMHahVK2 IqXCGGeClPQDggAx6WQ4p/qQInXJJKIvYpSOZMzLI0ST80tw/pRa9qwnWrWiaFo7PdhN0LNzVMHIG I26oYf8jvuKwnx/L16KGUXJYoYi3igXRta1PTYyb5KE0sOIbZ3JbRXCwEJY0o7zPsnd0laM6OqiMR yFxG6qWiTXJlgdZH0q6rJ4p7j45J8A+1wfbkpJJMVsaVOLR9cjUo1GGq7SQcqIclzB0AimuF8mWVP ZKMl+7BQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKv-1j for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008Ib-RM; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GR0-Hl; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgO-JY; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Martin Blumenstingl , Yang Yingliang Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 21/49] mtd: rawnand: intel: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:10 +0200 Message-Id: <20230401161938.2503204-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1879; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=fLR/Y8m4G0IqzpSPFOMpcGWek4i+WvFtu6lKjj+Ive8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkWFuhcoX4heRZmiJs/e9xqg+lSJZJnBVELz +hCHtt3PQCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZFgAKCRCPgPtYfRL+ TqYJCACFLSKf6YwAy9aD+0bHyVf/4M3y4muobC073ZwMfodzdjxvLU/NDA7vrTkODi3Xz2cedb+ 7533Lzek8vsY5MsWiXzl32pVs/qYqCTZFrk+US2CBp918qCYBpPvP1jLfP1ZX3O3Xt+ejhHzo1c Lw9ei0lxbXiVL4CdCdeWvzoLCk9Thdha3RV+tvdI6471TddL8URbZ6z2Igr6kbl/yUVAB+koFdu YmU0Q0Kk4RpLX6e2lHSZzBXRhk4CBvLu/RPFCTzP7FFUtwkeWNQwbjra4hVKkiNXh16h2E+6Ffi Wsaj60ilrWf7ovHFC3QM8sUpR/ovrAN++OH7Jm+WxIJV9LM0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_884681_EA549C22 X-CRM114-Status: GOOD ( 16.21 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 6f4cea81f97c..a9909eb08124 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -706,7 +706,7 @@ static int ebu_nand_probe(struct platform_device *pdev) return ret; } -static int ebu_nand_remove(struct platform_device *pdev) +static void ebu_nand_remove(struct platform_device *pdev) { struct ebu_nand_controller *ebu_host = platform_get_drvdata(pdev); int ret; @@ -717,8 +717,6 @@ static int ebu_nand_remove(struct platform_device *pdev) ebu_nand_disable(&ebu_host->chip); ebu_dma_cleanup(ebu_host); clk_disable_unprepare(ebu_host->clk); - - return 0; } static const struct of_device_id ebu_nand_match[] = { @@ -729,7 +727,7 @@ MODULE_DEVICE_TABLE(of, ebu_nand_match); static struct platform_driver ebu_nand_driver = { .probe = ebu_nand_probe, - .remove = ebu_nand_remove, + .remove_new = ebu_nand_remove, .driver = { .name = "intel-nand-controller", .of_match_table = ebu_nand_match, From patchwork Sat Apr 1 16:19:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764083 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sYpW2wdX; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=hWccJAjA; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj896Jr3z1yZB for ; Sun, 2 Apr 2023 02:21:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dq6+3cLPH3RYIhypk1n7ILUuIVK/bZDYjZW5lX261nc=; b=sYpW2wdXAEHsVA 8iCp9LW+d+Vp+scmuSTCBVRGns5pDQ4lj1uffu/TZn/4NKO0LIaNUd8qXnfb/0sySK2CcYbzgDs7Q LOUng4Nc8cZzL898+R4iVUyg/4SAzTF9UShCl6K4cCZXFLX0jZeeFKUtFDVRFtr7HZYWHDhrB/qyc zy2jpEgK3Y18RQJn2UWAzjLI7tO5Pryzyl0fzhCpGbOls2bvTeFIFZFYTBEECuDXPoTr0O1Fb+qAp qw5B1mLcdQJ5lhUODAiNgxFXjpMbCcUJ5n3Bp2UBW3YTS92dtuEqJ8Jmj5TUknt9drnke2BqS1EQj GnjT09jPT/wI1dDXAN4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxn-00AsMd-0A; Sat, 01 Apr 2023 16:20:23 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxb-00AsFu-02 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=82OGQX4FQHKXC/0gh6rSGyigQm/ixNj7n6g/PqGRZFc=; b=hWccJAjAyD0Qyjx0+EgoPdEn0d OFDWMJNJt8N+9LrnBYdEzU+jzMamKOjjSwb+Tn9YORQkl8d2ojLmbO5424yvdYWJkf6bQ+0I4Zr7V 5lQLX2Lm2LwRizajZopNwQlyxNt5Uobx1mjPVXwdzNBI26kwyNAhBxwgYRlgN4sehC11454R3DyBQ A2wqWchq4k2pBOXNldhAkI3YTqgDAZLaL+gX7JCzM4M6vP/TDOGiQJxTx4H8YCNFqc7jV9ztYBhcq mtEERMyKRYDVpgY+32PEyI+bie42NIRvJ7vtSTIEzUx8kanWIVeZVFrdFV0PlGLMNlzvEGWJmk9nP F3OssBbg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKx-1G for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008JG-Jd; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GRD-L5; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgS-QD; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Vladimir Zapolskiy , Geert Uytterhoeven , Dmitry Torokhov Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 22/49] mtd: rawnand: lpc32xx_mlc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:11 +0200 Message-Id: <20230401161938.2503204-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1879; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=TWFefpDxHWfkuMQsZUU/YYnQA1Ncz9g/YAZzkYUP7N4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkd8KJ2FC0m02q7GglRFellH7wX4OKY4WkZK fheCZgA7i+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZHQAKCRCPgPtYfRL+ TvECCACow5b8t+Hq5gDTf6e+tnBdhSOgrsnyqDBhEiYEqa77h150Sgy1x+wfRmsH5/b88M4R4WD 8qKRyef2PAKE55ATKvBO68X0fZqz5iO85iunO+VG58sH+4wzGbUjrWcmrVENgZgWhPh55dDADA5 GJdr6qn9zRKR+b982z12byIVLj942NSZTVNwAlSNk2bHOE+gMJYR87UFWVze+MOxm9zqZYpECFX ROd4IiNuKolA0ytb9DVyK+t7Wl4rN2gzUgsavWjDRpcoI9z33qAlwPwwfaYKzc4zNexhTMWEhfQ h5XWkNg/OZ3N6f6vG+ofuD1Z3FiUEAy4KKvcjf9M0Xb5boak X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_626945_54B03295 X-CRM114-Status: GOOD ( 16.28 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/lpc32xx_mlc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c index ae7f6429a5f6..b3136ae6f4e9 100644 --- a/drivers/mtd/nand/raw/lpc32xx_mlc.c +++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c @@ -827,7 +827,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) /* * Remove NAND device */ -static int lpc32xx_nand_remove(struct platform_device *pdev) +static void lpc32xx_nand_remove(struct platform_device *pdev) { struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); struct nand_chip *chip = &host->nand_chip; @@ -846,8 +846,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) lpc32xx_wp_enable(host); gpiod_put(host->wp_gpio); - - return 0; } static int lpc32xx_nand_resume(struct platform_device *pdev) @@ -889,7 +887,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match); static struct platform_driver lpc32xx_nand_driver = { .probe = lpc32xx_nand_probe, - .remove = lpc32xx_nand_remove, + .remove_new = lpc32xx_nand_remove, .resume = pm_ptr(lpc32xx_nand_resume), .suspend = pm_ptr(lpc32xx_nand_suspend), .driver = { From patchwork Sat Apr 1 16:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764084 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xyXIyqFG; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=GPoPtSeL; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8B24gXz1yZH for ; Sun, 2 Apr 2023 02:21:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DrPq9crYDKCAEFm08wMeuy6aQDcpkknC8O24nhb1Mjo=; b=xyXIyqFGgC5yTi HR/MZz9It5NdCJSm9LAvaMcS832E2LXnllKhtkdjC+GgKqOiWSONI5Crws1Dw9vopjYciVE1tRiDZ 1c47FD/c8j/WRNBQ/TeJ7NocofCvoSN/ZZ9FvYkYBsU5WNorqotFyKIhy1qq2rJVt55iOAmaINgyu oDRqVpEn2ETYbI2wsbP2FSauvVZmfgAPNL4J+VRcSuoI7arAt6gQEmaQXjMC3SFUH1fOwtm/L/hB0 mtyqqw+9FzgTDC/3+jOzyAzfL3bncNjbOJwF3Sw2uyGc7iZP1etXNcZ9N3Bgcnnn8INNVcmcMdrH/ /oqnODUEOgxS3TAl37pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxj-00AsKk-06; Sat, 01 Apr 2023 16:20:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxa-00AsFo-1r for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=0s7087k9+qYnF+2XxvnOQFOrdung0zyXRBTlUmz+j80=; b=GPoPtSeL97arH6mSb6CGXG8Gs+ KFSOFRlcVWRasIBmJOn67yOwIoLPQZ2wqhDaYP2XyE3pQB9pJfPctYO3xjl387dymAnjRUHboyPtb FIc2iwpuj1azYIcJNLHeBAqvZLt2BcY7k0ZwGwwr1L9CF8aJ0MfDmDvnDi5ATowQVkxn93wcFte8z hXhGF/ome6wgbXe4R95Tz/Q71oktxNRKTK1w+DBf47FEecUuxktUC6h8JG/wMpl8IcPXk6Me8z1/5 gbtbjvTwlYmhcWw6Qx8iNgr6/iGYbjGeEnAmSzrYUlShT27rnqa35HuGZRu5MrPc2nrvKeHn7QEK9 GL0VBnBA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKs-0x for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxJ-0008Lt-6h; Sat, 01 Apr 2023 18:19:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRL-4Z; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgV-2B; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Vladimir Zapolskiy , Geert Uytterhoeven , Dmitry Torokhov Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 23/49] mtd: rawnand: lpc32xx_slc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:12 +0200 Message-Id: <20230401161938.2503204-24-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1861; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UbNuXQQQ0KcBVxzTXxsiQ9ppdg24ns5eP5qhdM3pSMc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkjOoX2tn9StM5R7P/QaqUZ/q53dU5RYfwhc nxcaOCwwbSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZIwAKCRCPgPtYfRL+ Tqp9CACOW6nBWlTrLGkaBFcuz7IA2lDxG9WvCHr3IeR/PjNGixZKY5yt/BKvzDjUplRZD76ydop ZWCEbRbsiMNVvkQ1nC28vMyMDmNRLs8snNLwDnF8A6OfZvqCabcgZMKgBdgUX+3gIS1T79REaYt Hlk3bESCNim6lA2Dp6RZHn8zRWD7p+Ng1qMOQbWwaiQmqAGjEjstGuB7YeteDO7O60W8bMUddlq cf4ZkCzUK0TQHKrngtLwyuluawuZgsC0nXWSdEonXJ4Qa9pg9DKNSZU3oIYJ/l+gLpsCBXQu1LM IvwiT0u/EeyMSiWe5LnhMLqHAcz/zYik/TvDVdBT/nslK8e2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_539347_1573371C X-CRM114-Status: GOOD ( 15.63 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/lpc32xx_slc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c index 6918737346c9..3139b6107660 100644 --- a/drivers/mtd/nand/raw/lpc32xx_slc.c +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c @@ -946,7 +946,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) /* * Remove NAND device. */ -static int lpc32xx_nand_remove(struct platform_device *pdev) +static void lpc32xx_nand_remove(struct platform_device *pdev) { uint32_t tmp; struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); @@ -965,8 +965,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) clk_disable_unprepare(host->clk); lpc32xx_wp_enable(host); - - return 0; } static int lpc32xx_nand_resume(struct platform_device *pdev) @@ -1015,7 +1013,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match); static struct platform_driver lpc32xx_nand_driver = { .probe = lpc32xx_nand_probe, - .remove = lpc32xx_nand_remove, + .remove_new = lpc32xx_nand_remove, .resume = pm_ptr(lpc32xx_nand_resume), .suspend = pm_ptr(lpc32xx_nand_suspend), .driver = { From patchwork Sat Apr 1 16:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764101 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nEAfq5pG; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=kq91fkVb; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9D1PWLz1yZB for ; Sun, 2 Apr 2023 02:22:08 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gBawTKemVZevQxgtAlOdEOynkn7W8kjl90nRR3gh+DI=; b=nEAfq5pGcNufOZ dRk5SnKW0Or27VhBePHsKrxzHPOOgbT4iy04Q3T0ZuAjMJB2vzMu4Of8zYC1XX4gdn9Rh6pg+BxKV jqWmmwQBWu1dU7q2G23Z8WyHmCsg2PjnnEin3y3+tlJsilkUid4o8S8baoAhoJqZVgWSWPImM31ms Ce5A6/sHp5l9OAyS7URbSfx39ZrCmXMiml+MtgTDX1na1v8NkHHQOTPc2Oc1yOf7dFTd77KFfbkem i41nby7dTFWxAOWPlZCmmDkArNA0eHOZLkYNn9B9Rzg66vxxb6pFw1sSfvcsniiLGRChHOFA/ycPc b9cRR3UdpYazbQm6at7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyy-00AtDt-2J; Sat, 01 Apr 2023 16:21:36 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxf-00AsIx-0c for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=U1ZVdiFEE2IcIgO9RpwX5XO4FLEKO9wpt6OXzQrcZGY=; b=kq91fkVbz7UKJmoTjTzCGsALYQ nfNKLhYTW9WC/I2EE4CHXMOpl1O+Oqc7lCP8U1Hvre4UML8hVOpQ37UqyOVpgxOsdXRsI9bRLbnLV wSDyKSFAEmQ8SEYubd22kE16ccOQCBDsSEohZzNZhDmjeBX/ZkuocKrimeCup3w0dW3BSND0ERIKI SK84npq6IMCrvO42+zOcDw3hx6poS51Mf1Bynxh9HBf221H45O8UZEP4CezIPpi4iQtsAZRflfxG7 lpcCqhhXS0WkDAZfxfjlHsO/+/AdN4N7JD4bmgTQoukEUM6BrZjb0ffQgSZneyjimn0uUR3hXT8aE MmdvU6Zw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DKp-0n for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxJ-0008MN-KG; Sat, 01 Apr 2023 18:19:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRP-7g; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgY-8x; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 24/49] mtd: rawnand: marvell: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:13 +0200 Message-Id: <20230401161938.2503204-25-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UH8mman7FpH1I+NbmK+dcyenV48z9RiSFvkc+mUbSUs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkk62BUOEslPj+Q3mC8dAUUueXFuyusv4PIo VObbrHvAMaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZJAAKCRCPgPtYfRL+ TpfDB/4wm1dWN/uAYfQuytapit1JR7K/uedI7C9hZ1yc2bRuJ5tv0dhfyy2rGj38FvuyZwiIgKe N7/H48uRcrfx0N4FnsiwoJiZR9iloQ8W4N08lDpwAcEhjrETmx9p1IYdPm39c/xiDtK71fbCQVl 7NTFHb+L/w2XgE8Y7EPVswLs0X7IZMz2/D2QaGN1QWbEOla5YOUEmCiy2bG304e+TF2XOoSM/lO HykZ8Bh8gMqqkGCFwevf2GrIoAwkBHkXpQO/DOWTsdymPFrWpeDjv2suisTiCR+Cly1w40M8qMi /3ql5TkD25AgvysYnt9D+JEXPhSO6TaUZaSOpkB/5kVFeyxm X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_534087_7952B966 X-CRM114-Status: GOOD ( 15.26 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/marvell_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 3034916d2e25..afb424579f0b 100644 --- a/drivers/mtd/nand/raw/marvell_nand.c +++ b/drivers/mtd/nand/raw/marvell_nand.c @@ -3004,7 +3004,7 @@ static int marvell_nfc_probe(struct platform_device *pdev) return ret; } -static int marvell_nfc_remove(struct platform_device *pdev) +static void marvell_nfc_remove(struct platform_device *pdev) { struct marvell_nfc *nfc = platform_get_drvdata(pdev); @@ -3017,8 +3017,6 @@ static int marvell_nfc_remove(struct platform_device *pdev) clk_disable_unprepare(nfc->reg_clk); clk_disable_unprepare(nfc->core_clk); - - return 0; } static int __maybe_unused marvell_nfc_suspend(struct device *dev) @@ -3154,7 +3152,7 @@ static struct platform_driver marvell_nfc_driver = { }, .id_table = marvell_nfc_platform_ids, .probe = marvell_nfc_probe, - .remove = marvell_nfc_remove, + .remove_new = marvell_nfc_remove, }; module_platform_driver(marvell_nfc_driver); From patchwork Sat Apr 1 16:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764109 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lpewYN07; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Je30Q56f; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWj0mC8z1yY8 for ; Sun, 2 Apr 2023 02:38:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W97z1odyv6ZOCt+n4LE64bLSBi3ZH4VUtuh4YpZk9hA=; b=lpewYN077jSyG4 e5UQtHlv7G54hhVGt/FRljLnuLXxZh0A7ULpxK/8qvkB1zw9bHwfXAxClku8Fx/nTdCCynLyix+Ju vWkP57dfEjgoSoyzabCmPJI9L3swLVmvfRmumcGLAAKzH5GfZ1EvZDdF0z9U9aoCDMesjiYkPpG6f lLvOWmHAPfH1rKAUVbHFNWObWaN3BEm1F5SYJVYLeB3i86cO1cc/49xX4Vhc20ou7zHiPOAmrd6T9 cJt1kq+OwjYSq74O5dhMxjJddC2LHzjzJ/xnAz4xBpQ/o4Ogc54I/cDGe3VhxoqRhyFZMYyXcoC4h PCdp5hUFH5glbY3hT31g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEG-00AwSH-2V; Sat, 01 Apr 2023 16:37:24 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieED-00AwRk-2n for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=DLAmKykExcbO0JzUBYJlHYgvFIZhTW7HXMdbM8jxP00=; b=Je30Q56fqMRzqYrd5PuIFvvddW wdxyg2sLfJCxIlIqHnKs4npUACVWulzqcOI+f1erxQVm2Yj4DOykugWVWLWcYsenP0Z/C2iKTdz5H cuxAbaDO0LkcSFkCljWcYdTIvJjqR43oJUNFQ4OUBiSu4Faes+oDeY2pwk4uE9o0SaBqTyDJz1dei xUNrMQazQFW+Du8pAyPBZ8eNf3lO75e5JjmtcFoThmZC6odFFw2x+f5HdlPPujVJAxnwIJbf7laZB EIay6ZPXyEzvk1OZTuWn/Gp26jY65F4jnfAaG5wlC5w7Q1aB3bJhVKqTMWjxCV7jmUCnEUbqjKIO4 ZpSfUvQA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOC-Eo for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxJ-0008N9-PW; Sat, 01 Apr 2023 18:19:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRc-La; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgc-G9; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liang Yang , Miquel Raynal , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman Cc: Richard Weinberger , Jerome Brunet , Martin Blumenstingl , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 25/49] mtd: rawnand: meson: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:14 +0200 Message-Id: <20230401161938.2503204-26-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1569; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1PHui4ayscbjWOMu4Uq3reeTu+VKa/h2YMHVa3mMo4E=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNSNUOl7hP66SrrV2+lljt0Hb/xmVvatC+pN1NjO/oN tNZatqdjMYsDIxcDLJiiiz2jWsyrarkIjvX/rsMM4iVCWQKAxenAEykNYODoX17UEXF9pg3/Xa7 L92WelVlb8fmtq7FvPwTT3hqtXx2nHjAUu81ve3b7l4WzJt0xSRgUeTN/5vZeC4s2PmiMHWV0fb Q185bPpiJpbPWveUL8Qk2fryksHr/wV6tuBqt2WfktWPUdxXUtZ1W6TfaK5F3umXWzNlHX5wteb m8o6AgjH/Ru4Uuc4zsKmNTTVdv2SnxNu5W7NyXJ7eWtU+f+eaWdPpJ1efH5GUOzJE8njfxfUd85 5SC6gmbWzrK8nfrlNipGYequ6yUTdw5e/aG/PAol3V2Rd8Kqk5xrRDLt9qk9zVTPf+i1SaHMu9l z3o/O63+/SnGIj+bNfrunmSu1rl3N8cHn1xT9EZC518vAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_658736_57EB645C X-CRM114-Status: GOOD ( 12.60 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Martin Blumenstingl --- drivers/mtd/nand/raw/meson_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 5ee01231ac4c..24f1ad025cda 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -1434,20 +1434,18 @@ static int meson_nfc_probe(struct platform_device *pdev) return ret; } -static int meson_nfc_remove(struct platform_device *pdev) +static void meson_nfc_remove(struct platform_device *pdev) { struct meson_nfc *nfc = platform_get_drvdata(pdev); meson_nfc_nand_chip_cleanup(nfc); meson_nfc_disable_clk(nfc); - - return 0; } static struct platform_driver meson_nfc_driver = { .probe = meson_nfc_probe, - .remove = meson_nfc_remove, + .remove_new = meson_nfc_remove, .driver = { .name = "meson-nand", .of_match_table = meson_nfc_id_table, From patchwork Sat Apr 1 16:19:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764090 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZSFYa/b5; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8J441Xz1yY8 for ; Sun, 2 Apr 2023 02:21:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=seXNMmH3WPfGOPzca0K8KhPoYfHPvk959C8S5paCbhQ=; b=ZSFYa/b55lwqBp hws4LCDNSh2NuVgiAjRhSJR1sciZzgG+NjF2n6C1llZ6HiPD7BFBatU7QSQ/3wsblSpAdRoR9pizC 6kw4KLRQZ1gU8QbUW7VhV0bkpRFeY5rDL2tISvo2MtsnBbrheNRLuG4dkciAQA3+GLiY/TJh0Kw+c 4gQAfyWTca/Ao8PDfePM36IubmdWeOZItlXefAkomM+X3mUIGWudeYiI3j60U6NYQ+yh8zRgx3xN5 +D2bpxpBJFyGTzfME+xagfa/eHFUX1L5jYYi6UNAT284eSFjzn51bf8UeG9UEneOy/8VT6P/7Y/G0 WsoS3ADPMat3oYSk7yLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyC-00AsXY-0S; Sat, 01 Apr 2023 16:20:48 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00As9n-0T for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxJ-0008My-PK; Sat, 01 Apr 2023 18:19:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRV-H6; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgk-N2; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Christophe Leroy , Phil Edworthy Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 26/49] mtd: rawnand: mpc5121_nfc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:15 +0200 Message-Id: <20230401161938.2503204-27-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1819; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HHKBs+ztWbaNRbFQg/27JaTmEYNnysEvMJ9/PAQExiQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkmFXTn26zDrLiPe+3+6NktgHh9H2lKUtR+B roDK/oGw9SJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZJgAKCRCPgPtYfRL+ TrA+CAC5dAbqyTuQccLXX2vjaKYRQWFG3gDV79iIGx8gGKPW/AnhRxA3dAlHX3l6JCrUttMB5E7 qxbwE/lN03yQlHswDTic2gtrztelwxhxVBQhi24XNhNi/Dj+B6YEduEA2938ulWIBzdOveIiFH4 /K17o2u6doGzio6YdY5OULlwW1yT6tFdrUfVMhQpw+mWIzyVLn34nWpCPIYjkZoA23sG/KHowBB TKnr0k0/qRmoyZ+xCiDKuWUZRVxzhDmWprHVo9Uv0URLVUWfCsinIrHBNefTl2Bv5Lx9dD0fBid WgziUmjj0hgIElkBu2xs6+yU470as+kNvEYethb99UybJcrT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_226465_9896044D X-CRM114-Status: GOOD ( 16.73 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [85.220.165.71 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/mpc5121_nfc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/mpc5121_nfc.c b/drivers/mtd/nand/raw/mpc5121_nfc.c index f68349cb7824..ab05ee65702c 100644 --- a/drivers/mtd/nand/raw/mpc5121_nfc.c +++ b/drivers/mtd/nand/raw/mpc5121_nfc.c @@ -822,7 +822,7 @@ static int mpc5121_nfc_probe(struct platform_device *op) return retval; } -static int mpc5121_nfc_remove(struct platform_device *op) +static void mpc5121_nfc_remove(struct platform_device *op) { struct device *dev = &op->dev; struct mtd_info *mtd = dev_get_drvdata(dev); @@ -832,8 +832,6 @@ static int mpc5121_nfc_remove(struct platform_device *op) WARN_ON(ret); nand_cleanup(mtd_to_nand(mtd)); mpc5121_nfc_free(dev, mtd); - - return 0; } static const struct of_device_id mpc5121_nfc_match[] = { @@ -844,7 +842,7 @@ MODULE_DEVICE_TABLE(of, mpc5121_nfc_match); static struct platform_driver mpc5121_nfc_driver = { .probe = mpc5121_nfc_probe, - .remove = mpc5121_nfc_remove, + .remove_new = mpc5121_nfc_remove, .driver = { .name = DRV_NAME, .of_match_table = mpc5121_nfc_match, From patchwork Sat Apr 1 16:19:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764078 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EQkxs0t+; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=ooCwshVc; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj85321Bz1yY8 for ; Sun, 2 Apr 2023 02:21:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sj0K8Gkt+84C6k5l2/7J7+Qj2WKgus3+PIIcAUty5nM=; b=EQkxs0t+c53cDo 4QYKXxb6fQ+cZwSocoWvIkNeQvIS81ktIDFH1weQSD1REqKFUUfg8sfUriIkKu7x2R7utILdBcZIZ 2d54WnDjnkACjjaNJPjvKZYb68oS6TDbvyAju7k4HM79e8LL/y6XfjGVP+fTjVwmsP1Dl/9lHy4aT /oJDrytKCpnHFO7np7iOFXkHWXKuGWBJXfs9ByDH8Py5MkselGqKR9LXs0/OpBBD21B7yF4bHEHUH 2O+/LmTfgw63RUdXIvR6w/QMsRzdYc+7TiUKMg3r/qfX1AdlofAjP67OR7cYeK2ELdCk6doIAJAb3 7nOwKhDz2Z46GF4s+XBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxo-00AsNL-1z; Sat, 01 Apr 2023 16:20:24 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxb-00AsGW-2k for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=QPV9HRMY9LSg4JnVSIQdXFkTx1dU76Wmm+2iMaFj6x0=; b=ooCwshVcKEr2I/zNEUJPQHxcEj EbaROZnpfpUYbr1M2GOfs6pL5Ax7ZfTaBqpglAXi+qjcwRwVGYcKw4bgzFYvhS8k9gdvfHDvtODAW l1S9Fwg59rViFWhxI+hG225+l6zvIDvIIqKoB/9H7ZEDHCHsDa3AaAD55WuFYyRIwrB4mtOnCWEyn FrIL0WlloSl8jDIR+XjUS7Xok4iSEarhJU+B2YowO8LBdarEqndsW41MudjXp7CWtJ8Q3/CFsxCFY 9Qe8BZxCInUuso3gG7bVNn68n3qfoI/j94Yp54KV1u1IJIuVho/mOD0vlrleto+txL1m18kATsZUN srHRRRiA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKw-10 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxK-0008N8-Et; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRb-LS; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxH-009kgo-UZ; Sat, 01 Apr 2023 18:19:51 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Matthias Brugger , Chuanhong Guo Cc: Richard Weinberger , AngeloGioacchino Del Regno , linux-mtd@lists.infradead.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 27/49] mtd: rawnand: mtk: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:16 +0200 Message-Id: <20230401161938.2503204-28-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1773; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=e523s9jRh/S6cO5O42rYQ7Q8m7mrxZAiPiAi9ZUPEJY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkn1m1Rxg9dsGd5QzAc25K+CVSCtFVHxMxSh zGEnsX1zBGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZJwAKCRCPgPtYfRL+ TvvGB/4m1l2TIyVfqpOpyosZc+stZOgYdxdZzla9CBSL9m/qBQpJVmNFI3Civ5kIz4GHTJ4axJ1 62s8mhZe20HTIlWfR2BnsWJwOtuzP7+zTcyvcMUrnuSkgwLGA52AkTwmb9qSE8yNmnTD6S51B5l Vhu5A3KRb9dKcjMHVVH+Xi/RXeiBIYIyGtL3flPU+1fHGH3YvaZR9H+wXO4JIyzvgonmPZ5soDy B/ih5y2Sy4L9AsoPcNq1eU77VeQ8AGADEko7yjd2GYQ8p9UVAmYNd7Uq3b3nNfqpznndWHa7N2o TWd84Hb9UlR9s8Mpm1OtCHeNSFt1wcAWqYAxQHzd5DIa+NGC X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_646510_156BA14E X-CRM114-Status: GOOD ( 16.17 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/mtk_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c index d540454cbbdf..b2fa6b2074ab 100644 --- a/drivers/mtd/nand/raw/mtk_nand.c +++ b/drivers/mtd/nand/raw/mtk_nand.c @@ -1601,7 +1601,7 @@ static int mtk_nfc_probe(struct platform_device *pdev) return ret; } -static int mtk_nfc_remove(struct platform_device *pdev) +static void mtk_nfc_remove(struct platform_device *pdev) { struct mtk_nfc *nfc = platform_get_drvdata(pdev); struct mtk_nfc_nand_chip *mtk_chip; @@ -1620,8 +1620,6 @@ static int mtk_nfc_remove(struct platform_device *pdev) mtk_ecc_release(nfc->ecc); mtk_nfc_disable_clk(&nfc->clk); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1663,7 +1661,7 @@ static SIMPLE_DEV_PM_OPS(mtk_nfc_pm_ops, mtk_nfc_suspend, mtk_nfc_resume); static struct platform_driver mtk_nfc_driver = { .probe = mtk_nfc_probe, - .remove = mtk_nfc_remove, + .remove_new = mtk_nfc_remove, .driver = { .name = MTK_NAME, .of_match_table = mtk_nfc_id_table, From patchwork Sat Apr 1 16:19:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764129 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0Tpn6xmG; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=YRAPq4/x; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppkl001rpz1yYP for ; Sun, 2 Apr 2023 03:33:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0bzUaQiEwSc8NXx0Q8VSuyuzYvCX8BTcWWsfqGEujGs=; b=0Tpn6xmGndgjAy dKTP3oP9/LSIcS3ZU4RoqDTJv6zc/ele9Dugww2a4q5NHVeU6wlw/APINfeb5wRi+VD4nfR+GRrMQ Hmq68htM0VJAUM+uYqSU5NkPJ/ECaqEjBNx/rmfHem2CKxd6AeMPN24maAY7RbIbPsSfLDkz3j3iA bnYgi16lFRWREoWCtkjxcOQb/3Ev7d7dK5bMdgcfNZMLfjmBuGExyHy9ZaBCmYh99z4AGRWgTsFXm jzsAPNde5wB88+O1DT1lJVZ7y7BsiKvbnquzOBoxEpcfdw4EDqions2I4YO1EeGpKNsklsq8yt/C7 TmnO+233krQ/DIW/ltNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pif4k-00B2Pr-21; Sat, 01 Apr 2023 17:31:38 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxc-00AsHA-2f for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=9g2XiRb2pnd7KmX0ldCm1r7c3ccrsCXtiEohe3dK6Ys=; b=YRAPq4/xQWzYu9S4W1GKMt17mJ mdMXX9V9gjyope9rYVlPnPTqKyR2RJJy0klRW4qhSIB9OWz1j+VEiq+M6JjSf7obCW1OO12jIwOym MTrk0Oa6DTTaUNOAd/x6zykCCMkG/AfOiClnpEbexx5ULfygKeQvPUuxw9h2rqKLxBRH8pqqR2FBD vcJ8BqxILJUei6Zqd4DMLccqgPc9YPgRTZ59g06bTVfyggpUF4E2PnQqRMkOcMSA9tLtUu5Fe66iB 7qFMdN97nG6pkJTfP4PqXyK9PI7gWZIEEEE6eoewZ5kkLhKN7foCM7MumAUSUguUw4XfVECLnAo0E DFLG1AEw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKr-1e for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxK-0008NT-6E; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxI-008GRk-SJ; Sat, 01 Apr 2023 18:19:52 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxI-009kgr-5q; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 28/49] mtd: rawnand: mxc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:17 +0200 Message-Id: <20230401161938.2503204-29-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1739; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=e4xzjXYDfJ+j8bymws7/MFBHTs5gYDu3T17rMOhPFqo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkuo7wKq/dC8HZ2p2Nnddl0rATHBKXP80foQ IxkORnbMzOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZLgAKCRCPgPtYfRL+ TvzgB/9yQjk4eMNBRoW9TxCvZOT09JOOHUCBaduZhz09ey/Lp+U068wjqWj1DqbIvk+QXniEJr6 V16jBFRutztO5vbYwAjCQMVF91uvGc7Ebp0sYqb8n++vAaQo6MBfLzNwpwzv175FJTI7d/O4+2f KCFEy8TaCv6U2FU2DqIeJvZMQmwGJoIuxAixXLMr7mvWDfHUIF4JxrxgL2UfjfMycjWaAEGJpQN 8gI4bwVs0mKYice+YrPzZ2gVLoyu7DATKqIWnUND20NnC9JZUMXI5cdj0djdsO+x8Kn0F+SqQnD OtNUlP8bw4To7G62sXyPF4t7vaTmEE3NudujJQ3H1C8XBLTL X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_933086_109288D5 X-CRM114-Status: GOOD ( 15.82 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/mxc_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c index f6c96341b896..56c1046cc073 100644 --- a/drivers/mtd/nand/raw/mxc_nand.c +++ b/drivers/mtd/nand/raw/mxc_nand.c @@ -1831,7 +1831,7 @@ static int mxcnd_probe(struct platform_device *pdev) return err; } -static int mxcnd_remove(struct platform_device *pdev) +static void mxcnd_remove(struct platform_device *pdev) { struct mxc_nand_host *host = platform_get_drvdata(pdev); struct nand_chip *chip = &host->nand; @@ -1842,8 +1842,6 @@ static int mxcnd_remove(struct platform_device *pdev) nand_cleanup(chip); if (host->clk_act) clk_disable_unprepare(host->clk); - - return 0; } static struct platform_driver mxcnd_driver = { @@ -1852,7 +1850,7 @@ static struct platform_driver mxcnd_driver = { .of_match_table = mxcnd_dt_ids, }, .probe = mxcnd_probe, - .remove = mxcnd_remove, + .remove_new = mxcnd_remove, }; module_platform_driver(mxcnd_driver); From patchwork Sat Apr 1 16:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764104 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=fMiQ4kki; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=gdmgChvY; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9R0dGbz1yY8 for ; Sun, 2 Apr 2023 02:22:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kFBgulmdF1Jj9Awj0wgudBu0MCxwczECIVlTh1nj620=; b=fMiQ4kkiNZGgPJ doJ2BNL2fx6w0okvDE6yZO5uhxqyaxTIDQj9jQms16XS9p+KZEXkBOl0XagEHUCD0fKLBQygwg1V5 vs+4y/2FhOSknZ/cJOe289NMU8f/E3ofE3ZqhG7OQt6O35Mdn33mByBbckUJR6CWBQpYMbcpm8X1A BDkXnpM9aEe4CyhXL47I9ArYDyojdKnSz3hL2PxSlTuSv/PMjPAwpm5p85Mvjb8yE7rO0DWLeEvOk p+2olNxvoRF6zCMgfpciW1MCEGBpX9ONUllDpa6gBrq8TuylU6lxUCWl+dvdCFRBN+kAuJWpwPu5F DoNUanYOX1HsXkInpu3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidz8-00AtPX-2M; Sat, 01 Apr 2023 16:21:46 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxg-00AsJU-0V for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=PvIIyOgWTRJ/ZciFDr04PorRcSxoJ3RyFpQBQxFwan4=; b=gdmgChvY14OgzzoMs7CmLnN7Ga JUIMMj6ZwFc+luAa0LxewTf+WsVAwe7HsMUYpyjU9u/5ejV9x7qv4pp4ecVTa7JCvACEUm+tP9caX 94ijTN7+kWDk8TZCPzH4C2/0XSloBOlxxSE6klguh4iitp1GHgB98vc0Tx0vOvcoKIYwV/5El//5n Ih4UcXl+HkY/oQwizFunaZbeYpWkZ0VYgCrWZvv1Sn3CGxlWr2PnZNiV4AT8H4TJutUqgqpK1253Y 6+n2A2HIBIX4pKWLe5Xn8kt1nQ9TbI/WrpcWJNLs3Wqxz0D/ib62rCnGUqIEt/QVHMM0kL3xng/zW yRlmIMfw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DKo-14 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxK-0008Nj-AD; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxJ-008GRp-3x; Sat, 01 Apr 2023 18:19:53 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxI-009kgw-Bd; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 29/49] mtd: rawnand: mxic: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:18 +0200 Message-Id: <20230401161938.2503204-30-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1770; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rWPkYqoEydSYHk43eQLy3o1FwM6CRP1SaxcZbhcEOt0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkvxAwMTjlzxl5e/Lo/aYyDwbCiiDeaeyWOt nZ6UXAjodKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZLwAKCRCPgPtYfRL+ TncBB/oDqI9rby3kUJ5uf4k4YlV0zGefT6LlTjpE5julwHre+/93kY5WMwVn/ZOrY0t8zbzrBmW spDsLPEGV7+U7PHDo/BSzrPzoyOULf8sKHXiU4JwarNREkOcYdPii48XZ4j7AH+cufDXpadqANY giiL17O5U3OOGjkI/lwQmUBp7OvbtHLLfXcKNjzsIBH3mvm4fnDoRRtlYochm4I2996cn0j9HFc aomcXtFpJL6bYPYE89yEcoRgNlOUyq3ul1USFK2EJ7EKyRSMPIHwiHVpLHLJBkLSjcA3eDxs+57 dRUlMB6pW5eBM1q0cBdNC5DM+pkDuvAYvUm8nrv4SXSohme+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_729231_35A7161A X-CRM114-Status: GOOD ( 16.72 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/mxic_nand.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/mxic_nand.c b/drivers/mtd/nand/raw/mxic_nand.c index da1070993994..be8050e84b4f 100644 --- a/drivers/mtd/nand/raw/mxic_nand.c +++ b/drivers/mtd/nand/raw/mxic_nand.c @@ -553,7 +553,7 @@ static int mxic_nfc_probe(struct platform_device *pdev) return err; } -static int mxic_nfc_remove(struct platform_device *pdev) +static void mxic_nfc_remove(struct platform_device *pdev) { struct mxic_nand_ctlr *nfc = platform_get_drvdata(pdev); struct nand_chip *chip = &nfc->chip; @@ -564,7 +564,6 @@ static int mxic_nfc_remove(struct platform_device *pdev) nand_cleanup(chip); mxic_nfc_clk_disable(nfc); - return 0; } static const struct of_device_id mxic_nfc_of_ids[] = { @@ -575,7 +574,7 @@ MODULE_DEVICE_TABLE(of, mxic_nfc_of_ids); static struct platform_driver mxic_nfc_driver = { .probe = mxic_nfc_probe, - .remove = mxic_nfc_remove, + .remove_new = mxic_nfc_remove, .driver = { .name = "mxic-nfc", .of_match_table = mxic_nfc_of_ids, From patchwork Sat Apr 1 16:19:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764122 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lwddyxf1; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=ipJXGOcP; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXd6T6xz1yY8 for ; Sun, 2 Apr 2023 02:38:57 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MXiRMNcXI7QvhSsZLJ8tZPFVTFrH5U7o8WsrHlPrbKs=; b=lwddyxf1EHJ7qm DzUvkzupUNfOY2xsC/XIuz+RtHE3j8/gSPZrDoN+DnwjeBzcMt6P3Y+5nrQfRSfUZpLG8SxY5iSDN UDmt+YJ0U6knENcGl0amjlC5VYqHqi8h6Eep0Tcr47Va2aMRv/XdeBXL1INLIxkZsO6WUJ7XVBUZd VYOJpOuLtl9n2/2gKUYl4ufPybwRxqSKfKYnteWaZ0lKKsWJfMuH4BY2KtEttq0GjqUg1fi15rpkO kOppZRjrDQEZO55tl+yuBjpS4QGj1tpr01halFeW2xLnzQE/XuDrML4kuBHP/xRa2iwGHW7WQO5kE +fona8gUVJZDf91pUHkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieFG-00AxDo-2S; Sat, 01 Apr 2023 16:38:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEP-00AwRk-22 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=do9F7LZxhIo98Aj2uu/fm40T4OcRv2K3VmBX/SguUB0=; b=ipJXGOcPCG5MyQ0Mzf9SREdjOY qnuTes/aAA/iWBtSa38UhIuByw78DBdVcWHcCcpJO7ySbmXQYGJtSgec1oBb6CqSAOB2IqD9Nm8NB u2HDkVcx0OGYcaJ4fLM3z58M+gqHJQteOITMW2+wUe7oYafDSkz7dzzA4pnjIVrXGJP9We3INSPoQ fd8e1ztOZuFs21kUiSSSyVTTb9Zdbo1JAh8IqAqR9pGsjZh32X6cQu/BS3K2uktSahd7Z62xG5N6H NmXWCnekJy8jaDV19lTim0qVtmcMX+tYKgtmTFmriCFzSS8cTtwel/AkvvbXr/uA5cEvypgmVyPrw 0A91yp6w==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYO2-PH for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:05 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxK-0008Ph-Sk; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxJ-008GS0-VS; Sat, 01 Apr 2023 18:19:53 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxI-009kgz-JY; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 30/49] mtd: rawnand: ndfc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:19 +0200 Message-Id: <20230401161938.2503204-31-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1686; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ERgQG7Gi0NdKB61npZUy+7RZjzs3JxDpVBIvkTKvp98=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFk1U0YOeUztywFXXJ0xmbfnY4WKmH+EGlaCh rvxNcDtD2SJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZNQAKCRCPgPtYfRL+ TsbiCAC6bl1e+g7hViAoqNZT3itW0MwTcrHJ+3sfHTxdKpBbTr3LS5bcybzvWyOIjeWH1PnWEsn KfLN8CM8NURIa6SDhU/3HM5WOTL9RgbQVDKhHWhOoqYhv5bOZl1rDnz9l9UXzc1o9skbv5MJfy1 pVZH31t4u3l/Hkhm6OQsejRcdTAgriB0a5ie6r1AKND7p+/HCilITbhLxv68plVjJ5n7tgYmkue Jud1sUYfTkMyPkLmvN8cl0lFx8v3yIVPpKS7Jic+frI92bXvjnb8o50fz0aZMUfAEwHgo/h8WPr WyF86WKrQbWB1cAv0NMV0tU0U6sjELxfphQ+Wc0WUawyHT/M X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172002_908211_072FAF33 X-CRM114-Status: GOOD ( 12.74 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/ndfc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/ndfc.c b/drivers/mtd/nand/raw/ndfc.c index 338d6b1a189e..57f3db32122d 100644 --- a/drivers/mtd/nand/raw/ndfc.c +++ b/drivers/mtd/nand/raw/ndfc.c @@ -240,7 +240,7 @@ static int ndfc_probe(struct platform_device *ofdev) return 0; } -static int ndfc_remove(struct platform_device *ofdev) +static void ndfc_remove(struct platform_device *ofdev) { struct ndfc_controller *ndfc = dev_get_drvdata(&ofdev->dev); struct nand_chip *chip = &ndfc->chip; @@ -251,8 +251,6 @@ static int ndfc_remove(struct platform_device *ofdev) WARN_ON(ret); nand_cleanup(chip); kfree(mtd->name); - - return 0; } static const struct of_device_id ndfc_match[] = { @@ -267,7 +265,7 @@ static struct platform_driver ndfc_driver = { .of_match_table = ndfc_match, }, .probe = ndfc_probe, - .remove = ndfc_remove, + .remove_new = ndfc_remove, }; module_platform_driver(ndfc_driver); From patchwork Sat Apr 1 16:19:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764131 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=p1+s640H; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=aTWAn/tS; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppkl04rCbz1yZG for ; Sun, 2 Apr 2023 03:33:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2tC6NBMWXawnyZNsFQjKrjMWG90uxnaOcP0xZiG81xQ=; b=p1+s640HeWpiTy ISTIGl8fdR+QeH4H0MLnytWv/3qqTcr1o9vlP7ZYbBRQ+mD3F2fNO082DBkbG3m9xPLOVgNGVIvYC yXpCQJqWYGxIjb7dkmtUQPeOIwyChYndMfr+Mq7EGeUxGorittZ25yg2CAWMVgtROXR3S2VdBp++X /l/PLkoWsSHQLCzk9PdbENMSappQCvcwPDHoPpjipRjvIbgp3DYTy4YWOrRoKyBUSwq3O9Fxm0Byh ylxJzUmlDrBgA6BK1yhxZNAMCUqU++RpO3w8xbXn2sgg0+qtIiMWbB+f2e+r21cwJ6iHUFFdewRp8 oeNpblCMfG8i7elKiHFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pif4n-00B2QL-2J; Sat, 01 Apr 2023 17:31:41 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxd-00AsHa-1u for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=NCE/ldrxSa+FF6qnukQ2DHKY3ZdJE+sGfGdk1eIOhBo=; b=aTWAn/tSoAPtdVtUFAGdCUxWxp GYWluIRVAUmft8XRI73DfK4t+lAnwzL/M1SmMqs243Sp3+qfKZhGYgUUdgTt2+8oxEj2VwZmcpk1i 7p0QAPA+gUHEzerejJPaATgJ3ugIcFWCHE6xY2mLQM0Y+V0nnhnPMKCNhi3gZx8y5oqPBXDF1hb9d zVCkPzDvqdd6X6qe2BLqpXp+Gzn9Hs197DRbP0zzJhqWhwgZEmRvAx26ZUhD7UD5XyYDiZ6zKqykV 0NxUd6hto6gCUKCTIdpzeu0VQm1AaTwfjcd0YvFJD+jdHZ+WGG9HjvJ1oW6e2OU665xaBLt1glmzV mpAQrOGg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DKy-31 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxL-0008Pq-0d; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GS3-0p; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxI-009kh5-Pv; Sat, 01 Apr 2023 18:19:52 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 31/49] mtd: rawnand: omap2: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:20 +0200 Message-Id: <20230401161938.2503204-32-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=TjwsYyVXkVzqjG2vivAFKm41kuR5ZKJlPg0Vh5ce9Xw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFk2eS8BmfIUsjae7lovOqs/KE4sctEFcpuhD jsnTdErsNiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZNgAKCRCPgPtYfRL+ TgxDB/9P5lfFOlz9gSWDpu1e0hHgB8Sxwz0uFI0rklSMd69NOkDXXfVc9Q9B+V3ynogYMmt3o8g C5yuiLfLZF7+criDceHGQUIUP5561t79iEpurCoQdMvA29T8McJ96JSKo3KvsECMQrAzr9sSnNs +5WvTiJW4ViDwkHyuttKfd5CKYmug+gt+sBppv4iQuBG0ixrCqDYzNpyo4y1Jj2B5N/jA/INaWS C8a/eYcTrJPlv/a9A178tcfLqPawZmzXFYQ2OXjC4dKoIeIevlL/DAftkF13dxPq7VVu1m9RQzo kR817M0i94y/slVFighOFUuj7lh5292uS+qp398+mJg9h8NH X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_217616_C99D953C X-CRM114-Status: GOOD ( 17.10 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/omap2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c index 4a9f2b6c772d..db22b3af16d8 100644 --- a/drivers/mtd/nand/raw/omap2.c +++ b/drivers/mtd/nand/raw/omap2.c @@ -2273,7 +2273,7 @@ static int omap_nand_probe(struct platform_device *pdev) return err; } -static int omap_nand_remove(struct platform_device *pdev) +static void omap_nand_remove(struct platform_device *pdev) { struct mtd_info *mtd = platform_get_drvdata(pdev); struct nand_chip *nand_chip = mtd_to_nand(mtd); @@ -2285,7 +2285,6 @@ static int omap_nand_remove(struct platform_device *pdev) dma_release_channel(info->dma); WARN_ON(mtd_device_unregister(mtd)); nand_cleanup(nand_chip); - return 0; } /* omap_nand_ids defined in linux/platform_data/mtd-nand-omap2.h */ @@ -2293,7 +2292,7 @@ MODULE_DEVICE_TABLE(of, omap_nand_ids); static struct platform_driver omap_nand_driver = { .probe = omap_nand_probe, - .remove = omap_nand_remove, + .remove_new = omap_nand_remove, .driver = { .name = DRIVER_NAME, .of_match_table = omap_nand_ids, From patchwork Sat Apr 1 16:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764120 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=b6CSAOtT; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=sg993TZ8; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXW37Y8z1yY8 for ; Sun, 2 Apr 2023 02:38:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yZT5/f7XLLXFLCHJ+UctHuCXHEnNjS6p7wKjOrKTiZM=; b=b6CSAOtT+MJvKI 0TX4lnI+PEMs4Hfj6r+NwcRoc+kU6rL93zKtQXZmGHgwaUG61KTatJnLOdrj9q+RHqLlSM/EdbGLh pO4tynYaXUiw7P6YE1Sc/b+/5pWycFN2TCSevo4TqWftrmObDKCkcX5sBIRBZdD4goUMjqiSU3gwl e0IK3npvGjCZIuyvBOhirLZRGet+KPkJ1HU8F8lEePamgbNN6I5BWnJhnp3G9qN35vMxXMzigcKCg zsJ5fF1ZJ03GpngZBCggpRx3Z6LBEkj+Pc39p/fM0Ys3qx4YFTF6oQpfvDIi5p/ujy2mR0/9xOEKE xzi3pQT8v2TH5vZ2qR9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieFA-00Ax6i-11; Sat, 01 Apr 2023 16:38:20 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEO-00AwRk-2N for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=UJ4T/KfUDsDdf9tmeKn6HHIioht9qInU7rNyOQsws2g=; b=sg993TZ8pthqwgHsrJ6mCECnDJ GGeIizNd/sIUpqOqL0Jb6pARVeXI5NE1oxczG3tKxupxJ9ypkxQRG4x+oYQit/Ru1+BGvLtUcbyyO z4FL/fm09cQD+cv6tNlcsgLppA+xMyrUL9TtaeX2baliacGRwdzBjuHZvGBYRTbHdI2R9HDR99REw FopoS7rNEKSLQTuPGuSpPoTjZIxrGOU2EMxmUgWOjw6j3g88EEEbUpe9w5+PM2099pHYlPIcZB7wa GZ3dPvL4KoC0SCZ3IVWtrS1E2VckH/Rgw5RS0b36c0xCIYj71tmQLilho072U3Go0DHaQehPEdkKM k/xiaGgA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOA-CJ for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxK-0008Pm-Rt; Sat, 01 Apr 2023 18:19:54 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GS1-08; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxJ-009kh9-0O; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Roger Quadros Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 32/49] mtd: rawnand: omap_elm: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:21 +0200 Message-Id: <20230401161938.2503204-33-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=QK21oKBC4EcORQtoFTg+A4zhmU174bIn9nqdM2+firM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFk87fuvxNbvZZ6hgm3NBoqwUoQBwWMIrfOww Jtt1oKEKYeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZPAAKCRCPgPtYfRL+ TrRmCACqCl7WCRf8RCrnXPFIvsXOjpMc33TRUNPsmCr3GPWVkMkBlz/j4l6CLs/MYmHhUF102ud N769ujNtRvVHBMPTX876DfRuWMCqmH+Acfor3Ye6OfHZwg/xAXYlsnv5C9EiHlGyukI1YXK9pE4 iJ0aLW5XAHhjrUjisfjGnxEkfZyBSn+NfZ8eTKpWVmBK+Em2IswXCHe2+PET6d8m0Csduw6DKL2 1zsipR4tCQW/sAdkYYI6gtjZ+IL+pRmYg0BgWsCRPuV40UoANhHMz1jPoyuwU/2qWBS41C+tQ2M aw9mTzaeis4PUxEu/E7Aq1HWWzNOzqYPFBBsPiAbAEI/PHsx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_620162_75BEFA4D X-CRM114-Status: GOOD ( 12.33 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Roger Quadros --- drivers/mtd/nand/raw/omap_elm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c index 4796a48e1012..6e1eac6644a6 100644 --- a/drivers/mtd/nand/raw/omap_elm.c +++ b/drivers/mtd/nand/raw/omap_elm.c @@ -422,11 +422,10 @@ static int elm_probe(struct platform_device *pdev) return ret; } -static int elm_remove(struct platform_device *pdev) +static void elm_remove(struct platform_device *pdev) { pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -561,7 +560,7 @@ static struct platform_driver elm_driver = { .pm = &elm_pm_ops, }, .probe = elm_probe, - .remove = elm_remove, + .remove_new = elm_remove, }; module_platform_driver(elm_driver); From patchwork Sat Apr 1 16:19:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764121 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZYpwWEfT; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=oH2vw32Y; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXX1NHlz1yZB for ; Sun, 2 Apr 2023 02:38:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1HqEmC+mh0ZMjgSIqafs3VuZpSnDYL1xPiUZirIEHcU=; b=ZYpwWEfTY4dpsb gqC3LaLncBfQ8y4oh1AY4KUrCbpozE7+mUdX/ZwSU662GGiPXoAz5BqHWrHl5UPPUqrF9WPIZ3j+w /xx7cISmJ9nCreFpq40O1xdcZi7aF/soLngSdy+gCTn43Gk8sRiSWBjg3uQ6GF+E1V8X7z3SAJZaE E+DPCO6k86f51bzd79KcYr9kKE+f4Pe3oTCz5NVlTGtpOnq4caKzJI/Gdi1+I8gK520TWLk7IBuwB gYB1kSfLt9lZGkEgr7bM9jUcqXXHpYVEMTm4jfX0FQxjEfN7pNqlhAkCqx+0phvboegy/3OOr2ZSD ntJFOEbrmdI7AMEkhGBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieFE-00AxAB-0I; Sat, 01 Apr 2023 16:38:24 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEP-00AwRk-0p for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=du27Q0n/f1QePymWPzjyyEdCxXBBRCPBaY+ZxA+VYGY=; b=oH2vw32YrdHfC/wqM00efTMOcK KNwkNtllzzjq48sXbXUqbO8iVx2q0yq9g0NZp7hvtSFkfY9eOyfxmAxsBKgSYAm5DJlUxz8I0ZmIo Jy6SGO3KEw7Cov0NuAnHc1QiTwRywiYeLMdHDHhP8afXtMpBbb11z8c5nbqIGMjkAnwUUirMyFgXI 4ekYuCbNZ09dMWMb1P0XgPYaLuXvT0A0H5UWWITzQImTY8IzUQozLjeHPXIWKSlgiBwIG2Zjk3EyT I4930PAj0eWqafw1sfpx+T8qiF4An2rE8pH1HobeGLenGrZ1QUh6r0JoqlXMBsUbkMVrr6NwCTGK5 8TbCztTg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYO9-TF for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxL-0008SO-D6; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GSO-JB; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxJ-009khC-6c; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Christophe JAILLET Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 33/49] mtd: rawnand: orion: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:22 +0200 Message-Id: <20230401161938.2503204-34-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1791; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=W+UYBgQAJFZeZsDfcOBfTmR0jObXHTo9YMzd82OzR4A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFk9+UQ+F5lK3o+3fgK7D1bp9dyovfn51We/3 fmkM0dwqDKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZPQAKCRCPgPtYfRL+ TrluCACDw5GELQM8EroSOXvPTA15GbyyDqV3n+WwfjlkxQJn4hAJSd3AoIPXvzE8kztRHhEUnr7 R9gilRSIYvDFRnVc3RRRJ2Fjeq28rViA/CYaApOe9twT2eDJ6XwKeuHk7zCQymFEdNzaOpuMWpB ai2t/0hequ367xyMS/RuPHtH0f65hzWNT66vDX+P5un7v5RsAcJ9tpGuy+U7LzIfQQw6DIQ7GVK DpIHJLZYJ+Bu/tOzZplxsiu8XrpT57+VzkI4IF0afS+o7FhsKgt7cnIwr6Gf82tF8iVOfzFbpJT Q9BWtYA/o9YqSk3R1mDZvJFwo6u7iY+6pIDbpOn+k8Jug7ZU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_029790_0C39CD0D X-CRM114-Status: GOOD ( 12.88 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/orion_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c index 1bfecf502216..39a6c6360588 100644 --- a/drivers/mtd/nand/raw/orion_nand.c +++ b/drivers/mtd/nand/raw/orion_nand.c @@ -207,7 +207,7 @@ static int __init orion_nand_probe(struct platform_device *pdev) return ret; } -static int orion_nand_remove(struct platform_device *pdev) +static void orion_nand_remove(struct platform_device *pdev) { struct orion_nand_info *info = platform_get_drvdata(pdev); struct nand_chip *chip = &info->chip; @@ -219,8 +219,6 @@ static int orion_nand_remove(struct platform_device *pdev) nand_cleanup(chip); clk_disable_unprepare(info->clk); - - return 0; } #ifdef CONFIG_OF @@ -232,7 +230,7 @@ MODULE_DEVICE_TABLE(of, orion_nand_of_match_table); #endif static struct platform_driver orion_nand_driver = { - .remove = orion_nand_remove, + .remove_new = orion_nand_remove, .driver = { .name = "orion_nand", .of_match_table = of_match_ptr(orion_nand_of_match_table), From patchwork Sat Apr 1 16:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764093 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HwHBKYG5; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=TsgSd7A+; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8N3sh6z1yY8 for ; Sun, 2 Apr 2023 02:21:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=23hPTFHIiKvYXsKyJpBPTiCytcNn8V+hYmybv0LNfd4=; b=HwHBKYG5ey53eK 6c+OtQT+7uDMOODJOrZ5yZ/gyqKIdfBXbPG+bWNikoo3W2zuzvHXfEVot8k8u0xf2qOUKAtTBzh8R 3I8yo0P2Lev+oSuffz9chPxaDWCOSIjh7cLFzolPBRBMxz01oyFuJQMg2hm6n+vMD7TFSER5gQP7s +fghWSnTe5GnLa+FM0/5m86z/PGjS7Q9/VKogqerNCnLvufi9/g7RlixsihpKL3kKp/y0dXdgl6++ 93x4ZuEXeIgcrN8lT7csRxzZwnnVlzWQYOP+P2fKwNc3EY6fN+6gOexRG9fo3q+nc2SmNUIA67uxz Qn160hWhTwmC9+EcwDGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyI-00Asd6-04; Sat, 01 Apr 2023 16:20:54 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxc-00AsH9-2g for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=pwNlpReiP4UFJrHRU78ls469VQ+wJyJRTNIvcBVxz2s=; b=TsgSd7A+d1clkLuhD+5qBe+jQ3 NAe58woNl/mBNHu2J3IgRFADqf32cOTkoguqvgvY41PexVFnViYUZeSPKzkFxMIGnOJA6PRASMRm0 8PSKEsuGQFKmZZH/iYdV6JBs1NRGr0Zb7BfZoKyTBUUbptRwJsN3ClJgKQXVFwLMzPxz8kxwpFR8w zVPULggFM+swDoiKaxIcmmvBLg6v4xgYNe9/uXgXl0mb3+Ql3CSgjvEjKJkrCzmfGqzcPNZ8K1ewd Ys9E3sr6HQEfSa/YeIhRKpZLBTdYPIZgb7RFgTCGucNZCuhROqpOkLE1J4Gu17zoaLVKfMhpn2PmJ 71/EN6tw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxW-008DL0-24 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxL-0008Qw-A4; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GSC-BI; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxJ-009khG-Dq; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Neil Armstrong Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io, kernel@pengutronix.de Subject: [PATCH 34/49] mtd: rawnand: oxnas: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:23 +0200 Message-Id: <20230401161938.2503204-35-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1781; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ppMyZMtxr0Rfp3eW34pywE1GTBWM+Uo0QrudEukFwqg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlEE9Bn1CzxMRpIgPFMxewAVFVlbB8/wSZk6 CO7rGdovj+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZRAAKCRCPgPtYfRL+ TjY0CACpcD3sTcg3BqqwgsCA0VfAKHEH+BQf5s6T/Iyi4FE++rZIblv7tyKbpufw3b1UPiaXL5F nxp5tY+gFy92GBIMbYWy9yIHvUvtntg9WLpMZGObSxfqbqWAzNEf5QmA8YZsnfhdE2JhAE7HT1P +M3rP1rDmB9cHEOS6uLmYd455sa+HXBzxiYPJhS0zfsnjS2fqkQanFZ+UXSlsvFDF0FFmlKIsy6 AJgh696Aa4GUNlCVMMQodNBwANOK92a2CZMwmuBQ+uVOnqXG2MytUcxNxnVFlujgbsXRdnpdRoa upTfoOFFJWFZnpXY94J/CMGjSOIAr50i5pC6DEX2My+SSWxU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_963866_76401821 X-CRM114-Status: GOOD ( 16.35 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/oxnas_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c index cd112d45e0b5..e3c9807df1cd 100644 --- a/drivers/mtd/nand/raw/oxnas_nand.c +++ b/drivers/mtd/nand/raw/oxnas_nand.c @@ -171,7 +171,7 @@ static int oxnas_nand_probe(struct platform_device *pdev) return err; } -static int oxnas_nand_remove(struct platform_device *pdev) +static void oxnas_nand_remove(struct platform_device *pdev) { struct oxnas_nand_ctrl *oxnas = platform_get_drvdata(pdev); struct nand_chip *chip; @@ -184,8 +184,6 @@ static int oxnas_nand_remove(struct platform_device *pdev) } clk_disable_unprepare(oxnas->clk); - - return 0; } static const struct of_device_id oxnas_nand_match[] = { @@ -196,7 +194,7 @@ MODULE_DEVICE_TABLE(of, oxnas_nand_match); static struct platform_driver oxnas_nand_driver = { .probe = oxnas_nand_probe, - .remove = oxnas_nand_remove, + .remove_new = oxnas_nand_remove, .driver = { .name = "oxnas_nand", .of_match_table = oxnas_nand_match, From patchwork Sat Apr 1 16:19:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764100 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=dBl6Q3Nr; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=qvH8WZWz; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9C0Llnz1yY8 for ; Sun, 2 Apr 2023 02:22:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KCSQG2xPwkaBQ/afl4Nf1O9oMxbX7xEXmmc4HF8Nu6s=; b=dBl6Q3NrKzoEi2 8FwazCFsklwyJzwFo1ho+UNHKXnfKg5JH/sAQ9QXevvovNGefn5b3Q/ldowrHcF+jwM58mPByj72q 7tNoio6/2khcPRRIY2+6xEJY85glE3MruSGbzj/brx8VAjpgI7zWdEaS5MQv54/1Y0azHsSz2F1KZ Y6Ma40SCKFAdMptwESluCDo9M082aprMS5B8dqM/Uo189ZTyXgTcX8slNqUTYvWIaiTdEaCqYUPtB VfIQ35thKpqxhvtv3xGqIgfu+dvZUc6axQCtWbdraZLJmjljS55iBuUl0eTlbYPD2+O/vRU+WNyUK U8k1Y/KmYd7MLp+ckeLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyv-00AtBj-0x; Sat, 01 Apr 2023 16:21:33 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxf-00AsIv-0P for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=jrJiyKZF9kqAhMV8Ti7tWzbfe4xxL2DeSQ69bt3YA6w=; b=qvH8WZWzA+c4tVjREtX/LStBOf yrlbep6gEXHblJDYLQpPukv5k51OP05mWVXLd6pcwsfFqEttd9OJKir7uUK5a+1MPHsLXQXBd1fni +s6q2e5wBCOV+zZYYqXaD9AMeZnEfA2RRV6mupebRSCpd5jYwuuUGu3iAC5p93Vedsk7qLVKb8tsN 91gWganx3sgLV/R1CBGe/P4WPIwK+KUkUT9xSUQ6x01S/WLtXIlYyVQ4CO/PYL+0/50TfiktWb2fj AJcJ2EKDh674reMaOSeGIz5uf5ItxXVK0QtRaqywdiqVmq4Kz6Y/eYMngWO8UiBba8I+LS7BXqi2W Nc2CD82g==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DKt-0w for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxL-0008S4-Bh; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GSK-Gc; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxJ-009khJ-Jz; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 35/49] mtd: rawnand: pasemi: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:24 +0200 Message-Id: <20230401161938.2503204-36-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1789; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rgBV6881M98FXTWkqugpWL04vASk/F42pNRXrgmXIWk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlFJ9oxzlBlf6V4uTLw8WDLIk+Qvk0gKyb+M wjxdszSaFSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZRQAKCRCPgPtYfRL+ TiQUB/9f+dwzu29y0r/j5ted0svXmvaEHiC+MlWSlj/nK9NVZqxxwKw99FM4IQ3s34LlU3pJg/k UA4+IGON9Ir13kD/fIdTlUbP94dEsgB5HIVmrXL0heMSQtCzD52+JLzPF2SsxTRbjbJex4nJ30/ J7YHSknMp+/YxxiSQ7EGUizkyqUik7ukQddRG/M2vRHYABPOjCYrHplIqIjC7UG6IxVCdELMwVX /idcZYLWVa1q/mPDfJ/oI145YckPNLC0bDg6hLwSDttYmqkGiOGlD3K/UOG09jasKyO7yN3iIcE jHEElVa56NFF/K99yYQr690k4B4ntGoYzQKxE4pPPdkcOefh X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_607636_46F9C121 X-CRM114-Status: GOOD ( 15.82 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/pasemi_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c index f7ef6ca06ca9..19b2c9d25863 100644 --- a/drivers/mtd/nand/raw/pasemi_nand.c +++ b/drivers/mtd/nand/raw/pasemi_nand.c @@ -197,7 +197,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev) return err; } -static int pasemi_nand_remove(struct platform_device *ofdev) +static void pasemi_nand_remove(struct platform_device *ofdev) { struct pasemi_ddata *ddata = platform_get_drvdata(ofdev); struct mtd_info *pasemi_nand_mtd; @@ -218,8 +218,6 @@ static int pasemi_nand_remove(struct platform_device *ofdev) /* Free the MTD device structure */ kfree(ddata); - - return 0; } static const struct of_device_id pasemi_nand_match[] = @@ -239,7 +237,7 @@ static struct platform_driver pasemi_nand_driver = .of_match_table = pasemi_nand_match, }, .probe = pasemi_nand_probe, - .remove = pasemi_nand_remove, + .remove_new = pasemi_nand_remove, }; module_platform_driver(pasemi_nand_driver); From patchwork Sat Apr 1 16:19:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764119 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bUGq/qIh; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=BlDrWoaM; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXR1qkCz1yY8 for ; Sun, 2 Apr 2023 02:38:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N4UjYDz/+WQ5GUNHw5ahvCxaGiFXLywwBgGGmRvAX4s=; b=bUGq/qIhLsig9x pPlwjm5Ylk28mD0jan7solRZPn5Ray6/wMWBkS1dr3qzkyl0tQFBa9bQuWlwDmBIVqIU6XON6nFfk JGksMgDQ4x4XZxaezS2bzfronO+uGbtkstYCwOkRDZXCl6PeVQ5EQQxLot9JidMA6Qd5nb6PDSHCJ Di/khPHcvk4PttbkhfZUy4bseZVgXqVGZ/jFb4AyhSq6roHyPktkSpp1mM3Xql3vNRNaiJFR3axVy f/iw+1wTASxB3/XCNTaLfTaxviTIg0E03Hv+5RndbKghqTtMz6xm01jh3KOdBtjuSnMN+Ingkik09 e+8lp0UvsmPH4vrcZGpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieF8-00Ax5A-0s; Sat, 01 Apr 2023 16:38:18 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEO-00AwRk-0g for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=TeXN6K3AIPHjYsLgWZHGmyqOlz8GF0S1emngmyYWmu4=; b=BlDrWoaMAn3VFqI62ZCL3zJulG OEgG2/yxn0MGEHvRZZGbXmQ5wyKuVWIKlfB1zQuqNpPlUkJIRNIS+HoLXSQTTXK696eNYW1qnXBJ2 KKbJn4jIGaPTCo/RYgzV2Xifv0VCBL4klBkv/egOxT3iUClUsVKEXWhm85pXMzw010lXPPQlqNRYT KnoHhe4bNmne1PNuUuzwq6ZSGxLszsXaZ181+Rjszkii6ZUV2czXanoRPbGbCOhjO+uJ1a+iSAs9B cq3zMnRFFLO0XJ27nFOwCb++CSdExcXj1ZzmDZOrFfgJ99uQYJicoRk/5P3pdcaL/RMfjqccFxTqM bOJqdtCg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOG-AN for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxL-0008RY-9o; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GSG-EW; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxJ-009khM-QI; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Naga Sureshkumar Relli , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 36/49] mtd: rawnand: pl35x: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:25 +0200 Message-Id: <20230401161938.2503204-37-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AxtPLgQzR7Pws7jjdB4styL0Lqk95tDnFAYXhQ+R31g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlGQpBjusXQRZBv2p3prtnlHRb7v3esbGEmf 1ONCIeg4xqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZRgAKCRCPgPtYfRL+ TslAB/40NjSbGLG+7p+aKQKsumeNDWD7s5i2MGUHDybYdgGbnvNFU00IM6ngRS7NYAJQ2mPgBb3 V+Yme9xEOZXI+MjVYBnzQbKURiGnspzgy9kzm/kSD5TPoDR7hDgoDPLDCZyrXFMEdEvtzHvrf2k LKN/Fa4ievxfrO8wPJoxq+AOXZ3N0ffXuTg/WVIdOEuo8ADqkh9+2hSiV1BS2yftmPTPEeHnDmA S1R2bvRlidMaqY2a9sU3V+0Zx313mNy/2fS6iChIoMEnNOeYndpUzhu+EIlza/DSOz/k7SjwXGF TMVES0N7vGdzh0Ga8Bae8XsaALR8un3speUJxNW+/0KQ1LQY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_528342_05757122 X-CRM114-Status: GOOD ( 13.04 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c index 3c6f6aff649f..28b7bd7e22eb 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -1163,13 +1163,11 @@ static int pl35x_nand_probe(struct platform_device *pdev) return 0; } -static int pl35x_nand_remove(struct platform_device *pdev) +static void pl35x_nand_remove(struct platform_device *pdev) { struct pl35x_nandc *nfc = platform_get_drvdata(pdev); pl35x_nand_chips_cleanup(nfc); - - return 0; } static const struct of_device_id pl35x_nand_of_match[] = { @@ -1180,7 +1178,7 @@ MODULE_DEVICE_TABLE(of, pl35x_nand_of_match); static struct platform_driver pl35x_nandc_driver = { .probe = pl35x_nand_probe, - .remove = pl35x_nand_remove, + .remove_new = pl35x_nand_remove, .driver = { .name = PL35X_NANDC_DRIVER_NAME, .of_match_table = pl35x_nand_of_match, From patchwork Sat Apr 1 16:19:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764111 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=h5//JOIe; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=tZ0LD+e3; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWk5Ts7z1yZB for ; Sun, 2 Apr 2023 02:38:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7MafgmoX4z81Qx4akksna0gsfkhf4D4gSGdfE6l/u7c=; b=h5//JOIePKvSak +1S1YZtvHhUG3szH8RIPvpgfK4KJy5D0G/4V/eNQYRA0LdICmm+pC8aedmDgEjNRB+JqqGZkeRb7H Z0vW4KudWvnv6JdPByRoVG1wJ2ab8KZYQdT23z5DF2HaYtsOWl9iP1fj5ZBIR+LaBHeRhcOuOJ4Uz +00kE9kDCKnunnoLo8UUubWopXaGeV93RmdOBKrzzQWfi5/0xXE+bxF8kUU2UN47zUeVsPNCZqCer GQoDzqxAHrAn2g5ESUFCVjX2L69uM4U6/W4KrNSxCO/XX5oKqKErDYf3/7cBacZfeM19N0btnzLiY JIw4n63qhuiOXR7CjdJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEL-00AwUu-0g; Sat, 01 Apr 2023 16:37:29 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEH-00AwRk-2e for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=ph+cnt8Hs7AKVrV6PyLogq7L6B91w1aXM90bs/oHrI4=; b=tZ0LD+e3x/6kwXFA2Arqp1MkWt lUZvXSZy35ICP0keWpx1EYsSggFRYhKuXxsXoQXTqJ7rNWTkzzjTdBwr0AeYlAIS2Sa3FJTdjw74d oKpCyKfaWOZLpIbz3oxd4rFPI40BwSBhzysP+cCnMaO6ZbZom0b4GXsHnKvOJljbjg19tr8+KtY5Y b4m/GZ6XpBW5lB2cfdwsbyHFXbb4P6/pyPXj0RwuQhdVfnSbhZBspRDDgvWMQ1Y+/nKfav6/7jaEY CoJsmE33bjgdCrsVmrBq8J2CjesPx1DEuXKOQ/OincnPtc/CZcgtNaIY3F7WvRGgdlphx7iDK+3ag O5OGOOHw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYO8-TQ for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxM-0008Uz-1U; Sat, 01 Apr 2023 18:19:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GSU-Vg; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khP-0s; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 37/49] mtd: rawnand: plat: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:26 +0200 Message-Id: <20230401161938.2503204-38-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1852; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=mtTC77dY/jlmYhEDaZDGEnIq1bGkztkuMOaio2j3eog=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlHNTC4uIEI8j1kypPD1arzmeVOuF8tH+YqY UTt7RgIWaSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZRwAKCRCPgPtYfRL+ TgcqB/9HUcv0/3C7kfapY8N2T9pH/0cmt1yZUUCRhZ8487Uqux93CGgxAkmi1+uBMphYu3xn/xy V9JVoVRql7lCVjH8rhgzSJBOWNRAkUz94yi/Rspf8Z80/MHvYomHcJ6nCI8zTdRuqPGJFZ/c3CR XFbN+vi4ha+53wo5HaLph6nyFJEwI/IQ7+/Zw0KTUKKXUGNT9kSGo3FwItzl+TDHdsSAgIMAXxR 2cwz2Spks37FDsmDcR3YX7pI72ZXN9UMo9UDlnX8B8jPOO/VIt3JY8vqRuE5pTM6PO8TsFWU1to u5rc17pDtsF+egxFn1nO4lfB2FYk4Ad3ioUtko4Ev35Rr6z+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_036866_6547379F X-CRM114-Status: GOOD ( 13.70 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/plat_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/plat_nand.c b/drivers/mtd/nand/raw/plat_nand.c index 7e0d0a8dfd1e..b5c374b51ecd 100644 --- a/drivers/mtd/nand/raw/plat_nand.c +++ b/drivers/mtd/nand/raw/plat_nand.c @@ -122,7 +122,7 @@ static int plat_nand_probe(struct platform_device *pdev) /* * Remove a NAND device. */ -static int plat_nand_remove(struct platform_device *pdev) +static void plat_nand_remove(struct platform_device *pdev) { struct plat_nand_data *data = platform_get_drvdata(pdev); struct platform_nand_data *pdata = dev_get_platdata(&pdev->dev); @@ -134,8 +134,6 @@ static int plat_nand_remove(struct platform_device *pdev) nand_cleanup(chip); if (pdata->ctrl.remove) pdata->ctrl.remove(pdev); - - return 0; } static const struct of_device_id plat_nand_match[] = { @@ -146,7 +144,7 @@ MODULE_DEVICE_TABLE(of, plat_nand_match); static struct platform_driver plat_nand_driver = { .probe = plat_nand_probe, - .remove = plat_nand_remove, + .remove_new = plat_nand_remove, .driver = { .name = "gen_nand", .of_match_table = plat_nand_match, From patchwork Sat Apr 1 16:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764103 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kPkoC6P6; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=mQlnOjI4; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9L01lXz1yY8 for ; Sun, 2 Apr 2023 02:22:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WuyqGiIJzfYd4FPg85iBBcEPc0wL5g+aSV5EJ0Rb8bY=; b=kPkoC6P6Ne5lpa nA+u/PtOGMPKPLaAxr+Jj6geKg6kWK0rR4jMjnZ6eeDFWJUS/F5fR6BmkthUE2+kQ3MXUr6JXDi0g 9fL+RnNeQu6gblBWe0zcu2lodMQ8VdyxC2uSHcGKBk+3qeS81iZrG9/BmADBXliT2n4O/IrqBWYUy INqmB3mI/qTki8kmTsW+JrxhFAqdKro7DGuhcDIJ3q2w7pIO6OzDybgLu+KRGm4SAFyCRkzLHzA4O UDcKAeo3enHT4vP6kbBbNtf2c4VfhvMfs5XIMyM7wU7nrklQI2liHQgv/0FvCnP9/vC+I/0Y0CD9F ylJ/12y3TdVI9N5eQU8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidz5-00AtKq-02; Sat, 01 Apr 2023 16:21:43 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxg-00AsJV-0Z for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=/O11WgaS5cBOw6Rxe6DxWIEIPKTr28R/vgUioRrfmfk=; b=mQlnOjI4hJ0FRYj/ifrFcoxbrc Lhs3m/gTiu1AL/uRU+/JUva3GqRlJy/hIAPrE6B7YMb5Q4sS+5y4tfD1hnOmPWBYii1ocnvRPRElV OP1e1mwCTO8niEy5kz9XGVuywYuEjOfA7VAsoRxcsDH0YxlGSyZsn8WFZc19Txrs6qcsCAeZnrvHp EfmoXzO+mvQLtjSPdASmnF+nY//Ia99JstKuX0PG2AoYkoP7q+jVCBHjqwRudJR2YC9S3+rN2PQ7N DfQcBrQmB42zumwmRDq3L2PJV/VOZ2z8TYKMshaYgdM0dvUxxsiVTRN1VzW+gPIKjBlpI/eU33Nzr ny97+xcg==; Received: from metis.ext.pengutronix.de ([85.220.165.71]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-008DLR-1K for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxM-0008Un-4u; Sat, 01 Apr 2023 18:19:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxK-008GST-Tr; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khV-7r; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Manivannan Sadhasivam , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 38/49] mtd: rawnand: qcom: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:27 +0200 Message-Id: <20230401161938.2503204-39-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1878; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=G28o7xn3QeMDu6fYFFRYPya7v5M/PkKU71x1+qlTeuM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlIoSNlhz8SuPP1vj89aETRFZubu7irTsjfo seAd3212iyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZSAAKCRCPgPtYfRL+ TlG6B/0ToTS5PmudnWMvPXc08gvHEHveyRmqI7ZmtdZLRYRCCj8qe8KsVhsQcsJTd73Z6ggGkOx TIW4NvZh9lWSMxLI5pd+hdAkIuoROHvfnlXH5VJXAYJf8qXO8NDozk4tiwuwB+tUDdDo/FIgeX4 JMKBWLS9FOnI0boY53KWw/Acb0j/SZBqN0emeA61Bko07JE/6hTwRtF6KXSzUp9tUdf9/4nzsJG XyO3X64lRIA591mmoYy9Mh28lXwszMvqT++JT83dKptAPuSNDT2/xvToXkCrISLTyi2xw/Q3gne MbcghY8XSx32hMyRSr9OehzOlAQAkKS0GGMRmET4yKitNY3q X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172007_704628_AFBC326A X-CRM114-Status: GOOD ( 15.94 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [85.220.165.71 listed in list.dnswl.org] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/qcom_nandc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 198a44794d2d..218c8a840e32 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -3315,7 +3315,7 @@ static int qcom_nandc_probe(struct platform_device *pdev) return ret; } -static int qcom_nandc_remove(struct platform_device *pdev) +static void qcom_nandc_remove(struct platform_device *pdev) { struct qcom_nand_controller *nandc = platform_get_drvdata(pdev); struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -3337,8 +3337,6 @@ static int qcom_nandc_remove(struct platform_device *pdev) dma_unmap_resource(&pdev->dev, nandc->base_dma, resource_size(res), DMA_BIDIRECTIONAL, 0); - - return 0; } static const struct qcom_nandc_props ipq806x_nandc_props = { @@ -3405,7 +3403,7 @@ static struct platform_driver qcom_nandc_driver = { .of_match_table = qcom_nandc_of_match, }, .probe = qcom_nandc_probe, - .remove = qcom_nandc_remove, + .remove_new = qcom_nandc_remove, }; module_platform_driver(qcom_nandc_driver); From patchwork Sat Apr 1 16:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764118 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=JZDxQUKT; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=q6Fn+Ed0; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXD0yqNz1yY8 for ; Sun, 2 Apr 2023 02:38:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ba6aYqmYVLn/o7R2O/X/CizOdYZV2u6WxPwdQgrqzA=; b=JZDxQUKT21Xqny DL/4yd2np7SkUytmpvHlIkB9XMgg6fdBOts6adnk8SLhP4TgsX1hkm1oO8gZ9pMTPeN9I/y+wJSQY yHeKQAqZPJ1e9c2AUrwrty3PpNQ5tSP8Ed8Cx3GOnFf3M1Ihx0WtjcS30ERVtCPT18BTtbeS8/AP2 ubLH1awg1zl+72+4QxM2ErqatNKB1OlyTFfZfk8qO0eSF8HvT1j+ykV9rvkW7UXGcRMaWI0MSEg/0 z/2SP+neQyn3EIy+bUUimkd08STdKXdIqSWHNbprwr9fQzAJLZhPK01Iui3U5fRVOkShJilm5Ouqg p4Fq2a0Dp+73OxG5PSzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEl-00AwqW-1y; Sat, 01 Apr 2023 16:38:04 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEM-00AwRk-3C for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=mSvEJXJvcAoEFHW9n+sWIgt4u3AoLiJqat4yqpdGqYs=; b=q6Fn+Ed0eAM4Gyqq1W5i+z73DG o7G3LczrUJ6cOtPf1XU5Yb/sIfLAU6yeEDKm8Zz5AUBIa3ay4Z0eEpMNRJOG9aRvL2uUcHWTG+Pwu A8+R5meL09yiab9ZKo7CW1F31/M+9fnChfpBMMfwQ0n3WptD7HX7qcz4j8+Z8zim5m1igKXZGNQu3 KppSpBm9/VtmwdF57x91wv7h5+uysmP1DT2pAqT7jPxIky4KjIHrTSlZsIU6YG8elmViyYKbAsQAF ii8T7/8CuPgMYwsgLC1XNnb6wIIXYb/M6pkNCfAZ3rlM4yX8UxwuSSct2nTNT0ANcj+BKmCwztPML Cz2OPijQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOH-La for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:09 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxN-00009j-2u; Sat, 01 Apr 2023 18:19:57 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxL-008GSm-JT; Sat, 01 Apr 2023 18:19:55 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khY-Dj; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 39/49] mtd: rawnand: renesas: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:28 +0200 Message-Id: <20230401161938.2503204-40-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1696; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=gCkd0kQYH0yqAD5z8JJPYsdxxLL+nMTSfiU1Ye2kvJc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlKGrs3kW0HWbv+BREGmgko7MmQtzQoVAwq7 zzJ9BT3s1yJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZSgAKCRCPgPtYfRL+ TkRICACMByzQD3H+9q4YrpmHGekHt0ruPg7GY+C+TJtCYkyukcmEXeTnZBkeODX7YvXVzBxmWp0 CaMbHGN7ZLksa/nCsz7cbI+67PmuRbXx3Zbeilu0mag7qk2QW0TXkGISSLIRGKWK3kpfiQuMIsg KkuIZj2DhvloKHcpKcO2nQ/e0GfU0BCF0KicViStmPeRwnoqOvbjwJpsMJDmms0D88OohjKMVy+ HHtrC1ApF5TYf3iAftr8YhDfqZtqrP1YYQFTTYNzzliLq8+zxca6aXtqmwSu0LSIjnfYSomKI3+ nV+VNY2T+DqAzMP1KCSyFHyCpGQvD30+dM1BB1WIJbukPdOZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_823379_B5DFBDD0 X-CRM114-Status: GOOD ( 12.80 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven --- drivers/mtd/nand/raw/renesas-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/renesas-nand-controller.c b/drivers/mtd/nand/raw/renesas-nand-controller.c index 1620e25a1147..589021ea9eb2 100644 --- a/drivers/mtd/nand/raw/renesas-nand-controller.c +++ b/drivers/mtd/nand/raw/renesas-nand-controller.c @@ -1386,15 +1386,13 @@ static int rnandc_probe(struct platform_device *pdev) return ret; } -static int rnandc_remove(struct platform_device *pdev) +static void rnandc_remove(struct platform_device *pdev) { struct rnandc *rnandc = platform_get_drvdata(pdev); rnandc_chips_cleanup(rnandc); pm_runtime_put(&pdev->dev); - - return 0; } static const struct of_device_id rnandc_id_table[] = { @@ -1410,7 +1408,7 @@ static struct platform_driver rnandc_driver = { .of_match_table = rnandc_id_table, }, .probe = rnandc_probe, - .remove = rnandc_remove, + .remove_new = rnandc_remove, }; module_platform_driver(rnandc_driver); From patchwork Sat Apr 1 16:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764115 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZfOKfDel; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=b9fAZVcp; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWx1pRRz1yY8 for ; Sun, 2 Apr 2023 02:38:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q+8I0Upe8sjGckFjbo9W2+okPR1LjY1RfofyoN2ecdQ=; b=ZfOKfDelqp0Vq8 JJGiMTZ0tTsZwyEITu1Xb/c2tFXlBctzpEr1BdCTDfglde03LoKs3K/fw3La1u+ozuz7sFKxQHdok KT+ABYFeV+J+QB8b4BpSPg9hN0RQJxPlmUIf7Wn2bhUYot2JkK0qhP6tzNBzrtIbbh88YPvbT+Mc2 22MIhOCh5D0iZycpwy7KNZo1c5bF46n27RI1CDal4Yx/zXI9KkbfFyPWVnRYCnzpy1nenwXM17xMx J0AN/h/5eGBYz9yucQ3XhBbwzBQ6G+GX7hIaR6Ajc54Tna5ujQUi4P09qkySIZNox6CwUcDTg9pxR Hj4wDI7Flui5Ec36qqnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEb-00Awhz-1q; Sat, 01 Apr 2023 16:37:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-39 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=iVOSM2Z37bCVGj4weZVcMNa8xT3KmUYLRmfHzRoboII=; b=b9fAZVcpljsH+GQDgL7izXjBVM zLKouvQdNrj/YWc1aM4pMUx3FL4lIB803rhZDR+llIiALIXe3IN0OL8Vqjx5MF4XPIjpIknTDdXbt oJZYQ51Sn8XA1e53kCpV9B8HnP0jw8lNlL4bPRQq4tvHA85oC5TIRejJe/PImAO8t+ZY8bJt5Rtnx ZzGtrFXsZ09cJJKe9PhlL/dhAVjhbhvTw5gUEhJCeohYtcJSY0yjE6WetxYv1GM49xbX3QEmJX2yy Ld/q1PftiIx70xo1SKGQ59ez7LwYhZenH9oCM67MHR84kx81N2xQqdQLanEp/bv/UqSC49T9t0S3R y/As6sIA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOI-RW for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxM-000071-Of; Sat, 01 Apr 2023 18:19:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxL-008GSe-Ah; Sat, 01 Apr 2023 18:19:55 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khe-Jg; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Heiko Stuebner , Phil Edworthy Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 40/49] mtd: rawnand: rockchip: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:29 +0200 Message-Id: <20230401161938.2503204-41-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1838; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5b0XHAUgin6YhP/t2Zk642ckRtz9ynLH1TjOf9h6WJk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlLKZ66exyKSWjWWPv7uJwM4AvwSe+dQqGRN rFNljS/ABGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZSwAKCRCPgPtYfRL+ Tqs+B/9BktD5yecoMur2/dGiT9krTJo3UN72YS1ieMgx8g55r7hlTahlQXa1TuHfAYJFUOufoVe au814z3dA45RnUTtHC4jsQ5EY7OuritRayjCfWRzh4lSp8mElLLDJA7qm3ty1+V16kp0iwDDxk6 jSa0tY5yjBAHdhCVVDNo31AEe4ThKEuWQOWWiNl6IbMZ6nRT9ph2zOhiQEfSMfSdcO7i3gvZW++ SCPDaDXLGdYeOlIg+hE1OhAm0tXJ2VsEz3fkO9KNACFRCcRzRc+2m9a0MYDOw/6yFOaZVMYC36l qgpj44JzTogpOXCA7OVjDUqtyvnKc+z0z3FMLUJv7k9suVh1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_974959_939BF35E X-CRM114-Status: GOOD ( 13.63 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index f133985cc053..2312e27362cb 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -1427,7 +1427,7 @@ static int rk_nfc_probe(struct platform_device *pdev) return ret; } -static int rk_nfc_remove(struct platform_device *pdev) +static void rk_nfc_remove(struct platform_device *pdev) { struct rk_nfc *nfc = platform_get_drvdata(pdev); @@ -1435,8 +1435,6 @@ static int rk_nfc_remove(struct platform_device *pdev) kfree(nfc->oob_buf); rk_nfc_chips_cleanup(nfc); rk_nfc_disable_clks(nfc); - - return 0; } static int __maybe_unused rk_nfc_suspend(struct device *dev) @@ -1476,7 +1474,7 @@ static const struct dev_pm_ops rk_nfc_pm_ops = { static struct platform_driver rk_nfc_driver = { .probe = rk_nfc_probe, - .remove = rk_nfc_remove, + .remove_new = rk_nfc_remove, .driver = { .name = "rockchip-nfc", .of_match_table = rk_nfc_id_table, From patchwork Sat Apr 1 16:19:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764110 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=K3YkWr67; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Yvymh9Vg; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWk12NWz1yY8 for ; Sun, 2 Apr 2023 02:38:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vsglTh8RovadKk7ih2PpbaT0OOcITcAqBzhQauLSYZ0=; b=K3YkWr672GZVWU ySk/SCMXGYmDAWtQk9RvN9CTbhaDASnVQ3JdDjCp7jv7v5nWVVJ4v7S1G9XCyVENzZknTBMopwkVX WwSkx6JdUt7zq0YuWQ2DCMi1s4aHrVwIc/W45kR3iSa6ZBVpN9lxtCe0tQ5t/CwmOV9AcrruF8ogR uCOKa964HNRvSQebbx4bmTPqBEhPsRouDvJGefIsEckA1Z4RpCLtrHHBzJV8gCUpVBVOyU4lg1UOr Q0nFlwybGD342f9Wp3iwUYQ5SVQn0sIIYay4qPS7uhZeYkREf3I+5XElc3/crpjsLqHbhut8yCRMx WUOt+xvXyERYxT3xSJEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEO-00AwX1-1V; Sat, 01 Apr 2023 16:37:32 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEI-00AwRk-0m for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=ErzwJ5kzo6l5ZW5Rc4wdyAvH069TDMDmCzN+eXTqyw0=; b=Yvymh9Vgy9rL8xYmrxUOEXPxb7 KjlCMy+cDCmnOfhzAtI87b5YoCECrSI9xK1laeQ7hNC44Q41huqNY4NYt3YPL1/yKDEYvndIyplWo 2mwtbV0LHWml5msv9zt1fFp7B3pDywNSPR7RE++URuODLotnrIHav0y2b/HU0vKWyHLd+5zEKZooo om6Xkuzof/lpLxWH99TwPUyrGkHFhKklGRokZ6gyNTq8VmLjDvWx3j5W7B0i6j49Kg96RVslxQRss LqdEawT1wr+uj0xxq2lbXOdOTr7PGfhNyVh5b9eubhrVHa9cCQ7FaTA749TCjexHq190encc3L7Kp wz8WhGPw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxW-00CYSi-AX for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxN-0000Bb-97; Sat, 01 Apr 2023 18:19:57 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxL-008GSq-S5; Sat, 01 Apr 2023 18:19:55 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khi-RR; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Krzysztof Kozlowski , Arnd Bergmann , Linus Walleij , Stephen Boyd Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 41/49] mtd: rawnand: s3c2410: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:30 +0200 Message-Id: <20230401161938.2503204-42-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2029; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=gguQzC+fJqIHjPX5PYpmAn7zDOs8OCBvzY7Y15EDBEQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlMQXXoDqp81e3QnKDx7z39gru64y4FbgMaj KI5M1IdxlOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTAAKCRCPgPtYfRL+ TlCuB/9eFDdyVe27z4YEIwZJnF0ArJxl5hIR8b7wf/Tg6+HlE2efqZpkTpvE2wnotHdVxDbZx8X jUxuT4zTfczv4RiQv2iB71Weu0yLZDms9b647m0/P38xf3aeyEPeqCkaXRosRNHAzvSBWoZk0vK GSkP2+rQYDKi4UWFPsI/z9JGV3ewr5hN50vCZvmVL9HgwOBZqFkRZCcWyYeY70u9jYEhzRLBgRq uJ2xndXGSCR5TfggRuPEbfTJpp/cLDt5Zykg/b2oo4FB51pT2Xzy9Dn/haU2uLMB7+yxQMB/NhS OzMtJJJOq64RqRrUIV5wsINPBCXJdxgOqYVNxeSzTEkTr7CB X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_391913_0FF98C88 X-CRM114-Status: GOOD ( 14.09 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/s3c2410.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drivers/mtd/nand/raw/s3c2410.c index 80d96f94d6cb..ac80aaf5b4e3 100644 --- a/drivers/mtd/nand/raw/s3c2410.c +++ b/drivers/mtd/nand/raw/s3c2410.c @@ -709,12 +709,12 @@ static void s3c2440_nand_write_buf(struct nand_chip *this, const u_char *buf, /* device management functions */ -static int s3c24xx_nand_remove(struct platform_device *pdev) +static void s3c24xx_nand_remove(struct platform_device *pdev) { struct s3c2410_nand_info *info = to_nand_info(pdev); if (info == NULL) - return 0; + return; /* Release all our mtds and their partitions, then go through * freeing the resources used @@ -735,8 +735,6 @@ static int s3c24xx_nand_remove(struct platform_device *pdev) if (!IS_ERR(info->clk)) s3c2410_nand_clk_set_state(info, CLOCK_DISABLE); - - return 0; } static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info, @@ -1218,7 +1216,7 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids); static struct platform_driver s3c24xx_nand_driver = { .probe = s3c24xx_nand_probe, - .remove = s3c24xx_nand_remove, + .remove_new = s3c24xx_nand_remove, .suspend = s3c24xx_nand_suspend, .resume = s3c24xx_nand_resume, .id_table = s3c24xx_driver_ids, From patchwork Sat Apr 1 16:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764139 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ojDE3j2i; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=QvKpLmtC; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppl3T1HTxz1yYP for ; Sun, 2 Apr 2023 03:47:17 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l6LWRSq3dP1m0nBDXEqbzTlwZGbe6tzFRKDVqnpy2iQ=; b=ojDE3j2if9otHN sNZP/GAl0UuZSU1zvs64oUl7hir7nMNTar26PbvEFeLCnd9FmJn8Ownke33EhnEUNs61OTrMiIm7C StzqPRFLYSEmR50b12v6anvS974pi4Nxze452V+bPlD+T+OuTJ1LiXWxQiax1AAb9wGKf6ATIMUnu CAj5H8nCU1XWElnkRHfTplHuqz6XJuUpEbsV4TPqExowa4bq578mFVmOf/y5VkRNN5/LCpJAvwNCT QI+olp/sciRL1PuM/uHsnVKKJI2iROZmobi9RppDhmdc3+F0zrBiIrTx6VGLPBXazKchX9oR8b34+ 9CBSKvIUrmMoheWxY6pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pifJG-00B4AH-2x; Sat, 01 Apr 2023 17:46:38 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-0m for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=F4wck+ks+4to/R4TiUTZ2YDPxWlJIYAoZYky0TKDG4g=; b=QvKpLmtCNupcAxlk2E7Og8/URw qkCU7I1lwsb6RbW4JD3LekR+U2O5rXD/2pLMtF8peezKMukXYxmWYDpW/tMuiS4w7O1CeoM4j+fo9 wiJ1LCQR9qHzf2gq4SANapm1q3Aarl9+vZY2RVLLGrlS1hMJNy0suLZrFKA6b1IOIhKNqbWlLhQp9 kyK72fuPhIl9rjgR8V9nts9BEf/xsi/LwZwZlerOk4mQDmYOGFbQ5d+DbhhtmsvHnrpdaaYJ2D4Gs U4ap5JBmn+UZ/roGoNAStHCnE0WltWdnkmMrgb2cWXbOGv4o55witxKlfkN7b3LGGk9zjKHtyFl+5 Dg4agLMg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYOX-TG for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxO-0000FH-Bd; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxM-008GSx-D1; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxL-009khm-1h; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Miaoqian Lin Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 42/49] mtd: rawnand: sh_flctl: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:31 +0200 Message-Id: <20230401161938.2503204-43-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1620; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OxxfogUXdY3Kq+QGkZ0cg1gQEnSA/05REu23SWtVrzU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlND+8tMOdKWG94IDfmEmWxp61KDsqraKv/L 3uihieVIAGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTQAKCRCPgPtYfRL+ Ti+zB/44Fh984vvSJFO/W8rj4GtOK3p3ViwY3py0aFQ1VcuUVOFZB1lK75XdurX1s3993MfKUZB iXXl9AHV/88uCuK3nm4Co4PS5I7LZCmtthPFBtf/UXlGQYBGD0hbGo932Bcq9PdnVT00QpK8xzU /qvQBn5bo3fQ6QLxB7pVFwYrFv2GK8+4WxVd1+wJYYRGOQt+t/ZY6AcfwjS0Uwem+hDYVg9xNLD NGL2rvnEDMTy1RxqYc521ivoXAiJCRFWQow+ANTqk1J4l3Et8VmhZVCwGK8jYXkQGSvS9J8GOMU 0IX0hMb8I3CQFiZKmKia+cTy7xdBNnMiJXhHBJQvnazMSe87 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_010497_60BEE7A7 X-CRM114-Status: GOOD ( 12.56 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/sh_flctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/sh_flctl.c b/drivers/mtd/nand/raw/sh_flctl.c index a278829469d6..63bf20c41719 100644 --- a/drivers/mtd/nand/raw/sh_flctl.c +++ b/drivers/mtd/nand/raw/sh_flctl.c @@ -1203,7 +1203,7 @@ static int flctl_probe(struct platform_device *pdev) return ret; } -static int flctl_remove(struct platform_device *pdev) +static void flctl_remove(struct platform_device *pdev) { struct sh_flctl *flctl = platform_get_drvdata(pdev); struct nand_chip *chip = &flctl->chip; @@ -1214,12 +1214,10 @@ static int flctl_remove(struct platform_device *pdev) WARN_ON(ret); nand_cleanup(chip); pm_runtime_disable(&pdev->dev); - - return 0; } static struct platform_driver flctl_driver = { - .remove = flctl_remove, + .remove_new = flctl_remove, .driver = { .name = "sh_flctl", .of_match_table = of_flctl_match, From patchwork Sat Apr 1 16:19:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764113 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L87H2xI0; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=By99Hu0c; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWl72Jqz1yZB for ; Sun, 2 Apr 2023 02:38:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hvNv+POHLgRvsUrezenwrfLPKrJRBn8kT+nKONsOcjY=; b=L87H2xI0R5SJLM n9n2PtnWD2ANgAZGmh1RktedJyqY1VsWgJQTndS8eD+npY/XNXVvVUtR0k3DOY4xBmpBrMGGDK9Ym j6rB5hlX8OjdijAxkL+38gxLaA1o4tIAiKFTAtaJmwvCIiBkmlxHXRinxPDEf00Fzd2C4PxOx6yQp 0t/8kl2YJEsN1kN/Q5wn5Tca6mOs7mXx9U3IOqGYwmQ1XlMPOXD49VfCHX5GM+eyJShXStBGdvX/z AiD7r+CtYuP/ZFvfeOvpGWsc9yLEysIxNfX2IVbwYNXnEZGGzUJCFxWsk2Mu4yocTyJ7AVSbgk3N/ irwYHSKupOGvhFC8ckQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEQ-00AwYi-1N; Sat, 01 Apr 2023 16:37:34 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEJ-00AwRk-0A for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=QUQzEwoqHYVhyNuFKBuptQkbUbzzYJu+BSQVVZBazMU=; b=By99Hu0cTSgIC4lSXn/pnS0cf5 2Uod1G2mgVX88X4s7b/islH6pCz1hp6r19D696XS/Gv1QPpnFOu5hVEisFLqwcdDtnVLVtenjWQzi nZQ++2g2cizHMDvIONGuDAs4JZOC42j08PZ6G7u5/vjoHUnkk0FT5HPRRfiK8MExzRk9VWJnpzeRz 8rFUdDBkZjpM5ZvFPHWKL6gU5EMOjffK/nxeyfhoH5ImDc4IxkJnI64lLYWGKVrxiKCjjxheLR6Lm reRAX9/s8hv3pz+6IN17+uZaNR1Ery44CQoBSJacDCPjdBsueEFGzefjh2tdxQJ0yRM6Ff94aouzN OSfYGnMw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxU-00CYOV-Tp for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxO-0000Gv-Mm; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxM-008GT2-Lk; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxL-009khq-7d; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 43/49] mtd: rawnand: sharpsl: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:32 +0200 Message-Id: <20230401161938.2503204-44-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1781; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=lIBMbcBcuZgc7q2CmWYYOuZJ9PgnD9/upiDaofVxe0g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlOTLFRAnW2450EI+o6Ym9zeQr/Hb9RllnlJ 7uf5pkqZ8aJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTgAKCRCPgPtYfRL+ Tia/B/0YtKw50nTPyfVHFVtiT5MAd7XjRDogwgw54fLdPdMlaedqLAjqJBIwcojfqWSPdwfKBwr ElgC0AlFOp4zNQX6Uzvjp3U74nFpXW+qQ5h3XIdkuRb3uKAAdW6FgQ1AeVS6cfK3wowp0wq1nBb 2mci5RcWlyLj9j1wlqH/DtXh6tehnn5dD01H4nZ0evNJXo7CZuREIewYIjNDAMxljEVQJYKDjiU 4N+7U+CEzEOV39NW7l2faWqI1bUw28Eo8eKxMGZztNCw9zwD3ajLhVif1xTJET3YjWHPHg5l/Zr rsROmOJFR8PwpNyXsPXLbD5NOSqgOr5vUtf33ijyQcomIETH X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_994688_D1EC06F9 X-CRM114-Status: GOOD ( 13.36 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/sharpsl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/sharpsl.c b/drivers/mtd/nand/raw/sharpsl.c index 52ce5162538a..2402dc5465d5 100644 --- a/drivers/mtd/nand/raw/sharpsl.c +++ b/drivers/mtd/nand/raw/sharpsl.c @@ -210,7 +210,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev) /* * Clean up routine */ -static int sharpsl_nand_remove(struct platform_device *pdev) +static void sharpsl_nand_remove(struct platform_device *pdev) { struct sharpsl_nand *sharpsl = platform_get_drvdata(pdev); struct nand_chip *chip = &sharpsl->chip; @@ -227,8 +227,6 @@ static int sharpsl_nand_remove(struct platform_device *pdev) /* Free the driver's structure */ kfree(sharpsl); - - return 0; } static struct platform_driver sharpsl_nand_driver = { @@ -236,7 +234,7 @@ static struct platform_driver sharpsl_nand_driver = { .name = "sharpsl-nand", }, .probe = sharpsl_nand_probe, - .remove = sharpsl_nand_remove, + .remove_new = sharpsl_nand_remove, }; module_platform_driver(sharpsl_nand_driver); From patchwork Sat Apr 1 16:19:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764114 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0y1QOJuw; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Nv+T9WWu; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWr4mCsz1yY8 for ; Sun, 2 Apr 2023 02:38:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vAnO4dtTI1SXYO7iq2uDkdLc89Q9QBhyN4si8I/5MFs=; b=0y1QOJuwdhlvcN 8gVLdBu0cZmjNKJToJcoHgr1Id2OrFjwBXueE+JHXCgMf55e5n+4FWygqG7iquhLYefTiT+jm0BM3 qOXw2lYOMDX5eOXvLF9zp2ypphzvRbo+dmrkFbJQcVKDSazdT5hBkWkS0QhN/lp0L3JoIi9xzW9zw /fkXcvz49PMb0e2ItWCjYhg7sJhge/a59WzB6rBXtrJ/Mb5KCABPXIrNWumfDu1VGZQqevg8MPc7g LB0mxK94qlYBfApJ59fBp1Nu/ctefIAmp9sFHHcjcnKf/nYYRDzJW9bFXhbiPdwYdCgS0NAAVptvs DJOw7XnHrPR0b/bjpqHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieET-00Awal-0C; Sat, 01 Apr 2023 16:37:37 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEJ-00AwRk-1K for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=0dlD/ciAM1mAdaJeniyJfYCyGG0Ji/lVaYEE5QDKm2E=; b=Nv+T9WWuXEbu7y/xXtdfMX0n+v B+XJM7nLMk5OO1B7csW/KYMDADbbfXbsn86OFQQv/j5D55hAO2Sx5tTDiA46paopj/LrXJ4vpzmBb LQMNpwgcedUmhDSjbhme+bV7/3fjOmc8iwhLC72JALNt8yljVkoarv7eVXw+7HZG2eHfvgwFdUtV6 xfu0eYy5KUyhwhUh/+Nkv0PHMf6L2WCSfmPxUR0cSItEL7PVCrKZIxVQxL4PoioEVqfvVkgTxZ+S4 yr9/Gd4B16aQfwuUMEIoOchW5bKNs5devjAAYehEgqRLvz8CexwO9dL7gaMmhKJBTwutYOvCVmN6X CFDhpxkA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxU-00CYS4-Ps for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxP-0000N0-LF; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxN-008GTQ-M0; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxL-009khu-Fr; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 44/49] mtd: rawnand: socrates: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:33 +0200 Message-Id: <20230401161938.2503204-45-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1848; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ubqLpURaWIdRpwU4SbY9gA9Nj93h7rIhZhWsYkx7Yqk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlPiK0nHU5VZtlcPwHjM3pOl5BJPTRkzbG14 XLSiYjIDzqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTwAKCRCPgPtYfRL+ ToxGB/4wV1VkjAunagUxV/4qSr4uxkRG2WdKKpGYttkUj99xWx/hMpZGFQ3ZEQHPG1KTRraaiHT UPo7kvnhcQb+dWyH8zs8WkN/GIf04OAuU+rXpnfgIX8g+mJkJhBhFF0xDE2siVQGqN02fe7iZHK vWtWU/ZvX9a1wNrYyOspdc8hxI4wZlAjiCuQ91fzZnIcNB4sA18MEp0GrHiYNdVkkQ99A91J5rK ki4FvLhxpoPpe3TH+EuvMLulTBOPBpB4CcAn2jI3fCXD1LzsnBHcffyS7iTJ/+lYdn7pTpGnvYp XN3pF6JPg9JOwQ0gmB3ttsMKzitOUUFwDecbqB90agJW1H6X X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_877285_DA77E0E8 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/socrates_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/socrates_nand.c b/drivers/mtd/nand/raw/socrates_nand.c index fb39cc7ebce0..a8b720ffe9e8 100644 --- a/drivers/mtd/nand/raw/socrates_nand.c +++ b/drivers/mtd/nand/raw/socrates_nand.c @@ -201,7 +201,7 @@ static int socrates_nand_probe(struct platform_device *ofdev) /* * Remove a NAND device. */ -static int socrates_nand_remove(struct platform_device *ofdev) +static void socrates_nand_remove(struct platform_device *ofdev) { struct socrates_nand_host *host = dev_get_drvdata(&ofdev->dev); struct nand_chip *chip = &host->nand_chip; @@ -212,8 +212,6 @@ static int socrates_nand_remove(struct platform_device *ofdev) nand_cleanup(chip); iounmap(host->io_base); - - return 0; } static const struct of_device_id socrates_nand_match[] = @@ -232,7 +230,7 @@ static struct platform_driver socrates_nand_driver = { .of_match_table = socrates_nand_match, }, .probe = socrates_nand_probe, - .remove = socrates_nand_remove, + .remove_new = socrates_nand_remove, }; module_platform_driver(socrates_nand_driver); From patchwork Sat Apr 1 16:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764108 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=LaaypVsm; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=lEOEXAYE; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWf1ShWz1yY8 for ; Sun, 2 Apr 2023 02:38:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sXI39vXAaViY4PVdoVsvafI0ia8k10fJhv6Vi/rWmCQ=; b=LaaypVsmhzR3VE ovs4Uggl8wM7BFRfIHowk5kWqUFAnUGdc3F74T5g/+To7Jcfbm41q/4ffYc/WiaHSLPGSsxKCf5R7 map82D2FyqU0ap0idCNbZe8KOuGG8ef9NukFe8craiVoFeo9asP74yFWDkZq/ixBBeW82GUWejhlx YWFXRZgZ+mEuK4SKC1ebBUffPuM9UrG25cXGCcAI6sS+UcgiVQnDLaV/G0qMWom02Ohyy3j5d4pBR jvf7rkMJ03nx7hXbUyeLRlmc7SyNI4gFs7A8E97T85eqmvx/RX38dzAUBL/Vj3kYwAcgAM7L9Xno/ pvvMcOx12FkzRF54m0Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwUT-1C; Sat, 01 Apr 2023 16:37:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEH-00AwRk-15 for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=ojvEeNTmk3GYW05R1yrHV6n8/z4ws20erldx3TZFspQ=; b=lEOEXAYEK/TPL1scevank4Hiza S4p/RHGCtqSeHblHwdhWHbrhhc6C/1oKAx1+mqckL1ItXf6Mcq9Oc15zSkB4DZxDYEogG7Lg4Fjq5 zp12x71vWU/mTzck0bH4NTrOyr7r13DdIPtISJsNQwdKS4xakDz1MbG34lMp6sNvjRDFkeJUwwyBG 5fP3Jd5XV3TkS6fQ5cpx/zhs5+Zab+W/gUc7VEK/0bXC4qBio0pFWJFINHTFH9hHyNL2gEK4K8Ctw X5buMv/FST22DleCBWJ+N/6015iWwD+k6a8klF74FEUygVsgvikYorldxoO9kQUB+D0J3IHZ5duEL 1RwQfzJQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxW-00CYSj-CB for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxO-0000HA-E2; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxM-008GT4-N4; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxL-009khy-Mn; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Dmitry Torokhov , Jack Wang Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 45/49] mtd: rawnand: stm32_fmc2: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:34 +0200 Message-Id: <20230401161938.2503204-46-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1912; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AEOfFfpg8jnamUficc+JbatV7+ft2JVAarvqxLIvw2c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlQYs1o0K6QqS7EEqapqX9nS62hboypZ4nf4 48fJjzJYDyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZUAAKCRCPgPtYfRL+ ThSrB/9r9Cg7UBQvFzPFrqICftflvmP1LawosdzFYl0KYvNmgvXQNCfcc1lYm206AYw6g9u/RZm PTw9ugnrMAvf9E8vDSRj9bTIG4ebb4w0kImvQgJOfv9VUKGmFETqUC3tBtvenGRt/9hmPxaUlmn xm0fR0IE+A2GT7JCh8TJmWYA6qiyTxUtW/QV7076WXcixvAffoE+u3CdFBpUH5ubfWFYKRl9V9I /OvaTYpY0+xvVvMqIylLWTmjuTKH7uhDic8Q6twEKy+ucYS4Doo6R+iY8zZOeZBPTWPfjVzYuzP Tt/hpkDNogojwR6qsfh5+RbvrACEJD6ittMOm+p4oG9Exytw X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_445454_74535D4A X-CRM114-Status: GOOD ( 13.16 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 5d627048c420..e3d09dd5963b 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -2021,7 +2021,7 @@ static int stm32_fmc2_nfc_probe(struct platform_device *pdev) return ret; } -static int stm32_fmc2_nfc_remove(struct platform_device *pdev) +static void stm32_fmc2_nfc_remove(struct platform_device *pdev) { struct stm32_fmc2_nfc *nfc = platform_get_drvdata(pdev); struct stm32_fmc2_nand *nand = &nfc->nand; @@ -2045,8 +2045,6 @@ static int stm32_fmc2_nfc_remove(struct platform_device *pdev) clk_disable_unprepare(nfc->clk); stm32_fmc2_nfc_wp_enable(nand); - - return 0; } static int __maybe_unused stm32_fmc2_nfc_suspend(struct device *dev) @@ -2103,7 +2101,7 @@ MODULE_DEVICE_TABLE(of, stm32_fmc2_nfc_match); static struct platform_driver stm32_fmc2_nfc_driver = { .probe = stm32_fmc2_nfc_probe, - .remove = stm32_fmc2_nfc_remove, + .remove_new = stm32_fmc2_nfc_remove, .driver = { .name = "stm32_fmc2_nfc", .of_match_table = stm32_fmc2_nfc_match, From patchwork Sat Apr 1 16:19:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764102 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=r4FK43Qd; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=qPxQHeIh; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj9G3PjRz1yY8 for ; Sun, 2 Apr 2023 02:22:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mYTkrMhvPOmh+W6GL3dZsGiVgJAOknqKCLQEX5ynwgo=; b=r4FK43QdLzSYMb 6KjdJv9jZAaFbDwNpxqJ/ubkyz9cLvp8GOnCYSE2LSeWKECjNHeJFxkFEvp8xAMVNvIVCKSMIr3aJ KgwD1tVbiXIVJCFXz/d+3vUi9xiUeko5rDmld8+6hM264CV7NgfL/t39OivbJ+XKC076p4yGZDwFo Ra55dMJBercQxheWN0BkGIQz53bChbmBJAdyf5eNy6BxemWz3BWclOY25KY5JjaX08BrTSlgQOXm7 T5odQye/iwWklqAAF1s5b5EhS1kIaA3jcKerq6llNY0hflIyRJQGjwMtcl9Eqjsj6P1gQxM4bTzoU ZnVZUn+2lVr1CREY8Hzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidz1-00AtHf-0U; Sat, 01 Apr 2023 16:21:39 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxg-00AsJW-0g for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=/4VgSFI99GQlsIZfx+4Tl0jOWRRxkDfP1BWBHQUPIv4=; b=qPxQHeIheC3uZY5eVKa1zMEV+/ B16kEmm4klPspgNT2S+trLdAcSx1r3r/4wCEUiCLOTRYGAddA3zaiIBWcztr6EA3Wnr4FKF1tVE5J 37QqlMZBACHBdjWVQqyEH3kugUwG2TXtpTnBQlY4BEyUqlTQE/8UeRarLbTiyxeO78Y88Wp4hhj5G CZ7i99NltjAZUgfoIZU9X4bcv37byLgrhLdlzaXJo9yBwjX8jJf3QhBbSPNbgTRQC6Fq+Lx5cwgb9 yvv3ZGcE2ztHHhuD4QoHO0mvxavosCVGR/0f1SUgKDWFhhVuq/TT+mFF2h20aAhWltYjfr6ppDBnC qpz+n07Q==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxc-008DL0-0o for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxO-0000H3-NT; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxM-008GT3-M6; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxL-009ki1-Tu; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 46/49] mtd: rawnand: sunxi: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:35 +0200 Message-Id: <20230401161938.2503204-47-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1784; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=X08OgOol1r208v7SCAuNsUZxIRp3p+XIkNYqv7E4PHI=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNyKCo+xreZc9zV8yU2Oldn8YmpmtaVS3SNHWHwrkTq SZWMYc6GY1ZGBi5GGTFFFnsG9dkWlXJRXau/XcZZhArE8gUBi5OAZjIoXPs/xRCHErE9lhOFfhr rvixW1s9IPn0X48I7hPuaZudfAx+3dQ8OFdLWrHCb7nk0+a+VUrVfgXfnm+2Wbhq+YSTy2dwcs+ 8e2tFQdANicKeA6zJNw7M6PZw2fj89Zk70kGa/h/eeOV5bOzPXqBtae5UWLf2N6/T6fYfhZ0dS+ Wbb13Ub7QIqTUpqTt5lq2ivUeB1ShjgmuPR/CaxnW3fu/5lVJ1S/72oUXSj1m3Ho27/nBZ5h5t5 YYfl9ikhC4ozomcsKcnIKxkYs+K1PBT+uqJ91Q9PTdN8WF7kKk1N3ddjXBC29RC6bV8SZse1My9 W8pkWy4mXp94ZOkj/qCL7z7r1iis4swumHU3uD9p7oG9AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172012_500334_A853021E X-CRM114-Status: GOOD ( 15.96 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- drivers/mtd/nand/raw/sunxi_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c index 13e3e0198d15..9884304634f6 100644 --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -2173,7 +2173,7 @@ static int sunxi_nfc_probe(struct platform_device *pdev) return ret; } -static int sunxi_nfc_remove(struct platform_device *pdev) +static void sunxi_nfc_remove(struct platform_device *pdev) { struct sunxi_nfc *nfc = platform_get_drvdata(pdev); @@ -2185,8 +2185,6 @@ static int sunxi_nfc_remove(struct platform_device *pdev) dma_release_channel(nfc->dmac); clk_disable_unprepare(nfc->mod_clk); clk_disable_unprepare(nfc->ahb_clk); - - return 0; } static const struct sunxi_nfc_caps sunxi_nfc_a10_caps = { @@ -2219,7 +2217,7 @@ static struct platform_driver sunxi_nfc_driver = { .of_match_table = sunxi_nfc_ids, }, .probe = sunxi_nfc_probe, - .remove = sunxi_nfc_remove, + .remove_new = sunxi_nfc_remove, }; module_platform_driver(sunxi_nfc_driver); From patchwork Sat Apr 1 16:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764112 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yYpBGwsw; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Oq/MYdHB; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWl4hwQz1yY8 for ; Sun, 2 Apr 2023 02:38:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8W6/DZlyOxTccZ2KnfFQW+4Vu15PcfZe8bAZRJ3G+zM=; b=yYpBGwsw+5/bkI 7mp5XCakEILdr46YPyMP+8JLoF/4XHypRAuasKJmYqYRn0mtGDRuarzr7Y93R8Ee+EjDVX8rd/fGE 0Mw3YkvnwmgyQBIB/bTzgG/hlsKQRNvJeoudJZm2AxOGvtzCG6cfL+lwIGrCceXOnXpWQ3xfEhNQo N1Efq5gOMaQZr3h09ODho2zDg49dUusKhRllzRfLyUNABdnR8TiJkWdtYFiSSVclTJNuR2RCK/8/J qbeufwFJcSn/0CSbBdkUqe8GlC9bqCEjp/SuasRVMn1fXjgDXS9YF9yLohB6zYDUO05VT2VtaNe5n m6uQxufkSeTVYucWS6YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEP-00AwXh-0r; Sat, 01 Apr 2023 16:37:33 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEI-00AwRk-2D for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=301kFvtK4RtbC0nZ+yzzxf3wyF/k/mU8UZOl0iG7Pt8=; b=Oq/MYdHBBhToiBhv1/UrGxvu+v mggtr2hurbLTkTLpFxAqmKUMZPrIeA/l4bkRhDujDnQ5U/VmqUrmvobq26EOwWabNKJ1qftiGGGs/ xCxl3NX6jHUM0aRfpLwviOjYWjndnfN6bUhhj9fFBDgMm5VQdWh87uhZBcPjj3vikbWYk04bAgZGH 9UbbjeLj4dT6Ty0hVYINi8LSPTjhdUFni9Hi2RlpidyMJughOp2VtWTdWRde6RZuA3+TPCyZGUHZm iihWlhpUDbtekxKx7TuMipa3eHm0pc1QJsch39U8iozZBCwbKFayQ5TMzU4dUuwVoS8iif7AW/5On PuoTSCpQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxW-00CYSf-4g for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxP-0000ME-Hx; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxN-008GTN-Gb; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxM-009ki5-4s; Sat, 01 Apr 2023 18:19:56 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stefan Agner , Lucas Stach , Miquel Raynal , Vignesh Raghavendra , Thierry Reding , Jonathan Hunter Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 47/49] mtd: rawnand: tegra: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:36 +0200 Message-Id: <20230401161938.2503204-48-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1816; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ZiZFcm2VIBzpJkDbD8DIuKg1PQYv1Ul6eBh2oA6JjdA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlTMtlZDjKeoygTPmrf6hZi+i2/pICmViBsi CEyn2O89+WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZUwAKCRCPgPtYfRL+ TkNsB/9QNZahdyLisGkG6jy26g0n4gYeXOUuhi1ekybIlVCO75qsiXWDUGQW4WmM5mx7lcyXmTi zoODOr5CJP8UuKYOqC2T2jSOGFvN2dKtLdh4mhyHaZNdyksoGw0rUCIfI1JlmtSXNo5HaAsp3hx PXoO18Q6yocN0esmIkwUnIOZ0PPelpNRn5cGrZ8zfQtvHPdwjdXGenW4tXgwEedXsr7erMiVqfQ VmPufDSQ4DtguTF2kXXQkReGR3+tjsotqqaYPkZtbkQg6Ak3c6cKKSQeP4x9pKozNhW1VPvTLKL d2fiVOEnWXUb+Fk2HNrSzLjffkCV8HB7RDN7zkf/V9leigQm X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172006_239123_5AEBEA74 X-CRM114-Status: GOOD ( 12.85 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Thierry Reding --- drivers/mtd/nand/raw/tegra_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/tegra_nand.c b/drivers/mtd/nand/raw/tegra_nand.c index a9b9031ce616..eb0b9d16e8da 100644 --- a/drivers/mtd/nand/raw/tegra_nand.c +++ b/drivers/mtd/nand/raw/tegra_nand.c @@ -1220,7 +1220,7 @@ static int tegra_nand_probe(struct platform_device *pdev) return err; } -static int tegra_nand_remove(struct platform_device *pdev) +static void tegra_nand_remove(struct platform_device *pdev) { struct tegra_nand_controller *ctrl = platform_get_drvdata(pdev); struct nand_chip *chip = ctrl->chip; @@ -1232,8 +1232,6 @@ static int tegra_nand_remove(struct platform_device *pdev) pm_runtime_put_sync_suspend(ctrl->dev); pm_runtime_force_suspend(ctrl->dev); - - return 0; } static int __maybe_unused tegra_nand_runtime_resume(struct device *dev) @@ -1277,7 +1275,7 @@ static struct platform_driver tegra_nand_driver = { .pm = &tegra_nand_pm, }, .probe = tegra_nand_probe, - .remove = tegra_nand_remove, + .remove_new = tegra_nand_remove, }; module_platform_driver(tegra_nand_driver); From patchwork Sat Apr 1 16:19:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764116 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=X746vr2U; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=fB2H+t16; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWy2fWBz1yZB for ; Sun, 2 Apr 2023 02:38:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKWeC3wNwHifLVF/Chf0GLb2K1LhmBuppV6BD6BV0dE=; b=X746vr2UYiDvRI a1VsbVuvDw3ADtWo/BDO+eleHm0/n4G5wt6wxOtl0IxuUxnQPseGoT+acSDPv7eXXMNNuqYoA6Ja3 V9XWBrTxRPW0vhRPCm6T4ghbgL2hQtE5efSsU1O+QgHleEUTC6YYHcokmi2efPEMllbiH2Sy72c4Z J0JGh4LfYDXjxac4o5XhvbsGdZlPcdjnJG6mEseP30dvkO4pWqiLL/JKpO2GFs/ZJajYXXF9ubgUR rV6h28JSEoO9xq7SGDi9lGXQ7aznDZzAKAsi4ujB9YTxxIE/F1PNObANnbIqNNdP3I+D9QClL8tIR 4zxP0WJeNeSSU5WyMxyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEZ-00AwgM-30; Sat, 01 Apr 2023 16:37:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-1t for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=6YTKVNhVYU62naPvmcQkueKVrUUgKaFRioux7XyGtTQ=; b=fB2H+t16Fsi5z7arKOuipN4yDp c80PvoTslVnOssAKA7b5kjCZQxU3baj06leEYxnPkD+UI0u800S+6XsUdBrVI+mahZSW3K5b04lo/ 61/YDmHWok0XBhUK64QWEANf3If7SpuFNxLZzM18WAZUDcV8RoVEz6BPq7FBUOZdMt4zVXKMxYtGX GvBQI68mbd+c/WMU6xtgggbFDucCpZM0+lFHu45Rj2Of+k359j5dxYYaAbiBslcIUZ3zhQTwzD64B MQlXkCBsaFFk9jiv782UoPLkNcIo2qjONstRtBmWhTTQa48D3KjmgleFuInwhkcrspkdEr7I1Oykn Pr4URbWw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYPV-TS for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxP-0000KV-3K; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxN-008GTF-5z; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxM-009ki9-B8; Sat, 01 Apr 2023 18:19:56 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stefan Agner , Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 48/49] mtd: rawnand: vf610_nfc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:37 +0200 Message-Id: <20230401161938.2503204-49-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1725; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GrOH76yu1PLnzUKUatdG4MKq+Rlpxkq3aALTBWGM8g0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlUJYg3gY/NAkBfrkLhlIZgasPREVAV91JkC IdFJVgdItuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZVAAKCRCPgPtYfRL+ Ts1RB/wN3Lp3pwj/SNhPT4HWNXt1w8rPHZM2lc6ay7a/MDHYe93frEjuBQvMy/HwYGVU5NyIkjY FGgb1UjzTvm7HJ7ypQSrzPW1smfQQC6knc2BbRd2GczYAVHDyTtsfO9axrz1rEs0kPBOU5xnt7Y /6erqh4aT9NmPGzkYT7rCoOEfLL9A1QPT105S6Qvj+gc7dfG7CypS4+mF5xgrxfF/l3u+FVBHrT VCVTY9shVs9JBVelCL4PW/QNC+4cB6FVlpHREhi26z29ETB6HR14DwX5krCAifd/s/9oVgydagC K3Nst8HQGbuzNUyeJL8yrtDCTraawyiKm4pNbj8SXyp831mH X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_993994_7BC6C177 X-CRM114-Status: GOOD ( 12.66 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/vf610_nfc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index b643332ea1ff..86522048e271 100644 --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -909,7 +909,7 @@ static int vf610_nfc_probe(struct platform_device *pdev) return err; } -static int vf610_nfc_remove(struct platform_device *pdev) +static void vf610_nfc_remove(struct platform_device *pdev) { struct vf610_nfc *nfc = platform_get_drvdata(pdev); struct nand_chip *chip = &nfc->chip; @@ -919,7 +919,6 @@ static int vf610_nfc_remove(struct platform_device *pdev) WARN_ON(ret); nand_cleanup(chip); clk_disable_unprepare(nfc->clk); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -955,7 +954,7 @@ static struct platform_driver vf610_nfc_driver = { .pm = &vf610_nfc_pm_ops, }, .probe = vf610_nfc_probe, - .remove = vf610_nfc_remove, + .remove_new = vf610_nfc_remove, }; module_platform_driver(vf610_nfc_driver); From patchwork Sat Apr 1 16:19:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1764089 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=4HLHFC1l; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppj8C3ff3z1yZK for ; Sun, 2 Apr 2023 02:21:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a+RO6t3j8MQE1Hm6fSwzhypJM97LQ7H0gyFToPKD8CU=; b=4HLHFC1lcEvaYv nKLHBbnmsoC5dounq7PoY768hSBN0vDu03+GzJ/CVUkgZCTXA7jyrbq9WDEGhpE35M1ooX2fP6GNL O6A/TOsSS8J22ykEjxaPotPalmOrslc8kWkMxSFHCGCyURmyQMAKngNea75jREjiZIXkHszNijCMs 1sMobe8s9pEOSD+q2cMWJ59ReDFq8WW5yYO8c7Js1rvAkxatH5QeQyPkCy08FPAKKHiwegS1pwThQ kHwWE1ENHfkgvw2J7r21U73VDkng8y8jzrPVyFnrYo+qZ1j6DDgDzWR8+4CA7Zg5ApwLcbhHEhmZH wBI0Xx1wfpy7aAg9HmdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidxq-00AsOR-16; Sat, 01 Apr 2023 16:20:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxX-00AsBA-15 for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxP-0000LW-CS; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxN-008GTK-CY; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxM-009kiD-J4; Sat, 01 Apr 2023 18:19:56 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra Cc: Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 49/49] mtd: rawnand: xway: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:38 +0200 Message-Id: <20230401161938.2503204-50-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1857; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5YFrUJmlWlgutYJkBqaIuy6wBe87bfq4UYHWS2feeYM=; b=owGbwMvMwMXY3/A7olbonx/jabUkhhSNyNCUthCJprCWx3lbffnOK26vdy6ecExl5eZ9h9RKb 3SuCSjqZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAiL1ex/08W/rYqakYgj2bg p+RjeYvUHK+xfxJnm11/beafW7rXrt1L/T55m9XPu76LNJxOSyTpcPKG1uk9FT4s8lBgzrVUrUs /7u7ccbxB7PUme0dB/6MPrpjIXW6LWaPlySS369OExo7rn+pevQtv8rp90UPOQ1MpWM+u8/EbzW 3/MuaurrTQre26obTv/Zf85I1dm870NDsrq0kkZDyWMIxR0X/wIaKl/Pm9F9z/dCpYyvdJesT/Z MsId+sMUzGMTGCRkD4amv9uwfK6hHf1DhlJzREpEd2ae/dqLTHmDPX+fJHvluCZX6GBH3y9tBfx Ta8/dW7+JvUP7gtYTO6fvffE2qvpYZYRj1dSjMz81I88AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092007_395386_2DD66CB6 X-CRM114-Status: GOOD ( 17.53 ) X-Spam-Score: -2.3 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/xway_nand.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c index 035b82aa2f4a..6b1e2a2bba15 100644 --- a/drivers/mtd/nand/raw/xway_nand.c +++ b/drivers/mtd/nand/raw/xway_nand.c @@ -238,7 +238,7 @@ static int xway_nand_probe(struct platform_device *pdev) /* * Remove a NAND device. */ -static int xway_nand_remove(struct platform_device *pdev) +static void xway_nand_remove(struct platform_device *pdev) { struct xway_nand_data *data = platform_get_drvdata(pdev); struct nand_chip *chip = &data->chip; @@ -247,8 +247,6 @@ static int xway_nand_remove(struct platform_device *pdev) ret = mtd_device_unregister(nand_to_mtd(chip)); WARN_ON(ret); nand_cleanup(chip); - - return 0; } static const struct of_device_id xway_nand_match[] = { @@ -258,7 +256,7 @@ static const struct of_device_id xway_nand_match[] = { static struct platform_driver xway_nand_driver = { .probe = xway_nand_probe, - .remove = xway_nand_remove, + .remove_new = xway_nand_remove, .driver = { .name = "lantiq,nand-xway", .of_match_table = xway_nand_match,