From patchwork Mon Mar 27 08:49:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1761450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::237; helo=mail-lj1-x237.google.com; envelope-from=swupdate+bncbcxploxj6ikrbl5rqwqqmgqe5auyz5a@googlegroups.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=NQxvggOf; dkim-atps=neutral Received: from mail-lj1-x237.google.com (mail-lj1-x237.google.com [IPv6:2a00:1450:4864:20::237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PlRMp0hNZz1yXv for ; Mon, 27 Mar 2023 19:49:56 +1100 (AEDT) Received: by mail-lj1-x237.google.com with SMTP id t17-20020a05651c205100b0029f839410fcsf1547705ljo.1 for ; Mon, 27 Mar 2023 01:49:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1679906992; cv=pass; d=google.com; s=arc-20160816; b=fy6SoDSXdQK/Pg+2RJpeEVwgHM+DZbfxHhW2lt4RLTAo1fyxSiKrjgDK0oBlu+y7tg JvFYhCfWd9paKKk/suMgGvH9DgFkLBLE3Exbu417X5XRj6zSC25LgBQAYL9qcavhyb0X EvH/6Xj7lMeBzlT5vuI3+0RlHbQACCixpL+G/UBxmvCMl93v9UVecKphqDmA6fC1AmFS Q1V+Avda3PiDoWh7ukER3D+zIteZmpxk0n92CcNuNXjin+fqlbrPf0zk1vwxMhLsvyLL xwJ9t1cxT8N3txG2gjvEW9KbY1/QnZ59cuta1bSTlA9wAYNGJ+FKd7u/k2sWwN5gfT1E +raQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=yH5SFC6hKfv7h6PEQ82i4ia3Q9OOpwj6eJXQGIxNzH4=; b=VpGoAK+dplsCLTGdfDB5jaxZR8zfrV6Sm7u/P4dItp8BwJUiWQ33OswhBM/EMyh+C+ 7mDD548x8HmC334SzwBg05o0Ibs0YUk3rZS6e2VmW+jy+Llj4xxKEyCzRbgSsE7eBp1K BdCte9dcP0HMkc95CJIYrba0RKGNqluLSA+OBxHz0C6p8tsAco3A05T3abjHvRgYc82t e6hkj5ONEIa1GxpMLOTaDQO5KEuKbUMJXyCRNl3Zta78BfgzVWAy22QGgU/fdw7WGD4v gePwjujSUsahqiMbXjUrEKqxRrrJjrHPYzE+fLJy+d4y52NzFTCFXEjf7vXA/NuxeVr2 nFTQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; t=1679906992; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=yH5SFC6hKfv7h6PEQ82i4ia3Q9OOpwj6eJXQGIxNzH4=; b=NQxvggOf9R+FNbzGCuCOq29JC8N2bp7FkDyPW+Ri/Kg/7qlCTqinJhta3ufeI7pL+/ 4JwvuGfqOIiqHVK6yNxR8DXWr08gsevCMSfRSiKKSpHZSX6ILhGUGcChzunAlU2JrEHW k7CPSFwptrLV+6pFxtuDLETSxD+ASyLndiY+nDAP3Zgle6DCeE5iycwr3d1d5ckvFplr /GLjViTmf7a6h81y/WC4ShPQryqAHrO/WCSrlFznHtWFNH0F1rJsJ4rl3MF5Hi1mgJjc g7wiCwsSuFDPWJqy3Vo7B6qmw2PWuaJHUw3Z84v9pl4b/ZqJwegjguygHEl1GRqJgQ2H wWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679906992; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=yH5SFC6hKfv7h6PEQ82i4ia3Q9OOpwj6eJXQGIxNzH4=; b=jgK1Y66FHvk73g9Y1crGM6lw2Bvq/nEy94dZ27R8pqL9womSMvIv66TA7jdv+ic1s7 knhwrAjn38KHcVzCeXza3Edb3zU9GGr9SXTZolbmSYNPAFyQ5z02i2lRmMmwPCgAPvvl uDgIeNAm5HwI0Z554MVh+vPITMtE+Vhr5aaRubtSRFPERCLCAKhCnREYH9SgQgmgkrPe JtWwiNcwyhjnrY6Xt8qpHbFcjyIn457gl2LXUedDYUYf6rTtKFxhl9FJuz2g/xUbEXNb axi5ZBnLJyVy5O/50Lsc8EL/hbSr90Si+7YioGAAEoD91s5eF7AD2V/4gP7Jr5IazS+H BGYw== Sender: swupdate@googlegroups.com X-Gm-Message-State: AAQBX9eSQSX0WUb4fV96NSYmg50RfHJnOAEhSFBJFNy0HVgunEUBYjn0 Od5KMKO9f7N8Uic5luszVZw= X-Google-Smtp-Source: AKy350ZHeKXZ75i5nEd7z6Ye5Su8dkez6J0Asgg6ikZq1uQlXZp3VNJMLIsAPTrA5Tfe//+rVUeu6g== X-Received: by 2002:ac2:4436:0:b0:4e8:9049:b640 with SMTP id w22-20020ac24436000000b004e89049b640mr3088663lfl.4.1679906992554; Mon, 27 Mar 2023 01:49:52 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:651c:a09:b0:293:12a9:1ca5 with SMTP id k9-20020a05651c0a0900b0029312a91ca5ls1353277ljq.6.-pod-prod-gmail; Mon, 27 Mar 2023 01:49:50 -0700 (PDT) X-Received: by 2002:a2e:9c52:0:b0:298:a79a:e3f3 with SMTP id t18-20020a2e9c52000000b00298a79ae3f3mr3234386ljj.1.1679906990875; Mon, 27 Mar 2023 01:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679906990; cv=none; d=google.com; s=arc-20160816; b=HLRlBQQOyeWcDAV23FTujnWx0NeD7Rk+Qypu/VWi9aw71NwjRCI2N31fbafnxLDdYl rp5a/cGtrhJOs2TL7B8uXBK+4tgYG4C3/DsmUnlx6jmRThHZQyXnWLGF1JLjW70DS2YR Hu/IOJt+UPefeUFVMBdI66hqgebuTJVU4e9/EMZ54cLdO2Y8M3wi75hhMsi6oCim44mW 7ToaN76qCyuYhD3w1dordgfEkx3OHD5iTaiUsMVXO7sa445bQgve/dUots9R58mKemeU 9cnEauMo8CljOwI7hgHqyUtdY+ENNIRltE4Ek32jhxsmjE7conDcovGIXWgp9NcWU6OG Ya1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=Jy7WE61Z5DJnO2cfx3p7YA6UMvZvDXCafnmZv2VSYiM=; b=eGtnLFOQlktX3spchkl+jrP7HC0vAEPq+8rmLyCzSPBbNvOQJnQYt7KIewY0fTLvGU +l09+eqr0VAP4/1MiI6zyRGssubBu1U/YQhiutuWyhW3DRzjQTRgMHH8iVS3FeWFjY8d NSvB+oRXG0nyR22zdfYwfcklKndEx55hkYC5rW6K3aE4KCROpbjjyJgaf+2MRuEUWPqf bZCJi3jzBWt2eetxFBgF4Mj0RczaZ7WwJEGEc66W18eBXcpxSAEAJEeG/kVHw60Gk+2L uVnC8saC3QI46ktYkHT2By0IKWUUr27DAOU6FD2BnaJ2xPa2sB8nZbmrpq1GLmbJiyYR fTdg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id j17-20020a056512399100b004e848d12fdbsi1499510lfu.7.2023.03.27.01.49.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2023 01:49:50 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=212.18.0.9; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4PlRMf12cjz1r1fw; Mon, 27 Mar 2023 10:49:50 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4PlRMf0h1mz1qqlS; Mon, 27 Mar 2023 10:49:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id NfevJfu_ZCVn; Mon, 27 Mar 2023 10:49:49 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 27 Mar 2023 10:49:49 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 8D4A44540E35; Mon, 27 Mar 2023 10:49:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id A_YwXQ-kVkdJ; Mon, 27 Mar 2023 10:49:46 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id E87BC4540C14; Mon, 27 Mar 2023 10:49:45 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH V4] delta_handler: fix coverity Date: Mon, 27 Mar 2023 10:49:44 +0200 Message-Id: <20230327084944.107936-1-sbabic@denx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , This fixes: "Argoment cannot be negativ" #343301 #451058 #343302 Signed-off-by: Stefano Babic Reviewed-by: Dominique Martinet --- handlers/delta_handler.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/handlers/delta_handler.c b/handlers/delta_handler.c index e078157..4ce49ff 100644 --- a/handlers/delta_handler.c +++ b/handlers/delta_handler.c @@ -1095,9 +1095,9 @@ static int install_delta(struct img_type *img, cleanup: if (zckSrc) zck_free(&zckSrc); if (zckDst) zck_free(&zckDst); - close(dst_fd); - close(in_fd); - close(mem_fd); + if (dst_fd >= 0) close(dst_fd); + if (in_fd >= 0) close(in_fd); + if (mem_fd >= 0) close(mem_fd); if (FIFO) { unlink(FIFO); free(FIFO);