From patchwork Tue Mar 20 03:07:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 888021 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (helo) smtp.helo=arrakis.dune.hu (client-ip=78.24.191.176; helo=arrakis.dune.hu; envelope-from=openwrt-devel-bounces@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LIpVU/SI"; dkim-atps=neutral Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 404yYT0bWzz9sWB for ; Tue, 20 Mar 2018 14:08:10 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id BDCBBB8065C; Tue, 20 Mar 2018 04:07:59 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP; Tue, 20 Mar 2018 04:07:59 +0100 (CET) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id A7180B80334 for ; Tue, 20 Mar 2018 04:07:57 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .linaro. - helo: .mail-pg0-f66.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7 Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Tue, 20 Mar 2018 04:07:55 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id a19so101549pgw.6 for ; Mon, 19 Mar 2018 20:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=knat3QhzBQLwXGTw3x/k9ayd0mBszLy35xWUyB+xMh8=; b=LIpVU/SIkyfmQwjGJcg//eSlwd1O+02UEzT6Tx0TjByV46E0dSIZMGHJaBnD3GQX5p ITwHOnGqbt9Ru88fZ6fduMWiuJtn26DF8XFlGFMolrc7O1F/zF7UwwdMQR/AxpE1JO0K NM2FhwIBA7VZQtX4s6uFmItNMj7Q+qgnv71Pw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=knat3QhzBQLwXGTw3x/k9ayd0mBszLy35xWUyB+xMh8=; b=myN6lTLGYYvniVxIgFdlRaCzwsbFJmTp1UYBI3G1BJzcm2wBVZ65ibvrzB9MdoFv6b D1ry41A0b/iouHqFh74HqI29oz5M4EjyGiwyPyhR6eiJ/ccdNgo9slQHI7iBaCoUALhC Jorr+0BTUBHCvyuOdKPe5b9Vo3EknGJmqiZwWXejDKP/cNE/ysLGUxZHHVB3ePpbG9f1 HVR6VTbzMGV7DoyoNfATi/E49A/FXR/0YigfZfNqVCHNMyeS337QnxvQ+suIWdztkjZH mUOgGPm7Z2v9DypdZ7+gRF7pdvbwMk6whwVxKVK9gADjMP1dD0Gdt5kzGWE21zRR/6WX wF6g== X-Gm-Message-State: AElRT7HfMCHZiWKavrBcuDTdBpzYUpXVmp1rbuX4dBIP0zxq3NxthHgR OT79/OHj6Uvmt/POjdNCAjjLzA== X-Google-Smtp-Source: AG47ELu2AumIGOIw5LQGyOCgSRY3IrKfYIowFsoVixQtd8yfQyle/RrHP8a4B8eJc4IJMD/2+UPhMA== X-Received: by 10.99.117.86 with SMTP id f22mr10627656pgn.180.1521515273208; Mon, 19 Mar 2018 20:07:53 -0700 (PDT) Received: from localhost.localdomain ([218.255.99.6]) by smtp.gmail.com with ESMTPSA id r18sm656066pgd.46.2018.03.19.20.07.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Mar 2018 20:07:52 -0700 (PDT) From: Linus Walleij To: linux-arm-kernel@lists.infradead.org, Hans Ulli Kroll , Florian Fainelli Date: Tue, 20 Mar 2018 04:07:45 +0100 Message-Id: <20180320030745.9958-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.14.3 Subject: [OpenWrt-Devel] [PATCH] ARM: dts: Set DNS-313 LEDs to use better triggers X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Janos Laube , openwrt-devel@lists.openwrt.org, Paulius Zaleckas MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" We just used one LED for "disk activity" but using the green LED for disk read and the red LED for disk write gives a way better user experience. Signed-off-by: Linus Walleij --- The necessary changes to the LED trigger has been merged to the LEDs subsystem. --- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts index da8bb9d60f99..5fb3ea8bf300 100644 --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts @@ -59,14 +59,13 @@ label = "dns313:green:disk"; gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>; default-state = "off"; - linux,default-trigger = "ide-disk"; - /* Ideally should activate while reading */ + linux,default-trigger = "disk-read"; }; led-disk-red { label = "dns313:red:disk"; gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; default-state = "off"; - /* Ideally should activate while writing */ + linux,default-trigger = "disk-write"; }; };