From patchwork Tue Mar 20 02:46:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 887996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 404y4Z1tM9z9sW7 for ; Tue, 20 Mar 2018 13:46:38 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="LXOniMKM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NQQR4r8V"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 404y4Z00tjzF1kW for ; Tue, 20 Mar 2018 13:46:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="LXOniMKM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NQQR4r8V"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mendozajonas.com (client-ip=66.111.4.29; helo=out5-smtp.messagingengine.com; envelope-from=sam@mendozajonas.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="LXOniMKM"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NQQR4r8V"; dkim-atps=neutral Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 404y4T5bt3zF1dG for ; Tue, 20 Mar 2018 13:46:33 +1100 (AEDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C10FD20AB3; Mon, 19 Mar 2018 22:46:31 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Mon, 19 Mar 2018 22:46:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Fo/KJudY4Mznbam7a LG4+NpCuX+6B8qrUy90ogcgKZ0=; b=LXOniMKMCBfZWNnvnKkoZUOEPfrvgYjVs qzzQNY0H01UcRnQExdaBS7ur4tLSQ6KBwkBhBN02I7p74rJOeBNOxSH/Gt3tn4qJ s4fbCMQpYd3AvpocsVcFxu2tNsE9B0U8EExB1SOycIb7wS5hah69+GQgMj8V+FrR 7yDZYgKDxoih6MqVvl0aYakw3lhBaId4BG4K1j52KFNkoXZ5D99lJ/npNM3KmcFq b7pWT8wIhaRU151PTREROX2RpqpIXgValHmPR3ihZhpmK/le6LbCGfsSfTXKU2v4 b08ytTcC7uzsq1pkPv0u7r8leAMdUct3LVMaWacgEQ0IiXXt2G7hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Fo/KJudY4Mznbam7a LG4+NpCuX+6B8qrUy90ogcgKZ0=; b=NQQR4r8VJZ/+Z0bCPXcvm63rwD8nSuYEP 5G5Ym7UbsiG/jADph0KC0d0j5Km2hIJVdyhR3S3glCR8QlFG7FiXLAQ98DiMRTD2 9AeDHUyLfola/v/x6jxgACz9wSaCods8zHm6DBlL89oO7UV71eSEwMVjjOoSFi95 4mSlqBQTtbnQzw8wrIMp5d+oUyffRJflyixzfLs6+tHAB/1fCaU8zNPs4rV2DxSV f2YnFzXWt78DOjcB16ZM9YwhJNzMlCbs48QT53LZrIric/TcMDvEkjRDF2JuEpBP fZf/i6hl005Fpj6rf9TgtCJgMh9iKaIo+727GBnejG9Y+Bus99okQ== X-ME-Sender: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 974B17E13B; Mon, 19 Mar 2018 22:46:30 -0400 (EDT) From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH 1/2] discover/pxe-parser: Avoid potential null dereference Date: Tue, 20 Mar 2018 13:46:21 +1100 Message-Id: <20180320024622.4435-1-sam@mendozajonas.com> X-Mailer: git-send-email 2.16.2 X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" Fixes Coverity defect CID 149918 Signed-off-by: Samuel Mendoza-Jonas --- discover/pxe-parser.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/discover/pxe-parser.c b/discover/pxe-parser.c index d2ebaab..fd8b8e8 100644 --- a/discover/pxe-parser.c +++ b/discover/pxe-parser.c @@ -273,12 +273,14 @@ static void pxe_conf_parse_cb(struct load_url_result *result, void *data) if (!data) return; + if (!result) + goto out_clean; handler = talloc_parent(conf); - if (result && result->status == LOAD_OK) + if (result->status == LOAD_OK) rc = read_file(conf, result->local, &buf, &len); - if (!result || result->status != LOAD_OK || rc) { + if (result->status != LOAD_OK || rc) { /* This load failed so try the next available filename */ info = conf->parser_info; if (!info->pxe_conf_files) { From patchwork Tue Mar 20 02:46:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 887997 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 404y4m6wwYz9sCL for ; Tue, 20 Mar 2018 13:46:48 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="RLNz2KPq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="d/2g6kM5"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 404y4m3rkQzF1lG for ; Tue, 20 Mar 2018 13:46:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="RLNz2KPq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="d/2g6kM5"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mendozajonas.com (client-ip=66.111.4.29; helo=out5-smtp.messagingengine.com; envelope-from=sam@mendozajonas.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="RLNz2KPq"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="d/2g6kM5"; dkim-atps=neutral Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 404y4W2BG9zF1j9 for ; Tue, 20 Mar 2018 13:46:35 +1100 (AEDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3204520A85; Mon, 19 Mar 2018 22:46:33 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Mon, 19 Mar 2018 22:46:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=Ehi89xF/F2Y36VUexcmqszwJzyjIKtStTgV4rczzkzw=; b=RLNz2KPq oE77J0XpUB1Qvw45wnQJ1RnEkIsfQD2pB05JlHiOhAwDBGBd1L1uZNQK4FI3wrqt ndqqTMIKyCBzNTbKrS6zsvfiSgsbvOPWOz5F56zYYqPSpjGvr+enOv4vK+a9KVE8 2MCCsMx/7b91F03b3/2c7XBowWHcXNnwdiAkSIfVAzkJSLqoR+MCjVZH5da9Aox8 OmAP4t1L/6hiopVIxl7eoRPKlD6jE+cFATSfuHQHYeMEvf35aPFBlwsent05H6TR RGa62oRlq6o86v9ndbuki6ro2dy2nJk+sCFYLEpFJN0gVF2/5GSzlIuT/fBFnaed P9uUjlle2miAlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=Ehi89xF/F2Y36VUexcmqszwJzyjIKtStTgV4rczzkzw=; b=d/2g6kM5 6xDg6wyPNuQ1XIh/ojF40mPpBwQy1peKSdHzTUzGjVk2mwOO30typB3olhTHB7a5 Jn7IcI8AFP6tU6HcY9K+vDgGO2cWydfRsnbORK5m6nVGa0yFmLZ/XUD2QMIz8SXH 6tkzZBp7XSOly+lg/IPNMGVtDHLjf7UNwiMsnkJ7XQ6OeCQ9QdBdb7KoJFDOnWJp 0QBfNvc6Bt820uudI6pIVoZCTPszH7NWodYnk9s92gWbUokEyDHyDXOmKbu56gYn /HW0xU7KZg3J3yqZY2Xj996UNkR4t9+OoFAd1dRUOwbMOANjrsmtaNx5FsZa+Q5d D6ujSvfd6PVduw== X-ME-Sender: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 0F4C37E13B; Mon, 19 Mar 2018 22:46:31 -0400 (EDT) From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH 2/2] lib/file: Avoid off-by-one error in array Date: Tue, 20 Mar 2018 13:46:22 +1100 Message-Id: <20180320024622.4435-2-sam@mendozajonas.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180320024622.4435-1-sam@mendozajonas.com> References: <20180320024622.4435-1-sam@mendozajonas.com> X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" Fixes Coverity defect CIDs 143606, 143610 Signed-off-by: Samuel Mendoza-Jonas --- lib/file/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/file/file.c b/lib/file/file.c index 0d18788..57a2519 100644 --- a/lib/file/file.c +++ b/lib/file/file.c @@ -37,7 +37,7 @@ int copy_file_secure_dest(void *ctx, const char *source_file, char **destination_file) { char readlink_buffer[MAX_FILENAME_SIZE + 1]; - char dest_filename[MAX_FILENAME_SIZE] = ""; + char dest_filename[MAX_FILENAME_SIZE + 1] = ""; char template[] = "/tmp/petitbootXXXXXX"; FILE *destination_handle, *source_handle; int destination_fd, result = 0;