From patchwork Fri Mar 17 20:27:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Olivain X-Patchwork-Id: 1758376 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PdbKf2W6lz2477 for ; Sat, 18 Mar 2023 07:27:50 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9455441BEC; Fri, 17 Mar 2023 20:27:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9455441BEC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id voD0DzLevFDp; Fri, 17 Mar 2023 20:27:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 95CA941BF0; Fri, 17 Mar 2023 20:27:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 95CA941BF0 X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id E955C1BF279 for ; Fri, 17 Mar 2023 20:27:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C9EA240576 for ; Fri, 17 Mar 2023 20:27:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C9EA240576 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1A-fpz-jXR4O for ; Fri, 17 Mar 2023 20:27:43 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D626640393 Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by smtp2.osuosl.org (Postfix) with ESMTPS id D626640393 for ; Fri, 17 Mar 2023 20:27:42 +0000 (UTC) Received: from b52572-12.ea.freescale.net.net (unknown [37.174.21.176]) (Authenticated sender: ju.o@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 8A6437802FE; Fri, 17 Mar 2023 21:27:33 +0100 (CET) From: Julien Olivain To: buildroot@buildroot.org Date: Fri, 17 Mar 2023 21:27:22 +0100 Message-Id: <20230317202724.79207-1-ju.o@free.fr> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1679084859; bh=HJbUJZXSukifBu7DZavnbCkNE3CCt0y4OtcwTkj41uU=; h=From:To:Cc:Subject:Date:From; b=XfYKV02Ar8qiXzXAgzNU8Sz5mLJ6E2bmAfvzCOhyt06te9HtF2bbpHjjOspoMr3ND eIvqBpeDiVR7DIo8rfFwW6HtEQ54EZ7KzqZdqrwudhxCj3Bsa6ZKUlBg6KE4gr9pRh bBAlAaLwyu+4zvapyh29uSzwZpYZQDv97kjQXekX/5z21haT8re+3mdsMk0GsZBPtU SdANJa1zmcv1ToIjRD4B1qeFEmuLV9l7TEe77u+dbutlrotldOiM59hww2/RpENUxZ FshRBk6SqIwJ9yZcwvmF41NO9aGjeBa1aPt4WaTqBAgqRTIfAhRLCupDqsMf/aN10t K6lMAkatde3PA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=XfYKV02A Subject: [Buildroot] [PATCH 1/3] package/kodi/br-kodi: fix shellcheck warnings X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Marcus Folkesson , Julien Olivain , "Yann E . MORIN" , Pascal de Bruijn Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" When running "make check-package" on a system with shellcheck 0.9.0, the command fails with output: make check-package package/kodi/br-kodi:0: run 'shellcheck' and fix the warnings ... 3 warnings generated This commit fixes the warnings reported by the command: shellcheck package/kodi/br-kodi Fixes: In package/kodi/br-kodi line 11: LOOP=0 ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In package/kodi/br-kodi line 12: killall "${KODI##*/}" ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In package/kodi/br-kodi line 36: exit ${ret} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Signed-off-by: Julien Olivain --- package/kodi/br-kodi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kodi/br-kodi b/package/kodi/br-kodi index 83d4d4e5ac..bc64515246 100755 --- a/package/kodi/br-kodi +++ b/package/kodi/br-kodi @@ -7,6 +7,7 @@ shift # In case someone asked we terminate, just kill # the Kodi process +# shellcheck disable=SC2317 # Don't warn about unreachable commands trap_kill() { LOOP=0 killall "${KODI##*/}" @@ -33,4 +34,4 @@ while [ ${LOOP} -eq 1 ]; do ;; esac done -exit ${ret} +exit "${ret}" From patchwork Fri Mar 17 20:27:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Olivain X-Patchwork-Id: 1758377 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PdbKx6ydmz2477 for ; Sat, 18 Mar 2023 07:28:05 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 267A341BF4; Fri, 17 Mar 2023 20:28:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 267A341BF4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OLnHVG5EZygH; Fri, 17 Mar 2023 20:28:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 38CF241C10; Fri, 17 Mar 2023 20:27:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 38CF241C10 X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id CFCB11BF279 for ; Fri, 17 Mar 2023 20:27:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AA81240576 for ; Fri, 17 Mar 2023 20:27:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AA81240576 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ODZanbh8SAVX for ; Fri, 17 Mar 2023 20:27:49 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EDF3540393 Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by smtp2.osuosl.org (Postfix) with ESMTPS id EDF3540393 for ; Fri, 17 Mar 2023 20:27:48 +0000 (UTC) Received: from b52572-12.ea.freescale.net.net (unknown [37.174.21.176]) (Authenticated sender: ju.o@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 29C0978032A; Fri, 17 Mar 2023 21:27:40 +0100 (CET) From: Julien Olivain To: buildroot@buildroot.org Date: Fri, 17 Mar 2023 21:27:23 +0100 Message-Id: <20230317202724.79207-2-ju.o@free.fr> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230317202724.79207-1-ju.o@free.fr> References: <20230317202724.79207-1-ju.o@free.fr> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1679084867; bh=HI3mQ2U0CFz5j+LH5/WwzDDTXjr0VhWfT2J619dyWMo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fnK68SFC+2J2ybAaiDI+AbnnPNZD4JEyzpXaGHJgZo/uQ6d/HTVp2wJmhg6wm/Sn5 Wwo+qKk3S9g858YKw5ZLTkNiYt4Ig2FqonSsm7cyMC0q5bpS8Wh3X/xraqV/pYxp/t RbvG+GEhwO4ekyGTqhi1FFwoi4Bk7E5LtG+jv6xAb6KfiN25e2JxSze7uvHjkucY4R bqpO8a6OhCwnUgZz+Nctz1bGwPnM2WxWgnegv3IXbh/9jcAmWnuO2zOJoppjhdurpI +ivQcXWhb5IvDN/2zEt/vHZ4q0cp6QHkGsK9KIpOeAc0vZeaiRBpHbkRxeaFLgHPcS yMUhTMBikSJWg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=fnK68SFC Subject: [Buildroot] [PATCH 2/3] package/linux-tools/S10hyperv: fix shellcheck warnings X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Marcus Folkesson , Julien Olivain , "Yann E . MORIN" , Pascal de Bruijn Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" When running "make check-package" on a system with shellcheck 0.9.0, the command fails with output: make check-package package/linux-tools/S10hyperv:0: run 'shellcheck' and fix the warnings ... 2 warnings generated This commit fixes the warnings reported by the command: shellcheck package/linux-tools/S10hyperv This commit also fixes the four-space indent by a single tab on the changed lines. Since this fixes the indentation warnings of check-package, the Indent exclusion in .checkpackageignore is also removed. Fixes: In package/linux-tools/S10hyperv line 27: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. In package/linux-tools/S10hyperv line 48: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Signed-off-by: Julien Olivain --- .checkpackageignore | 2 +- package/linux-tools/S10hyperv | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.checkpackageignore b/.checkpackageignore index 405e1c5677..04966a9b06 100644 --- a/.checkpackageignore +++ b/.checkpackageignore @@ -94,7 +94,7 @@ package/libftdi/0002-libftdi.pc-requires-libusb-fix-static-build.patch Sob package/libiio/S99iiod Shellcheck Variables package/libmad/0001-mips-h-constraint-removal.patch Sob package/lighttpd/S50lighttpd EmptyLastLine Indent Shellcheck Variables -package/linux-tools/S10hyperv Indent Variables +package/linux-tools/S10hyperv Variables package/linuxptp/S65ptp4l Indent Shellcheck package/linuxptp/S66phc2sys Indent Shellcheck package/lirc-tools/S25lircd Indent Variables diff --git a/package/linux-tools/S10hyperv b/package/linux-tools/S10hyperv index ec934bc972..32887d1b6c 100644 --- a/package/linux-tools/S10hyperv +++ b/package/linux-tools/S10hyperv @@ -24,7 +24,7 @@ start() { for prog in ${PROGS}; do start_one "${prog}" || ret=$? done - return $ret + return "$ret" } stop_one() { @@ -45,7 +45,7 @@ stop() { for prog in ${PROGS}; do stop_one "${prog}" || ret=$? done - return $ret + return "$ret" } restart() { From patchwork Fri Mar 17 20:27:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Olivain X-Patchwork-Id: 1758378 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PdbL93GWzz2477 for ; Sat, 18 Mar 2023 07:28:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1D7A64026E; Fri, 17 Mar 2023 20:28:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1D7A64026E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oq89t1Yo4ocg; Fri, 17 Mar 2023 20:28:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id E6D74401BF; Fri, 17 Mar 2023 20:28:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E6D74401BF X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BCBD71BF279 for ; Fri, 17 Mar 2023 20:27:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 965EE6134D for ; Fri, 17 Mar 2023 20:27:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 965EE6134D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6URfp5pEEEs for ; Fri, 17 Mar 2023 20:27:56 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EBC9860FAC Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by smtp3.osuosl.org (Postfix) with ESMTPS id EBC9860FAC for ; Fri, 17 Mar 2023 20:27:55 +0000 (UTC) Received: from b52572-12.ea.freescale.net.net (unknown [37.174.21.176]) (Authenticated sender: ju.o@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 43EC378034D; Fri, 17 Mar 2023 21:27:47 +0100 (CET) From: Julien Olivain To: buildroot@buildroot.org Date: Fri, 17 Mar 2023 21:27:24 +0100 Message-Id: <20230317202724.79207-3-ju.o@free.fr> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230317202724.79207-1-ju.o@free.fr> References: <20230317202724.79207-1-ju.o@free.fr> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1679084874; bh=e9XMOzb/AkktWCGTZHGHWbQjDo8cC9W1BfMpSX+grT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gJN1i3f2dnq2xLCXM/jNcRwPatXSxSuhlG6PqQTqTR7VzrQqO2URb2bjEpW2GDIUu QmNWog+r9Pr++6AuO40sySnlZfH6F9Mvmr0PfcA+iL1nsRmgrLNxmYVDiqsNzg2vbY gMAECQn+Fvq6Fhse8geMJTmE4X2w3M/10jJ8ZbUCYRXToPwSokBPXgXvwEHZuKf4Zl yYB752rNrEgfM0AwGspM9H11Pis5C8m7LSiQJ3NonDid/rGUbObXXRJIFBKzpfY2bO 7PsojpDZ82QdaL6ZF9uFWqRVQuuF3rynJm8xeRqe12vVW8GdDeinzlIkI/fj7G3/jO 1cJCQwYeuiIkA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=gJN1i3f2 Subject: [Buildroot] [PATCH 3/3] utils/config: fix shellcheck warnings X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Marcus Folkesson , Julien Olivain , "Yann E . MORIN" , Pascal de Bruijn Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" When running "make check-package" on a system with shellcheck 0.9.0, the command fails with output: make check-package utils/config:0: run 'shellcheck' and fix the warnings ... 1 warnings generated This commit fixes the warnings reported by the command: shellcheck utils/config Fixes: In utils/config line 175: if grep -q "# ${BR2_PREFIX}$ARG is not set" $FN ; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. In utils/config line 178: if V="$(grep "^${BR2_PREFIX}$ARG=" $FN)"; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Signed-off-by: Julien Olivain --- utils/config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/config b/utils/config index 5f5e4362e5..9107725a70 100755 --- a/utils/config +++ b/utils/config @@ -172,10 +172,10 @@ while [ "$1" != "" ] ; do ;; --state|-s) - if grep -q "# ${BR2_PREFIX}$ARG is not set" $FN ; then + if grep -q "# ${BR2_PREFIX}$ARG is not set" "$FN" ; then echo n else - if V="$(grep "^${BR2_PREFIX}$ARG=" $FN)"; then + if V="$(grep "^${BR2_PREFIX}$ARG=" "$FN")"; then V="${V/#${BR2_PREFIX}$ARG=/}" V="${V/#\"/}" V="${V/%\"/}"