From patchwork Mon Mar 19 01:40:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Roslyakov X-Patchwork-Id: 887529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tMciXneX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 404Jhq5LJhz9sVM for ; Mon, 19 Mar 2018 12:42:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755189AbeCSBlD (ORCPT ); Sun, 18 Mar 2018 21:41:03 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:37796 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755175AbeCSBlA (ORCPT ); Sun, 18 Mar 2018 21:41:00 -0400 Received: by mail-pl0-f66.google.com with SMTP id w12-v6so9303090plp.4; Sun, 18 Mar 2018 18:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mIh0iHA1A5NMUA6hG+oGZwA8I17SwnoJn5Hp9tUBj2I=; b=tMciXneXDzb8xsceEXQardpp4OyzXqC4nVdAYUf6MeLV/L3tRRQ+qgeEzV08AVxnSX Mzbzk5w0cZNZwvfXnnPyTg/KBWp+yeU0dKDCmJ52RmHcCPlf+3N0zb3YXQcgQhdOo2hy N5MUPmklpwgjFv9zm52copjGhlVCHFr1QJ7eCaXvkYloneIxFwDCQctYo6BkKu8STaDh E7X93hyoZBlMB5K9lyWMKfb0e958amjfHHcI2aH5QnaAvHcLU7EhQG2fEZh6a33HQCKV ai6Cfgl88XfEIWj5p1RppaoufxjbrU5T4XXYJL04lNuyPgaZXLAvBW7DI8O7qvLJdOZG CJWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mIh0iHA1A5NMUA6hG+oGZwA8I17SwnoJn5Hp9tUBj2I=; b=BKzM8StNhh46rOzBlE0fYzlu/QOlwpiiqk/+njBa8cx1s++6X7cvHmhqLobo0OmdOk Ak8Q5jgbXLXVWdFDMxIEDqxoAG/dG5+kbwb+vIl/5YHhQXU2dOYOPeDURYWj9fMdc42c 8UxA2/MfTLiO0zfFUswvhuavLcd6yAfxzy/v/cUHeyvWnfFTpxYoBfHN4u91SrCR6uXN 3hJ9OnjjjMpbEPvdYly7s9P9c7xvksMGcnAXtzI14iPd5qJz4aoNi1sNcpYuxTF+aEwk y6gllSIYLV+yn9S/IkisLE67+emp+2azwJ9b2kwwNMwIZcl8fREhSFQYjOrftbVENZZG UnJw== X-Gm-Message-State: AElRT7HDCq9NNOPrCPkZ84f7ydxfZYxxjUfokRi34Mr53qdmZ+BTWtJ3 JGxzYInijG5d3Oo1n3lwCig= X-Google-Smtp-Source: AG47ELs8v3QLhffGi0LoINhRiDFLmQ+3vMomb1zeQ6Bjozt8rUgqThqB4icXbdjdp8iHqNnYC7L9nQ== X-Received: by 2002:a17:902:5845:: with SMTP id f5-v6mr10801175plj.164.1521423659741; Sun, 18 Mar 2018 18:40:59 -0700 (PDT) Received: from localhost.localdomain ([1.20.128.144]) by smtp.gmail.com with ESMTPSA id g5sm23370838pfh.6.2018.03.18.18.40.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 18:40:58 -0700 (PDT) From: Alexey Roslyakov To: andrew@lunn.ch, kvalo@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Alexey Roslyakov Subject: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings Date: Mon, 19 Mar 2018 08:40:31 +0700 Message-Id: <20180319014032.9394-2-alexey.roslyakov@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180319014032.9394-1-alexey.roslyakov@gmail.com> References: <20180319014032.9394-1-alexey.roslyakov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There are 3 fields in SDIO settings (quirks) to workaround some of the SG SDIO host particularities, i.e higher align requirements for SG items. All coding is done the long time ago, but there is no way to change the driver behavior without patching the kernel. Add missing devicetree entries. Signed-off-by: Alexey Roslyakov --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index aee6e5937c41..14135752b659 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c @@ -30,14 +30,20 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, struct device_node *np = dev->of_node; int irq; u32 irqf; - u32 val; if (!np || bus_type != BRCMF_BUSTYPE_SDIO || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) return; - if (of_property_read_u32(np, "brcm,drive-strength", &val) == 0) - sdio->drive_strength = val; + of_property_read_u32(np, "brcm,drive-strength", &sdio->drive_strength); + + sdio->broken_sg_support = + of_property_read_bool(np, "brcm,broken-sg-support"); + + of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align); + + of_property_read_u16(np, "brcm,sd-sgentry-align", + &sdio->sd_sgentry_align); /* make sure there are interrupts defined in the node */ if (!of_find_property(np, "interrupts", NULL)) From patchwork Mon Mar 19 01:40:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Roslyakov X-Patchwork-Id: 887527 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RWuFEJQF"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 404JhJ70xPz9sVM for ; Mon, 19 Mar 2018 12:41:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755212AbeCSBlL (ORCPT ); Sun, 18 Mar 2018 21:41:11 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:34819 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755201AbeCSBlF (ORCPT ); Sun, 18 Mar 2018 21:41:05 -0400 Received: by mail-pl0-f65.google.com with SMTP id p9-v6so6755958pls.2; Sun, 18 Mar 2018 18:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0eDTsRbPBFp0dmzng2ZtjhAyxeO8SQfkszKzABXC5jk=; b=RWuFEJQFz5NtNEjP9QBpIPvvJbl6YnABfl+Y7WPRfbD83InUZe6plmZnORJmmyiT4E hPIIPskq/hJZK9NuYJW3buVFyVG1zP77lIbIJ8+AprdkTs1HaeypS58A45ugcGDKpEoP A2ZBZiylxLlLKRD1Trqhe9HC6Y4lIAsJpBcJadYz+D7J4ZRNRMVkt5GqtVEffXEo9aX/ r0Hszp8wy+uhGBcREO8D5U0VkiyvrZEeLdZUs951yQzcOeelsf+N9pyIjf5SKH5zb0CI uGUuHJ3Fww1xVXcPuaYKOeaXJw6McvOy4n8Ypq/M5SnMvPIF6pbNNm2lGlEWgKJhYA5K 1/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0eDTsRbPBFp0dmzng2ZtjhAyxeO8SQfkszKzABXC5jk=; b=kKKVO+Q91/K12N2j773rvKNlbqeMl1WANbuk/8A0zwQj52XUVIgf+uRyys9sTwW4m9 bbFyr40aaDQwA4WoGRrE/fm9+uLpL3EDdd4pIl7MGFhQRs2VK10uxsOKJvXYqzx7vCvJ RiYWMe+lWJpoV2lU7Kg5XzJ7kFUsq6n4iswt6icZUOUDPE833nHBC1WUPHs8cQRTMi1H 2m1h7Cgm4L5HJ990phfOOWhISzllVoKVCqxJXUsfH0y7TQtNXbceGh+/hunVJCf3G+QE dRQ+FRjGnCUlkaL6huAHQtYZZHIfBQ0s3mCb6uL11mnUsFfhtFsU/gxxUOl0dU1fhwVl p8dA== X-Gm-Message-State: AElRT7Hm2SuFUe0GQ5cHbuDp9DvWxOXp9tyImH/kDWcxtO3PXTy7h9rn +hc3aW9DlQJkkYZ+upt5BxY= X-Google-Smtp-Source: AG47ELvOngdHu19Gh8FkiTm+tpP1lTLZN0W2TtEaWiqzXGIFr3GfISZwyKrAK5xzqx96kW8nQx02eg== X-Received: by 2002:a17:902:983:: with SMTP id 3-v6mr10786949pln.278.1521423664743; Sun, 18 Mar 2018 18:41:04 -0700 (PDT) Received: from localhost.localdomain ([1.20.128.144]) by smtp.gmail.com with ESMTPSA id g5sm23370838pfh.6.2018.03.18.18.40.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 18:41:03 -0700 (PDT) From: Alexey Roslyakov To: andrew@lunn.ch, kvalo@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Alexey Roslyakov Subject: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac Date: Mon, 19 Mar 2018 08:40:32 +0700 Message-Id: <20180319014032.9394-3-alexey.roslyakov@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180319014032.9394-1-alexey.roslyakov@gmail.com> References: <20180319014032.9394-1-alexey.roslyakov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov --- Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt index 86602f264dce..187b8c1b52a7 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt @@ -17,6 +17,11 @@ Optional properties: When not specified the device will use in-band SDIO interrupts. - interrupt-names : name of the out-of-band interrupt, which must be set to "host-wake". + - brcm,broken-sg-support : boolean flag to indicate that the SDIO host + controller has higher align requirement than 32 bytes for each + scatterlist item. + - brcm,sd-head-align : alignment requirement for start of data buffer. + - brcm,sd-sgentry-align : length alignment requirement for each sg entry. Example: