From patchwork Sun Mar 5 21:23:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 1751983 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cvukHtrd; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=gmx.net header.i=ps.report@gmx.net header.a=rsa-sha256 header.s=s31663417 header.b=AEHeMw8/; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PVFBm29tQz1yWx for ; Mon, 6 Mar 2023 08:26:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=10sVc5aHqObPFUSNEjBeKcBtihH2kVdHiNxg0CxIC7A=; b=cvukHtrdeF2Uz7 Jszqsvrede+oHZxgiTG2Q+l9opB1HTycO/zxDU64FL9c4WOf76LlZcjP/R2N6pxBjO2MAqmK9mON1 qotlBKtJNUwmy9TD1NJNvM/fmPNgAbfPQsfLhiVkjDP8nZAFgi3jfSgWdhwREb2I5Sj99RQHt8K9w L5uHs+UvexrU9x14iRBcQ49hwcHOxZO02JCUZl7wIGGkse40j4/wnpoly8eg1o2/OPw8qOtYWWeSn UA4n+iWu5E5+KnORAOoQC1gvuzpHfoIwK0julwWrE2xGBqAyGR1l8dYcCfIL7XufiOUkY/rhNoM9j lVqqr3XLhj9uLKBduSCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYvpW-00AfJD-E6; Sun, 05 Mar 2023 21:23:42 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYvpR-00AfIK-Ue for openwrt-devel@lists.openwrt.org; Sun, 05 Mar 2023 21:23:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1678051412; i=ps.report@gmx.net; bh=UnWPtdmZk3sMXnSD0FJN6DTgK6ds/ULASHYyilCwUYc=; h=X-UI-Sender-Class:From:To:Subject:Date; b=AEHeMw8/m5o1vVygRYRMWANObnTHFYp4yBM2Tu44Ky3nvcykOomkbkoVtdDiLBUh/ TPjbJAxNZR1wFdeLuV5R7MkDnlA7QIy5vQ6yLdd0KDIO9VP8pNlv4oAVHZhQbt20VJ lH4aXEmYTgkFZDB9MniR687CTuohWL4MHe/bg3u+YusUaeMZZVZzAL0vIV2Xh7oKIa +OgjcRwxKbPde1Zxjbmtjx9O3qfyIHKx8jKSBK5ZKZbjDY302ibz3Gl/5Wklr74aZN +QrLmFolLzK1Tpzi92cmX9Vbck5dzP0qCBnbZdOB//odbnopmoAURoVVU2EVyP3pTL mtVxG9mnw2tPw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([62.216.208.78]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MOREi-1pwfD029Py-00Px8f for ; Sun, 05 Mar 2023 22:23:32 +0100 From: Peter Seiderer To: openwrt-devel@lists.openwrt.org Subject: [PATCH uqmi v1] uqmi: avoid gcc false error reporting (storing the address of local variable 'complete' in '*req.complete') Date: Sun, 5 Mar 2023 22:23:31 +0100 Message-Id: <20230305212331.31143-1-ps.report@gmx.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:G61zAX96dmvO0eUB4V4QKdnDlg3B2mJjPzekbC5D61oONCBfJdm jh6gPy8+g1NfTvjaS+XktepfgB7fhw/6wbzWfWHVzHFswn4fP2wmioRxRON/CyxpDzMOT/8 fuQXXNO0bCnx3q0/r7iUBHSofo2xF0l9azrUhVZXC1v66ujPP8isXA4DyIosp5aSMfTbiAO I6ZpDbaIhHsttOmnlxt1w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rHIVNVPPxpE=;LdnsQjspB9ZT9iqkhRV8h4XQycP BYZ+fOEcRI08AvZXPwQRhLD/UaL+SS2Gh53vso4LIWhXs7kMThwMo/KLEpgcDP3Li06HdU+Kw mx0ommTbY10G+juHPvJ8kZR57iKtW315z608l5WNXLw7tV6osKpkWv0Zr2i8PDFYDSfjacYAx FXENPls6KhPaqofu9vU9POAM0CHlwfA8Iityyve1G9SD0fni3BN6AwU2pzWvIFnCRVjBOwrVc Opy1yh23EGe9H9KMpTvQAVCAFrR5KeSFlSYPDUQ5E2syYtvOHYmMGq1h0n4jHfVGuXNxJ5iV1 vkjhr1+Zm5ZeBW+Ac+5yvkF9L3qk0mlcd3ACuoxmdySGiMn/n5HswrOmyfbHYHsgaOsWHX1gM ERWntg0h6Jk/9I6BBg9WqGCHBjBG0KDKuPhKwET8G8b9iNU4+IW1UeRSrzF2qZRIUJDjeKTJ/ KBeBdiBk2PCkeu643iD0K1uHGCjwhQQ+1Gt9b9G6U68owKHmygQlc+S3bd0jb6QytKBTjYxnh vxpBOdGTPZGm/xFMzJ4PkybmVu3ZH1qfu8yZA14v+2hEeY+CQXalc51TmubFAPKhM7BMxAYkp iurf7rDKPPyFaCY2MWN82qNCbZMk2ozJ1j04rF/Z4kWI/oFCIu5WMcS8xy/b3CNVB3FIMUi+s DUuLDYcWEy6YyId66MuB3wiZ7wxrG2l7322ohXDLw9Xih+GvPtD5wNMPNjtG6BJ7K3+U44bly mmyaYfVY17TxzUcPX1Fjet91X+Ew9Jcy+dL8koYUtzNAKoD8GHLNk5pk2+/DhVP8nm67Vswng yNkTsBawucNNxEprawe9TgDvpEbjk7G/T3WSf6Ia3qidKUBd08zKYSQ0RPOR4aQsP9y3fLW6W eU3kjzt34iQ/JiCQoDwrSv7uVQsnt1b4Dq1wjUvOB8derJl/rroarquXy9M6ryR5zxIddaQd6 O6TDPV6HC91Xf9ICBc2hvYfsSEY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230305_132338_315262_3A15B4F0 X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Avoid gcc false error reporting (req->complete is later reset to NULL in case of use of local complete): dev.c:217:23: error: storing the address of local variable 'complete' in '*req.complete' [-Werror=dangling-pointer=] 217 | req->complete = &complete; | ~~~~~~~~~~~~~~^~~~~~~~~~~ Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [ps.report[at]gmx.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.18 listed in wl.mailspike.net] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Avoid gcc false error reporting (req->complete is later reset to NULL in case of use of local complete): dev.c:217:23: error: storing the address of local variable 'complete' in '*req.complete' [-Werror=dangling-pointer=] 217 | req->complete = &complete; | ~~~~~~~~~~~~~~^~~~~~~~~~~ Signed-off-by: Peter Seiderer --- dev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/dev.c b/dev.c index bd10207..b8ac273 100644 --- a/dev.c +++ b/dev.c @@ -203,6 +203,15 @@ void qmi_request_cancel(struct qmi_dev *qmi, struct qmi_request *req) __qmi_request_complete(qmi, req, NULL); } +/* avoid gcc false error reporting: + * dev.c:217:23: error: storing the address of local variable ‘complete’ in ‘*req.complete’ [-Werror=dangling-pointer=] + * 217 | req->complete = &complete; + * | ~~~~~~~~~~~~~~^~~~~~~~~~~ + */ +#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdangling-pointer" +#endif int qmi_request_wait(struct qmi_dev *qmi, struct qmi_request *req) { bool complete = false; @@ -231,6 +240,9 @@ int qmi_request_wait(struct qmi_dev *qmi, struct qmi_request *req) return req->ret; } +#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) +#pragma GCC diagnostic pop +#endif struct qmi_connect_request { struct qmi_request req;