From patchwork Sun Mar 18 18:41:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Roslyakov X-Patchwork-Id: 887442 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Y2Ei61TU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4047MN1Vtcz9s9D for ; Mon, 19 Mar 2018 05:41:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754248AbeCRSld (ORCPT ); Sun, 18 Mar 2018 14:41:33 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:39956 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbeCRSla (ORCPT ); Sun, 18 Mar 2018 14:41:30 -0400 Received: by mail-pf0-f196.google.com with SMTP id x1so6143817pfh.7; Sun, 18 Mar 2018 11:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=672+yd+I6DXkSZ+hogRWMQQCvHW6fSNJ8MEN7p/HwkY=; b=Y2Ei61TUpXFmtzr0ED8GNzApPlQFibeC3sG/wPnCZObQed/lTHCrzKj/ydRWILDb9z Ica3pQPIMlOJq/VM1Bg+x4zJFbzkcXo90Uz1/+3ZlRTLSqtnWey+oX59QhA/Qn+j/LFl /blBImME8OS+tMzuit4LbmhIuCIEqQZSfI6CULW5Cqjzi3rX3frkViB6qXbWT7XcRTc1 dU5O5VgOIrTR4HddQIN9QKr9gS369/Qnel0i2TJ/wq9Bf8w6heV1X16Qc9mE+ikb/wfs 0B9zQElXzAwomV9OQ3oVZiHI6yfWxlCbUqfkxNP1Xx4eKwo/lhaljvm2a2PuTnQOulmR uvEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=672+yd+I6DXkSZ+hogRWMQQCvHW6fSNJ8MEN7p/HwkY=; b=VWnG/W6TZkPH9+hc/ngpVtk9zyB8Wxg1s26fVK+QfINtaDqlZ5ep2GNcOumKZOseN/ jD6Dmq695bayBvXx+PXAK6Xd7yKSxTfzHA/9cu/bChXVvIXPosrMxBpcE0SsngBICANj Ubpeh53rsTizmOLESAR1mpB/jDsV+1qRKMgwfp4k5jMJILStskHAoY0Qo59Hcq9jbc78 poNYX0dOgMbXWxmT1iBsvwKgbMpVv5OGTlHxQP0Hc59P1Xv8v7S5cDf8zIr4/Ox5Ph2a TMf/M2U5V77/09pgDI2tYyV4DhGtJ0OXRq/Iye5b+FXnx5t+Oqw2m6VYOtMh86bfQ7ix 9c4w== X-Gm-Message-State: AElRT7Eq6OHIBpcvCUkWcsA3CvA2AHu5lyWI9Dd/GteN0I0fWjRo+cDR NsRNJbnJ52o0xrWALEr4QQI= X-Google-Smtp-Source: AG47ELuqrlyN0akLAgOga/OerTXG7kktyyxmhyBpUXzVv2+pLRGovXDNujFbDvt1YfKSuQIrKSAH1A== X-Received: by 10.101.97.139 with SMTP id c11mr7071789pgv.435.1521398490256; Sun, 18 Mar 2018 11:41:30 -0700 (PDT) Received: from localhost.localdomain (node-2fk.pool-118-173.dynamic.totbb.net. [118.173.12.80]) by smtp.gmail.com with ESMTPSA id a3sm24856084pfh.120.2018.03.18.11.41.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 11:41:28 -0700 (PDT) From: Alexey Roslyakov To: kvalo@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Alexey Roslyakov Subject: [PATCH 1/2] brcmfmac: add new dt entries for SG SDIO settings Date: Mon, 19 Mar 2018 01:41:00 +0700 Message-Id: <20180318184101.26951-1-alexey.roslyakov@gmail.com> X-Mailer: git-send-email 2.16.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There are 3 fields in SDIO settings (quirks) to workaround some of the SG SDIO host particularities, i.e higher align requirements for SG items. All coding is done the long time ago, but there is no way to change the driver behavior without patching the kernel. Add missing devicetree entries. Signed-off-by: Alexey Roslyakov --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c index aee6e5937c41..0718ca09a40d 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c @@ -31,6 +31,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, int irq; u32 irqf; u32 val; + u16 align; if (!np || bus_type != BRCMF_BUSTYPE_SDIO || !of_device_is_compatible(np, "brcm,bcm4329-fmac")) @@ -39,6 +40,15 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, if (of_property_read_u32(np, "brcm,drive-strength", &val) == 0) sdio->drive_strength = val; + sdio->broken_sg_support = + of_property_read_bool(np, "brcm,broken-sg-support"); + + if (of_property_read_u16(np, "brcm,sd-head-align", &align) == 0) + sdio->sd_head_align = align; + + if (of_property_read_u16(np, "brcm,sd-sgentry-align", &align) == 0) + sdio->sd_sgentry_align = align; + /* make sure there are interrupts defined in the node */ if (!of_find_property(np, "interrupts", NULL)) return; From patchwork Sun Mar 18 18:41:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Roslyakov X-Patchwork-Id: 887443 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E4LHSud2"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4047Mq6Fzsz9s9D for ; Mon, 19 Mar 2018 05:41:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481AbeCRSlq (ORCPT ); Sun, 18 Mar 2018 14:41:46 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36279 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314AbeCRSlf (ORCPT ); Sun, 18 Mar 2018 14:41:35 -0400 Received: by mail-pf0-f195.google.com with SMTP id 68so6150130pfx.3; Sun, 18 Mar 2018 11:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0eDTsRbPBFp0dmzng2ZtjhAyxeO8SQfkszKzABXC5jk=; b=E4LHSud2uJ/bsN/JgBy9TCZsLcJ//wJTsDqoDyBZ1IAVz1bTv7Qx/8aB2DeKMy+WQu i0JLtW/d4uO+Z0oeMXqb8rQBZl9XNZgUr3ibsG1DtlRx8wAuqF02TtE/MyasGfQsw0xX jOMqqWQm9g5UAasXAHencZ5sVTG+aq7ovIYWc6bMuN9TfRr3CN/CgFlsQk4mhMCM9Lj0 eENgfGasHTJao9tJYKv3zssdWJb8egQUx9ffWcW44NeRfWAK1wZOHuW/jzUx9Ag/wTst c61Lo8MJwwfd66ijkl1P0ojupDtvppE9FEsmIQHY7kV4YRvjnvxGQA8uGyMG1ny/6dRE bo/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0eDTsRbPBFp0dmzng2ZtjhAyxeO8SQfkszKzABXC5jk=; b=f3wiMmvpzNp9u2HHgFvJKOz09UBGtarsR4Qhs6sAvhkmHQmKtjt3XLWmucjCL44i5n neXj8jicPba/zXB5oBshcgQftR9XVXJ6GaaASnovDPBLhM2N2mAICaf5FstH7IJIJ+A3 rFXNlToTXweXMTp6ZKqylAs1G+s4iH7WcYjdwxA3BLgiUsBBvGhzL6tjVOpghPVpGHxn FyVWmypOTY2BBVAYgV8judz6wVYZjlT66YLDQHqiw+mF2uWYtkq3Rqcs8MewDPcpw6dd 2U+wqPP9gD6QhVqLrd9tbkti8zjjoW6xAnGghfoQVcK3C/9ki5EsAL0fkgAsFGdEf/FO u2xQ== X-Gm-Message-State: AElRT7GpknYVxYj84XAqO4I39HMzcdkqSZgcb3Ce0cu8zXbmc/R8MLer a1G9xKaTkfNeDxMyidGe//U= X-Google-Smtp-Source: AG47ELv7U6hshRnstGPnlcpwEAUasLMGRDcXqzcsrfZe953qnH5FnVlMykE2spIKAM4eX3wSXlH32Q== X-Received: by 10.99.2.140 with SMTP id 134mr7209277pgc.117.1521398494925; Sun, 18 Mar 2018 11:41:34 -0700 (PDT) Received: from localhost.localdomain (node-2fk.pool-118-173.dynamic.totbb.net. [118.173.12.80]) by smtp.gmail.com with ESMTPSA id a3sm24856084pfh.120.2018.03.18.11.41.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 11:41:34 -0700 (PDT) From: Alexey Roslyakov To: kvalo@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Alexey Roslyakov Subject: [PATCH 2/2] dt: bindings: add new dt entries for brcmfmac Date: Mon, 19 Mar 2018 01:41:01 +0700 Message-Id: <20180318184101.26951-2-alexey.roslyakov@gmail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180318184101.26951-1-alexey.roslyakov@gmail.com> References: <20180318184101.26951-1-alexey.roslyakov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov --- Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt index 86602f264dce..187b8c1b52a7 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt @@ -17,6 +17,11 @@ Optional properties: When not specified the device will use in-band SDIO interrupts. - interrupt-names : name of the out-of-band interrupt, which must be set to "host-wake". + - brcm,broken-sg-support : boolean flag to indicate that the SDIO host + controller has higher align requirement than 32 bytes for each + scatterlist item. + - brcm,sd-head-align : alignment requirement for start of data buffer. + - brcm,sd-sgentry-align : length alignment requirement for each sg entry. Example: