From patchwork Sun Mar 18 14:17:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 887396 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ev/IDecw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4041Vy26V6z9sTH for ; Mon, 19 Mar 2018 01:17:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754147AbeCRORo (ORCPT ); Sun, 18 Mar 2018 10:17:44 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35248 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbeCRORo (ORCPT ); Sun, 18 Mar 2018 10:17:44 -0400 Received: by mail-qt0-f196.google.com with SMTP id s2so377018qti.2 for ; Sun, 18 Mar 2018 07:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=30l2T82+XXKjNyuR899GpTL3w0AEcQeCYTDSe5mJjaw=; b=ev/IDecwHDKsgTY/vCLUfK+4NZzUPH4rGktOplwTNxgHaVAkUPCSgf/8XzDZtGp84f SI9h82klyF8VcRwd+TD78+Ahh463yOZy9ChQTVq3Az/j9HS3XgJ8QqNE3X7NsTFQbCy8 2sJ5X5VZJkbl19OutTIrD/K9PMJBwDAA8Xz1V2wNLXzhVoJeMHIlD7aTDPXTaJ/scnLh HgakPAJXBylVXh2C8xK7Clx1YYuD7KDgLOKEm7c7aLTyOYtg2okmeJ4k4AitG9vcYn9P g3Sda1oK3boyzMuJxjY+prEp/RnaaJWgLzILPSs/v4eHRKAQe8N8KtERBqsH5K5qnVN2 /GPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=30l2T82+XXKjNyuR899GpTL3w0AEcQeCYTDSe5mJjaw=; b=mKU8S02n9aZfREnsfvPGKfQSkgXNHHIQzJw3bKLwXmoMKUr06UInqplzo2MZy+xMa/ oA6WuDK/wvnP8rmTIGQ4YQGjC2alkNIXqW5ohgOkfnCDNR1JjcG6O3zo9VYgu1xW9Sdt 4MY+mR3ccbfHQrRHTNqo+bzZL/77i265zAUO+GC/nFRvMoydOwrR0MDDvzuepKlC8jBX +mCgW7QhOoj9v42HtK9LP7CCxsmiT57AFIBVbZTWQSsMwyK1Uef//1x49GQUlcgrdO77 iTcf1Y0HieT8NY5hqUb5wFX+wX4QnVr7pL3X4CVi3xajV3tXh0otPpFDiOqypIRiuQqp b6Gw== X-Gm-Message-State: AElRT7HOHYrckj+L5UnE5N8t4b1skw1ToRAOKmrLn9/JRmv9rL761n2Y ikDvbGlyCGKo6gUhhPArUv8= X-Google-Smtp-Source: AG47ELtY1rH8f6nRNOJvGa5mOdwHSjjQOykKwZxT6hT73NvMPpr5P9UBygAoxDFLjZzH0/pHwgipPQ== X-Received: by 10.237.58.67 with SMTP id n61mr13158652qte.324.1521382663525; Sun, 18 Mar 2018 07:17:43 -0700 (PDT) Received: from localhost.localdomain ([187.180.181.98]) by smtp.gmail.com with ESMTPSA id g9sm8845336qti.11.2018.03.18.07.17.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Mar 2018 07:17:42 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, Fabio Estevam Subject: [PATCH 3/4] Revert "dt-bindings: ifc: Fix the unit address format in the examples" Date: Sun, 18 Mar 2018 11:17:30 -0300 Message-Id: <1521382651-10256-3-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521382651-10256-1-git-send-email-festevam@gmail.com> References: <1521382651-10256-1-git-send-email-festevam@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Fabio Estevam This reverts commit 4e017f1419397473cf3db6e9fa020013998b1aa4. As explained by Rob Herring: "This "fix" is wrong. Memory controllers with chip selects should have the chip select in the unit-address. The correct fix here is you should drop "simple-bus"." Signed-off-by: Fabio Estevam Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt index a4d4b6a..89427b0 100644 --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt @@ -43,7 +43,7 @@ Example: 0x1 0x0 0x0 0xffa00000 0x00010000 0x3 0x0 0x0 0xffb00000 0x00020000>; - flash@0 { + flash@0,0 { #address-cells = <1>; #size-cells = <1>; compatible = "cfi-flash"; @@ -58,7 +58,7 @@ Example: }; }; - flash@100000000 { + flash@1,0 { #address-cells = <1>; #size-cells = <1>; compatible = "fsl,ifc-nand"; @@ -73,7 +73,7 @@ Example: }; }; - cpld@@300000000 { + cpld@3,0 { #address-cells = <1>; #size-cells = <1>; compatible = "fsl,p1010rdb-cpld"; From patchwork Sun Mar 18 14:17:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 887397 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d+RV5t6a"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4041W04mdFz9sTF for ; Mon, 19 Mar 2018 01:17:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbeCRORr (ORCPT ); Sun, 18 Mar 2018 10:17:47 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:43737 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbeCRORq (ORCPT ); Sun, 18 Mar 2018 10:17:46 -0400 Received: by mail-qt0-f195.google.com with SMTP id s48so15480124qtb.10 for ; Sun, 18 Mar 2018 07:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uUD6n+E7iEZmMfDYRZTjxdSBCAPHBrRjst123oBD0vU=; b=d+RV5t6aW7TzSz8iVHEksW2OFVUcExorSlkoKXwjd3MTtRqBGVHOKrNdDcmDVW1sLi EkdK1wG3ct8GYS9Qtqy24+A6a5ltVmqVrFHPCf7Jgv5zn4Zz2wMyqEffiS7XGA6au5uB xCO4pG/6tmqzkGQqljypFcVDpjUr0eYJTlQ4ru3Z+X4sCU8an9cVT4/vJnaWFNKD9fce 2QLJgPSgxgspo79twoZt3YsjDUkMs/SE5CvqUaBoqKtENOSf8c03YFGhREXTCbjZlY4n 6Q7xPPf03oJKcHq2+ywhprEZBy+k1jIZGUHWlRtkPS5f4tEFuBqexB3huysac/CUQhJ2 Fvtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uUD6n+E7iEZmMfDYRZTjxdSBCAPHBrRjst123oBD0vU=; b=bnulDJr4e/W/b1X/r+TEKSTpwGWc+4ELv5y3UjAtmxYEk++DlhppVxe3WBgbRv+Zsk ijBgInboUZ5/kV/GwgtikJlKe4oEWNJcPIkCNmo2rNDuSQjufQno+HlDNRuDpkyJOD6N Y7TAflIvJ21Zs1+/kRLiCZZze8JPuwf9e4OGkE+8TzQ1WJUeIyNJYihUkqMJlPRDHAVs kROqwY1zOcF5DBn2fY5WFh8iJ6FNEUtOcvzy2B9cRTraxFYYmsyyUvaZ5rxzoU6kHrAe 6M/beuIsGKavYuQ5P2yxgGNnEDrKDd1PgAIIiC6WOrSo+VnGAq7oInLqaG6ByGnb+43T gfCQ== X-Gm-Message-State: AElRT7G9jLTNZ84ccSn1dS7o2ERaIpCdkZrr0S8T3wDEOosREcaJRvYp 5D7scxX5MrJMoqLNvE5YEaM= X-Google-Smtp-Source: AG47ELvoH6w9fgV4dF1qjn9J1MGmf+IGRxfFbZjc9FFwe2eQTM0hD9E3bhkRrcHvfx/HTMRCSRSFJg== X-Received: by 10.200.57.228 with SMTP id v91mr13155270qte.16.1521382665845; Sun, 18 Mar 2018 07:17:45 -0700 (PDT) Received: from localhost.localdomain ([187.180.181.98]) by smtp.gmail.com with ESMTPSA id g9sm8845336qti.11.2018.03.18.07.17.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Mar 2018 07:17:45 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, Fabio Estevam Subject: [PATCH 4/4] dt-bindings: ifc: Remove "simple-bus" from ifc compatible string Date: Sun, 18 Mar 2018 11:17:31 -0300 Message-Id: <1521382651-10256-4-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521382651-10256-1-git-send-email-festevam@gmail.com> References: <1521382651-10256-1-git-send-email-festevam@gmail.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Fabio Estevam > DTC warnings will be seen if these examples are used in a real dts file due to a mismatch in the unit address notation. Remove "simple-bus" from the ifc compatible string to fix the warnings. Suggested-by: Rob Herring Signed-off-by: Fabio Estevam Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt index 89427b0..2314871 100644 --- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt +++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt @@ -31,7 +31,7 @@ like FPGAs, CPLDs, etc. Example: ifc@ffe1e000 { - compatible = "fsl,ifc", "simple-bus"; + compatible = "fsl,ifc"; #address-cells = <2>; #size-cells = <1>; reg = <0x0 0xffe1e000 0 0x2000>;