From patchwork Sat Mar 17 02:02:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Zhou X-Patchwork-Id: 887249 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Y0QCsrp5"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4035FW645Tz9sLv for ; Sat, 17 Mar 2018 13:02:55 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A528C10E5; Sat, 17 Mar 2018 02:02:52 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1AFCE10DB for ; Sat, 17 Mar 2018 02:02:51 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id C6D6B2C3 for ; Sat, 17 Mar 2018 02:02:50 +0000 (UTC) Received: by mail-pl0-f65.google.com with SMTP id p9-v6so4367035pls.2 for ; Fri, 16 Mar 2018 19:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HjTQ3wKajjB3bnUwaCvheK51pqUNV2LUAnS1kn+P1QA=; b=Y0QCsrp5cJdrdxGIVCFj9CWRW6//u9h+f8OxSuZ8uCtoW9kuuxrWAAXXWrw/nDEujF wyRQI3dkgSJDlo/rTjhpe+7XaL1+h/cUsEZg2zUsdxyqdjefrIkGeRWHOQC1KuvPJOI5 uGQfaW8rqjxe5ikMDenTleuwh5yuDNbiAvUg6gVODu4wvZPNNuFFyz6hBdOMVdvmcc4l HjyojWxaOyiUMB3ABvnWwchl/jiDSY0zSHKiQAabA1mZWRgiLDVProd03g5IJHZkcwec 9zY5AyjTnyARqFXs6MpCDKaWxpLM/Sy0tpURhPbRysd357qtGIlyV38V/H2Ip2njyyAQ E+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HjTQ3wKajjB3bnUwaCvheK51pqUNV2LUAnS1kn+P1QA=; b=uGXX6zMCllbHfbx0F+c6jNFIsqR9cAx5EGWxBffQmYB6sjbnLyu7ZStg7lgTa5nV/7 +wFRYvmzJQOmJtgGXQhYV0BG42MTPncX5pJOuUAxcnbsvOZwsrnjweBzrRIIVI1VXHOw 3wjrCck8Ln7Mi+WhoRJZdK+re16ZH3BzH/fQaqxa0aE2JVrMHOzBpu0YmaLRw/SqdPVC 0TYDLGbpvfA2Cm+u/Y4JSujv8p6h4b/6GGZgdvgDzwMjSbmoPpvcLFhG+9nRr/2UuTrt 0C0rf5wYS7+qGh3VKeWuHZbDsMaseLecdGvs432IyTjb3xlDeYfeFVCkOCPKpq7GS5k0 MuZA== X-Gm-Message-State: AElRT7F5jyWh/hXdaXrnlZM9WyzIVKQP51vBpwklo/mgcRfOa/Yf0NoE pK0Qr/6ya9PPDXyQw1gWpU9PuQ== X-Google-Smtp-Source: AG47ELvMfkw89Smr1amf2BaKjGgMjlV8pwLzJWnGbOVZiDWnBsYtscvIlASP85Mbu1twH6cb/M1Yng== X-Received: by 2002:a17:902:227:: with SMTP id 36-v6mr4082142plc.134.1521252170196; Fri, 16 Mar 2018 19:02:50 -0700 (PDT) Received: from localhost.localdomain.localdomain ([216.113.160.70]) by smtp.gmail.com with ESMTPSA id 29sm15702651pfj.40.2018.03.16.19.02.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Mar 2018 19:02:49 -0700 (PDT) From: Han Zhou X-Google-Original-From: Han Zhou To: dev@openvswitch.org Date: Fri, 16 Mar 2018 19:02:43 -0700 Message-Id: <1521252163-101920-1-git-send-email-hzhou8@ebay.com> X-Mailer: git-send-email 2.1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovsdb: omit_alert should implicitely turn off tracking. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org OVSDB_IDL_TRACK is not valid without OVSDB_IDL_ALERT, so it should be turned off as well in ovsdb_idl_omit_alert(). Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 642ce66..5848326 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -1252,7 +1252,7 @@ ovsdb_idl_send_cond_change(struct ovsdb_idl *idl) idl->cond_changed = false; } -/* Turns off OVSDB_IDL_ALERT for 'column' in 'idl'. +/* Turns off OVSDB_IDL_ALERT and OVSDB_IDL_TRACK for 'column' in 'idl'. * * This function should be called between ovsdb_idl_create() and the first call * to ovsdb_idl_run(). @@ -1261,7 +1261,7 @@ void ovsdb_idl_omit_alert(struct ovsdb_idl *idl, const struct ovsdb_idl_column *column) { - *ovsdb_idl_get_mode(idl, column) &= ~OVSDB_IDL_ALERT; + *ovsdb_idl_get_mode(idl, column) &= ~(OVSDB_IDL_ALERT | OVSDB_IDL_TRACK); } /* Sets the mode for 'column' in 'idl' to 0. See the big comment above