From patchwork Mon Feb 20 12:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Gherzan X-Patchwork-Id: 1745076 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=h38pP1y1; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PL2ZX1jRrz23r4 for ; Tue, 21 Feb 2023 00:00:04 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pU5lu-0000R3-VF; Mon, 20 Feb 2023 12:59:58 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pU5ls-0000Qw-P9 for kernel-team@lists.ubuntu.com; Mon, 20 Feb 2023 12:59:56 +0000 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 97F713F11A for ; Mon, 20 Feb 2023 12:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676897996; bh=4DC4XzrJtuVWBJEm3te7J/slH6CaZm1M0KEMP6DTpsU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h38pP1y1oYOXWj4QMjBcMQyxO2Pm4e3WFYszPeA3upPKPCc2ecPyyjTLAkKewKtTQ +E+RnzjHOLJnBKxkIzuTP2YFzGZdUzErjPKVU/NmB/gcM1aFgjxnlsP6pqsC7gX0aS KSjVbix2625B4ePVsvtNqb6tNDT2CZThIWrKP9nFFtqY2pUKDtnpSqxKNvs5ABMXoW igU4xhvxC/LwqNBfZdRXQuCEUPv+Pe/tVZwqlhQqEJwSBi8UDifpWUh2lMCT0VdQE0 /PaLxLaYXL3tKqdO/veG+wDom0qP5pOvCEGl/b+8lKZqWIfrrGS1vde8l0j2EIaeRq wTufrSY0e8hEQ== Received: by mail-wr1-f69.google.com with SMTP id d14-20020adfa34e000000b002bfc062eaa8so259490wrb.20 for ; Mon, 20 Feb 2023 04:59:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4DC4XzrJtuVWBJEm3te7J/slH6CaZm1M0KEMP6DTpsU=; b=TpzVd0IPLbfKiEgsee+hig1TPrBCCAzFxxF3unCBQx2KxuxNts8VXWgzup89TM9ZrP vD3xgUqI3936ubySdaabhYnqDiCEZoSZtm9H4EefFHMhPlV7bsqhj0Wn2pV9fA7CFVSs rbT95j5ImZbZ4cch6cJAnxx5juwsHaCaRoVkbMUIA/h4LgaO+Z7JS9XQOChkdyaiVuIH Lq8sbFvajZ8dg7Z8Zykym5HRjK9/2/T6fC5w5IBLpehGluP7FwFrfQxZWsmo4jxeG0xs k4RwZ1m9QcGX3zc0tr6wR3EZlPdAtXiClgUe2LyAZw/nEM+y9EUUjC1lYEF0OlRUVZbX zHJA== X-Gm-Message-State: AO0yUKUIrA7ge+cq61DACVDVLI4hdU8kfhAEA5lGRupzAx10svQKwzkN SLSHO0y9Ij9/4y3FPDm6PWPQawjQPy4/zUduHXubZhlCSmm2k0NHTDP5DZxgWSH5Yc8wUUwlGzs iwWUU36okBxA9kDaDPvdTXDC1C5zD03qJuXXNIp7F77hEFPQqXg== X-Received: by 2002:a05:6000:92:b0:2c3:d83a:113a with SMTP id m18-20020a056000009200b002c3d83a113amr1190607wrx.4.1676897995941; Mon, 20 Feb 2023 04:59:55 -0800 (PST) X-Google-Smtp-Source: AK7set9faZgM9svmhVmJ3/YBLlaAuBuX2yKiAPvz0nUTpjrhrBdKjcs6ExWo9Y3R0SFyan+P2CWZKA== X-Received: by 2002:a05:6000:92:b0:2c3:d83a:113a with SMTP id m18-20020a056000009200b002c3d83a113amr1190600wrx.4.1676897995676; Mon, 20 Feb 2023 04:59:55 -0800 (PST) Received: from localhost.localdomain ([2001:67c:1560:8007::aac:c4dd]) by smtp.gmail.com with ESMTPSA id v25-20020a5d5919000000b002c551f7d452sm1234171wrd.98.2023.02.20.04.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:59:55 -0800 (PST) From: Andrei Gherzan To: kernel-team@lists.ubuntu.com Subject: [SRU][B][X][PATCH v2 1/1] UBUNTU: SAUCE: selftest: rtctest: Force passing unreliable subtest Date: Mon, 20 Feb 2023 12:58:33 +0000 Message-Id: <20230220125831.2861180-2-andrei.gherzan@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230220125831.2861180-1-andrei.gherzan@canonical.com> References: <20230220125831.2861180-1-andrei.gherzan@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrei Gherzan Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1814234 Since 0b63accf87225b5eb7e52814c374cf02d733d4bb, the test includes a verification of time passage that is unstable as it is prone to different results based on the system load. Other investigations led to disabling this test in various other places/projects. For example, Linaro also disabled it[1]. We have chosen to keep this test but to force its result unconditionally successful as opposed to reverting the aforementioned commit because: 1. it keeps running the test with results and data that we can use in the future for any "smarter" way to deal with it - eg. statistical approach 2. it minimizes the maintenance burden of this patch kept in our kernel trees It is worth mentioning that upstream was contacted via the mailing list with no feedback[2]. The request was to increase the current tolerance set at 10%. [1] https://bugs.linaro.org/show_bug.cgi?id=3402#c9 [2] https://lore.kernel.org/lkml/a304b6f1-11db-543b-2cb3-372f34dc7697@linaro.org/ Signed-off-by: Andrei Gherzan Acked-by: Thadeu Lima de Souza Cascardo --- tools/testing/selftests/timers/rtctest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c index 411eff625e66d..6166ff7b022ba 100644 --- a/tools/testing/selftests/timers/rtctest.c +++ b/tools/testing/selftests/timers/rtctest.c @@ -319,10 +319,11 @@ int main(int argc, char **argv) if (diff.tv_sec > 0 || diff.tv_usec > ((1000000L / tmp) * 1.10)) { fprintf(stderr, "\nPIE delta error: %ld.%06ld should be close to 0.%06ld\n", + fprintf(stderr, "\nUbuntu Testing Force Pass LP #1814234: PIE delta error: %ld.%06ld should be close to 0.%06ld\n", diff.tv_sec, diff.tv_usec, (1000000L / tmp)); fflush(stdout); - exit(-1); + break; // LP: #1814234 } fprintf(stderr, " %d",i);