From patchwork Tue Feb 14 21:30:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Srinivasarao Pathipati X-Patchwork-Id: 1742596 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=3DBfic8t; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=onAw/Ed1; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PGZQk38M7z23y8 for ; Wed, 15 Feb 2023 08:41:18 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HWZgj903x/vN171Y4ezzG1IrTcRu7h8XP7yadKHnkB8=; b=3DBfic8tI8qq5M BPx3krqUOcjh6xhOKtxwl8Hmoi90WvlDilL6M+Gbf64nIIBOE5wVXCEK5dG+GBvaFi72JRYe2eUpg gn7BcAKfAzVJ9mMCnUhZ8rLjbPanyibMMEynTWZciXx9Czajt0k9ZzX7YjENlOnnF8F+JwXIDwL4C Wi2650lHI5jS9MtQ8ntvl+nxYW5ACNtBBBrCp7USLZhK/t0FS0+x2fVq0MOdJ+Rsm7LiDYzrcNOZE MpLyR4cUdr4LFxq1AajdCfmyMgrlsyvs4QRox2iHPgsl5Vh64cJ/fdFN7vHljhMAEthMU2csqJsoY 8w46B5hJMnxp64WcP8+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pS32v-003d50-Jr; Tue, 14 Feb 2023 21:41:05 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pS2tn-003ZNK-36 for linux-um@lists.infradead.org; Tue, 14 Feb 2023 21:31:44 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EHLlIk027227; Tue, 14 Feb 2023 21:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=jdadcMHUEHEz3wESNyYCqEqZE1xiSFm7gjLwEXCHUq4=; b=onAw/Ed1Rds4wArHiFBeJntOEqNg5p3PqBvyUh6+M+MtRv8Jh0kvC6waD+qY2BBAZDjJ JfNSKdQQEJjFmMbGFa0EBbVuhLAH0HMdSLl9GyYd3gjazEZ9b78V/qfeoHvNKf2IkN07 P0eJM9p3sh7SSA9wtmqR0NDpqDxIcv6Xg68ANEzv6ky4vcLjJLNnOQ7r0wjS4OSNO+WT SREsyWc3lilplPKQEEe8D+Ncz2Ba4oSoCTTopsz/P47twra/NfFNrKAYMJP9t6FadVId hOp5/0eZ3AfjHx+EHRQjszmcLGEQp1bQ1IPlAucGlIrwcIsw0SfcaSTWBLi6U/CvKE4t 3Q== Received: from apblrppmta01.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nqyygtu5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Feb 2023 21:31:32 +0000 Received: from pps.filterd (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 31ELVRmY013297; Tue, 14 Feb 2023 21:31:27 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 3np43kjtbk-1; Tue, 14 Feb 2023 21:31:27 +0000 Received: from APBLRPPMTA01.qualcomm.com (APBLRPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31ELVRKm013292; Tue, 14 Feb 2023 21:31:27 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-c-spathi-hyd.qualcomm.com [10.213.108.59]) by APBLRPPMTA01.qualcomm.com (PPS) with ESMTP id 31ELVQ2F013291; Tue, 14 Feb 2023 21:31:26 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 212714) id 1DA434801; Wed, 15 Feb 2023 03:01:26 +0530 (+0530) From: Srinivasarao Pathipati To: richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, quic_c_spathi@quicinc.com, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V1] um: Fix compilation warnings Date: Wed, 15 Feb 2023 03:00:43 +0530 Message-Id: <1676410243-10566-1-git-send-email-quic_c_spathi@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: o9J2jh1-t8dYIgz2zYsGdSgbsy5oOMaz X-Proofpoint-GUID: o9J2jh1-t8dYIgz2zYsGdSgbsy5oOMaz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_15,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=360 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140184 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_133139_212956_238122B0 X-CRM114-Status: GOOD ( 16.91 ) X-Spam-Score: -0.5 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Use_dynamic_allocation_in_sig=5Fhandle?= =?unknown-8bit?q?r=5Fcommon=28=29_and_in_timer=5Freal=5Falarm=5Fhandler=28?= =?unknown-8bit?q?=29?= =?unknown-8bit?q?_to_fix_below_warnings_and_build_failures_where_CONFIG=5FWE?= =?unknown-8bit?q?RROR_is_enabled=2E?= =?unknown-8bit?q?_arch/um/os-Linux/signal=2Ec=3A_In_function_=E2=80=98sig=5F?= =?unknown-8bit?q?handler=5Fcommon=E2=80=99=3A_arch/um/os-Linux/signal=2Ec?= =?unknown-8bit?q?=3A51=3A1=3A?= =?unknown-8bit?q?_error=3A_the_frame_size_of_2960_bytes_is_larger_than_1024_?= =?unknown-8bit?q?bytes_=5B-Werror=3Dframe-larger-than=3D=5D?= =?unknown-8bit?b?IH0gXiBhcmNoL3VtLyBbLi4uXSA=?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E5_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?= =?unknown-8bit?q?_low_trust?= =?unknown-8bit?q?_=5B205=2E220=2E168=2E131_listed_in_list=2Ednswl=2Eorg=5D?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_0=2E2_HEADER=5FFROM=5FDIFFERENT=5FDOMAINS_From_and_Envelop?= =?unknown-8bit?q?eFrom_2nd_level?= =?unknown-8bit?q?_mail_domains_are_different?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_author=27s_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily?= =?unknown-8bit?q?_valid?= X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Use dynamic allocation in sig_handler_common() and in timer_real_alarm_handler() to fix below warnings and build failures where CONFIG_WERROR is enabled. arch/um/os-Linux/signal.c: In function ‘sig_handler_common’: arch/um/os-Linux/signal.c:51:1: error: the frame size of 2960 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] } ^ arch/um/os-Linux/signal.c: In function ‘timer_real_alarm_handler’: arch/um/os-Linux/signal.c:95:1: error: the frame size of 2960 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] } Signed-off-by: Srinivasarao Pathipati --- arch/um/os-Linux/signal.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c index 24a403a..9de8826 100644 --- a/arch/um/os-Linux/signal.c +++ b/arch/um/os-Linux/signal.c @@ -32,23 +32,25 @@ void (*sig_info[NSIG])(int, struct siginfo *, struct uml_pt_regs *) = { static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc) { - struct uml_pt_regs r; + struct uml_pt_regs *r; int save_errno = errno; - r.is_user = 0; + r = malloc(sizeof(struct uml_pt_regs)); + r->is_user = 0; if (sig == SIGSEGV) { /* For segfaults, we want the data from the sigcontext. */ - get_regs_from_mc(&r, mc); - GET_FAULTINFO_FROM_MC(r.faultinfo, mc); + get_regs_from_mc(r, mc); + GET_FAULTINFO_FROM_MC(r->faultinfo, mc); } /* enable signals if sig isn't IRQ signal */ if ((sig != SIGIO) && (sig != SIGWINCH)) unblock_signals_trace(); - (*sig_info[sig])(sig, si, &r); + (*sig_info[sig])(sig, si, r); errno = save_errno; + free(r); } /* @@ -99,13 +101,15 @@ void sig_handler(int sig, struct siginfo *si, mcontext_t *mc) static void timer_real_alarm_handler(mcontext_t *mc) { - struct uml_pt_regs regs; + struct uml_pt_regs *regs; + regs = malloc(sizeof(struct uml_pt_regs)); if (mc != NULL) - get_regs_from_mc(®s, mc); + get_regs_from_mc(regs, mc); else - memset(®s, 0, sizeof(regs)); - timer_handler(SIGALRM, NULL, ®s); + memset(regs, 0, sizeof(struct uml_pt_regs)); + timer_handler(SIGALRM, NULL, regs); + free(regs); } void timer_alarm_handler(int sig, struct siginfo *unused_si, mcontext_t *mc)