From patchwork Sun Jan 8 16:17:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 1722950 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=gyymas+Y; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Nqj0j2k7Qz23fj for ; Mon, 9 Jan 2023 03:17:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 57D68854DB; Sun, 8 Jan 2023 17:17:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="gyymas+Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F3F8855EA; Sun, 8 Jan 2023 17:17:51 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9C9A18546C for ; Sun, 8 Jan 2023 17:17:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-pl1-x635.google.com with SMTP id d3so6914948plr.10 for ; Sun, 08 Jan 2023 08:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/n2KAR1PU+C7MlpQzvrMpsLN7XNMseGEF8OoAgxuTM8=; b=gyymas+YTHVkBCTNb/OI6QRLY2pfyy94IxWDoPqw7KwwXv5nBI3cSWRwnLkeJL2as1 WWxDoSb25SkwcUTl/fWXRLJKQ4iOAse4Ckev+uWdD0iLKrv11WU4d8TvKCSXNPDNousf nPleVV3tTsSZszn1nOzwN8wNADqx3a6ct6Gqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/n2KAR1PU+C7MlpQzvrMpsLN7XNMseGEF8OoAgxuTM8=; b=WyGzDJYs2uYXnga7+LTOIKucVlFchImo3eeuTz4wZippaxmMfHnaJwIUWzpazEH5rp EPhKDq0gjxUGqqfjbJ7xW3twx+of+t09XoxP14F1kV2PJw4smaOi19K3W+NqvZZw1JTB 8xHIRGl55+zMvuD2KM8bEYvm9z1ezOYqw6Gy/NNKH/sFdNgrhOu/LhN+ERBSb04c0rOS gRb+TKaFUcG5VGzVo6O9Ko6Bvb2BuCQPD+lmbqJ2yiJwbu50EMZrBejgQhZvgTTjAjcf S8qBKGCW9ZExkD9kwbOVktsx7v2F73qjRVNwZVdk7bnYXNQu3XffpCZbH7ZUEhOMdccY fprg== X-Gm-Message-State: AFqh2koSdPBq4LUAYQ4UvvCwg+qHxo4r1ka2zxzzejtpdOSuvW1dwqNs yKDTJyW1XpMGCff+Wr8W0egnIg== X-Google-Smtp-Source: AMrXdXubC9D/NU/ezjCtfy/CE2lV2nRH2mXE7E6QkWUCq28yAWZsNYLzt/1bB8GM0Vl+6BUE8fdGIw== X-Received: by 2002:a17:903:1358:b0:193:d0f:5d68 with SMTP id jl24-20020a170903135800b001930d0f5d68mr9068051plb.25.1673194666834; Sun, 08 Jan 2023 08:17:46 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:3640:1796:9817:626f]) by smtp.gmail.com with ESMTPSA id w13-20020a170902ca0d00b00178b77b7e71sm4351976pld.188.2023.01.08.08.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 08:17:46 -0800 (PST) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass , Tom Rini Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Jagan Teki , Quentin Schulz Subject: [PATCH v2] board: rockchip: Fix binman_init failure on EVB-RK3568 Date: Sun, 8 Jan 2023 21:47:34 +0530 Message-Id: <20230108161734.50094-1-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean For some newer SoCs like RK3568, the Rockchip has not released any DDR drivers yet so idbloader needs to create manually using DDR binaries offered by rkbin. This indeed no requirement to enable TPL in the U-Boot source code. If we mark TPL disabled and mark BINMAN enabled by default then there would be an issue of binman_init failure during board relocation. This is true as binman failed to find the top-level node like u-boot-tpl here. Here is the boot issue observed in Radxa-CM3 RK3566 board, U-Boot 2023.01-rc4-00057-gac2505d463-dirty (Jan 04 2023 - 23:44:18 +0530) Model: Radxa Compute Module 3(CM3) IO Board DRAM: 2 GiB binman_init failed:-2 initcall sequence 000000007ffd2008 failed at call 0000000000a18cac (err=-2) ### ERROR ### Please RESET the board ### This might be fixed via binman node in rockchip-u-boot.dtsi however disable BINMAN_FDT for evb-rk3568 defconfig for now as we are at the end of the release cycle. Fixes: 05713d570762 ("rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards") Cc: Quentin Schulz Signed-off-by: Jagan Teki Reviewed-by: Kever Yang --- Changes for v2: - disable BINMAN_FDT in defconfig instead disabling BINMAN in ARCH_ROCKCHIP configs/evb-rk3568_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/evb-rk3568_defconfig b/configs/evb-rk3568_defconfig index db3acf5be5..e799690578 100644 --- a/configs/evb-rk3568_defconfig +++ b/configs/evb-rk3568_defconfig @@ -64,4 +64,5 @@ CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y +# CONFIG_BINMAN_FDT is not set CONFIG_ERRNO_STR=y