From patchwork Wed Dec 21 13:12:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= X-Patchwork-Id: 1718259 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=syrmia.com header.i=@syrmia.com header.a=rsa-sha256 header.s=selector1 header.b=GXwHfuga; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NcYlc5mZzz23dP for ; Thu, 22 Dec 2022 00:13:00 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B527138493E7 for ; Wed, 21 Dec 2022 13:12:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2109.outbound.protection.outlook.com [40.107.20.109]) by sourceware.org (Postfix) with ESMTPS id 5BB123858023 for ; Wed, 21 Dec 2022 13:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BB123858023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SdBdw3gBJVT6BPvyo/8slGYtEw4qy6RXYlDTprZbYD7ulY8Q/aaJbie9ywiLPxEZgSFe2a2gW1khKYqPkqAOGzxwiKI7TmnHbz5HJaX/lijiYpy2/WH42oIj9UPhYUc8VzpvDFc+WcGX8imcjEGu1tu8/r75cAVLo2sX51LLDoedqfZAUIGLLDbedHIODOpsUB1eoJXyNB9Cah+Z2h8vt8QFFzWmwKhEyJbwFJruhPq+fYkJDcXZAHtPNsuxae75Cto3RhoffZNLl0A0WYD0Duosu+eV4t0IJPGVYToJZbFjdpvELtp03i1SF4HvBJPg3fCNsXw5xuNaWtgk2XZhtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dAx1c6qUlxr/5s1+ekYV/vv3cdWGc6DmHOhSIj/6sns=; b=Ctl+eDLSzvUWjlOjzX0l1o6HKwr9AN/sqIXU6KfGZhok+oVTp0WJ4+ES6RMbmeNZ9ih6df8LpuKYsXKIphSaMjvF4CPIJfj6WEWsQex7u0f0YY4ApjFDqyBeVDFMRSYetwz4n9/hY8FbF9ES2dEFvKZUX0oZT5kOFZjsYk2916MHq2dZy1cpTpnP/BCJ/nOdcswPwNWG+U28ea8EPVR02TCavvokjbEZwtbdpi06TgJm3XeBYvtd7unKFDdrW9mhYwFvS6APqufFLkOxVT38jRFvvTtnp49vV4OSSyCUkirvrj5zm9o75hBkty3x1i7xmQRu6/gUwjfLIvN/4nlUiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dAx1c6qUlxr/5s1+ekYV/vv3cdWGc6DmHOhSIj/6sns=; b=GXwHfugatyN6uEmNrKZdDrrJy4Gt6Aaw5oNxSWw4eUBlPVFT5W9atrTA7BFHTq2BoddIMSaS13l92hECodXv86cWK/3xRLTL3uPytofrnH0Ksipa04hdvayoujHdrHAx9nO3m5klWWC+IPfUjsAKBjyeT3R6UVuZnTu2DRy2Vco= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by PAXPR03MB8225.eurprd03.prod.outlook.com (2603:10a6:102:24c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 13:12:40 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b%7]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 13:12:40 +0000 From: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= To: gcc-patches@gcc.gnu.org Cc: djordje.todorovic@syrmia.com, richard.guenther@gmail.com, jeffreyalaw@gmail.com, =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= Subject: [PATCH 1/2] ivopts: Compute complexity for unsupported addressing modes. Date: Wed, 21 Dec 2022 14:12:13 +0100 Message-Id: <20221221131214.190579-2-dimitrije.milosevic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> References: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> X-ClientProxiedBy: VI1PR0102CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:802::35) To AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR03MB4882:EE_|PAXPR03MB8225:EE_ X-MS-Office365-Filtering-Correlation-Id: e0595547-c33e-463b-d9bd-08dae35509a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +/aBNWoHQHO5SyQhVW0IU3Z7LlRAIIRDJxpKC0yeS/2J7C1muWXBcZNOc838ZAwC7gYxJ1/mw9KROCegqxwlsck3FGBhK/kBZ/0qGo7Rx4Kefk1M70/bnt9HKjtJtPwEGRAXvsrh/9gZ+VhBr6NrX9KR4cWL1HYh2f+gU0mCgZ3L0ubcx4XZipTr2T5Ns69z7lN4IIVP5b5ClEd1YlVVT4IDy4lVn8bsC0b4a5qhYtci+3JeHmH8DZgqQBlUJoUV5PbZv2vryw4OphB2BdZeWj4Qiu0sdI/4++pYaoTbjMb0mZahzcd6+m4WCw1nlPGSU7/L/mVeYFiuz9kZy7+1O9jSddJGCAuawFtVnIraiCwlVG7z1fGAsN3l+Nqt+qlmeA/SEeL+q3Q8rOprGU0Fx1PdcZIDC1mIWZLDg4VVOmuOgjbkIaUz3B0cIlnoGP9jigVU5esw/5ItZnNQ7NW0dlgBT4UM40d/lTOycjxEZBQUxLX+d7wKP/bvlWWp6zKndw11kpN4B3WOgDdRwox5C8TkV6gEjv4Jiftglz6K2ZhSseAYen72HEFrzz+n7Y+IuU8A7TaDssyInKDjUb5elazIajKcirroEsE2UAD9y2i6dFOOt/xQ0i1busEbGIcJI0jiFMbASiOEPBQuGfosMgG7C7o4IUQFQ9MtbxDGFmw1ANch0aKTV4O0k0B7LtIH44XUZUEkI1dNMLN1HFtJXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4882.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39840400004)(366004)(136003)(376002)(346002)(451199015)(2906002)(38350700002)(36756003)(38100700002)(86362001)(478600001)(107886003)(6666004)(6916009)(316002)(83380400001)(5660300002)(2616005)(6486002)(1076003)(6512007)(26005)(8676002)(52116002)(66476007)(66946007)(4326008)(66556008)(186003)(41300700001)(8936002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CmWVZbFCWuIvG4xsJVMcVf8NTR25MObU8oHR7ScSUrL63UWEpses0/P54JXHBmMj+BvPu3gN7Yb57vkExKc+fWvKB5JsZwYHHQOVEcS27SX0xCaaBDACUhFu9satNjD3uoDcL0tu5j9VtSC1YehKkfYgiWtmpt0NlU7aZvI/0W4+BIJvJ3s6Q0OLLF5ZQu4tZDRXVHvdos+s8KPFkubyIoaqLYr56MwlVcAKNrSDhlqERxfXAiE8QpEbOF/LfDl8aJRSCTT4ks7CJogjnfVotj96BNvSr5jqfufyD84yS7eeH7dI7pDMctUL8y9aeetuysho/8spcvnf2pOfOqRAM16SugUnK61YsVHEgXswG2FSzz/mQp9zYJezWtmBQ3jZs1Sf0wDRtydO6eDpMLMoKK8T72K88VcKxc0DU6Et0lPvbeMDX6YEDdC0BfDNYAiB6EiOcvmWq0VHDSirCcx3RB2Dt1iqiJVwX/EgTViOchbgM93iHfy6xjoNsgsfZs3DuqdL441Ax5M5vejgqlTdvvIoJ3azA0SIwNyPZVAM8nJuGJYwUrJEk91WpnQNn/m1aD4ksQnDyBL3TJf/rwrcWTVYfDwWrnZz80ad06vEb5qIICeQZw//mEF9siNTDc/pU/RjYvFRj9vYtcysLasUFsghP/1LJPGPaQwpnrb4NCqwItjSJ59bVpNwEE5mO5ovahUdzpbuYD8qxcxej+C9jX4XY4b2ZLzRvZ3B6u+aSRhXDMky+ohjq/Tt/OczWriwTLZqZ/RyfDaR7POow/WH3l9BP3Wp8VWIDDbx2AoSSEYkyurAvIfvZ5nWMwlJ11OV6OdxEIt5edDZ9nIbm3geBuviCmmuO4ivGvUP7kJR4u44QWEWIKB1CgwAEB0b4xyZBH3Sn3AQqmX+vGumPQKSOka5ElDglusne5Co+XrXrUa27L1Ss4ejN+iqnzPQdaCSEgstydoYeejJdrL91EF81k1ninKPUH7VtU1pbqfFwPpJnRH/j17IcjyCjbUzSWEdDUoTHBTxuQBjUSoAr2K9SJffDAiDmR5V1SmRbueA58RNFJaqmOt2XIU+pr2nCnmS2Yl3VLCe0ofaWNBZmOY4D+SOuDFocfH7TKn4wSUaG+CdNIw9nHO+Uf0taK6bjJ/0AF/lE97aUSLxD+7FkrXWo6O9dRvymBosgoPANbgbCjADlCJyhndK2K13xPY/l4C7yd/L1Ao54hFyenc9e2w6B0//mSBigJ3LkkxgdZLcliJwJ3iX8wuPNZ0f/MSfXOLPZl8XxBbe+FvWcwXCAsAhIvYnj9SQh+WyRtAdwx5p4XALy9ytNRQbgkF8oVAFXyhnXROgqWwOCGDyxWzctNwFSDrj6DzZlRgv3Y86btvIQ+WFlsxSKNxRD5+GtrBbF4WB/ep3ENGgvAofeQ29UqoGqUGFr9qodL5ShWCUrxFQCKJdBqu22T2Y/F1f9AGbOe8SgvBYIt25GleNJeT/0umQaf7+KuhGS9moQcxQYMa3AIfI7rzTeZzbW8O/qdsyOIApjV43uqX2XKhOTSQygnhdKZjYvNnz9xwoWBgFG9sAeGDsj8+D6uyLxriL1/8bN25iTYoPWym20juuC0tmXpE+8mIhdH9HeJw5OaoGzN7wH3Q= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0595547-c33e-463b-d9bd-08dae35509a0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 13:12:40.0858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5eLbKYms5Z7kvaaX11NuETb5LLTdMSs3OP783y7qEsIGwmKPm8qJbbu2JVfggYG+o0RyDgtFJHskM1qOZMpeIZW48W1EZMi+pp2Tn5G54AU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8225 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" After f9f69dd, complexity is calculated using the valid_mem_ref_p target hook. Architectures like Mips only allow BASE + OFFSET addressing modes, which in turn prevents the calculation of complexity for other addressing modes, resulting in non-optimal candidate selection. There still is code that adjusts the address cost for unsupported addressing modes, however, it only adjusts the cost part (the complexity part is left at 0). gcc/ChangeLog: * tree-ssa-loop-ivopts.cc (get_address_cost): Calculate complexity for unsupported addressing modes as well. Signed-off-by: Dimitrije Milosevic --- gcc/tree-ssa-loop-ivopts.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gcc/tree-ssa-loop-ivopts.cc b/gcc/tree-ssa-loop-ivopts.cc index ebd4aecce37..60c61dc9e49 100644 --- a/gcc/tree-ssa-loop-ivopts.cc +++ b/gcc/tree-ssa-loop-ivopts.cc @@ -4778,10 +4778,14 @@ get_address_cost (struct ivopts_data *data, struct iv_use *use, comp_inv = aff_combination_to_tree (aff_inv); if (comp_inv != NULL_TREE) cost = force_var_cost (data, comp_inv, inv_vars); - if (ratio != 1 && parts.step == NULL_TREE) + if (ratio != 1 && parts.step == NULL_TREE) { var_cost += mult_by_coeff_cost (ratio, addr_mode, speed); - if (comp_inv != NULL_TREE && parts.index == NULL_TREE) + var_cost.complexity += 1; + } + if (comp_inv != NULL_TREE && parts.index == NULL_TREE) { var_cost += add_cost (speed, addr_mode); + var_cost.complexity += 1; + } if (comp_inv && inv_expr && !simple_inv) { From patchwork Wed Dec 21 13:12:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= X-Patchwork-Id: 1718261 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=syrmia.com header.i=@syrmia.com header.a=rsa-sha256 header.s=selector1 header.b=svvhcLlw; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NcYlf6590z1ydZ for ; Thu, 22 Dec 2022 00:13:02 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D527D384E7AC for ; Wed, 21 Dec 2022 13:13:00 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2109.outbound.protection.outlook.com [40.107.20.109]) by sourceware.org (Postfix) with ESMTPS id B0977385B502 for ; Wed, 21 Dec 2022 13:12:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0977385B502 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cooQCu9FXzwuzk2hIEjAcgiOwVUd5Ack8M15w5CvUtmYGRucwjdwUcB2SCcnzpSXccUKKJHK24W0Uia9+/vHAtcAa9HPtcsAi5bVnFrAhtTJwPzWIoNt+DynUKo9X0oOJiguz2KMyO4cpB72yxhpm/psqpPPl8C51wWj0pkQ1Ncax597pZbm3f8rgIY2pQylpClwC0OZx9mTVoLfHTjYF2zIjeYyo7fl1mg4TDqFCKqpu+FHGXvWe+fuBFWhapRNboRL8o3ERr6UgoonTXYNRJR5EKC8eWmr9Mgn3UWs9NMB2IlqurOCVjySRUs/QcGSqpWdfYzyIOo9mjsP/pAdVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j9aGxqqO2/mwQgWJsZ3oZHU/+vtyf1BpWpAhwq7/3Qg=; b=ay4pnsPEa9xWkuzGAa1XmCMghRFGXZFHbnZRhdXj2PVFzAz+0InRAtlcy4w1VmGwHcKrfipVKYOCb/rQ5P34y6M5LfgPgdC9qcSlfF72tUYluKOVZrp2ZbqlpDjrp4wN3N9ZaZrdVD6+Kk6UsmzjPld2VhehdXhIuI41eTDOnlXHXpxG/Y4MCcvUO6UKMpQ4zlocZNR0aU9afFRkkWyfmkwb+QNfL0hO132aJf7SQ/l29ozSDXyVagLL81Fyj/WNkzOx+LSIL/+Qltx1s/JMYQCpvSXN6Ck8wVypecDcXRbplPfQ9Ec6RwVLRimj4aTkdYSknkTuUQGlHIXNAbOCpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9aGxqqO2/mwQgWJsZ3oZHU/+vtyf1BpWpAhwq7/3Qg=; b=svvhcLlwxjm8ItJ0ek28WbQwGIqXziB4noL73yOD5FcWL03+STP1uephGXy6ES8WKVKrDS8+o1n9o5GHiA/85rAQQ0hxLNQ7Qgf95UlizFwdMATxmrs9JElcS2xxqy639UlMt7DtzzYGrC274RrTwlvCNrSTQ3MGLYUC4qJ6SVs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by PAXPR03MB8225.eurprd03.prod.outlook.com (2603:10a6:102:24c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 13:12:43 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b%7]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 13:12:43 +0000 From: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= To: gcc-patches@gcc.gnu.org Cc: djordje.todorovic@syrmia.com, richard.guenther@gmail.com, jeffreyalaw@gmail.com, =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= Subject: [PATCH 2/2] ivopts: Revert register pressure cost when there are enough registers. Date: Wed, 21 Dec 2022 14:12:14 +0100 Message-Id: <20221221131214.190579-3-dimitrije.milosevic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> References: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> X-ClientProxiedBy: VI1PR0102CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:802::35) To AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR03MB4882:EE_|PAXPR03MB8225:EE_ X-MS-Office365-Filtering-Correlation-Id: ee420656-e9e1-45ea-bbcd-08dae3550b71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J5UI18o2paK0qUEP5gBkYugQ/jxtG1zENtufQNINv4GJ6QhPrrlE8GHITecbPxw350FecPCGizJdytAFBpFDu9ngjvaoQKFG1Ku0dYym9213AsEeeuASCyjpTCFsp7rrCkSPxWMW+lwUEKKEQ9Xq3aBNWGEHsbHKb002k2QZ07DmPVpav+L4O2DTkp8sB6bRQ4Tj6j/rZljSicSJQOadKWDJs4Y8/ATtDqtNXwYpNenzhytyU7LjRyePnXbIW13Qt5BQqbAjdgt889Vl3NiSaUshzvKE9Hy51hVp+PcICFscRsTdvX5ihpECFxHF1/P/EXfqcc0VvrqnaVtN7Db0ZuPkC6JdOTCRL+oqyZWj71niHWUOxcxlzMAV9gUt6yLZqx1Dz19EKUw3+tp0bAnpUPqaFabwDN73wXuqla+DE9lxbBKq9jODWMH+CmROiBqSjyiS16KyyFPD2ugFY4KRcZu2CtevrBgBRwnzxgRqFkESgm5DukOdxmmfpg0W+0Qrn+CzQf1i1tpvTwLQ/Ji/TqX+m4lHdAdaMayG8CMO7QELQD3wv4xArn7a9M2PSrD2H5tk8HIbqA38enIaHZwmpVlTDEzmFaqxSRrmm81wTL9l9UQFi6MzwbxpXysg85Sw3W50jLg5UH888nrYzCUdQ0ynQZ8z+9EjvcXPT2+cXuB6uHm24p57fLhL75zbcX034Bgc2oo86JbYIMsG1qEddQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4882.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39840400004)(366004)(136003)(376002)(346002)(451199015)(2906002)(38350700002)(36756003)(38100700002)(86362001)(478600001)(107886003)(6666004)(6916009)(316002)(83380400001)(5660300002)(2616005)(6486002)(1076003)(6512007)(26005)(8676002)(52116002)(66476007)(66946007)(4326008)(66556008)(186003)(41300700001)(8936002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /h+OTbYt6aMyD5jxlbluyZQh/0kSfl+IlT+oW0UcYAm5znFwaTzsQzJ8tEml/aFE9fk5lPkyuy7719FUYMkB69Iwh2RJh5mmXWQTAF3qLsgAwrOT3345wWlno6ZCerUPFsYVzHMSD3lCrJ7d+PQ6n3o55azcNqKtUreThnymYzwtj+/bFU5hFjTnhczAAPgAfyY6bpbHgQgBg/nZ5kFU1i9tmiza4X1u2WZ5ODAopHUxnBelITXV/vUR1w4NxmFDM62fkE4+gBgp6FrXQchenZSBBkNG86vspvmTb+jsZWG6JM/G5SNVYS865ufeowboolWJlA467FTjiQmkp3pTJ+3XJwSaWnIDxNbxevHVcZQjLQtHixsregZ5jgyywx5KkHCisZ+S7fqlDgY+iT9kOWUA4c71VR1VaSYSKqFsGqeP8j5h7nYJWtlgs7qW/OFl+6Ys6e9K+AK3v0okZq3KVj8aBdXVdfJc7k+a7ga6CdLhW0WAn4UUMLZHfGUjKgdBuH3aSySTSMkNaXcEMfqJwNYddU5lHgHPDwzKQ1xxfwVKWbmNz7CueZQiqIJry3DlJ9KswsDaD7G5V3Hi+jhs1K6Fd09eCmnmPYsxKGZqyethA3vFdPQvpccYZlOevZgDqNRkfn2u2xgA/yvjumEtv8ItBi0NLM6RJ1jIbpeP8li7MmZYTUj7YPsZTKmgXS+d9yEvqCAOPQ1fTDxJ6+GY3+RbZGn/zL3odRnueLkeAr4nmnEb7atzbrFA4Tjs4BYvaFTXuEhpQ/hEzzd7LHYE4qddFquQeLTxtaPCiIHdgq0ct1AoGszFm4+et7bKmTEijFXt79mPfZR5wdH5lhQn/xbtmm2XcEkfFl9R/SsTuCczT66gwuezumvcfbPNGSZqMPkZRc5MDjGpxBB18qhkmAWM/waX1vBIxY89PeLEweUujR26fGqXuGerZr+2ePN5xlBH7R9pP27lHotZN0hTxrHXz57U8BMdz0B3wlmBTtnhswld8YWzmolMwjVk0i5TCBn1ygDw3Tc5eUqSiK2tj7P19X3mWJVe3+FoTgs36iRC08aKp5w2gNEFQLKeWpAjyaZLLo0vpJ+jKkKv0BS9KceYfbSQiO3ZnKcxEhJj6T804dm08xlDIs90CjS6PDaC0nsmuntb9KfSHGF9AWWgq7YotywseQx7oioSoPTw1R1+ZQj7DXJYod+bGeZokyxedVXQWCYXoPD9MyCpOR/BQG2xR20Sd89gxRhX9seuHoZUveWGoAp0HMpw4vLTrjy8vK/I2LVIpwaLadEjSM7vGD4qFo3IjM/IlOTGM+T7qzrRW7fkoBpuelGsjQZDCiuelO9xvbRg1hFn5J5H7/WQqIX1XGiFkWgk8ZDDBxiiN/vk4zFco/TCZMhBdAUHHn4rAI/BiwY9tMH4xgVPFCT6DDRRtRLUOybnrh+uTKHO3luEMOrwHwKUMrY55ijFy8Xy/Jg6QRpobAhkhNdPIvVvUbkK3+E7gqi35bJCIUexKRuAXIrozCPief98RZLEbKF0JvI8ztHfTosn+TB816W/xEQoSEJq8dNBolb9oISDZpa1j7JF7F3B2VQentNDS1YmwS4ErGFdr06osSecAupxX/q0byv6Uy6fXh47Xo4dZpQ= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee420656-e9e1-45ea-bbcd-08dae3550b71 X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 13:12:43.2105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WaZhMadCKGlsXUs+zc4+QnGwvpRMYApzc0dph1/LAHHxXURtXvsO6jUls/yEGY7tPuTGxV5QrD8Wa7KMR0RKqu9/4/8kZYxfGQwn2g39Vd4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8225 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" When there are enough registers, the register pressure cost is unnecessarily bumped by adding another n_cands. This behavior may result in register pressure costs for the case when there are enough registers being higher than for other cases. When there are enough registers, the register pressure cost should be equal to n_invs + n_cands. This used to be the case before c18101f. gcc/ChangeLog: * tree-ssa-loop-ivopts.cc (ivopts_estimate_reg_pressure): Adjust. Signed-off-by: Dimitrije Milosevic --- gcc/tree-ssa-loop-ivopts.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-ssa-loop-ivopts.cc b/gcc/tree-ssa-loop-ivopts.cc index 60c61dc9e49..3176482d0d9 100644 --- a/gcc/tree-ssa-loop-ivopts.cc +++ b/gcc/tree-ssa-loop-ivopts.cc @@ -6092,7 +6092,7 @@ ivopts_estimate_reg_pressure (struct ivopts_data *data, unsigned n_invs, /* If we have enough registers. */ if (regs_needed + target_res_regs < available_regs) - cost = n_new; + return n_new; /* If close to running out of registers, try to preserve them. */ else if (regs_needed <= available_regs) cost = target_reg_cost [speed] * regs_needed;