From patchwork Mon Mar 12 23:00:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 884939 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B2mqQBTb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 400YPT3Gttz9sSm for ; Tue, 13 Mar 2018 10:01:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbeCLXAu (ORCPT ); Mon, 12 Mar 2018 19:00:50 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:39514 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbeCLXAs (ORCPT ); Mon, 12 Mar 2018 19:00:48 -0400 Received: by mail-pf0-f195.google.com with SMTP id u5so5025405pfh.6; Mon, 12 Mar 2018 16:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=iiAaIsby/YpzmSaMub8sQRfGjQl3KQk2V/zJrf/ERpE=; b=B2mqQBTbDs45s1TDktpTyTVOI4COIzzurAULSfFWlL2lTX+knQfxiOMNxaKVKUWyKZ pb3Ne391wbsb7qYfvzhOjn3ZtDakkk4S+pcMa+/V/aAagMmGpNzTa5j8jv8wo67eN5UH GGRAwTE1Mt4DxFSu5mhLNc8W4cE0A8Qzin80rlpl8NJqzWxbSJaEvF4AMg0E1Ysc6AKV sOPekDjJu5EPQV5vGZ0iHAqNVSYnui+noedMI/y7C6qFhdLLb5ZN2LyTmPW0tOzoSacI SzkB60eHoXTnDJ8AKLXik/qd4K3mZuWbTUxkaDMD/nakYlPhUROwrUd0Yg6zNcKwA9q4 HSrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iiAaIsby/YpzmSaMub8sQRfGjQl3KQk2V/zJrf/ERpE=; b=EMHifn6XyJh1cfN6+yEKbFluCtq7Voljjqy5DVy72W4FuL5o6BhuKxDBdtY85y0+UQ 8lyBXq40Y15k9p5P1H/YLOfF86yI4I7Au2mCR+7uOo2sHSBv3AbYt7uOSu7Z28CaLR+5 MmXTkyz2gAfqBQvK2PfdrKbk4DHsksbNi69QSpoCBDTraxgxkk6a5iDEt0wU4pXjNcOn TQJ7Bgs39gUmQqB35ERMCVfmSepGhLyvg4Y1biQ88p1TIyupm9H/6sUr0LY1G63QZNqa n2kSLGJwXb196imxkFXPAhJhPW/IMQvksFA3iXZt14kUuA1gAL2XtGMZTzUoJsYMrBwQ OH/A== X-Gm-Message-State: AElRT7Fm1Cs+oUt7N5PsThFbGwfzFFgL2QYCYE0P/s2+CTjVdZ4CKeGI X5R25K5bZCjxXFCsavHak2GM3t/h X-Google-Smtp-Source: AG47ELsYNBUSo/PexBIY/vZ9pgycq6feMZ4JzxLuuP0wgZIgiinfla5LEJ1OtutnFYy31CxNzHkujw== X-Received: by 10.99.100.197 with SMTP id y188mr4592014pgb.277.1520895647872; Mon, 12 Mar 2018 16:00:47 -0700 (PDT) Received: from stbirv-lnx-3.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id n13sm18659834pfg.45.2018.03.12.16.00.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Mar 2018 16:00:46 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: yxj790222@163.com, Florian Fainelli , Andrew Lunn , Vivien Didelot , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: dsa: Fix dsa_is_user_port() test inversion Date: Mon, 12 Mar 2018 16:00:40 -0700 Message-Id: <1520895640-28139-1-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org During the conversion to dsa_is_user_port(), a condition ended up being reversed, which would prevent the creation of any user port when using the legacy binding and/or platform data, fix that. Fixes: 4a5b85ffe2a0 ("net: dsa: use dsa_is_user_port everywhere") Signed-off-by: Florian Fainelli --- net/dsa/legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c index cb54b81d0bd9..42a7b85b84e1 100644 --- a/net/dsa/legacy.c +++ b/net/dsa/legacy.c @@ -194,7 +194,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, ds->ports[i].dn = cd->port_dn[i]; ds->ports[i].cpu_dp = dst->cpu_dp; - if (dsa_is_user_port(ds, i)) + if (!dsa_is_user_port(ds, i)) continue; ret = dsa_slave_create(&ds->ports[i]);