From patchwork Fri Dec 9 14:26:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 1714254 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=cQi52Z+/; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NTCyY4ZTYz23ns for ; Sat, 10 Dec 2022 01:27:00 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD010383AB42 for ; Fri, 9 Dec 2022 14:26:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD010383AB42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670596017; bh=JuIWD74HKwWNjOrJZz4pgvOuEyslg6/fm38pr8lKdJU=; h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=cQi52Z+/YZ94g+DPNM/5wpNVoC7RtYM9m4iHGEju7Hrh2+CN0K8fBRZixWLDKSBly 0fdfHrcRVgs4WaLBq6ni7acxa1hXH0UsumFMC01P40JNPqtQFsxSimZ82S/hDT/NwY 6Nsgy1hswyuNlvi1Ut3X3QfRgN1db4tjQfSxeHto= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2055.outbound.protection.outlook.com [40.107.22.55]) by sourceware.org (Postfix) with ESMTPS id EC943383B681 for ; Fri, 9 Dec 2022 14:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC943383B681 Received: from FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) by DU0PR08MB8066.eurprd08.prod.outlook.com (2603:10a6:10:3e9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 14:26:27 +0000 Received: from VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::f0) by FR0P281CA0046.outlook.office365.com (2603:10a6:d10:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.5 via Frontend Transport; Fri, 9 Dec 2022 14:26:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT009.mail.protection.outlook.com (100.127.144.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5901.17 via Frontend Transport; Fri, 9 Dec 2022 14:26:27 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 09 Dec 2022 14:26:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 80dc0c3f0355ec58 X-CR-MTA-TID: 64aa7808 Received: from 9510d751b4c9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7F085EBA-DB4D-450B-9081-ABDECA5D6B16.1; Fri, 09 Dec 2022 14:26:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9510d751b4c9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Dec 2022 14:26:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XInHm5+DO4uKJGjF4DwQIlKDFysAdQQGjwWINB40QofDug++Seo4LOKG1o0+NuqqSujdS+mxg2CbXrdf2HIB3C6Q143glLDGHx0w7dAyMGgm3Z6SqV/+8Lgvt5H2xEFugSZ1ws4Pk/IfMf2iHUU0ow3+BAwFB7T+/3tKjCYx9+3MFhVOP6fvuRWPhyy7a1pDMMk/Xufj9mLHrIlDzpljb+E2xZvP5GK9UCfxt0dePB+EgFkcCTO8t6GKDeEnpsK0CXMcD50lcmGFl5zRIwixKJS+iFFkNXFxeE0DydTyZkfqTclQCcSi3gdKFFD+5G60EQzXP2fLhEsHdfQ/vv4tsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JuIWD74HKwWNjOrJZz4pgvOuEyslg6/fm38pr8lKdJU=; b=iR1agJZjCGo0h5cXQTSt7gbENu6P6GEBzzUPjxD7ztLos026IOKEiYTWUMnuq3eXiQ4kfrGe27YvgFUoIMCO5yMoS4MkDRvYuGQBBX78n//cGiNcoFwmTR9MLH9c/Rjmih0P7UKA/+0cSw0nen4+nfTIVDacgXDIQPS+HGrkC96DZMIDEEYur6jyNx8qbsXAcYip7SqzurQ//3uIQ0fviyliThoe+VVGtjPnMcTrYxWqPiWMblaOVYBs1nhh1ksYiW1H4NXDq1AkmDqrL66YhDFI1mnrmVMVjyg2+SLbmeItwQIf+Ub29Pcu6A2hybbMNsyZKFKNGDw9mpApTqEYcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by PAXPR08MB7671.eurprd08.prod.outlook.com (2603:10a6:102:245::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.5; Fri, 9 Dec 2022 14:26:11 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::66e4:4940:d096:4f7]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::66e4:4940:d096:4f7%8]) with mapi id 15.20.5880.008; Fri, 9 Dec 2022 14:26:11 +0000 To: GCC Patches CC: Richard Sandiford Subject: [PATCH] AArch64: Enable TARGET_CONST_ANCHOR Thread-Topic: [PATCH] AArch64: Enable TARGET_CONST_ANCHOR Thread-Index: AQHZC9lYp+BmyKu8Bk2Kv3vmS2lUUg== Date: Fri, 9 Dec 2022 14:26:11 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|PAXPR08MB7671:EE_|VI1EUR03FT009:EE_|DU0PR08MB8066:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f0942fb-170b-4437-d476-08dad9f15b8b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: m2249EFlh8LO1JexesmXRspDaMKWoLVrUIqhKpMXBpoCBWtKQydKkmMRY/lnjC9NElSHlBEvvM9JcFljX/kYv1LWVOP7Z5T4qStbbJT//nJdQuEoaVA9mRNAdzQ3iy5RDDt7mHVK/yITGi0U/WocsYtQ2uYFTQsn4tBGxKHqOzU5cHJEkWFQfbY3duWVhHC8x0ounkHOrJwLsHCQ1ViRj0dsR+a/L80mYYCjPIagkJPcEsC7YxKtuytuNwKOQfAyCA5Uv+4HML2tdWArvfa8RJQO+5XsuN1ny3ZvomQq184wvsg7n2lO2k3UEECSCUsmwi527gDOHJkNB0N+kwydYHnFfuJUky9dKp7rFufJr7ysyjsCqyXU+kCqumAazddDuCTXw5r2eFa/leqqogsxjfe+AEN3NyRAIQiYjX5G0dAvK3vhTTmet8jPNsRtw0O4IzJNzyPtkEg4LKfnGEDG2xv/UxIyqiXgluj6PyXuckdpxfbfKc1PtvPRTnsMvwNQR4sWkODs7HuIOiCz60v8eIaKo7atdbez6Z7Slr10IlJNbk4XaWChzZiZ/LR+i7cjJFSdHcUgTYmpoXGW4PeMEobNrGlUfMq0YvCiuGKGJTjMvjWnFo81hH+T1IJaol2Wj9i1jWwiwqhs80ylL6xRSMZcPjYmP7dkbn0I0iwAUruK+IopEDRgfh3vD/mwNp83270bgJ7tIQu/je1dxpooi7cKsFytlD2Ev96y/Oj653k= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199015)(84970400001)(55016003)(71200400001)(316002)(6916009)(91956017)(38070700005)(33656002)(86362001)(38100700002)(122000001)(186003)(26005)(7696005)(6506007)(9686003)(66476007)(66946007)(8676002)(52536014)(8936002)(64756008)(4326008)(66556008)(76116006)(2906002)(5660300002)(66446008)(478600001)(41300700001); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7671 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57941afc-ae2f-4b33-3154-08dad9f15209 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jh6s1Fy2xwhv6E5ngJuCIvtqbi1R3fnCjMfOBFDKOPyvvwfxU4KBHnv+UqfcxZDOfOWILcwHH/DQTE815WuuXBrPM//HABDCj5Uru6pM7kLsoWakruF9dc98Em61qBciFl25SKwSSVHO62D0uA1ZGKdCXA6cV8F5xnvdffduxNFu1r1x1CaG+KBnT7iupFuqpIbejP3iArZ+xOMHpq2Q/99RSSeeXROmvXF1+cBGFAPMld6nxKd/ShSf2H2AnJqyixbOiqjCecqXvMUj4HtKhmreOhQCIshQf3Uk53dUmoZGd+OObKpQI7rThT6FQhcrfDunCTlLujy6XJVAn8YPEO//GkuT7kZ9tanI0xHdVKYE+o9euQgynJjctPQByRYuuOHVEBoUJwfc7uO90fV/lv9AfOFWXfG1bPcWS9mvB7MY+cR8rS+E860DRKEgNxOsDd8YiTtHy9Vx8DrgiAz+oY1+jbAOdJngixbYWvOIWV6HUr8CwBitVMbl+yJ3zRRkyP1w+/Ajz8UZ5TGX9LlB4g7QGHYtdl8g46fcE84u24K7kJyCAmdT8zcLJPUdrFa6tf22mYvwl8HKvK3t/VnvXm+QT0quTQ65LHweohw+jDbMgLOvqt9wniLbhEseNFe5d+T9wwvdifti4qNHrn016lUcJ6myNv9G9yzp3+SvWeIvm7JrHyogLqjMHDHEduAFuQZSLe/GYmwQiPT7UCCkpvOElulEGweMXurDfUv6zaY= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(47076005)(40460700003)(7696005)(6506007)(2906002)(9686003)(26005)(82740400003)(186003)(82310400005)(336012)(5660300002)(478600001)(33656002)(52536014)(8676002)(70586007)(8936002)(40480700001)(41300700001)(4326008)(356005)(70206006)(316002)(6916009)(84970400001)(55016003)(81166007)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 14:26:27.1332 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0942fb-170b-4437-d476-08dad9f15b8b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8066 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Wilco Dijkstra via Gcc-patches From: Wilco Dijkstra Reply-To: Wilco Dijkstra Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Enable TARGET_CONST_ANCHOR to allow complex constants to be created via immediate add. Use a 24-bit range as that enables a 3 or 4-instruction immediate to be replaced by 2 additions. Fix the costing of immediate add to support 24-bit immediate and 12-bit shifted immediates. The generated code for the testcase is now the same or better than LLVM. It also results in a small codesize reduction on SPEC. Passes bootstrap and regress, OK for commit? gcc/ * config/aarch64/aarch64.cc (aarch64_rtx_costs): Add correct costs for 24-bit immediate add and 12-bit high immediate add. (TARGET_CONST_ANCHOR): Define. gcc/testsuite/ * gcc.target/aarch64/movk_3.c: New test. diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index e97f3b32f7c7f43564d6a4207eae5a34b9e9bfe7..a73741800c963ee6605fd2cfa918f4399da4bfdf 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -14257,6 +14257,16 @@ cost_plus: return true; } + if (aarch64_pluslong_immediate (op1, mode)) + { + /* 24-bit add in 2 instructions or 12-bit shifted add. */ + if ((INTVAL (op1) & 0xfff) != 0) + *cost += COSTS_N_INSNS (1); + + *cost += rtx_cost (op0, mode, PLUS, 0, speed); + return true; + } + *cost += rtx_cost (op1, mode, PLUS, 1, speed); /* Look for ADD (extended register). */ @@ -28051,6 +28061,9 @@ aarch64_libgcc_floating_mode_supported_p #undef TARGET_HAVE_SHADOW_CALL_STACK #define TARGET_HAVE_SHADOW_CALL_STACK true +#undef TARGET_CONST_ANCHOR +#define TARGET_CONST_ANCHOR 0x1000000 + struct gcc_target targetm = TARGET_INITIALIZER; #include "gt-aarch64.h" diff --git a/gcc/testsuite/gcc.target/aarch64/movk_3.c b/gcc/testsuite/gcc.target/aarch64/movk_3.c new file mode 100644 index 0000000000000000000000000000000000000000..9e8c0c42671bef3f63028b4e51d0bd78c9903994 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/movk_3.c @@ -0,0 +1,56 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 --save-temps" } */ + + +/* 2 MOV */ +void f16 (long *p) +{ + p[0] = 0x1234; + p[2] = 0x1235; +} + +/* MOV, MOVK and ADD */ +void f32_1 (long *p) +{ + p[0] = 0x12345678; + p[2] = 0x12345678 + 0xfff; +} + +/* 2 MOV, 2 MOVK */ +void f32_2 (long *p) +{ + p[0] = 0x12345678; + p[2] = 0x12345678 + 0x555555; +} + +/* MOV, MOVK and ADD */ +void f32_3 (long *p) +{ + p[0] = 0x12345678; + p[2] = 0x12345678 + 0x999000; +} + +/* MOV, 2 MOVK and ADD */ +void f48_1 (long *p) +{ + p[0] = 0x123456789abc; + p[2] = 0x123456789abc + 0xfff; +} + +/* MOV, 2 MOVK and 2 ADD */ +void f48_2 (long *p) +{ + p[0] = 0x123456789abc; + p[2] = 0x123456789abc + 0x666666; +} + +/* 2 MOV, 4 MOVK */ +void f48_3 (long *p) +{ + p[0] = 0x123456789abc; + p[2] = 0x123456789abc + 0x1666666; +} + +/* { dg-final { scan-assembler-times "mov\tx\[0-9\]+, \[0-9\]+" 10 } } */ +/* { dg-final { scan-assembler-times "movk\tx\[0-9\]+, 0x\[0-9a-f\]+" 12 } } */ +/* { dg-final { scan-assembler-times "add\tx\[0-9\]+, x\[0-9\]+, \[0-9\]+" 5 } } */