From patchwork Sat Mar 10 01:35:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 884070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="d5ML4y6l"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zyn014ZTQz9sl7 for ; Sat, 10 Mar 2018 12:36:17 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 5E3EDFC8; Sat, 10 Mar 2018 01:36:14 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E9EAAF7A for ; Sat, 10 Mar 2018 01:36:12 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A6C925CE for ; Sat, 10 Mar 2018 01:36:12 +0000 (UTC) Received: by mail-pl0-f65.google.com with SMTP id s13-v6so6171037plq.6 for ; Fri, 09 Mar 2018 17:36:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=ui3dRiRpkNkDhvgL8mjLyxfmLU3IJLPTJydJ0yz/8Dc=; b=d5ML4y6lgUo6CR8rjPZ1w5tLeK/8zApWKqhOzLGIqugi+HKyneQzx7fQ5jskSeQ/SB ZCOcc9thqcYQN/gHCQU6F7xidIz1Ve1jNU+0KZKrgN/XzZD8K4eLLVSqxcvtVV6dOnez hXa+FYsl1wn9zG86APzTOLJqLOP/El5XmJYm4LwbsxFrbincKhw+6rd5Lzr1iR4EeRWd YnN/U5ZF8jzT+cwF/1K/t0f3HzZtK7eoZy+mq1pm/3lz1vWFuA2yqUb8kiYt3Ypfp+58 74XuX/8Ipsf+vhPKSU8V0ibQcRo3pIsp696E9CaADvn6X4w+FEyXy5U6Jl+PSF51mvQM v0OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=ui3dRiRpkNkDhvgL8mjLyxfmLU3IJLPTJydJ0yz/8Dc=; b=ZlSmze8GWtfkLyEdrgaL9o1GiFx5cu7Lku1YAOFNFVSEL551hg3POLTpc3SgH37WVB 4qj2ChC28WS3+MQVlVY10SR5so8lxmEwYzMPBXxGPc2KXSsJ32paSizsl6++mFSPgq2X wl2qVK//LvcFKqvkMFxp1wgawJ4/5y7Ub/Ea3HAVVH+m9TRb2KPdEeudRCLkejphm8b8 Dwd4wYicYfdwRY3kqRfENpFiHs6DK8x2v/UF0g0v4iRmn37vd7BqgwX/bV+/KGsnCPMi obNCWNJevCKUlyA5B/+WIeLIJL+KuOXAKB7zBke2N0A+gBdCqbsfY6uWoQ5mabtAXei6 aqoA== X-Gm-Message-State: AElRT7HhZZCwZUgxCZAjCgoBRbG7kT4HDHtY0o5vEyHCkegUuVWzjHGW Opk7zfc9v4B0/cVvj+8I03ibeL9/ X-Google-Smtp-Source: AG47ELvC0/YlRWQcPa1GY4VGzVOQ5aE9lUAIoC9Q1zV19rAZSEm+Wg7Y/SAU4xIsL5fhlyXuRm5QJw== X-Received: by 2002:a17:902:887:: with SMTP id 7-v6mr484529pll.89.1520645772061; Fri, 09 Mar 2018 17:36:12 -0800 (PST) Received: from sc9-mailhost2.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id k185sm4228684pgk.94.2018.03.09.17.36.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 17:36:11 -0800 (PST) From: William Tu To: dev@openvswitch.org Date: Fri, 9 Mar 2018 17:35:45 -0800 Message-Id: <1520645745-3785-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] dpif-netlink: improve queue id error message. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When users set queue id larger than the 61440 limit, ex: set_queue: 65500, print the value in wanring message. VMWare-BZ: #2071111 Signed-off-by: William Tu --- lib/dpif-netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index acf1a6debcf7..c171795710df 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2511,6 +2511,7 @@ dpif_netlink_queue_to_priority(const struct dpif *dpif OVS_UNUSED, *priority = TC_H_MAKE(1 << 16, queue_id + 1); return 0; } else { + VLOG_WARN("queue id %u is over limit (61440)", queue_id); return EINVAL; } }