From patchwork Wed Nov 16 10:47:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0BW5ghrz23n4 for ; Wed, 16 Nov 2022 21:48:03 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CD75D41796; Wed, 16 Nov 2022 10:48:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CD75D41796 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yyVJeLuT23yi; Wed, 16 Nov 2022 10:47:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 864A441821; Wed, 16 Nov 2022 10:47:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 864A441821 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2F154C0071; Wed, 16 Nov 2022 10:47:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E6FEFC002D for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C117661012 for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C117661012 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wu7DVpt9thMB for ; Wed, 16 Nov 2022 10:47:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B56DB6100F Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8b::62b]) by smtp3.osuosl.org (Postfix) with ESMTPS id B56DB6100F for ; Wed, 16 Nov 2022 10:47:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9QdZwBNRdxS+Y23WvbI+WJuj/gOe+KTdCcx2H/FsCLCEbpjGYdf8UFwMPyrPHEKCzQx+i7dqgD2LpO7b0YoaGF8Bk2uvcBfEH7yFlDQmd3yg3o7Pq4N2/fhqTaXWVB5FrDi2ivGVwNxyY7VMEaz7DSFo9lCH2gTjqqv6qFhkWIS2n54vn8uUZ+/p9UdRQ1tJhAh9f5QAc5hZlMXj/YUzPU/WC+U8V8HgiYrKqvLsGwnbMbAxrzif4xFFtoCoI0BuGIS9k2bCIfX7XNuDTi07v0kcxJzBR7tuoBuKpNBRRXyXW4in/QzdM/updn0mj1mTEp8XczVoksIBP579hp7sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FGcRraTZ5bbZgigYBOvXlYoAOq/YxSaZv4puB74bceE=; b=PIuvZSG7mZ7C37nhAii+UuAVVnzTfIvuElvGffDcmFn5PWwyj8NKxFQ+a0DlMIrpILPI/MoTUNqEO2lkVxvo9mInHhUadPXLOsfO5wpjSj/9l3WNMzWB5KX9q67cxyRO4ALzTbgmvtlBQvS+kWG7DoMfsBoEyF+3IsMCvjkPDzAHMDBm0SJqq3BqAYEI9R8oMcHXEtwJvvyKwogULLf65tYmB+BnFSFCANXsAdmKS2jodIbkLOFV/KZP0uAsbbY1lMsvadfys6XvabPXJEFudVapXR2NRE55v5BNFE5sj6I9pRHqzoXHSnIhDavrZxgJ+XRs76Y15KasTMvkhDhPvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FGcRraTZ5bbZgigYBOvXlYoAOq/YxSaZv4puB74bceE=; b=aswmE2p+ZE31SmSXa4XW1ywrJdFDFZprbPXW508h70GX4hrVgBLwQLvInF9x9N0ECrEFVbSfVEh+FTMkcHh1qNJRsfTIuZW3ecLVgFKJIijswtAeI7ToMkzABnhX3Uf5xaeSKMwx1Hey2cNKvG8Srbw9gTZT6V1UIthax6vQEaoYr3HKywEl062DtOgFdRY6eW3EzJVDt4QnHZ678M/fvge4Ze43TsU6geWMviqu3+xcM1jqpTzKO6dD5PykwMKENrFHMbtKSr6GQVsRA3kLel1k+SO+LTY/5/XgJRTK9vlYNwmlf53bUqQXY2WN1aJAuQ49UcIDqizxdMlSkufzXQ== Received: from DM6PR18CA0013.namprd18.prod.outlook.com (2603:10b6:5:15b::26) by DM6PR12MB4532.namprd12.prod.outlook.com (2603:10b6:5:2af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:47:53 +0000 Received: from DM6NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:5:15b:cafe::4b) by DM6PR18CA0013.outlook.office365.com (2603:10b6:5:15b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15 via Frontend Transport; Wed, 16 Nov 2022 10:47:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT104.mail.protection.outlook.com (10.13.173.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:47:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:45 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:43 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:20 +0200 Message-ID: <20221116104727.915151-2-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT104:EE_|DM6PR12MB4532:EE_ X-MS-Office365-Filtering-Correlation-Id: 0094839c-ea97-40ff-c74a-08dac7c003a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nWTw14sqFctW6GPlUXyUJ9QYAMZAKC/DCWXNZq8muRU6Tq2Ie06I9In/a29irDyEF7EfDNT70n+dRlboXFSvmofFHbjFknQYRAUdWEmUtrSqDPiy16R0nTVVqbLbBFHSvb6sMaDYwYiqAvHlsHt10ARbWUjxBBLQQKACLFVRCg8VcRJakJeO4XYGAPtg5+hApwqMlt/c0OgmoNtxB1nZbPz9p3L/7afSb4oPkN2EGnyJ6E9HqhXxomPVKpr/l9gn0TjX8zfgsea6DwXD38i/kcgHe+q17iUoN6v+S0OoRE0/mTQlcS5Cxx2SOWI/jXninnFVpw/DqraUzoe/UqtNiklFT0ATBMKEZEgivIR2h9nbRjf4sCCa/LlAq8aqRas0QoIf8QicE/7gikufwo+xnwdpbUys3T0eJA/LE4BPPOo+4WUp8fOcjYWKezGSIb3iirtF9VYS11Y8iQXR23EjZFlJePkg67WAhDCzLnQzh94BaIWOwWWK3NsgdF1SasupebqpI4jaBs/RkGgQm/GaGPiUwxYBgbDqTz6IZXptnYDGmkzcvNU/QAhnf4hqj9+WDD1pijbMmVay4BlaPZfl0aJ1hTemzslLOTvORuP+6sU2GynfS61B4Rg3/FzOwRIqwWDcYb4OSRESUhIisTSRB4yg4pdXWiM+QqnYbq0HJxd1daf76YjBD+7GKt9MZtxg5mhFDtSj7cR+zfC8vxsw3pHPFL1U//dTPJ5w7ivP9l5znFUx0r+tTU1IphOSFHny98b3ObKSujj3aV78PUkwnQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(7696005)(6666004)(478600001)(426003)(40480700001)(2906002)(6286002)(26005)(107886003)(16526019)(336012)(8676002)(186003)(47076005)(70586007)(4326008)(70206006)(5660300002)(40460700003)(356005)(36756003)(110136005)(82310400005)(316002)(54906003)(8936002)(41300700001)(86362001)(55016003)(36860700001)(7636003)(2616005)(1076003)(83380400001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:47:53.3694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0094839c-ea97-40ff-c74a-08dac7c003a6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4532 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 1/8] dp-packet: Fix dp-packet may be used initialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: In function 'dp_packet_reset_offload', inlined from 'dp_packet_init__' at ../lib/dp-packet.c:35:5, inlined from 'dp_packet_use__' at ../lib/dp-packet.c:50:5, inlined from 'dp_packet_use' at ../lib/dp-packet.c:60:5, inlined from 'dp_packet_init' at ../lib/dp-packet.c:126:5, inlined from 'dp_packet_new' at ../lib/dp-packet.c:154:5: ../lib/dp-packet.h:944:32: error: 'MEM[(uint32_t *)p_14 + 16B]' may be used uninitialized [-Werror=maybe-uninitialized] 944 | *dp_packet_ol_flags_ptr(p) &= ~DP_PACKET_OL_SUPPORTED_MASK; | ^ Fixes: a47e2db209e4 ("dp-packet: Refactor offloading API.") Signed-off-by: Eli Britstein --- lib/dp-packet.c | 1 - lib/dp-packet.h | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 4538d2a61..f654752a1 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -32,7 +32,6 @@ dp_packet_init__(struct dp_packet *b, size_t allocated, enum dp_packet_source so dp_packet_reset_offsets(b); pkt_metadata_init(&b->md, 0); dp_packet_reset_cutlen(b); - dp_packet_reset_offload(b); /* Initialize implementation-specific fields of dp_packet. */ dp_packet_init_specific(b); /* By default assume the packet type to be Ethernet. */ diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 55eeaab2c..9864dfcbf 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -572,7 +572,8 @@ dp_packet_init_specific(struct dp_packet *p) { /* This initialization is needed for packets that do not come from DPDK * interfaces, when vswitchd is built with --with-dpdk. */ - p->mbuf.ol_flags = p->mbuf.tx_offload = p->mbuf.packet_type = 0; + *dp_packet_ol_flags_ptr(p) = 0; + p->mbuf.tx_offload = p->mbuf.packet_type = 0; p->mbuf.nb_segs = 1; p->mbuf.next = NULL; } @@ -638,9 +639,9 @@ dp_packet_set_allocated(struct dp_packet *b, uint16_t s) #else /* DPDK_NETDEV */ static inline void -dp_packet_init_specific(struct dp_packet *p OVS_UNUSED) +dp_packet_init_specific(struct dp_packet *p) { - /* There are no implementation-specific fields for initialization. */ + *dp_packet_ol_flags_ptr(p) = 0; } static inline void * From patchwork Wed Nov 16 10:47:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704469 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lYYZCalc; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0BY5hltz23n4 for ; Wed, 16 Nov 2022 21:48:05 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 51ED140BA0; Wed, 16 Nov 2022 10:48:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 51ED140BA0 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lYYZCalc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R2mkt-3_JqMo; Wed, 16 Nov 2022 10:48:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 478DE40BA3; Wed, 16 Nov 2022 10:48:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 478DE40BA3 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 14F14C007C; Wed, 16 Nov 2022 10:48:00 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id EAB12C002D for ; Wed, 16 Nov 2022 10:47:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8159481FA2 for ; Wed, 16 Nov 2022 10:47:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8159481FA2 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lYYZCalc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HnmzppbbLz61 for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B346681EF4 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2061f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8b::61f]) by smtp1.osuosl.org (Postfix) with ESMTPS id B346681EF4 for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPW8ZmTDvcQm9dwfPG76neONW3nFqvYMFaKQrAmWfQ2pwf9SphUf6IPi9izhiLcW/QnnMPGAHoY13SeYPzIXQOulIcWSHPRvhin4sxDNwrflLfaIKXU+A+jAVSxFV8+5env/jgafUdwkoTlhLzZXMywWR6Mw0mnQOzFWSuSY4ET74ldHvR/3bwhQoxnvumh7Ftqp5qm8NH4H0UA/CgvQnIYESc+UK3a169d9R6jf2FlscTAuIdo1Hafkqs/o83gDpheizHslbRjlOdx+XkmDS50jCNJA6rWnZ+cACSp+RS5q0gwhdNMj2QGYX2xh2ACBESvnVy1zpvUIuz9i2A75jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BMkoLqv0KSpjRHxwN0geSnldYNW5PoWszRdtKZThLFY=; b=izZACQoBgXemHsnScgHYSaO2rzw1uv9bIyWiG6/WUfbsMZDArb/JaFj4RlwfUUzjVXE2r3vRXZs2aB5sijByRR3CfrEZy/VV8Qy9FS8efcVGESMlGryVsjkeLszDaLr7r4tcCoIqsT3EEpBiQAgeMj4vCMvv3ng3X70fSno2qbQAAjWks69l2Y/AK8LhcBRf4j5+HAd/MuT4DCLu89bowNlR4J03X1ELL0+38wnVCUxfmFlVI92KOrG0/OcoRX3gCtnhtKw+9+gCNr56o4LKt1+tld53jG0ADwttIJG9B1dQj8a/HNQUQLmU/kqSTHEm5OxKXUeTGjYPF4C5Hz3glw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BMkoLqv0KSpjRHxwN0geSnldYNW5PoWszRdtKZThLFY=; b=lYYZCalcWTHxiJLZ9VXaQyu3Kg5xCGyQZieXxkUZhSuhlCmlEj/RQ1uW25n+MyOSyycTrqYBE6U4NHX3qkyMGTKT4RUmRSrvvyCPF3Jjj9PE3dF7uDUU6tjnQQ3LUcPmF+PlaDW1XqsKSnteZGkBCoHJV3qppeKYhLqYDC4E2K/5oMCAjUKGDZcTG2QtkWJQTUqUrMhASOv6yJcqgJxIbapwnarplegCq+V35hSuR4TDUKLykh9NibuT+7hZRlBTN8GMAnmpOM45smRbguoaad80qrhshlUCOXj+JebCJZKd0Usu99XUiT+YsuBXl/8R9wfHxlw2SuJ49n6YX7eX8g== Received: from DM6PR18CA0004.namprd18.prod.outlook.com (2603:10b6:5:15b::17) by CY5PR12MB6226.namprd12.prod.outlook.com (2603:10b6:930:22::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:47:54 +0000 Received: from DM6NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:5:15b:cafe::5e) by DM6PR18CA0004.outlook.office365.com (2603:10b6:5:15b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Wed, 16 Nov 2022 10:47:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT104.mail.protection.outlook.com (10.13.173.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:47:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:47 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:45 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:21 +0200 Message-ID: <20221116104727.915151-3-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT104:EE_|CY5PR12MB6226:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b4bc80f-cfda-41b6-4467-08dac7c0046a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wvVeiAh9aHSjGfYz+WNiBKPm9rsCIRoZaullvcXyeSFigCGcKpLlIVp3O8jVQbhDyMrgVmUNCYbil4bMvTg6JuDjyP/eUVAYoXYJhW7PpERaEONa39MTVNGuIH+Km3subBzxn4FdZ3AunDVi68A/WG6nFEOAi4p3E7rMPx7fPWj4yMMcbrVvtNStqQxsAEMI/+FBpNLDAlLgkrBcJJ/4RD3kISvPKOObVM6rS0F8KyUrzGElUFoAHKEq5pwSvjDlgqwRPwLN2ULIO1kvaQVzViCfVErcwDLfLxtBah8HOstauhZ2+GSLfZ9kerAl+hagoZLnRNdATeavRtnYabcc2/+zsg4QKwVwBU82vF/xiI9Dbs2GqHc+lLAQFCb7V3IwGzU7NEX1X27ZbJGiVD38gxwm4phsAdubtF5ZHT8XFhl8lvQdt49VoSc9mYsujoZHCY7Zr2KM4Pu7KtH2wFmm2dRPszpyBzIfaXgS2IaRKE5+eoY3KSEoCP3Js/yPs9Hlx5NtDDhTXfp0Utl/cm/tjoTQZZIOZf8lK39dmDKmUBOHW6oU5pw096/d4HuYmkbMd7+jkE/JDIVqVHVwkO8wgl8fESH9eRHWLrY7GgzVYeUB5qdAzVKS753IBXNeahbWxEqEQwqXVgcOYO1f3n0jl3me9Kjh0vW0oZtSBU2JYYt9nTZw+4eiQnhBlEp4pMDHkb/qxC9/SvZoQ3Ok+2co6RFQX+Y34PsaO9vgcu9Glr2TAWAfMXO54b6oL/zgyXqxJH1ZnGUC9jnDRCKk9cvTbA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(36756003)(7636003)(356005)(86362001)(36860700001)(83380400001)(40460700003)(55016003)(1076003)(40480700001)(2906002)(5660300002)(16526019)(336012)(7696005)(426003)(2616005)(186003)(47076005)(6286002)(26005)(82740400003)(4326008)(70206006)(82310400005)(6666004)(70586007)(54906003)(110136005)(107886003)(8936002)(8676002)(316002)(41300700001)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:47:54.6505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b4bc80f-cfda-41b6-4467-08dac7c0046a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6226 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 2/8] ofp-port: Fix 'strnlen' specified bound may exceed source size X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: In function 'ovs_strlcpy', inlined from 'ovs_strlcpy' at ../lib/util.c:377:1, inlined from 'ofputil_port_to_string' at ../lib/ofp-port.c:273:9, inlined from 'ofputil_port_from_string.part.0' at ../lib/ofp-port.c:170:13: ../lib/util.c:380:22: error: 'strnlen' specified bound 15 may exceed source size 11 [-Werror=stringop-overread] 380 | size_t len = strnlen(src, size - 1); | ^ Fixes: 28b114322856 ("ofp-util: New function ofputil_port_to_string().") Signed-off-by: Eli Britstein --- lib/ofp-port.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ofp-port.c b/lib/ofp-port.c index 16d587488..6e884cd3f 100644 --- a/lib/ofp-port.c +++ b/lib/ofp-port.c @@ -270,7 +270,8 @@ ofputil_port_to_string(ofp_port_t port, { const char *reserved_name = ofputil_port_get_reserved_name(port); if (reserved_name) { - ovs_strlcpy(namebuf, reserved_name, bufsize); + ovs_strlcpy(namebuf, reserved_name, MIN(strlen(reserved_name), + bufsize)); return; } From patchwork Wed Nov 16 10:47:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=qo5n5bV1; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0Bn4cNxz23n4 for ; Wed, 16 Nov 2022 21:48:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2786981FF4; Wed, 16 Nov 2022 10:48:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2786981FF4 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=qo5n5bV1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DIrl04Y_jxIm; Wed, 16 Nov 2022 10:48:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 45C0882001; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 45C0882001 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06E1BC0071; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1E6F0C0077 for ; Wed, 16 Nov 2022 10:48:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 00B6981FEA for ; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 00B6981FEA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kQyjWMsoEoH2 for ; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3583281FE2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::62c]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3583281FE2 for ; Wed, 16 Nov 2022 10:48:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9cMQxTmAlMFslc3ulZH7pSD2nTnCvcJ8y+ci4t1munprzphNtlRTPvovusqnoiErITG53N9dl2jPBsM51JT8V3T2ALksCGTWSh725WMTiFNhQCJSpxsjliWhcLKp4OSS25rApF0FHRFHPdwF5EzoFbw4Y1fea16jf4PlXve/IrMbQvssLvnvu5h16IZKQrMneshW1QKWnCIDkn99tWrfkaC6OfqvheOrPh1VNKnrSeWZWqxuRxBL26SBG8FOEMZRsevhSEJJl97CMzLEoPtepozya0U4s9GK2WmlkcMpJBm6dqIsNl2I10ZrbNBZkLl2h66LGk3bWtOCQClqseMGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EQII9F6/nad8H9fn8i1G638aYhBZQoAgcY09zYH3cNs=; b=cPKMn10UmQ6Y0Us98hW2qJN5YfxLA62kY5H9n3pih56p83nIaAhQ4TcVGmBAEjzvFe+bLIN58jQb+azr2NHp4gfnFY/PvmSZQ4Rs5iRyiy7QBdGFekVUmnYMF+tdyYa1ckCaxkUTjTbdkjf5GagqhONJgdijmho1z3CMvyXFXJJk4+GAzqWfEgJZd72r5d9yTyXkmjQZLx8ks9NShgVIQcOhwaUxowidM9p6AQCoMPhEQDaLso/lW97yHV8XrA0Ye2G6dxPP+wjCJFKXTIXW/5676SOZ/5lt9MNBlVhzo12+fXJlKQ/XLjACsq3V8h4t8xEuixb0+tk08T36Ot8Xjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EQII9F6/nad8H9fn8i1G638aYhBZQoAgcY09zYH3cNs=; b=qo5n5bV11Vbdgjy7PZc5JH1+A9m+ZQX/nis1CekHFqWKsssmbVgw04Hp+zOwwFwCxMb59UclogUFPktzxB/3rwAMswbt92pWLqgCBV3k1zD5LeDhRKlx8zwuTUMZWVb5Dydv94IG6NLK55csMYNP/evXfiuyU3+TIX+S8bn//adeSrrdVkYlqqvVmk1vsleju/JrQNP16ClySBLxt9u16TkGVsQACdG4GLqttXY2dENG5OnPz9TJ8TseK1rCSs9FYezyThxVfLLc3e+bwb/R5VZxm8q6sq0IwjK4xNSxfveINtvGoshum9ZFFqgdU/bsoqJe6Lh3Kek2gsIelbur6A== Received: from DM6PR06CA0070.namprd06.prod.outlook.com (2603:10b6:5:54::47) by SN7PR12MB8145.namprd12.prod.outlook.com (2603:10b6:806:350::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:48:02 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::a4) by DM6PR06CA0070.outlook.office365.com (2603:10b6:5:54::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 10:48:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:49 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:47 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:22 +0200 Message-ID: <20221116104727.915151-4-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|SN7PR12MB8145:EE_ X-MS-Office365-Filtering-Correlation-Id: 686c93da-2b46-4d24-a3ea-08dac7c008c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hnusXLhD7BComVa6TRNTByBXafj/PvMb8YE6V6KCknsqk5PoMAtWtXk2IlwK6JgAsdGmjcgxdRk9yZgkddQKu9cej0ejVdmOKHgN3q5BkhawbQTuHvVJqA0TXNln5HcePW7ZY+chUUUJZnGti/iQfQCrg2e0JSGgk7JPe/zhEvPb4ZMKINw+/fwBHkkQmuvdZGOLJxQP2NV8Zbx36evzYrqeUBRq5BCdGr6o8P8WVUj0vxUfyD2Co4eGCubGhhyfzz00eFNIZ/JquOGTjCfq8Z2E0fgGlP0bRdPSS4t40mVJOx+nQi/BzyqUoaKsFWmWrQgyIpXilG+lSOtRygPoiXxJUXeByMWvia+tLTVTFlrP6pX96WGz57rUBlcm77pF48ICa5ke0lfUTUJ5k74CuIttjCFv6HS+VFvtLp5z8tw7/IB12Bh9ZmPcIONsQhZIVrPZhatkCbHMiD0vAUQkQ1NddXl0mI8OpUa8v7Nl0R55rbiq/go3zOfOKK3J9X1vicvmql6HGBfxTScTe876QyPKgGtuDDff79WZS+bHHvu87SAgrOK29jepkEZb1Ug05QGHa9Yvw9EdOcqkDHNWiCGuyDpfOhLyBnMufDRj6nF6Y84iNlpByDVfoPKeTN3zTSUlofH0OOOWiY+yaaZ6OAv0lELXS/fYfo7AHbqkkBqi8w1lNEj9Ih51S/msfiTJMU4Ku4guu842o0btfoFQCbb3v3ovDW3SAciQQKNEGxeMbXaOJsn8hMvdZ1C69oqww0Qn53wYamGr2XiElCTS2A== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(5660300002)(41300700001)(2906002)(110136005)(70206006)(70586007)(8676002)(316002)(54906003)(4326008)(7696005)(336012)(6666004)(107886003)(40460700003)(86362001)(2616005)(83380400001)(186003)(478600001)(16526019)(6286002)(26005)(82740400003)(1076003)(7636003)(356005)(8936002)(47076005)(40480700001)(426003)(55016003)(36860700001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:01.9864 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 686c93da-2b46-4d24-a3ea-08dac7c008c9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8145 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 3/8] ovs-ofctl: Fix 'usable_protocols' may be used uninitialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: ../utilities/ovs-ofctl.c: In function 'ofctl_group_mod_file': ../utilities/ovs-ofctl.c:3107:16: error: 'usable_protocols' may be used uninitialized in this function [-Werror=maybe-uninitialized] 3107 | protocol = open_vconn_for_flow_mod(remote, &vconn, usable_protocols); | ^ ../utilities/ovs-ofctl.c:3124:27: note: 'usable_protocols' was declared here 3124 | enum ofputil_protocol usable_protocols; | ^ Fixes: 69185eb25acb ("ovs-ofctl: Only allow usable protocols for group commands") Signed-off-by: Eli Britstein --- utilities/ovs-ofctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index fe9114580..6805140d6 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -3121,7 +3121,7 @@ static void ofctl_group_mod_file(int argc OVS_UNUSED, char *argv[], int command) { struct ofputil_group_mod *gms = NULL; - enum ofputil_protocol usable_protocols; + enum ofputil_protocol usable_protocols = 0; size_t n_gms = 0; char *error; From patchwork Wed Nov 16 10:47:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=SxARc5YM; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0C44gDqz23n4 for ; Wed, 16 Nov 2022 21:48:32 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B1AA880A6F; Wed, 16 Nov 2022 10:48:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B1AA880A6F Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=SxARc5YM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0X4PVhITf3ir; Wed, 16 Nov 2022 10:48:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 251A48201F; Wed, 16 Nov 2022 10:48:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 251A48201F Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CB80AC0077; Wed, 16 Nov 2022 10:48:26 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3FE12C0084 for ; Wed, 16 Nov 2022 10:48:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E922F40C52 for ; Wed, 16 Nov 2022 10:48:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E922F40C52 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=SxARc5YM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gwLV5oE2AzZs for ; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9C73240C3F Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20624.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::624]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9C73240C3F for ; Wed, 16 Nov 2022 10:48:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKOddrv97KEbxQMJynI9BKi5Znn3xwTLkbNIz+M+Tz584m6SRalQy6EXZwsNmOqxUTfx/wjSBGTrifvQx2XMZ3596qtulLsathnxI9WBekInwttgCE9TEqHNvJ993EBTFk6c4UoB8Cj/5rMlByFIrVV+n5cDwMNCF3iJjV6pGQHLPznU8C6XrUbLQ2BOK8FnD8mgxhchBM3DZ5Hwz8dclsHdizkX7Tgab9rrSJ8PB/rXQuaTV5aXP1NbIYfCwkAgJYwd/1kOG5Dzsfcp2hFK/IVAKHc+xu+rrTc8xWsD9OsecLUggzX4PgBa4fD0jILZ2doSBRlI5ixP+T8mCS71tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4GeElDjSshhPmCaVFnHCcA9/yqNW5yGIkpYGs8fbJyk=; b=k0rGkp4D3z23vwuOENeFsfLhQdH+UZXgWbx2yfRwglU5b6UdOUdOkWPe1iUcfDMY7sWEQi0QVSMYDNbwmxqsizxpVZDcxRwxS6lG8mtYbzZ+VkNW55TdBt6Sl31/VtxHoXL/YfLc2iisYIw+3EAQbVvP5XvO439ZAOwLgYk1Ipe995nam6Au+yX2C5YYgdrr/Oedgjcgnz/d7jjB5bNqxo1rfbKxJEY4JZ+c/CKO00O0l6pAa2TIT0V9CEwvY/pk6PdSmrkx6FfIiSZl2hREx+Klr6yq13GGl6drJmEvCeATNIy2Gf2t7PiGFMVGZFR8unQrOiNgfzF69dcGftcQjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4GeElDjSshhPmCaVFnHCcA9/yqNW5yGIkpYGs8fbJyk=; b=SxARc5YM7F+kvoeax+5uBX7Or+FJGb7eHOOCL1vv0b0TZx4btmuLNStA9AHY2xwX0YKgRlXH7m7MCS++/0wUgr3GAvIqfN56oc7UEv1XEtnFRrvauX2DtTB4vEUcqMmO+FfzfUzPYRZbEKfueO8HLNmxMCD0sjeY/RTtXoigOftC1ySfb4E+/MSlUiwROA9OOeGM+v3vsybW2oJc1xjpD4VQMLTTtajajrR36CQsm38nhH6tV5Vn6QIffuHpt3PWY4vLNNgGV+LM/H7KtCXfmpGxph8mTaUJ51bJORo8VPJ8Me47EG/nvHr+Ms5QWsFiZPKD2cCe1iBpQQYof7VSCw== Received: from MW4PR02CA0020.namprd02.prod.outlook.com (2603:10b6:303:16d::26) by IA0PR12MB7556.namprd12.prod.outlook.com (2603:10b6:208:43c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 10:48:10 +0000 Received: from CO1NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::e) by MW4PR02CA0020.outlook.office365.com (2603:10b6:303:16d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Wed, 16 Nov 2022 10:48:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT079.mail.protection.outlook.com (10.13.175.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:51 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:49 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:23 +0200 Message-ID: <20221116104727.915151-5-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT079:EE_|IA0PR12MB7556:EE_ X-MS-Office365-Filtering-Correlation-Id: ccaf79bb-3338-4d6c-08bc-08dac7c00d3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +juvAbvfDjOUG4fPsFwFTzEgJg/FLf5vNK6Rp6FP1ARshn7JQ0p8nf/H8YyMuXs4PFiuTaPiQklOzMjdCQr+gc2XXsJPuItF7jMnUI3amiCBKJaFDJ5yfGBtQFHRvoXIhvc3DbRE22UExsgnVz9uFG3LeVz/lViMfa6ZNCXfzQM9+UtXAZNMYJW24+XHKQsA+Ky9f8aGp7s2UHK6QhN+HFSRg7ZmcgcSU1qu7ggqiWa/P3OK5ik4B83tVKsWW7dUkbSZhyT0tS6oYckpUlZXtwQDlcvXUCml5ChRP4UtKi0whTqgg+ReQgky3UONHPgV3lZoFckvJISQvVJKW9LHi6sVSKOBHigtxSG+Wy7c+IMMxUc0naHHWL6K1qUB/37oFcx1Wm7h9JvTErWCwg2l6AMSUkKhyXCvjaBFEmCEIhR3n2tI/lC6lcWoicAN1gDl9RPgbT/raoTD7Jxmat7IE22k+RnoBnrFhp4TMoSkx9apgE/yLnExzNrcZWGnipH4jHho/gXtmueuC005jtGGec09m/Y4gEvjLZBhaf6rSvS3qEiWiRqm+oF3JJwin0Lg4mo9RpLxiBdiAjcDPj/T4NDrU3FgyXtu3C1MbAn52X+1FmakdHnT1T2k/Ay+VKW20ET0GSf1kL2o5RwYjFiH7Ubx1dft7OplkIezmT66g4BgvhmdF8MXVWX0+lCD2cuGt0Jws9azMzlZQfKzOROi1TNVToFM+hdoaZD74Np48eMRjfzUTeKIMsdJdRNIvwhZqK0tzRqRmJgzSnvFVQk9FA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(426003)(2906002)(82310400005)(70206006)(70586007)(4326008)(8676002)(55016003)(40480700001)(110136005)(7696005)(40460700003)(316002)(54906003)(36756003)(26005)(6286002)(1076003)(16526019)(8936002)(186003)(5660300002)(336012)(107886003)(6666004)(41300700001)(2616005)(86362001)(478600001)(36860700001)(356005)(7636003)(83380400001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:09.5004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccaf79bb-3338-4d6c-08bc-08dac7c00d3d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7556 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 4/8] dpctl: Fix zone/limit may be used uninitialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: ../lib/dpctl.c: In function 'dpctl_ct_set_limits': ../lib/ct-dpif.c:698:22: error: 'zone' may be used uninitialized in this function [-Werror=maybe-uninitialized] 698 | zone_limit->zone = zone; | ^ ../lib/dpctl.c:2139:18: note: 'zone' was declared here 2139 | uint16_t zone; | ^ ../lib/ct-dpif.c:699:23: error: 'limit' may be used uninitialized in this function [-Werror=maybe-uninitialized] 699 | zone_limit->limit = limit; | ^ ../lib/dpctl.c:2140:18: note: 'limit' was declared here 2140 | uint32_t limit; | ^ Fixes: 4eeec031d4c4 ("dpctl: Implement dpctl commands for conntrack per zone limit") Signed-off-by: Eli Britstein --- lib/dpctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 29041fa3e..714bf3c4b 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -2136,8 +2136,9 @@ dpctl_ct_set_limits(int argc, const char *argv[], /* Parse ct zone limit tuples */ while (i < argc) { - uint16_t zone; - uint32_t limit; + uint32_t limit = 0; + uint16_t zone = 0; + if (!ct_dpif_parse_zone_limit_tuple(argv[i++], &zone, &limit, &ds)) { error = EINVAL; goto error; From patchwork Wed Nov 16 10:47:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=D5i+RDRp; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0By4FzWz23n4 for ; Wed, 16 Nov 2022 21:48:26 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CC9CA61067; Wed, 16 Nov 2022 10:48:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CC9CA61067 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=D5i+RDRp X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ljiGTSXkoN4U; Wed, 16 Nov 2022 10:48:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 25C3161037; Wed, 16 Nov 2022 10:48:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 25C3161037 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D22A0C0033; Wed, 16 Nov 2022 10:48:19 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 24C3AC0077 for ; Wed, 16 Nov 2022 10:48:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C4DCD81FEB for ; Wed, 16 Nov 2022 10:48:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C4DCD81FEB Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=D5i+RDRp X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o2Vb3qZ7VC_p for ; Wed, 16 Nov 2022 10:48:08 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org EB13181FF2 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::62f]) by smtp1.osuosl.org (Postfix) with ESMTPS id EB13181FF2 for ; Wed, 16 Nov 2022 10:48:07 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fisZOt+WqyevKfbOnUPryUZOKtoBXedI6M/dQcC2ZqwEKJvqLbI620KXkJ3P9ofiXT7TC+1L3bnYRQ17r5V+wNRBBa1Wi65S2PE+nT38bWniwLhv0PlilfypujER6UFjou74frchiR8DYC81526kMrLHfmTlIgqbo8w0pjltd5gp3cnDUZ4W6ppcm7f0iQB63UtHe87N27b6WRgOrN8uEiAxw7sBp1rsrbl/h8tmLwDHiKCr7SAcfowKYL1JE/0oWEccRndtvVmLDHY5og0imh90lcpQawk61jjAHLqMBUyn4NcxXuMjqPglzP9HQO+aL+UGLwbq2CwtEM6hm5S2EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShkrYhoXYPfFS6hvgagI1ZwrtYzap6qlQAtorTP57p4=; b=TCXFbJYUimnGton/W9robSEPiGphP8QyGhOjU2NbSPHd2dH/GqyUSRiCU/yRMbPoTiyahgDS9zY2Jhxjj+5vqjS95/3gnbFPzojZel8SjoF/zzEi1m6GkJ6/5hrGwtxg0hvBMvHbop7c4RRNxE0+7nrrfAWvUAzAk/FjImCxfoBSg2LLoYKOAZkrJy5iGFBr/rQM/aJ0uJgEw3BW6TgQuvI4VCkR/yIjfoXawCbKPcD3vDQ9+hI6uHkdXbdSxgoE+33nYU9EZFzju8ABN92ka43OGwKCDWQJ982ddvfuxotkANDgoHvpMl+mfKvCtZSuhxNIrkiT3KDwKBsG0Q5kiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShkrYhoXYPfFS6hvgagI1ZwrtYzap6qlQAtorTP57p4=; b=D5i+RDRpR4snCXT6Cck5e4RcDoRQOGK1+5bnq3P/3/DGLVcx7yjV95EzEMmrsKdcJd5yoz8k0zLYROaQ5aiZeJrZsA5ZXyqdwhPXMh9gaEHpb3OoVPMc+drQddKni7AMUcWbHqjvURLYMWhZX9ZNdySgeUBvxYnYbWLr+Vn0peLfaoRi2uz7kT/zCReo4nLBTKP6BRa2jWyhIABlinp6IcPFF6e2Xnjb9CE5JOPzyg8y/p7C32NbCyCr6OEbn3VLe0rgeX5qWQDq8Xh7f0Ia0qYEBI93fOnJTz/KUY0LSUSCWogM3W2dIpm5QTSt9KVKZ/8P63FX/8Bta5TaEB3QMw== Received: from DM6PR06CA0053.namprd06.prod.outlook.com (2603:10b6:5:54::30) by MN0PR12MB5906.namprd12.prod.outlook.com (2603:10b6:208:37a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 10:48:05 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::82) by DM6PR06CA0053.outlook.office365.com (2603:10b6:5:54::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19 via Frontend Transport; Wed, 16 Nov 2022 10:48:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:53 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:51 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:24 +0200 Message-ID: <20221116104727.915151-6-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|MN0PR12MB5906:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ba00ed5-361d-4d4e-0c9d-08dac7c00ac3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kckrlkYyNbWiYy0MpegtaoGwHS+izs0o6C28JZInDs+jbqnm5a85O+3dQAeN+wl1R+5ZszPvbGwhUBBgq7GGnPfKxllou9Jw2QSNU+46dZifncFBcr3PMLWcbjQkxzugGW9TdI2jXXS8O6Wk8Fmb9li5ZOfeFujijKoWP0nD8n/ScCgOzOXpSOwDjPF0pd8qHZ81zJRd9c3gpvw/RfYhizzwdQku6qTjybuBd0mewvIGQucFrs9mx6v069KDrSMyK+87tUbPo0m9vXUBt4ipjkZbpWoazKxsN+T62jFBK5L+QXzJ5ixRbYI9NCGp+0wZSf3SZryl2wx4GWPnFQ5Njj+E628kHhhe7YrLb1/U2SyEtvXIStVM7JUIR4Clh+czK+8DXnyqhnRzdq88qCflPzNPMWOj2gebO/1mf9x8pg/gcBpt29q15jkDt3/W3xjunQeFa+dDk3iGowCvllK0gHlJotuTEiGWAeL9CKtADMPt7MNohLWE50Z0JdvrrswVJnyFMblfVZS5dRYQG/beOUu95nf2CFpp6qR2NkPhFu+mTnzDuYexx5ZWGDQkbJjP/W8AJb6eVW/jGVKtLVl+PudFwPpvWWyNKKwAZGzb4/mYrz2fU48QiJyz/kUsKpje4GptZF5/JaAX80Tio+J2OnmpstV/awQhDMwn9fBKhd+oLc8Y0cRBaK5n2bKqI8cQk+pnVOPYCMIdvcqfPYS8Cb2LNhVh4MJsZbLb1Di5np1kim91kuFOoVTdyGG9fE2weiWA29qWueIIXvNOKw+8VQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(82740400003)(40480700001)(356005)(7636003)(83380400001)(40460700003)(82310400005)(86362001)(36860700001)(47076005)(5660300002)(426003)(336012)(36756003)(2906002)(107886003)(6666004)(8676002)(4326008)(7696005)(70586007)(55016003)(70206006)(16526019)(1076003)(2616005)(8936002)(186003)(26005)(6286002)(54906003)(316002)(41300700001)(110136005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:05.2987 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba00ed5-361d-4d4e-0c9d-08dac7c00ac3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5906 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 5/8] ovsdb: Fix 'table' may be used uninitialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: ../ovsdb/ovsdb.c: In function 'ovsdb_schema_from_json': ../ovsdb/ovsdb.c:246:9: error: 'table' may be used uninitialized in this function [-Werror=maybe-uninitialized] 246 | shash_add(&schema->tables, table->name, table); | ^ ../ovsdb/ovsdb.c:230:36: note: 'table' was declared here 230 | struct ovsdb_table_schema *table; | ^ Fixes: f85f8ebbfac9 ("Initial implementation of OVSDB.") Signed-off-by: Eli Britstein --- ovsdb/ovsdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb.c b/ovsdb/ovsdb.c index 1c011fab0..8e0bbc967 100644 --- a/ovsdb/ovsdb.c +++ b/ovsdb/ovsdb.c @@ -227,7 +227,7 @@ ovsdb_schema_from_json(const struct json *json, struct ovsdb_schema **schemap) schema = ovsdb_schema_create(json_string(name), version, cksum ? json_string(cksum) : ""); SHASH_FOR_EACH (node, json_object(tables)) { - struct ovsdb_table_schema *table; + struct ovsdb_table_schema *table = NULL; if (node->name[0] == '_') { error = ovsdb_syntax_error(json, NULL, "names beginning with " From patchwork Wed Nov 16 10:47:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=mDGqf993; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0CG4Yr6z23n4 for ; Wed, 16 Nov 2022 21:48:42 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B5F2B40C87; Wed, 16 Nov 2022 10:48:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B5F2B40C87 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=mDGqf993 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wtGYaKhSDZOP; Wed, 16 Nov 2022 10:48:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8328240C0D; Wed, 16 Nov 2022 10:48:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8328240C0D Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 423BDC002D; Wed, 16 Nov 2022 10:48:38 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 24F6AC002D for ; Wed, 16 Nov 2022 10:48:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2EE8981FD8 for ; Wed, 16 Nov 2022 10:48:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2EE8981FD8 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=mDGqf993 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dmbx8qFa9enP for ; Wed, 16 Nov 2022 10:48:14 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C25DB82008 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20629.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::629]) by smtp1.osuosl.org (Postfix) with ESMTPS id C25DB82008 for ; Wed, 16 Nov 2022 10:48:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRamwO1zDi+yWHLpJNYJGOGguXrQ6tmy64r89GAj4rkHhqvvLi6EWF/mP70rxyO8M46BU1u24mH7RRIuZqpSDnzFjTJWy5XJGCwr2bmBvumQnEo1b1yIdpZDu3d2RCSTx9+bLbBtxKK3rzXq7Yks20k7uxhQKCFakUMz5TkD/EdZqEeq2LAXWgVyQ4eXLyPQVbdRFhXw+RGIAiuuqjK2xGsfiVT9ajBU8WgDpMtyGXPEpZHGK2ib0P5lLsLCbui9+97OxdLv5RJsQsow8ARnuVhDrXBA+LTV0RKqti73QXSMyc2nBFkZKsC4NjD69kF8yfqMmiUAK/Px6qdrT/EgJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKEGXlBE4l/hpAYRoLMldyugKX0uJNi/S0GZK3HFDLc=; b=BuLVEBuVb8JiSCUMZuOURuNfM0tAtQdQWLmsAtGrm6hX2eW8ksSMQXh6kYQ4jXkcWcsdBFSzb1JpcRnDiYrRCGs+FdE1qYGrAVLeVbCHSDL187l3D46wRwxdD87/kmfFFIa+PClqnWEXNzDUGS5SWrZZpvt7HKKMsWxMY/TTtqqUWx0FJgWkwwpLMiviPJ8PFTJmjP5sbPRMkqdMsyUmgJeclVOEWajVDPTlHHVYHgr/pyrNZYqMlzTWsjAKQdR1l+y5O/4gUUHNH/ynHDsD8sMvKcUt22uiYt6nNQKR0dCUO14CxBaOBHVRFZNwHQ62JR+W0QVa2y8ETEPraDa1ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKEGXlBE4l/hpAYRoLMldyugKX0uJNi/S0GZK3HFDLc=; b=mDGqf993j9sAAnfy8z01rg0j6DYm9/b+ymirpRAd7pCndxwLwk2ywdq+Ql7f4w2BkRNlEYrR87Y7pYiYAOymm0KJnMooUcPhU3edIkEmsXf269xKzuN+M0BxWiCclGOBSi+YxPEet0G2wRsYaTUydjC+/SdfVDiGvlLGeEEG61KP2s8OIxoz+XqylcVsXbd7MYWYXUs+0RCMxVu8+OI7BUK0XydOS2ZeFeMB9Se/DUllJPPo67MUIE4zqlviJQONTxExr+5cGi61u1RwqkoM5srOuWlJVTrDoKdpLY8eHQA7KuKX6iU56jWg6OmnYLOHWQylmvR7EuwDpLxUFgVk6w== Received: from MW4P222CA0024.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::29) by SJ1PR12MB6242.namprd12.prod.outlook.com (2603:10b6:a03:457::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:48:12 +0000 Received: from CO1NAM11FT111.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::a) by MW4P222CA0024.outlook.office365.com (2603:10b6:303:114::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 10:48:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT111.mail.protection.outlook.com (10.13.174.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:55 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:53 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:25 +0200 Message-ID: <20221116104727.915151-7-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT111:EE_|SJ1PR12MB6242:EE_ X-MS-Office365-Filtering-Correlation-Id: ed6524f4-a668-414d-6a70-08dac7c00e7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PmLpAoWpSUE6rDEx0m8b3Rop4MUu2An7ludn2IK2OPVCj3UQD4HUckdjfWCeKiUTwPccJJfhTtVVj0FlNdFJn5AoWqgi6VQLE4dLsS/r34W1evNF2mADmqQj7nmLzY7M6sxbD91ucZWU4tXh+8GCUm6tL6L5eh3HSC0BR72zrs7skuN9J0/GOAAsWS/YBIhq8aa4iyBt2tXPSwDsSpUjpH+RUForZQOOwOn0CD7Y1J8JytQFgZon2BkpCp2wLctgBKdKYK++uufrHnYB4Jx6YGH/UuMiMPFP0mBwyU/DFXwvzBC1T+sv82Zkjwv4uk8qxP503/UCFhUYvvjMR+CCYeo4W6F1veCmRW4lyxT2YrA2eTaqSOe1dELjyn4MvsVbS52DyEnLzm+2jqUGbpFgzr5+9IR0kmnls3vSDQImeA/ZQxO8xugqobnMJ+s5GEnCcGd7UNwR2UO/6Db3ki/ESpCGmEN56XhSYYExq1C9IxZSqqIt/MQPau6f+fQaaD1+1q773r0iGih81gIfmKFth88VVBiRjFW3OBgUIlKf9z+3tqQQTDnZe8cDDDobdP2W7VC4DOyPI9btD5ZrwMGsvZhQvfityYQiW7S7h2X25G1lbucmgYgyBc6LRCtQzC+4a+bCIq3cuRrYHtL77LznvS8OaQffMvCbFdXFMW1yxGxv8hTcH+83Xk64921AkE0jQ+gPFsTzrUQFoVK78iAtSzz5ZH5TcpKfLgc/ndOdXPDb0uQg7XyrnFbapAJC4JIPi/qDtBS7jX5zP9P2JzHteLnAtvn9mlOdgbz1PtVhp4ywIH9MPWWzXjt8GxQI89ORKGWC69yTPkBIhpqPBshBRc/b34cOG8vnh8sRAESTcZo= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(966005)(478600001)(83380400001)(107886003)(40480700001)(55016003)(6666004)(47076005)(7696005)(82740400003)(426003)(316002)(54906003)(110136005)(70586007)(70206006)(356005)(7636003)(8676002)(4326008)(82310400005)(41300700001)(336012)(26005)(86362001)(8936002)(2906002)(36860700001)(6286002)(36756003)(40460700003)(16526019)(186003)(1076003)(2616005)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:11.6026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed6524f4-a668-414d-6a70-08dac7c00e7b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT111.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6242 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 6/8] netlink: Fix writing bytes into a region of size 0 overflows the destination X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no, with gcc (Ubuntu 11.2.0-19ubuntu1), there are the following warnings (errors) emmitted. Those are reported in [1] to be GCC bug. Workaround it. In function 'memset', inlined from 'nl_msg_put_uninit' at ../lib/netlink.c:212:9, inlined from 'nl_msg_put_unspec_uninit' at ../lib/netlink.c:248:26, inlined from 'nl_msg_put_unspec' at ../lib/netlink.c:276:11, inlined from 'nl_msg_put_u8' at ../lib/netlink.c:294:5: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: error: '__builtin_memset' writing 3 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 59 | return __builtin___memset_chk (__dest, __ch, __len, | ^ In function 'memset', inlined from 'nl_msg_put_uninit' at ../lib/netlink.c:212:9, inlined from 'nl_msg_put_unspec_uninit' at ../lib/netlink.c:248:26, inlined from 'nl_msg_put_unspec' at ../lib/netlink.c:276:11, inlined from 'nl_msg_put_u16' at ../lib/netlink.c:302:5: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: error: '__builtin_memset' writing 2 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 59 | return __builtin___memset_chk (__dest, __ch, __len, | ^ [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92718 Signed-off-by: Eli Britstein --- lib/netlink.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/netlink.c b/lib/netlink.c index 6215282d6..c30620fdb 100644 --- a/lib/netlink.c +++ b/lib/netlink.c @@ -200,6 +200,14 @@ nl_msg_put(struct ofpbuf *msg, const void *data, size_t size) memcpy(nl_msg_put_uninit(msg, size), data, size); } +static void +nl_msg_zero_pad(char *pad_ptr, size_t pad_size) +{ + while (pad_size--) { + *pad_ptr++ = 0; + } +} + /* Appends 'size' bytes of data, plus Netlink padding if needed, to the tail * end of 'msg', reallocating and copying its data if necessary. Returns a * pointer to the first byte of the new data, which is left uninitialized. */ @@ -208,9 +216,7 @@ nl_msg_put_uninit(struct ofpbuf *msg, size_t size) { size_t pad = PAD_SIZE(size, NLMSG_ALIGNTO); char *p = ofpbuf_put_uninit(msg, size + pad); - if (pad) { - memset(p + size, 0, pad); - } + nl_msg_zero_pad(p + size, pad); return p; } @@ -231,9 +237,7 @@ nl_msg_push_uninit(struct ofpbuf *msg, size_t size) { size_t pad = PAD_SIZE(size, NLMSG_ALIGNTO); char *p = ofpbuf_push_uninit(msg, size + pad); - if (pad) { - memset(p + size, 0, pad); - } + nl_msg_zero_pad(p + size, pad); return p; } From patchwork Wed Nov 16 10:47:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704476 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lgzIzhWt; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0CM1Yckz23n4 for ; Wed, 16 Nov 2022 21:48:47 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CE993418AC; Wed, 16 Nov 2022 10:48:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CE993418AC Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lgzIzhWt X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z6co_28p0qOt; Wed, 16 Nov 2022 10:48:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 879E941920; Wed, 16 Nov 2022 10:48:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 879E941920 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4A78DC0080; Wed, 16 Nov 2022 10:48:42 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 08495C0077 for ; Wed, 16 Nov 2022 10:48:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2E02B61031 for ; Wed, 16 Nov 2022 10:48:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2E02B61031 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=lgzIzhWt X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id toWUYfl3LlIu for ; Wed, 16 Nov 2022 10:48:16 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7A9706103C Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::60f]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7A9706103C for ; Wed, 16 Nov 2022 10:48:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5mCVOqbSDRkCxGab1PbT+kVnkflF4KGjQw/ERXlheBrJj4PaAI1j71/3qPmfMQ0lJEnIzgC40e4KGLp2MvC1xyHns6Aq2iC/xUPANGprmbzEASd61Z5BgO3794luu6FEKBaAV5bffigNNFcDo+XhOa9QsZjkImvaAKaCyc/OoBRiFRVVFFO4cKZk3OA5sedYM9qLVZocIiv1HtmVDI136ZAY+7L1UwsuBCVJoYxsteyuQbDAVJLPhmdyxdIfMrWSgomC1N28j6UaAki/0tMrjViw9jR7jNeREevtIKYGsuUvOILOP7Fk3rbP4BTI1DSXtT2+LTTs2HMVUctznAZtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v6yVnK1HWd7uoegPgtRrOxqEw5x2KYUUNVEdC/dH2TY=; b=Qa0wztEGeGzZzcU7t1ojKaShtnDXsVDD9eValgmS1JQkEADbxtr/na64X4+gYURvtwgH3/MlLk/uPuhbos3iw6xw1RxT8B1/G60gNGYVqNso8IdZvhGMAqCMkZIayTTUHtdH899XoMnePtII7mpu4uLmRjcPGUBaEm6ljLj/94uXJ/FugwEjPw5X1qTIgcSz5bxgktayp22PSV3Fu+NsYSg3XpFzV3616n2EwZz+aA5aJoxWX8vboggr2tjF0OS2YNUkjWYREh0DgaXqTx+81RafQpBbc+Dc7Lya7ztTvk6KmTlIUNSZqT53UODsiSQB4HhVK5k9zUy6mE2gl2HHzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6yVnK1HWd7uoegPgtRrOxqEw5x2KYUUNVEdC/dH2TY=; b=lgzIzhWtLxSZWtMDVDLlv6jxNi8wOkYE5fkw/0KcSRKd0/m8Mg05gIi0oX02Hr0zG2+X3P/LR0UE5qEVeFKsVejAjVnWByJ4CKBv6BdK4GB6pkXMwvaZa6ns0rCb5evdm9We+YGSQ22ZtQ3kBbFddqFeE27ezrRpZVEWb+wyFYJG3/kXltGuuwN3/qyw3EBREUPUsUYu6TVURpB03WX5I7UUIqK2K8pJ7z64FGN3cgs5+9J8aINndFObnft8oz2RTroTZnU5XxzXEbh6zKUToIq7MTck0KZG9hjktXlqBXF/NJnkLm9YgGjNOomGro4QVf848wx/s9XdH4Y8cgpZxA== Received: from MW4P222CA0015.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::20) by MN2PR12MB4046.namprd12.prod.outlook.com (2603:10b6:208:1da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:48:14 +0000 Received: from CO1NAM11FT111.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::68) by MW4P222CA0015.outlook.office365.com (2603:10b6:303:114::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 10:48:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT111.mail.protection.outlook.com (10.13.174.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:57 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:55 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:26 +0200 Message-ID: <20221116104727.915151-8-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT111:EE_|MN2PR12MB4046:EE_ X-MS-Office365-Filtering-Correlation-Id: ecd42849-8438-4a71-929c-08dac7c00fcb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W4Q8yx4YcPC3WQEsm1UMQwvIPVWa3oUzfV1Xyp7cBtSVj8l4DCMaWE61bS+SSe68oAv4Z5laxQbi0bsoFw8NpRiJOlsKrEZhcz5Eb5vieS5vyYPbBwYAenjxAAu4nnT2o/40SiRD8jR4ImUARw8MwGOqKqy/PdrRhFUdi+J+aaWc/KQYTutK3orgk50J5hoW7Wza3v/UKihrm18KS8vnFZAmJ4Vw53JmquVxg/ba+WHCcOR2Fq7xRAKitIonIWI8vRn+7+wea3w0bMN+a4j0Gb4N/Dv0X/FOh4VD/iWzGcBPx8mRuHgAVhVfEprgJUr70azVzZh0om4kgjUx8NCG4xfi6nVrer11Y17+VCYf/tIA5B11drdE9kwHF1Da6vAuzFbPPOTWyEzRON+k5PKyw77RS9ZA5yfcoQongAVEB7/dGCtfH9KxWA0attuyxs6eaAWthUfKE73hSNXUtunP2lDB9kfeN2IumRgfNzXcYn6TBLlmuxXy1chsPmEjz3ewitfjp+bx5Soc2AjT4liO+BXqS86Ea+gVGRAaERFVneqYBNw8UFp9BffUl57Sw5TqnUo11n25yxquoyNycDBXdhD/mjSG7EXdGxTa739iSnHRevc0TRTx3AGBk98+nod2fbSezmAXqUMFYwaudn2y1eWpqWWQsv+B6GxhrJtorfAXhGKHraBj+P4XJDYXHk9JDBCtoNQfR7ypNZPudc2f5D1ee0xoiIRzYQ+C3tFYObAsh9yXo0Q2LucF6nbtZGY/rwnW2gIiTafDbVWOTwJt8A== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(36860700001)(336012)(426003)(40460700003)(47076005)(86362001)(16526019)(7636003)(356005)(82740400003)(4744005)(1076003)(2906002)(41300700001)(2616005)(82310400005)(8936002)(70206006)(5660300002)(107886003)(7696005)(55016003)(6666004)(40480700001)(478600001)(6286002)(186003)(26005)(8676002)(316002)(70586007)(54906003)(110136005)(4326008)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:13.8056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecd42849-8438-4a71-929c-08dac7c00fcb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT111.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4046 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 7/8] ofproto: Fix 'reply.type' may be used uninitialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" ../ofproto/ofproto.c: In function 'handle_openflow': ../lib/ofp-bundle.c:195:15: error: 'reply.type' may be used uninitialized in this function [-Werror=maybe-uninitialized] 195 | m->type = htons(msg->type); | ^ ../ofproto/ofproto.c:8460:36: note: 'reply.type' was declared here 8460 | struct ofputil_bundle_ctrl_msg reply; | ^ Fixes: 777af88d50b8 ("Add basic implementation for OpenFlow 1.4 bundles") Signed-off-by: Eli Britstein --- ofproto/ofproto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 3a527683c..5ba1b55fb 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -8471,6 +8471,7 @@ handle_bundle_control(struct ofconn *ofconn, const struct ofp_header *oh) return error; } reply.flags = 0; + reply.type = 0; reply.bundle_id = bctrl.bundle_id; switch (bctrl.type) { From patchwork Wed Nov 16 10:47:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=CiNHChy4; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0C1278Qz23n4 for ; Wed, 16 Nov 2022 21:48:29 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1AA7081FCA; Wed, 16 Nov 2022 10:48:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1AA7081FCA Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=CiNHChy4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EJaDlP8de_nI; Wed, 16 Nov 2022 10:48:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id C29AD81FFA; Wed, 16 Nov 2022 10:48:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C29AD81FFA Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91FCCC0071; Wed, 16 Nov 2022 10:48:24 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 37088C0033 for ; Wed, 16 Nov 2022 10:48:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5D22641879 for ; Wed, 16 Nov 2022 10:48:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5D22641879 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=CiNHChy4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dIrcwOyaH2ln for ; Wed, 16 Nov 2022 10:48:11 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 24D874003C Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60a]) by smtp4.osuosl.org (Postfix) with ESMTPS id 24D874003C for ; Wed, 16 Nov 2022 10:48:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRUypyKhNC3jgqxsAM+mdwwtY2yBHwWExJ5WxgHSB1ezYGyKYz89DPtxLY0ISgA3c24X3hEMF6frsezURMeUqkJ77SoceN4OOz+7qIeL9a8e8mxC8HvxbBHhfcbteVGujfYo8BI9iLWb4LsW/tZqPc7Wn3nBYF8jWS4Oth3KDhlCZcL6vzQIAK6wGSIL4QlGdnT+4DlSw9N6Novzeu7Qu8r7yE4AFjLwPSwVtoqNuaJmu0BCEXVZeY5YKa2qKqSijr6OhBjDRpNuYFZ4ZjGDIIrcOOJ/VuM4Hn6lrd3ZinnVHwk2XKclr1aTJ2SLGAgRPlvg8ueyfS//m7lja/1HJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sDQneJ3nQK8BIaBHmqSJC91DmNRK6bRbvCsmgAVGjg=; b=MaLlk69Lm7hEd6dHYzC9OKwW5MtF7A55NWkeYWSVcMPgejt5sf9EntCpxy/ra7wcJTdOcJC5LnJBRornkBvzpTPuqQat1JGWVzads1COYKQETuHVrTFUoC8uBWU10bTXEZkkhOVIta2eAvvdmZGvBZCnmAh8bfyePelPaAkaG1BXGPJ3/dVvWBxb9PxZQGz5iUFBLJJteLitZ2cXq985Y9T8LEbP4McAs7xhkykCMST8PiLp182N1gvFFJ27byIWaDfCEpR0ChaV1on4KfWHq3a9WJiwK61IobGwolM30LUhdoJyEZ7WnFo4T6wM2Z0df0TQkzSdacNeNg+a+gTAiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sDQneJ3nQK8BIaBHmqSJC91DmNRK6bRbvCsmgAVGjg=; b=CiNHChy4Bqeo+J9p7E2bEubSEt4/uJe2N6yxBKseaDWLfVgTKDhQdKmxX3LEJAN9Ob9EchKTJpKqsCwBkTgRb5X84ERoeinNyY6O5v8euA3slvtaJ7/VkOt/HRF/2qVbl7XKLVW168y1Q9qtH3ivQYT8r8gCrswIw60XDbDUCYHWJH9aecRD44Bo6udiXio9adx0IcEplXK/t3HevMPkx08yNzE2UHMXU5o6gnRHwTO2ISG3ndjhG2D6IY2vTTgwPZbreJdtF7DF4zr2Yv0v30Ayd+F0Dt4pBY+W0xpMOHKF3ckLbtWyqX8JzlWLsm0blutNVGlGIB2/Ntjct/GOUQ== Received: from DM6PR06CA0072.namprd06.prod.outlook.com (2603:10b6:5:54::49) by CO6PR12MB5473.namprd12.prod.outlook.com (2603:10b6:303:13e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:48:08 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::a2) by DM6PR06CA0072.outlook.office365.com (2603:10b6:5:54::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Wed, 16 Nov 2022 10:48:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:48:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:59 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:58 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:27 +0200 Message-ID: <20221116104727.915151-9-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|CO6PR12MB5473:EE_ X-MS-Office365-Filtering-Correlation-Id: 815bf8a4-6dc6-455f-131d-08dac7c00cba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cedyf+vHnJ0MzGcsx7oIZ/rZc+eIJJzGUsdjDYInaNfLH6Kh1hVqvvlL3mwmJi4RmRPQ2jGPgF+Y5W3dUTwhIVCOyry1BkD16tdWlScfF2tuAanlU8mnBUkx0Xb8qty6lPTxNtw+xuhS870XuhkRjfMpEb1u9EALlKlzQoEXmMjQgYuM42SJtcG3BkCZnHdVSPdqUr8YeZf9sBPpId4cEihXAICgFMMPkaY7RktgY2DGktk1SXwmzGhSU2g2xLHYb5wXvwexabPLp1Z73LH7zJqf4h3NBbOTqxnhLfcC1QTr7pwoX9hW086Eysf0hLnnTDvxl83hsp4lULyRrVBfcOYJN/afbcVvOE4b9tA/nkbiQQyc7C+ldwGc7bcaekE2PZslZg/whHEMgBd7mAJCOIhPQec2Hp0NBm+SB7JCusNNZFMi19eMJZfs6ZxeQjP8obOryItNP1/OIxdM8DVerjyGaojCrjsae3u+7Bn4TI28vHqQWDewcAGGH5GfX5e22WkXBieYsKhCpiLeW2cUWCmfv7nQjjb7GrxpByRftmyIHp1wvXCm/ZTCoWeOppUCJFwsD9xtVAzZnqzCIYSWnPyFSlAm27R1T3dz3SWDpk4/LYo2hbwNoN7rYGinbQcGUtGNfHOF8b4Of7NnRXd4uDyF5q/DBzcBjmSfBpPX7229JDSs22b6d077Gdf744+WyOQnXbGfMvtVCq6jKaoCm9t+LvXqKeGLvROgNxNkwDB4iOWywRjGyEKd1DgKa/Bk8/xaZ3UVQO2BFHNhZMYlYw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(6286002)(26005)(5660300002)(70586007)(82740400003)(16526019)(70206006)(8676002)(186003)(40460700003)(356005)(7636003)(2616005)(36756003)(1076003)(41300700001)(110136005)(8936002)(54906003)(4326008)(316002)(7696005)(83380400001)(2906002)(86362001)(336012)(36860700001)(40480700001)(82310400005)(47076005)(426003)(6666004)(107886003)(478600001)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:48:08.5953 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 815bf8a4-6dc6-455f-131d-08dac7c00cba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5473 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 8/8] debian, rhel: Enable Werror option in spec files X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" After resolving DPDK cast align warnings as stated in [1], and resolving some more warnings in OVS side, enforce -Werror for debian and rhel builds too. [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") Signed-off-by: Eli Britstein --- debian/rules | 4 ++-- rhel/openvswitch.spec.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/debian/rules b/debian/rules index 971bc1775..ffc218e9d 100755 --- a/debian/rules +++ b/debian/rules @@ -24,7 +24,7 @@ override_dh_auto_configure: cd _debian && ( \ test -e Makefile || \ ../configure --prefix=/usr --localstatedir=/var --enable-ssl \ - --sysconfdir=/etc \ + --sysconfdir=/etc --enable-Werror \ $(DATAPATH_CONFIGURE_OPTS) \ $(EXTRA_CONFIGURE_OPTS) \ ) @@ -34,7 +34,7 @@ ifeq (,$(filter nodpdk, $(DEB_BUILD_OPTIONS))) cd _dpdk && ( \ test -e Makefile || \ ../configure --prefix=/usr --localstatedir=/var --enable-ssl \ - --with-dpdk=shared --sysconfdir=/etc \ + --with-dpdk=shared --sysconfdir=/etc --enable-Werror \ $(DATAPATH_CONFIGURE_OPTS) \ $(EXTRA_CONFIGURE_OPTS) \ ) diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index 9903dd10a..35ae42356 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -70,7 +70,7 @@ Tailored Open vSwitch SELinux policy %build ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=%{_localstatedir} \ - --libdir=%{_libdir} --enable-ssl --enable-shared + --libdir=%{_libdir} --enable-ssl --enable-shared --enable-Werror make %{_smp_mflags} make selinux-policy