From patchwork Thu Mar 8 21:52:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 883349 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zy44Z5d3vz9skx for ; Fri, 9 Mar 2018 08:52:46 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 76A1BC21F24; Thu, 8 Mar 2018 21:52:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8A2B6C21E90; Thu, 8 Mar 2018 21:52:40 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B2160C21E68; Thu, 8 Mar 2018 21:52:39 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lists.denx.de (Postfix) with ESMTPS id 60EF9C21C2F for ; Thu, 8 Mar 2018 21:52:39 +0000 (UTC) Received: from LPT2.fritz.box ([84.118.156.34]) by mail.gmx.com (mrgmx103 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MPlMc-1eyzPo0ZZC-004zBG; Thu, 08 Mar 2018 22:52:38 +0100 From: Heinrich Schuchardt To: Tom Rini Date: Thu, 8 Mar 2018 22:52:29 +0100 Message-Id: <20180308215229.27104-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.16.1 X-Provags-ID: V03:K0:R2jZUzPPEUXE4Z1O1nQ8BXtOxLGyWIC448kl9+/O/QZYZryKLFv nkMWpx35KdpyEERwZTdmye4t7ObFeT2RWFtZ/iZvH3CXoBLtJyOd0P5Paj0UIhwBNbVSDPW aJFi40AC1xmYOmRh1D1ElB7hsxuaGmJGPTzSix//OK1jNFTSup5Kkz1ZTq80FUXuR/oz0R3 X1NHTtROW2NyzhZBjQMtg== X-UI-Out-Filterresults: notjunk:1; V01:K0:/xdEiymTBXU=:EoxT+hV9JsMr9nzAEOgL13 wHqSwdEzG/WEuMZgX7jkSF4E2ggIV9kBe4AyrLIZYGQjy2UjSNXK3OjFwagXL6DUgHwGd4P5n aNmI2jjpF6ruQgHZD0cq2Hys/MAv/TMMN2FMx+nl0S7n/gVUX76SLSAAcMn5S9ZWXvSAKM01y 4ZyZdcsFsQkAY0L/LhZ1r+CMdOTT4HRQ+d/45pcSGO7TDd5QhYsGYNxcUEpEFrybOejGXMOZy Qqitt8HfDxBJ3MuUCYiv7sfTypgjXYNG1qdEZkkqBRAa94IGmtM6pCHaEhQkg3gVJCcdJRxvA fgBLea0+NirCrRYSs1W2SH+iG/7BF+Qkoj4onTdIZlA9R8YMQ3SxZyQF2BY2hmlHGKherEaSW dkwVg8Xt8g6DYgbDRXl8iMDR4MKnLp+TCiyt7RnMdDnmZ7/gNmzEJHPO7iApIP92lC100Ve7j T11rx1FopIpB9VJ55Fo+okVrgJEnTsEGNijv6zitrQipOT0gAxPEPU0MiEPuyOWopG5vAWPVq yzQ1s6OTSA/ArW6+6ZcwBqifbcnnwc+B35+h3FpTF9zFCyZhLqMweV2zXgep846UL1KowMmUU NF2lap4+8hZ8ckkjWoIBHowEpsfYvKNCIUyZYtVQZoNV9t7L+IjsOHGVd6ABecMzIIRy87biq weWS7ENj9hQSv0UW5I8eG9zcGwa+D+Lox3W7NV8N7jlxg25Ttqz82QNzGdxvMjgCHwaT8P+yP AKburSrnbUqut7R9yrUfLM1VJ9LCsMrGaPXook7Tsx1pcUPagO7hfYyKKgXREtIUYvGBuY3bG W1VDw8Ro5DEyEK6zZvnv7h7TpW8dA== Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] yaffs2: iterator variable cannot be NULL X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The iterator of list_for_each() is never NULL. Identified with coccinelle. Signed-off-by: Heinrich Schuchardt --- fs/yaffs2/yaffs_guts.c | 4 ++-- fs/yaffs2/yaffsfs.c | 9 +++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/yaffs2/yaffs_guts.c b/fs/yaffs2/yaffs_guts.c index bbe0d700fb..c8b27adda9 100644 --- a/fs/yaffs2/yaffs_guts.c +++ b/fs/yaffs2/yaffs_guts.c @@ -1872,8 +1872,8 @@ static int yaffs_new_obj_id(struct yaffs_dev *dev) n += YAFFS_NOBJECT_BUCKETS; list_for_each(i, &dev->obj_bucket[bucket].list) { /* If there is already one in the list */ - if (i && list_entry(i, struct yaffs_obj, - hash_link)->obj_id == n) { + if (list_entry(i, struct yaffs_obj, + hash_link)->obj_id == n) { found = 0; break; } diff --git a/fs/yaffs2/yaffsfs.c b/fs/yaffs2/yaffsfs.c index ba76a5ccdb..47abc6beda 100644 --- a/fs/yaffs2/yaffsfs.c +++ b/fs/yaffs2/yaffsfs.c @@ -2847,12 +2847,9 @@ static void yaffsfs_RemoveObjectCallback(struct yaffs_obj *obj) * the next one to prevent a hanging ptr. */ list_for_each(i, &search_contexts) { - if (i) { - dsc = list_entry(i, struct yaffsfs_DirSearchContxt, - others); - if (dsc->nextReturn == obj) - yaffsfs_DirAdvance(dsc); - } + dsc = list_entry(i, struct yaffsfs_DirSearchContxt, others); + if (dsc->nextReturn == obj) + yaffsfs_DirAdvance(dsc); } }