From patchwork Fri Sep 15 09:33:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 814190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xtqwf6rbvz9s5L for ; Fri, 15 Sep 2017 19:34:09 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E9B833115D; Fri, 15 Sep 2017 09:34:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OZ41dJ+iOaE8; Fri, 15 Sep 2017 09:34:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 0E4E23118A; Fri, 15 Sep 2017 09:34:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 81A601CEB3B for ; Fri, 15 Sep 2017 09:34:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7D36F89DF5 for ; Fri, 15 Sep 2017 09:34:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uFno8Agu5Ryn for ; Fri, 15 Sep 2017 09:34:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) by whitealder.osuosl.org (Postfix) with ESMTPS id 5834689B1B for ; Fri, 15 Sep 2017 09:34:01 +0000 (UTC) Received: from tarshish.tkos.co.il (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPSA id 96074440584; Fri, 15 Sep 2017 12:33:56 +0300 (IDT) From: Baruch Siach To: buildroot@busybox.net Date: Fri, 15 Sep 2017 12:33:39 +0300 Message-Id: <80f0f99699bcdacbed2aa551ef3051ab5dd45280.1505468019.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.14.1 Cc: Philippe Proulx Subject: [Buildroot] [PATCH] lttng-tools: needs glibc X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" This commit partially reverts commit a6bb295642919 (lttng-tools: update to 2.9.5) that enabled lttng-tools for uClibc and musl. Upstream code does not detect dlmopen() specifically. configure only checks which library defines dlopen(), and fails the configuration when none is found. The code of the prog.c test still relies on dlmopen() GNU extension that uClibc and musl do not implement currently. Fixes: http://autobuild.buildroot.net/results/add/add97b4b3f45841249f239367452205c38d4e4df/ http://autobuild.buildroot.net/results/382/3825c88bb8a23708e4c2fed99f2417555078c65a/ http://autobuild.buildroot.net/results/4ae/4aef36977f039a1533b409a7c172f0ceaa2c6088/ Cc: Waldemar Brodkorb Cc: Philippe Proulx Signed-off-by: Baruch Siach --- package/lttng-tools/Config.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/package/lttng-tools/Config.in b/package/lttng-tools/Config.in index 9c86cc264643..b84f201c2a22 100644 --- a/package/lttng-tools/Config.in +++ b/package/lttng-tools/Config.in @@ -4,6 +4,8 @@ config BR2_PACKAGE_LTTNG_TOOLS depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_HAS_THREADS depends on !BR2_STATIC_LIBS # uses dlfcn + # uclibc/musl don't implement dlmopen()/LM_ID_BASE + depends on BR2_TOOLCHAIN_USES_GLIBC select BR2_PACKAGE_LIBURCU select BR2_PACKAGE_LIBXML2 select BR2_PACKAGE_POPT @@ -27,6 +29,7 @@ config BR2_PACKAGE_LTTNG_TOOLS http://lttng.org -comment "lttng-tools needs a toolchain w/ threads, dynamic library" +comment "lttng-tools needs a glibc toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS - depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \ + !BR2_TOOLCHAIN_USES_GLIBC