From patchwork Wed Mar 7 08:46:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Guo X-Patchwork-Id: 882476 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zx6kT5ym6z9sf2 for ; Wed, 7 Mar 2018 19:48:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="do8Z3QRn"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zx6kT4WM3zF1cm for ; Wed, 7 Mar 2018 19:48:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="do8Z3QRn"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c05::242; helo=mail-pg0-x242.google.com; envelope-from=wei.guo.simon@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="do8Z3QRn"; dkim-atps=neutral Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zx6gc5gNNzF1YN for ; Wed, 7 Mar 2018 19:46:19 +1100 (AEDT) Received: by mail-pg0-x242.google.com with SMTP id m19so646584pgn.1 for ; Wed, 07 Mar 2018 00:46:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cTo2mE1iwmWaBUBiFYxPnGk/yFFksSCGieh6+xLlEHE=; b=do8Z3QRnGSEfNSjqBI3UFcdMkTPhdO+EMwwUEervFTDH8+/X4QHT57Z0unQR/cD1Bm eG5Xpj0G/SNh3FDbNowYYnzmEkZj4EULZaqwOL/UyiFeJUOAoBnJq+YCF3j5JbEIGT3J XwYcyxmg8KOvTQKEXFgzyszwcsRUUOx5pszh/jfWNE9R7XXfPt7DZTF7kQVtfDrl76UC 92caH2Shf+f7KISOjvyloMqNewYVAvVij5xJK8nKle4a37fCvDeGDR74bJT2Xw83PEC0 OBTV7r04nTlQnvOnGNYs28Ixv7w08W169SFMCw4ApgfaktBXtWTjNyKO0TQO9YatY7tp IwFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cTo2mE1iwmWaBUBiFYxPnGk/yFFksSCGieh6+xLlEHE=; b=m8hr+yiFYKFH/gaYE9V3L4HDodSy1FJMi4SNxiw2Q/Q7Et6QxV2VBIP8siITI2BNqS J5sqcJmZhb7DYYrzOK6cjhKg+2NMwJpL4bcjYTOgJfsbPuUhKLNUZnof5hKR56cCYvQl et7GQLRBG6NPltDUTd0inC7n2Ogy4wbTOWd8Kiq0ivZs7eeViEX+D0so9wVHKKJZqml+ FtwU7dDz6cplORQVnagsphGYHONnQq+BQm93SDTdvA+vp0mDrHcENN5ilfkevalb/YoL bSeKZ3ncuiWNFs1dpMDjD8/ZhplqJ4RBgo9zbn1znlZNvwr+wNn2mT28QyNjfjZGI15n 96dw== X-Gm-Message-State: APf1xPA37wZjUZUgEAgQDZAy+KYgf/p/mQiBIBJBVsypiROdGcY/ywtu Yh7EFPtxYHHgw/7oNu32bTlESQ== X-Google-Smtp-Source: AG47ELvqEzbmbKw3eGMN8kDffm/nl3Svt/xLJ1axsyoeXNWEXzB8t8qhhvFG3KxMvyX2tuBLE9My4w== X-Received: by 10.98.223.93 with SMTP id u90mr21904859pfg.13.1520412377232; Wed, 07 Mar 2018 00:46:17 -0800 (PST) Received: from simonLocalRHEL7.x64 ([112.73.0.86]) by smtp.gmail.com with ESMTPSA id v1sm34489718pfg.33.2018.03.07.00.46.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 00:46:16 -0800 (PST) From: wei.guo.simon@gmail.com To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH] PCI/hotplug: ppc: correct a php_slot usage after free Date: Wed, 7 Mar 2018 16:46:04 +0800 Message-Id: <1520412364-2680-1-git-send-email-wei.guo.simon@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Guo , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Simon Guo In pnv_php_unregister_one(), pnv_php_put_slot() might kfree php_slot structure. But there is pci_hp_deregister() after that with php_slot reference. This patch moves pnv_php_put_slot() to the end of function. Signed-off-by: Simon Guo --- drivers/pci/hotplug/pnv_php.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c index 74f6a17..eb60692e 100644 --- a/drivers/pci/hotplug/pnv_php.c +++ b/drivers/pci/hotplug/pnv_php.c @@ -930,8 +930,8 @@ static void pnv_php_unregister_one(struct device_node *dn) return; php_slot->state = PNV_PHP_STATE_OFFLINE; - pnv_php_put_slot(php_slot); pci_hp_deregister(&php_slot->slot); + pnv_php_put_slot(php_slot); } static void pnv_php_unregister(struct device_node *dn)