From patchwork Sun Oct 9 03:45:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1687784 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=esJ2wmPs; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MlSdy6NYTz1yqk for ; Sun, 9 Oct 2022 14:46:45 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ohNGn-0005lb-8V; Sun, 09 Oct 2022 03:46:29 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ohNGm-0005lQ-Dn for kernel-team@lists.ubuntu.com; Sun, 09 Oct 2022 03:46:28 +0000 Received: from localhost.localdomain (unknown [123.112.67.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 8A52E3F04C for ; Sun, 9 Oct 2022 03:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1665287187; bh=INOXbDFHVATtSVAfGg4kTTDi3KvtFytapEG8AT/uOYk=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=esJ2wmPsjJj9yYICDID0iDhJAHF8UnvsYzDDcCBr2J4VvP11UdEQJ4jMisFGhV0K/ 47iF0Ln7P5vzIKj+kiTD/n0TSKOQoufQNUHK1mCAq4ZbXuWxA2FqM5Cl8vNyEhAyYM 1VuPPuaIdsHQMCvKktntmi3IjImpktwZbMsZ7pT0TR8KmJelXE+Nb5w991BuB9qdSw BNWf9hPc/nGHbZySx0khlZwf2BXjFBaW4zdpK6qkKg/2FOZZtsLTeLQ3/5cRjh2SFJ wUNn3KkU7xXDSqEEqXX2J9gOxVQfbOpiiq2+RZpBzrSP6BD49H7suAmCT87eoKP6lG NysBr/LN3VWuw== From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][F/J/K/U][PATCH 1/2] ACPI: resource: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA Date: Sun, 9 Oct 2022 11:45:41 +0800 Message-Id: <20221009034542.13842-2-hui.wang@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221009034542.13842-1-hui.wang@canonical.com> References: <20221009034542.13842-1-hui.wang@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Tamim Khan BugLink: https://bugs.launchpad.net/bugs/1992266 In the ACPI DSDT table for Asus VivoBook K3402ZA/K3502ZA IRQ 1 is described as ActiveLow; however, the kernel overrides it to Edge_High. This prevents the internal keyboard from working on these laptops. In order to fix this add these laptops to the skip_override_table so that the kernel does not override IRQ 1 to Edge_High. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216158 Reviewed-by: Hui Wang Tested-by: Tamim Khan Tested-by: Sunand Signed-off-by: Tamim Khan Signed-off-by: Rafael J. Wysocki (cherry picked from commit e12dee3736731e24b1e7367f87d66ac0fcd73ce7) Signed-off-by: Hui Wang --- drivers/acpi/resource.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index b10aceb51bbd..446a3428e0ab 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -406,6 +406,24 @@ static const struct dmi_system_id medion_laptop[] = { { } }; +static const struct dmi_system_id asus_laptop[] = { + { + .ident = "Asus Vivobook K3402ZA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "K3402ZA"), + }, + }, + { + .ident = "Asus Vivobook K3502ZA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "K3502ZA"), + }, + }, + { } +}; + struct irq_override_cmp { const struct dmi_system_id *system; unsigned char irq; @@ -416,6 +434,7 @@ struct irq_override_cmp { static const struct irq_override_cmp skip_override_table[] = { { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 }, + { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 }, }; static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity, From patchwork Sun Oct 9 03:45:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1687782 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Nva/Tmdg; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MlSdy6wKQz23jq for ; Sun, 9 Oct 2022 14:46:45 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ohNGp-0005m5-Ch; Sun, 09 Oct 2022 03:46:31 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ohNGo-0005lq-1a for kernel-team@lists.ubuntu.com; Sun, 09 Oct 2022 03:46:30 +0000 Received: from localhost.localdomain (unknown [123.112.67.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 961863F04C for ; Sun, 9 Oct 2022 03:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1665287189; bh=/ZYHQPwUlbZLFe0SI5sYFu3vGUi4x929TPcBgyEec9M=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nva/TmdgLQhz7u06/DJuwOIq5phpmX4n6A9+V4xTVHK/qnZrKGDU5fTkCEo53rvV5 m/Q/+ft0+m2G4IEBrZp9UdSjrfbYxar83Jx0OkxV4r6yuUOiYSeJhc2hKiLrS1BIrU QOVpNkPDuo6GHbeACemdaGtBWkvGME9LKHsmlTChKGset/IilLGjBq3PuaHBKZDGns PCJNWt7AyNKTzICqKgDKFoRN9IK/iucknhUZMqQJkNUa22++XbwPuJ3qaI5z8sIzxE KRRH0pYa0/dlR2KwADm5gVd7AFcg3mD3idBNAzY3AedVeM94D7D56DVkWklDF8M9Om Yr++ineLx12bA== From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][F/J/K/U][PATCH 2/2] ACPI: resource: Add ASUS model S5402ZA to quirks Date: Sun, 9 Oct 2022 11:45:42 +0800 Message-Id: <20221009034542.13842-3-hui.wang@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221009034542.13842-1-hui.wang@canonical.com> References: <20221009034542.13842-1-hui.wang@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Kellen Renshaw BugLink: https://bugs.launchpad.net/bugs/1992266 The Asus Vivobook S5402ZA has the same keyboard issue as Asus Vivobook K3402ZA/K3502ZA. The kernel overrides IRQ 1 to Edge_High when it should be Active_Low. This patch adds the S5402ZA model to the quirk list. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216158 Tested-by: Kellen Renshaw Signed-off-by: Kellen Renshaw Signed-off-by: Rafael J. Wysocki (cherry picked from commit 6e5cbe7c4b41824e500acbb42411da692d1435f1) Signed-off-by: Hui Wang --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 446a3428e0ab..a970813f0ee8 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -421,6 +421,13 @@ static const struct dmi_system_id asus_laptop[] = { DMI_MATCH(DMI_BOARD_NAME, "K3502ZA"), }, }, + { + .ident = "Asus Vivobook S5402ZA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "S5402ZA"), + }, + }, { } };