From patchwork Mon Mar 5 23:04:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashish Varma X-Patchwork-Id: 881815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NQvK4Fn2"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zwFpk3N9Xz9s47 for ; Tue, 6 Mar 2018 10:04:30 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7FA4E10EB; Mon, 5 Mar 2018 23:04:27 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CF2F010E1 for ; Mon, 5 Mar 2018 23:04:25 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 749DE2C5 for ; Mon, 5 Mar 2018 23:04:25 +0000 (UTC) Received: by mail-pf0-f196.google.com with SMTP id u5so7913721pfh.6 for ; Mon, 05 Mar 2018 15:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=iIoKT/o6yjwX+lmrIe119mQ1kKWXXvOt3uAvjuXN1Sk=; b=NQvK4Fn2mZ8tQH+HwmbAgaXLFOpLcB5TiSWviGsQSNlPTgqIBfvt/6EOHMjvx8sWsW 8/NAnaRciFBbwtbLbBRrD7phBBMM3F2D+eREHK0ZAaUuC5rdr50v20asGKMc5BXN+Upt cHjKI2HB9oZVIu0OmhFRB+nnxmnvHdIxLeNo7qURMcZv/ARGS5gVaWOrcb9EMdwtUAQs UvTmjuTTYN1SaUKPTX4Iq1QtBtRbJyTg6AJjPIJiOW+T+6bs/Afu7Qy//bAGAp7wpRC+ oGQAGOl6ktvlFjjyqqji2rJPBXrQFKEq7GjrTdD9SbZTCCZGXjshm38da0lUeB4iB5uH J+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=iIoKT/o6yjwX+lmrIe119mQ1kKWXXvOt3uAvjuXN1Sk=; b=Gxtcsvv8xU0Sg0auOjvpl6S+Gvk0cE330XDf3DDCGw64UJHcI/uWGBnOHqx+B+8Sij E4LHpfxU0jpBmYJ282RSD/2dazoyXIDzp3gYktm+auROKUcUv5GTc61jvubY0x0XWxmu KtcKEvL46TPM9EWNqy2F25ihV6FwbzF/AepPwjjmwnnAOiBMzsBKf5KNIbml79IGrhRC ddIG8IBSbgokRBPoyprrUKluPnvZkpB/j6nuex58aQUnUy3UOk/I/CO+5a3tSyTcXRzi IH+fkyKuOBrLVpjJnMtyfzZqmYkVYkCdfWn0kqyn7CjSX5JEoXs1TifJ+vSTySBoivaN uGKg== X-Gm-Message-State: APf1xPCaSF4t+r9/YqlD2U1KoAQGU4K7jAhu9aCPtDOUJWnvhnxoKWaG K670pwm5cM/LFwt+8bBk8VHk+8br X-Google-Smtp-Source: AG47ELsbX4dCmTAqCivgdx7Yt/83n4N07W5EmpD5/Ee7mH8Fx3Gry8c7n/5b12vp99mybksqOWdITw== X-Received: by 10.98.217.76 with SMTP id s73mr16757253pfg.209.1520291064722; Mon, 05 Mar 2018 15:04:24 -0800 (PST) Received: from ashish-Ubuntu-WorkStation.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id f7sm20564031pgq.66.2018.03.05.15.04.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Mar 2018 15:04:23 -0800 (PST) From: Ashish Varma To: dev@openvswitch.org Date: Mon, 5 Mar 2018 15:04:01 -0800 Message-Id: <1520291041-15769-1-git-send-email-ashishvarma.ovs@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v1] ofproto-dpif-upcall: fix for segmentation fault X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Added check for NULL pointer on return from xlate_lookup_ofproto function. Access to "ofproto" variable when NULL was causing segmentation fault. VMware-BZ: #2061914 Signed-off-by: Ashish Varma --- ofproto/ofproto-dpif-upcall.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 526be77..0079674 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -2129,6 +2129,11 @@ revalidate_ukey__(struct udpif *udpif, const struct udpif_key *ukey, ofproto = xlate_lookup_ofproto(udpif->backer, &ctx.flow, &ofp_in_port); ofpbuf_clear(odp_actions); + + if (!ofproto) { + goto exit; + } + compose_slow_path(udpif, xoutp, &ctx.flow, ctx.flow.in_port.odp_port, ofp_in_port, odp_actions, ofproto->up.slowpath_meter_id, &ofproto->uuid);