From patchwork Tue Sep 20 18:48:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 1680178 X-Patchwork-Delegate: tudor.ambarus@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=is8DBL03; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=hF571Vuj; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MX9Yq1FTbz1yqC for ; Wed, 21 Sep 2022 04:49:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BG+BTRecTGPJAK4Xd3+QR7tY3jznKY1XwFZAFJ6Sb6U=; b=is8DBL033DOogX jw6vxM4C7gK9h57D3Gqeiyq2bIZy5kM7mBjRGYdMjV2TpYs5pjo+3tyFRTz5od91YSsZecpS79MXo JlGNqiyP5EXi9SndiJsQWbWrADGI0FQP/kiCv06r1ht3cnZN8J4akM1mSKUI7FaDQiTA75wSUf9Lq jf8fdShLQ5SQETkQqxTJgxbDtWDpUykYYdhnR7a93XxDMp5UVyBuu+yN+JTbUDFF9I5s/PpMfpqH/ dAlA7LmbpdcmciFpRLSubO43NaAxGJTLRX2hxMNvJc52K3Qx1hg5YkNfQtPlHZyE6wXtdRTgH+Z6f AnjAuQxybfhWl2RygrWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaiI9-005oct-L3; Tue, 20 Sep 2022 18:48:21 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaiI1-005oZ6-Iq for linux-mtd@lists.infradead.org; Tue, 20 Sep 2022 18:48:14 +0000 Received: by mail-wm1-x32d.google.com with SMTP id az6so2731615wmb.4 for ; Tue, 20 Sep 2022 11:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=e1rax8zHktkJE4NlsAmrfBmfy6JQLwKUdVTmbuE0Kvk=; b=hF571VujJCMDxHcL33xXykpja1h21tI7IF5yEPnBBYncPApGh+8n57VgyUlTu+m3yX wns7sSyA3Oug+os9C3c7qMqW79l4cj5reKYE2Ouc/wFN8PAQQcjeJZB2zME9NyX4GMY+ TnUNugxpJMyKaX08YJLgZrChhBULnCHcIu9v6OSOffTu7aGJndgpEi8Z0xAU6ZDPHqlV JLlu2ajyA1yroEGrX1aIdMInErCeqvTSxr44265WFwqp0tN2HRpsl04/yFuQQA1jMJLT VFyej89biFNpTlhvnGzlJx0so2Rb3j1fGr+vyBD4YpjgYpPde+fVVxbcsnacpADRRE2M LJGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=e1rax8zHktkJE4NlsAmrfBmfy6JQLwKUdVTmbuE0Kvk=; b=fdiyQRWozBo+MkumZeySsNJvsnmx2xu3/etwKxLwjMqnw8Hup8ixezurcphqC2k3pL MPkOtHAYmmZ6q4DBBbhaL/+dY8/tB+NLTfPGuqtkxa+bMmlMQvcEgX+S1jfWTJGe2Owe mUIu0lk6XUUKBFdYphEykkZu/uKkP3HayLAeJBCgTKBd5afbMWxmouqMsnXjag4W6CNy zFhffxeNuoblkNEdfx0Q81jsLuE8d59sotXxvIfielXoA/Z3wXK9DcErjw7gGDLbVmMz 1j9WHiVYLSRxOU2cyb74ZLo6xh2EEpryPBZMRnaR/ip1UcIAe1SjU2r+1/KQslofegqs mjbQ== X-Gm-Message-State: ACrzQf33M9GECL6j0EvXWedJsR78pUHJP444GDxZ+aOoe73hyMSnSq+u dBXi2kK17nEI0yiAh70QY/c67w== X-Google-Smtp-Source: AMsMyM4Tw/NhBtw2kzdJcNMS4tkb4L/Hz8kHuIiUNdJMWTGNUCY8P/Fe189L7qnKquwt04na0P0VEw== X-Received: by 2002:a05:600c:1f15:b0:3b4:8600:fd7e with SMTP id bd21-20020a05600c1f1500b003b48600fd7emr3570480wmb.40.1663699689952; Tue, 20 Sep 2022 11:48:09 -0700 (PDT) Received: from localhost.localdomain (host-78-150-37-98.as13285.net. [78.150.37.98]) by smtp.gmail.com with ESMTPSA id l16-20020a7bc350000000b003b4c40378casm469974wmj.39.2022.09.20.11.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 11:48:09 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v3 1/2] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Date: Tue, 20 Sep 2022 19:48:07 +0100 Message-Id: <20220920184808.44876-1-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_114813_644790_8E90B56E X-CRM114-Status: GOOD ( 14.62 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The datasheet of is25wp256 says it supports SFDP. Get rid of the static initialization of the flash parameters and init them when parsing SFDP. Testing showed the flash using SPINOR_OP_READ_1_1_4_4B 0x6c, SPINOR_OP_PP_4B 0x12 and SPINOR_OP_BE_4K_4B 0x21 before enabling SFDP. After this patch, it parses the SFDP information and still uses the [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:32d listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The datasheet of is25wp256 says it supports SFDP. Get rid of the static initialization of the flash parameters and init them when parsing SFDP. Testing showed the flash using SPINOR_OP_READ_1_1_4_4B 0x6c, SPINOR_OP_PP_4B 0x12 and SPINOR_OP_BE_4K_4B 0x21 before enabling SFDP. After this patch, it parses the SFDP information and still uses the same opcodes. Signed-off-by: Sudip Mukherjee --- No change from v2, just resending again with the next patch. Results from the tests given by Tudor in the following mail. drivers/mtd/spi-nor/issi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c index 89a66a19d754f..8b48459b5054c 100644 --- a/drivers/mtd/spi-nor/issi.c +++ b/drivers/mtd/spi-nor/issi.c @@ -71,7 +71,7 @@ static const struct flash_info issi_nor_parts[] = { { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512) - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) + PARSE_SFDP FIXUP_FLAGS(SPI_NOR_4B_OPCODES) .fixups = &is25lp256_fixups }, From patchwork Tue Sep 20 18:48:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 1680179 X-Patchwork-Delegate: tudor.ambarus@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kr8Xag1Z; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=RhEADarM; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MX9Ys0CgLz1yp7 for ; Wed, 21 Sep 2022 04:49:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GPqHgB99gLlV6TIN89VJiSJ44Af/hkKqJFvFPWx4uJg=; b=kr8Xag1ZSAX+Oi OLNPNCQwTwV4b63SwgH5sT7H6sbNL6i8kceKNZNryIo70mtmPbE28qXZA856k6t/ml2CNzFA8WLUe N3MPYoRGkzia1oMVeEP+LEQhAwm0pBVoOqFUn974G6rjKxe0s96c6WUTnCAF5cUrRsksYyGs/DwOy LRG3Mx8U56OI6aN9ocEzxRiTm9m5bK3SfjQ/thZgeL4Si5pqUqOl4Fi0MSFCjVjUWuNUP46QwP2ou 5asZ+/Ze/6rTN2tJ0FPg58gvT4k6zT2IePwGYrQ7oQ1UrAT6uXZpB5Yr7244M41U92G17F6+AThcn FE6CDzNECVz0/mLwY/WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaiID-005oeK-37; Tue, 20 Sep 2022 18:48:25 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaiI2-005oZX-KP for linux-mtd@lists.infradead.org; Tue, 20 Sep 2022 18:48:16 +0000 Received: by mail-wr1-x42a.google.com with SMTP id e16so5934584wrx.7 for ; Tue, 20 Sep 2022 11:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=sYGkRYa3l7UDhvpu09qUEbAPCdOAg7Sh9qulo+MPJsg=; b=RhEADarMcfwqx06RJ5pKHOLDpARgUmLEibIOuaPmPrmtHeGpNQb8+bpiW6fDW0LlqY ByvGg4YAL/NTG5nQQM2bDGEMh26Js9cw10ws0aK7w2ShLXyG2Ke8E5/XpoYq3R7qLjY1 uW2nzhKZY7q7gNsBxwCZR+jSk7dQ1lssroYMmB5FKVyaPPWd/EMAU0Hf9uzSqRLqhbGp ONLmc3V63ZX8QOt7kshON/KuHkvp2vSWkrHt2nvJPknbmvMabA7xOCOfbeugb3k6SYgz 4oOfutXiAl3nJUnQ5Kzm6Y2g3116T1QzfGprD9cmXj279vtlaELjbpfIC+NcUIpajUkM VtUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=sYGkRYa3l7UDhvpu09qUEbAPCdOAg7Sh9qulo+MPJsg=; b=AWBX2JUSK+HqARxDNptlu5lTDnYkgnfi2NE3DdjH2bEayX2h3fp0qPexCLSbqq1Pgp DpOGfFLos3z7cYfzOz7gr2EW4KhWnSb+KRicFjHVQxBOFaOnY0YcbypPGNoHSb8V0iZz rD5bCO5h1DQYKF3MijfE8Tb7sQ71meZcJNEBkOwWeHhpbKrohY5ORzPphGk5p4K/RKT6 cfYC/fkPWwBqizW7WgG7f8API2JRxDLAQjgNrbI9DnaMTACM0sWHSVmKN2Iuf226VECy 9DZAvUnarviMsW6KUyXkQlUHgs7Jh6nUOTPh7LNNsunErt9ELWhFXIf4nZF1bClz4y/j 3zRQ== X-Gm-Message-State: ACrzQf3XmpfrrYn3RDyZN0tikdku8S9dV7IrdDzk50aJJJIPz9iBuwfQ geiEr8JXDIhDS12zgdVyXyfvhA== X-Google-Smtp-Source: AMsMyM7pa5QdD4ZmGPKkW3ltpbqJyuLGw/cLMDy6S75S+Zi8DkGzecVEEWssv0F0yB4mdO8A6QmlOA== X-Received: by 2002:adf:f80b:0:b0:228:dbb9:5bdf with SMTP id s11-20020adff80b000000b00228dbb95bdfmr14987846wrp.327.1663699690940; Tue, 20 Sep 2022 11:48:10 -0700 (PDT) Received: from localhost.localdomain (host-78-150-37-98.as13285.net. [78.150.37.98]) by smtp.gmail.com with ESMTPSA id l16-20020a7bc350000000b003b4c40378casm469974wmj.39.2022.09.20.11.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 11:48:10 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v3 2/2] mtd: spi-nor: add SFDP fixups for Quad Page Program Date: Tue, 20 Sep 2022 19:48:08 +0100 Message-Id: <20220920184808.44876-2-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220920184808.44876-1-sudip.mukherjee@sifive.com> References: <20220920184808.44876-1-sudip.mukherjee@sifive.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_114814_691148_75858588 X-CRM114-Status: GOOD ( 14.88 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SFDP table of some flash chips do not advertise support of Quad Input Page Program even though it has support. Use flags and add hardware cap for these chips. Signed-off-by: Sudip Mukherjee --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SFDP table of some flash chips do not advertise support of Quad Input Page Program even though it has support. Use flags and add hardware cap for these chips. Signed-off-by: Sudip Mukherjee --- Change from v2: SPI_NOR_QUAD_PP added to info->flags instead of info->fixup_flags. Link: https://lore.kernel.org/lkml/498c33a8-014f-e542-f143-cba5760fafdd@microchip.com/ Results from the tests given by Tudor in the following mail. drivers/mtd/spi-nor/core.c | 6 ++++++ drivers/mtd/spi-nor/core.h | 2 ++ drivers/mtd/spi-nor/issi.c | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index f2c64006f8d75..992fb332514d8 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2474,6 +2474,12 @@ static void spi_nor_late_init_params(struct spi_nor *nor) */ if (nor->flags & SNOR_F_HAS_LOCK && !nor->params->locking_ops) spi_nor_init_default_locking_ops(nor); + + if (nor->info->flags & SPI_NOR_QUAD_PP) { + nor->params->hwcaps.mask |= SNOR_HWCAPS_PP_1_1_4; + spi_nor_set_pp_settings(&nor->params->page_programs[SNOR_CMD_PP_1_1_4], + SPINOR_OP_PP_1_1_4, SNOR_PROTO_1_1_4); + } } /** diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h index 85b0cf254e974..c2334fe33e2f9 100644 --- a/drivers/mtd/spi-nor/core.h +++ b/drivers/mtd/spi-nor/core.h @@ -458,6 +458,7 @@ struct spi_nor_fixups { * SPI_NOR_NO_ERASE: no erase command needed. * NO_CHIP_ERASE: chip does not support chip erase. * SPI_NOR_NO_FR: can't do fastread. + * SPI_NOR_QUAD_PP: flash supports Quad Input Page Program. * * @no_sfdp_flags: flags that indicate support that can be discovered via SFDP. * Used when SFDP tables are not defined in the flash. These @@ -507,6 +508,7 @@ struct flash_info { #define SPI_NOR_NO_ERASE BIT(6) #define NO_CHIP_ERASE BIT(7) #define SPI_NOR_NO_FR BIT(8) +#define SPI_NOR_QUAD_PP BIT(9) u8 no_sfdp_flags; #define SPI_NOR_SKIP_SFDP BIT(0) diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c index 8b48459b5054c..014cd9038bedc 100644 --- a/drivers/mtd/spi-nor/issi.c +++ b/drivers/mtd/spi-nor/issi.c @@ -73,6 +73,7 @@ static const struct flash_info issi_nor_parts[] = { { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512) PARSE_SFDP FIXUP_FLAGS(SPI_NOR_4B_OPCODES) + FLAGS(SPI_NOR_QUAD_PP) .fixups = &is25lp256_fixups }, /* PMC */