From patchwork Mon Mar 5 07:20:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 881330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YSDAqJCF"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zvrtJ292Mz9sZH for ; Mon, 5 Mar 2018 18:21:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fiPnoxrKPpp9V8BTgze1pyIhFNJc2ddvGL9hHfzcTRg=; b=YSDAqJCFwe3sOd W+RHr8udAcQAHo89rZCAqRbKTocRbeVL1sseJDuYN3upccuVuW69GVlfZAqKuZWAHkjWArGI4wZu/ Biu23yuaoM6/uYeG4q7EjEouRk4VIjbFIQ/XmoWrDoh7HbCR/l+WcnftrJu/YWsigVMt06rvgMU5n Pzs7sPMzR6mMHBpaUl+3tr4VIa7CP2tVMSYm52ESvOxSuj+C1vBGNz6h3QlHRITlB+rDUirCCTW0e O9eg8ZFrSi5tjrBFkKH2xiXsyLmG+wSsQxKs0QA+6bzZbxY9fiUOZmn4Ikv377zPd6SZnh/f89Jid xTML0BH9vgl8YaTm0+tg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eskQl-0004SW-Ck; Mon, 05 Mar 2018 07:21:07 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eskQg-0004PI-Si for linux-mtd@lists.infradead.org; Mon, 05 Mar 2018 07:21:04 +0000 X-IronPort-AV: E=Sophos;i="5.47,426,1515452400"; d="scan'208";a="256958319" Received: from abo-3-110-68.mrs.modulonet.fr (HELO [192.168.0.15]) ([85.68.110.3]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 08:20:44 +0100 Date: Mon, 5 Mar 2018 08:20:44 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Stefan Agner Subject: [PATCH] mtd: rawnand: vf610_nfc: fix returnvar.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180304_232103_231644_741D14DE X-CRM114-Status: GOOD ( 10.99 ) X-Spam-Score: -6.1 (------) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-6.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.134.164.104 listed in list.dnswl.org] 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_HDRS_LCASE Odd capitalization of message header X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , Cyrille Pitchen , linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, kbuild-all@01.org, Miquel Raynal , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Fengguang Wu Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Stefan Agner Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- Not a big deal, but the code can be a tiny bit simpler. vf610_nfc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -870,7 +870,6 @@ static int vf610_nfc_write_page(struct m struct vf610_nfc *nfc = mtd_to_nfc(mtd); int trfr_sz = mtd->writesize + mtd->oobsize; u32 row = 0, cmd1 = 0, cmd2 = 0, code = 0; - int ret = 0; cmd2 |= NAND_CMD_SEQIN << CMD_BYTE1_SHIFT; code |= COMMAND_CMD_BYTE1 | COMMAND_CAR_BYTE1 | COMMAND_CAR_BYTE2; @@ -894,7 +893,7 @@ static int vf610_nfc_write_page(struct m vf610_nfc_run(nfc, 0, row, cmd1, cmd2, trfr_sz); vf610_nfc_ecc_mode(nfc, ECC_BYPASS); - return ret; + return 0; } static int vf610_nfc_read_page_raw(struct mtd_info *mtd,