From patchwork Fri Mar 2 05:22:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 880319 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zsyPj16Kmz9s4v for ; Fri, 2 Mar 2018 16:23:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5229A89A97; Fri, 2 Mar 2018 05:23:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCIFUQbTLPAv; Fri, 2 Mar 2018 05:23:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 24C2A89AA0; Fri, 2 Mar 2018 05:23:15 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 594F81BF20B for ; Fri, 2 Mar 2018 05:23:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 536FC88B46 for ; Fri, 2 Mar 2018 05:23:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d3TfDJC4BNxq for ; Fri, 2 Mar 2018 05:23:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) by whitealder.osuosl.org (Postfix) with ESMTPS id 42D6888B0E for ; Fri, 2 Mar 2018 05:23:10 +0000 (UTC) Received: from tarshish.tkos.co.il (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPSA id 364DE440524; Fri, 2 Mar 2018 07:23:08 +0200 (IST) From: Baruch Siach To: buildroot@busybox.net Date: Fri, 2 Mar 2018 07:22:36 +0200 Message-Id: X-Mailer: git-send-email 2.16.1 Subject: [Buildroot] [PATCH master] dash: fix static link with libedit X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" libedit is an optional dependency of dash since commit 651af57cf011e (dash: enable line editting if libedit is selected). Unfortunately, the dash build system does not take into account the ncurses dependency of libedit. Use pkgconf to get that right. Fixes: http://autobuild.buildroot.net/results/801/801e8bc06277978556a301ddf54f609169de37bb/ http://autobuild.buildroot.net/results/123/12367267735b9165afef77289460c247aaad494a/ http://autobuild.buildroot.net/results/aa7/aa7cc7315d778c15c5165ca6423257a84b957482/ Cc: Carlos Santos Signed-off-by: Baruch Siach --- package/dash/dash.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/dash/dash.mk b/package/dash/dash.mk index 87c9cc9f8b87..2ee292b8d3e7 100644 --- a/package/dash/dash.mk +++ b/package/dash/dash.mk @@ -10,8 +10,9 @@ DASH_LICENSE = BSD-3-Clause, GPL-2.0+ (mksignames.c) DASH_LICENSE_FILES = COPYING ifeq ($(BR2_PACKAGE_LIBEDIT),y) -DASH_DEPENDENCIES += libedit +DASH_DEPENDENCIES += libedit host-pkgconf DASH_CONF_OPTS += --with-libedit +DASH_CONF_ENV += LIBS=`pkg-config --libs libedit` # Enable line editing, Emacs style define DASH_INSTALL_PROFILE